NAL HRD has been committed! - Page 3

shon3i · 1st February 2010, 18:12

Quote:

Originally Posted by kieranrk

Just out of interest does Blu-ray let you code 1080p25 without using interlacing? Can you use 1080p25 will pic_struct or something?

Also is there anything about NumClockTS?

Not without --interlaced switch (scenarist) and earler version of HRD patches. I will now test with or without pic_struct. Please give me few hours

Trahald · 1st February 2010, 21:45

While in practice it may be different, 1080p25 is not allowed.

shon3i · 1st February 2010, 22:17

Quote:

Originally Posted by Trahald

While in practice it may be different, 1080p25 is not allowed.

Encocoding progressive material with interlaced switch you get interlaced video 1080i25 which is allowed, and scenarist detect it as 1080i25.

kolak · 1st February 2010, 22:25

Quote:

Originally Posted by Trahald

While in practice it may be different, 1080p25 is not allowed.

You ave to encode it as it would be 50i and it does work.
If you have a good player you may get original 25p on your TV.

Andrew

Atak_Snajpera · 2nd February 2010, 00:23

PS3 plays 1080p 25fps without problems. I wouldn't be surprised if this also applies to other good brands.

kolak · 2nd February 2010, 16:43

Quote:

Originally Posted by Atak_Snajpera

PS3 plays 1080p 25fps without problems. I wouldn't be surprised if this also applies to other good brands.

It's not about what PS3 or even any other player can play- BD doesn't support pure 25p/30p modes.
PS3 can play much more than BD spec allows- it did play 100Mbit AVC, but at maybe 5fps

Andrew

mp3dom · 2nd February 2010, 16:49

Back to the NAL patch: At the end I'm not understanding if the current patch version (1.22) match the specs posted by Emulgator.

kieranrk · 2nd February 2010, 18:39

Quote:

Originally Posted by mp3dom

Back to the NAL patch: At the end I'm not understanding if the current patch version (1.22) match the specs posted by Emulgator.

It does.

shon3i · 2nd February 2010, 20:18

Quote:

Originally Posted by kolak

BD doesn't support pure 25p/30p modes.

Well support it as Secondary video, so is generaly supported. That's why i liked HDDVD, maybe is less overall bitrate and storage, but twice more Video and Audio combination are allowed.

renqian · 3rd February 2010, 16:23

here some primary question:
which Splitter Filter should i use to keep the field won't loss when i encoding?
and which decoder can playback the product correctly in 60fps on LCD or LCD TV?(i mean if i use the HTPC)

rack04 · 3rd February 2010, 16:45

Is anyone able to patch the latest git with v1.22?

rallymax · 3rd February 2010, 23:49

no. I've just manually done the change . When I get home I'll copy it onto my SVN tree so that I can generate a diff and post it.

mp3dom · 4th February 2010, 00:00

Quote:

Originally Posted by kieranrk

It does.

Thank you very much! Since you're so kind, can I ask what are the next steps before final commit? Is there something new that need to be tested? (with the Interra verifier I cannot test anything more). Thanks again!

alwa · 4th February 2010, 13:10

Quote:

Originally Posted by rack04

Is anyone able to patch the latest git with v1.22?

Ready to patch. The @@ get removed by patebin...

jpsdr · 4th February 2010, 13:55

Can someone make a patch with it and the autoVAQ ?

Thanks.

kieranrk · 4th February 2010, 16:14

Quote:

Originally Posted by mp3dom

Thank you very much! Since you're so kind, can I ask what are the next steps before final commit? Is there something new that need to be tested? (with the Interra verifier I cannot test anything more). Thanks again!

Need to fix max_cpb_delay_length with pulldown changes because it's wrong.
Also need to fix bug with calculation of displayed frames because it doesn't take into account any new parameters pass with the frame.

Needs a pengvado review.

Quote:

Ready to patch. The @@ get removed by patebin...

Use the download button in pastebin.

rallymax · 4th February 2010, 18:28

Quote:

Originally Posted by kieranrk

Use the download button in pastebin.

I did that and it still wouldn't apply.
what are you all using as your patching command line - and is in on Msys?

kieranrk · 4th February 2010, 18:52

patch -p1 <in.diff

If it doesn't work I'll post a new one.

rallymax · 4th February 2010, 19:20

Quote:

Originally Posted by kieranrk

Version 1.22.

Patch: http://pastebin.com/m6ed0b13a

I used the above URL and did "download" and saved it as "nal-hrd-1.2.2.diff".

I then applied it in a Msys to a vanilla git checkout on Windows7 and got this error...

rallymax@CARTMAN /c/SVN/x264 <--- don't let the SVN throw you off. it is a git directory.
$ patch -p1 < nal-hrd-1.2.2.diff
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

So I have no idea what's wrong. Note, that I've never applied a patch before so it could be the host that's screwed up not the patch itself.

alwa · 4th February 2010, 19:22

Quote:

Originally Posted by kieranrk

Use the download button in pastebin.

That does not help, the @@ are still missing... Try yourself if you don't believe me.

The file i uploaded on mediafire contains them, it works with the following command:

Code:

patch -p1 < nal-hrd1.22_fix.diff

1st February 2010, 21:45	#42 \| Link
Trahald Wewkiee Join Date: Feb 2002 Location: kashyyyk Posts: 2,269	While in practice it may be different, 1080p25 is not allowed. __________________ ...yeah...but...why on earth would I compare apples with apples?

2nd February 2010, 00:23	#45 \| Link
Atak_Snajpera RipBot264 author Join Date: May 2006 Location: Poland Posts: 7,946	PS3 plays 1080p 25fps without problems. I wouldn't be surprised if this also applies to other good brands. __________________ Windows 7 Image Updater - SkyLake\KabyLake\CoffeLake\Ryzen Threadripper

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

2nd February 2010, 16:49	#47 \| Link
mp3dom Registered User Join Date: Jul 2003 Location: Italy Posts: 1,136	Back to the NAL patch: At the end I'm not understanding if the current patch version (1.22) match the specs posted by Emulgator.

3rd February 2010, 16:23	#50 \| Link
renqian Registered User Join Date: Jan 2010 Posts: 6	here some primary question: which Splitter Filter should i use to keep the field won't loss when i encoding? and which decoder can playback the product correctly in 60fps on LCD or LCD TV?(i mean if i use the HTPC)

3rd February 2010, 16:45	#51 \| Link
rack04 Registered User Join Date: Mar 2006 Posts: 1,538	Is anyone able to patch the latest git with v1.22?

3rd February 2010, 23:49	#52 \| Link
rallymax Rallymax Join Date: Aug 2009 Location: Santa Clara CA Posts: 55	no. I've just manually done the change . When I get home I'll copy it onto my SVN tree so that I can generate a diff and post it.

4th February 2010, 13:55	#55 \| Link
jpsdr Registered User Join Date: Oct 2002 Location: France Posts: 2,637	Can someone make a patch with it and the autoVAQ ? Thanks.

4th February 2010, 18:52	#58 \| Link
kieranrk Registered User Join Date: Jun 2009 Location: London, United Kingdom Posts: 707	patch -p1 <in.diff If it doesn't work I'll post a new one.