Avisynth+ plugin modernization efforts

[ChaosKing]

Originally Posted by LigH

Does anyone know a source template for an AviSynth audio plugin that I might try to implement it myself, despite having hardly any practical experience in C/C++ coding? For someone with experience, I guess it might only take a weekend...

Is Vapoursynth, but maybe it can be helpfull too (not much code) https://github.com/dubhater/vapoursynth-damb

[LigH]

Sorry, no, VapourSynth is based on Python, which I know even less than C.

[ChaosKing]

Originally Posted by LigH

Sorry, no, VapourSynth is based on Python, which I know even less than C.

But the plugin is written in cpp...

[LigH]

But it is for a VapourSynth plugin interface. The AviSynth plugin interface is probably different, I would assume.

I saw that the AviSynthPlus repo comes with sources of the Shibatch Sampling Rate Converter (SSRC), that might be a convenient base to derive from.
But I also noticed that I won't be able to do that, with all the C++ interface syntax I am not used to, and related compiler control files...

[Jamaika]

Originally Posted by LigH

But it is for a VapourSynth plugin interface. The AviSynth plugin interface is probably different, I would assume.

AviSynth in VapourSynt is a mod of old version V3.
I am annoyed by plugins in ffmpeg AviSynth/VapourSynt opened as shared AviSynth/VapourSynt DLL.
In AviSynth_c you have all the functions you can open but warmigs are.

avisynth_c.cpp: In function 'int avs_is_yv24(const AVS_VideoInfo*)':
avisynth_c.cpp:66:63: warning: bitwise operation between different enumeration types '<unnamed enum>' and '<unnamed enum>' is deprecated [-Wdeprecated-enum-enum-conversion]
   66 |   return (p->pixel_type & AVS_CS_PLANAR_MASK) == (AVS_CS_YV24 & AVS_CS_PLANAR_FILTER);
      |                                                   ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

Stream audio

static int avisynth_create_stream_audio(AVFormatContext *s, AVStream *st)
{
    AviSynthContext *avs = (AviSynthContext *)s->priv_data;

    st->codecpar->codec_type            = AVMEDIA_TYPE_AUDIO;
    st->codecpar->sample_rate           = avs->vi->audio_samples_per_second;
    st->codecpar->ch_layout.nb_channels = avs->vi->nchannels;
    st->duration                        = avs->vi->num_audio_samples;
    avpriv_set_pts_info(st, 64, 1, avs->vi->audio_samples_per_second);

    if (avs_get_version(avs->clip) >= 10)
        av_channel_layout_from_mask(&st->codecpar->ch_layout,
                                    avs_get_channel_mask(avs->vi));

    switch (avs->vi->sample_type) {
    case AVS_SAMPLE_INT8:
        st->codecpar->codec_id = AV_CODEC_ID_PCM_U8;
        break;
    case AVS_SAMPLE_INT16:
        st->codecpar->codec_id = PCM(S16);
        break;
    case AVS_SAMPLE_INT24:
        st->codecpar->codec_id = PCM(S24);
        break;
    case AVS_SAMPLE_INT32:
        st->codecpar->codec_id = PCM(S32);
        break;
    case AVS_SAMPLE_FLOAT:
        st->codecpar->codec_id = PCM(F32);
        break;
    default:
        av_log(s, AV_LOG_ERROR,
               "unknown AviSynth sample type %d\n", avs->vi->sample_type);
        avs->error = 1;
        return AVERROR_UNKNOWN;
    }
    return 0;
}

Modyfity cpp plugin ffmpeg static avisynth
https://www.sendspace.com/file/znalx3

[LigH]

Would you be able to help me building an audio plugin?

So far I already asked 3 people and did not get one reply yet.

[LigH]

A little teaser of what I would like to get implemented as AviSynth audio plugin; it already works as CLI application:



I wrote that in FreePascal (Lazarus). I cannot write it in C++.

[LigH]

I am now halfway successful. Could build plugins in MSYS2/MinGW and GCC 14.2 (M-AB-S interactive shell).

Only flaw: Despite linker flags containing parameters to statically link some GCC libs, the resulting plugins still depend on them.

CMakeCache contains

CMAKE_MODULE_LINKER_FLAGS:STRING=-D_FORTIFY_SOURCE=2 -fstack-protector-strong -mtune=generic -O2 -pipe -D__USE_MINGW_ANSI_STDIO=1 -static-libgcc -static-libstdc++
CMAKE_SHARED_LINKER_FLAGS:STRING=-D_FORTIFY_SOURCE=2 -fstack-protector-strong -mtune=generic -O2 -pipe -D__USE_MINGW_ANSI_STDIO=1 -static-libgcc -static-libstdc++

According to AVSmeter, the 32-bit plugin misses libgcc_s_dw2-1.dll, the 64-bit plugin misses libgcc_s_seh-1.dll
_

PS: Even when adding those (and libwinpthread-1.dll) to the plugins directory, it is still not useable as AviSynth plugin.

[LigH]

It has been done. In MSVC it worked.

AudioBoost plugin: binaries / min. docs / repo

Might replace dimzon's AudioLimiter.

[Emulgator]

Hi LigH, congrats !

I did not test it yet, so just a tip about the wording to avoid ambiguities:
In audio the terms "Limiter, Compressor" are reserved for devices/algorithms which regulate gain and avoid distortion at any cost
(the regulation phase excluded, here a carefully chosen lookahead/time constant combo may serve to make distortion unnoticeable)

Going from the graphs you published I would guess that your algo remaps sample values, not gain,
so can be seen now as a soft clipper with selectable curves which is in any case nice to have.

I see arbitrary curves coming, or introduction of a sidechain input.
In the end you will be on the way to LigH's Arbitrary Audio Modulator allowing stranger audio FX like ring modulation etc.

[Jamaika]

What does it mean?
[avisynth @ 0000023dbcab78e0] Input audio sample format must be float.
I have no idea how to use it.
AudioBoost(4.0, 0.95, 1, true)

#define SAMPLE_FLOAT ???

[LigH]

http://avisynth.nl/index.php/ConvertAudio

ConvertAudioToFloat()
AudioBoost()

[Jamaika]

I don't know if it works correctly but you can test it.
https://www.sendspace.com/file/1vnpbw

AVISource("AudioBoost.avi")

# resize the dimensions of the video frame to 320x240
LanczosResize(320, 240)
ConvertAudioToFloat()
AudioBoost(4.0, 0.95, 1, true)

[tormento]

Is there any modern filter to dehalo properly?

I have tried many and some don't accept YV24 or they simply work so and so.

Any help is welcome.

P.S: Tried FineDehalo and DeHaloAlpha and, oh my god, parameters are such a mess for me.

[takla]

Originally Posted by tormento

Is there any modern filter to dehalo properly?

FFT3DFilter(sigma=0, bt=-1, dehalo=0.5)

If bt=-1 doesn't work use bt=1

[Selur]

LOL, I never noticed that ff3dfilter has a dehalo option. (okay, at least on it's own without masking it does not seem that useful)

[takla]

Originally Posted by Selur

(okay, at least on it's own without masking it does not seem that useful)

🤷 I found it useful when I used it in the past, where every other DeHalo overcomplicated things for a worse result.

[Selur]

Did a few tests and to me DeHalo_alpha and FineDeHalo both worked better on my sources.
Did you use some masking? Or did you use cartoon/anime content, where fine details are often a rare thing?

[takla]

Originally Posted by Selur

Did you use some masking? Or did you use cartoon/anime content, where fine details are often a rare thing?

No masking. The source was real world camera footage of a PAL TV show. The ringing was very bad. I think they used early digital cameras. The dehalo from FFT3DFilter produced a gloomy like image which I much preferred.

I think I also denoised chroma (for DeRainbow) so FFT3D really came in handy here.

I'd share a clip, but I need to rebuild my desktop, which will take me some months. (Waiting for Black Friday or similar good deal on some parts)

[LigH]

AudioBoost 0.2 is now available with both interfaces (C++/2.6-MSVC and C/2.5).