AviSynth+ thread Vol.2

[Jamaika]

Originally Posted by StainlessS

Jamaika, is that YOUR code, or Avs+ code ?

If yours (where post is Off Topic in this thread), then how about

if (!(vi.IsPlanar() || vi.IsPlanarRGB() || vi.IsPlanarRGBA()))
            throw_error("clip must be planar");

This is of e.g. avsresize but IsPlanar() is present in many add-ons to AVS+.

[StainlessS]

... but IsPlanar() is present in many add-ons to AVS+.

Yep, but you have to use it correctly.

if (!vi.IsPlanar() || !vi.IsPlanarRGB() || !vi.IsPlanarRGBA())
            throw_error("clip must be planar");

Your code says, if any one of (IsPlanar, IsPlanarRGB, IsPlanarRGBA) is false then throw error,
so, as at least one of them (actually at least 2 of them) is always false, so will always throw an error.

Mine

if (!(vi.IsPlanar() || vi.IsPlanarRGB() || vi.IsPlanarRGBA()))
            throw_error("clip must be planar");

says, if all of (IsPlanar, IsPlanarRGB, IsPlanarRGBA) are false then throw error.

EDIT: This would also work (if all isPlanarXXX false)

if (!vi.IsPlanar() && !vi.IsPlanarRGB() && !vi.IsPlanarRGBA())
            throw_error("clip must be planar");

[Jamaika]

So I open the planar documentation. I assume that YUV420P8 is planar so the codec should work but it doesn't for gcc 14.2.0. I'm testing 11.5.0 now. I'll know soon.
http://avisynth.nl/index.php/Planar

[StainlessS]

Just use either of the code snippets I gave in post #3062, it will work, It is your logic that is wrong.

either,

if (!(vi.IsPlanar() || vi.IsPlanarRGB() || vi.IsPlanarRGBA()))
            throw_error("clip must be planar");

OR

if (!vi.IsPlanar() && !vi.IsPlanarRGB() && !vi.IsPlanarRGBA())
            throw_error("clip must be planar");

[Jamaika]

Originally Posted by StainlessS

if (!vi.IsPlanar() && !vi.IsPlanarRGB() && !vi.IsPlanarRGBA())
            throw_error("clip must be planar");

I simply deleted it and it worked, but I wonder what IsPlanar() does.

For me, this entry is incorrect.
What is the meaning of writing for the value if (1 and 0 and 0) it will be zero.

[pinterf]

Originally Posted by Jamaika

I simply deleted it and it worked, but I wonder what IsPlanar() does.

For me, this entry is incorrect.
What is the meaning of writing for the value if (1 and 0 and 0) it will be zero.

If you read your problematic expression aloud in your native language, you'll likely start to sense what's wrong with it.

[Jamaika]

Originally Posted by pinterf

If you read your problematic expression aloud in your native language, you'll likely start to sense what's wrong with it.

I'm not going to think about it.

It doesn't work. when I delete the record it works.
z_ConvertFormat(pixel_type="YUV420P8", colorspace_op="709:709:709:full=>709:709:709:limited", dither_type="none")

Saved by fastblur
for (int pid = 0; pid < vi.NumComponents(); pid++) {
bool uv = _planes[pid] == PLANAR_U || _planes[pid] == PLANAR_V;
planes.push_back({
vi.IsPlanar() ? _planes[pid] : 0,
vi.IsPlanar() ? 0 : pid,
vi.IsPlanar() ? 0 : vi.NumComponents(),
!(uv || _planes[pid] == PLANAR_A), uv,
uv ? uv_pyramid : y_pyramid,
uv ? sub_w : 0,
uv ? sub_h : 0
});
}

Edit: For gcc 11.5.0 IsPlanar() doesn't work. So my previous arguments are worthless since the basic function doesn't work.
https://www.sendspace.com/file/16t0ja

[StainlessS]

Again, your logic is wrong.
One of the correct ones given

if (!vi.IsPlanar() && !vi.IsPlanarRGB() && !vi.IsPlanarRGBA())
            throw_error("clip must be planar");

!IsPlanar   !IsPlanarRGB    !IsPlanarRGBA       AND
0           0               0                   0
0           0               1                   0
0           1               0                   0
0           1               1                   0
1           0               0                   0
1           0               1                   0
1           1               0                   0
1           1               1                   1    NOT Planar && NOT PlanarRGB  && NOT PlanarRGBA, then ThrowError

EDIT: OR,

if (!(vi.IsPlanar() || vi.IsPlanarRGB() || vi.IsPlanarRGBA()))
            throw_error("clip must be planar");

IsPlanar    IsPlanarRGB     IsPlanarRGBA        OR        NOT
0           0               0                   0         1     ! (Planar || PlanarRGB || PlanarRGBA), then ThrowError
0           0               1                   1         0
0           1               0                   1         0
0           1               1                   1         0
1           0               0                   1         0
1           0               1                   1         0
1           1               0                   1         0
1           1               1                   1         0

[Jamaika]

Originally Posted by StainlessS

!IsPlanar   !IsPlanarRGB    !IsPlanarRGBA       AND
0           0               0                   0
0           0               1                   0
0           1               0                   0
0           1               1                   0
1           0               0                   0
1           0               1                   0
1           1               0                   0
1           1               1                   1    NOT Planar && NOT PlanarRGB  && NOT PlanarRGBA, then ThrowError

Correct train of thought, but it would mean that videos for avsresize must always be interlaced. I don't know anything about that.
http://avisynth.nl/index.php/Avsresize

[StainlessS]

What has interlaced got to do with your assertion about IsPlanar being wrong ???
EDIT: Planar has nothing to do with being interlaced, it is the color format in memory [being in planes, rather than interleaved eg RGB24 or YUY2]
[ Planar can be interlaced or not (ie Progressive), Interleaved color formats can be interlaced or not (ie Progressive) ]

Planar means storage for each color channel is stored separately and contiguously, eg
RGB planar, stored as RRRRRRRRRR, GGGGGGGGGG, BBBBBBBBBB. Each channels pixel values stored together, in planes.
RGB24, RGB Interleaved stored as RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB. Each pixel channels stored together Interleaved (although usually as BGR, I think).

EDIT: Wiki Color Format:- https://avisynthplus.readthedocs.io/...#color-formats
EDIT: The color formats: RGB, YUY2 and YV12:- https://avisynthplus.readthedocs.io/...-yuy2-and-yv12
EDIT: Colorspaces:- https://avisynthplus.readthedocs.io/...lorSpaces.html
Planar:- http://avisynth.nl/index.php/Planar
Interleaved:- http://avisynth.nl/index.php/Interleaved

Interlaced versus field-based video :- http://avisynth.nl/index.php/Interlaced_fieldbased
Advanced topics:- http://avisynth.nl/index.php/Advanced_topics

[Jamaika]

Originally Posted by StainlessS

What has interlaced got to do with your assertion about IsPlanar being wrong ???
EDIT: Planar has nothing to do with being interlaced, it is the color format in memory [being in planes, rather than interleaved eg RGB24 or YUY2]
[ Planar can be interlaced or not (ie Progressive), Interleaved color formats can be interlaced or not (ie Progressive) ]

Planar means storage for each color channel is stored separately and contiguously, eg
RGB planar, stored as RRRRRRRRRR, GGGGGGGGGG, BBBBBBBBBB. Each channels pixel values stored together, in planes.
RGB24, RGB Interleaved stored as RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB,RGB. Each pixel channels stored together Interleaved (although usually as BGR, I think).

EDIT: Wiki Color Format:- https://avisynthplus.readthedocs.io/...#color-formats
EDIT: The color formats: RGB, YUY2 and YV12:- https://avisynthplus.readthedocs.io/...-yuy2-and-yv12
EDIT: Colorspaces:- https://avisynthplus.readthedocs.io/...lorSpaces.html
Planar:- http://avisynth.nl/index.php/Planar
Interleaved:- http://avisynth.nl/index.php/Interleaved

Interlaced versus field-based video :- http://avisynth.nl/index.php/Interlaced_fieldbased
Advanced topics:- http://avisynth.nl/index.php/Advanced_topics

Maybe, my input codec is:
Planar YUV Formats: I420 0x30323449 12 8 bit Y plane followed by 8 bit 2x2 subsampled U and V planes.

  Avisynth function: LWLibavVideoSource [input_yuv420p.mp4, 30000, 1001]
Input #0, avisynth, from 'AudioBoost3.avs':   0KB sq=    0B
  Duration: 00:42:05.52, start: 0.000000, bitrate: 0 kb/s
  Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p(progressive), 704x480, 29.97 fps, 29.97 tbr, 29.97 
tbn

The problem is with:

  Avisynth function: LWLibavVideoSource [input_yuv420p.mp4, 30000, 1001]
  Avisynth function: z_ConvertFormat [YUV420P8, 709:709:709:limited=>709:709:709:limited, none]
[avisynth @ 000002f02ad57f60] avsresize: clip must be planar.

test wiki:
LWLibavVideoSource("input_rgb24.avi",fpsnum=30000,fpsden=1001)
ConvertToPlanarRGB()
z_ConvertFormat(pixel_type="YUV420P8", colorspace_op="rgb:709:709:full=>709:709:709:limited")

[avisynth @ 000002f02ad57f60] avsresize: clip must be planar.

[pinterf]

This one is really tricky: I420 is a variant of YV12, but their colorspace constants differ. Some filters can only accept and check against the exact YV12 format.

This is why VideoInfo::IsSameColorspace
- first checks for exact code match,
then if no exact match then
- it compares the two VideoInfo's IsYV12() which reports true even if the clip is I420 _or_ YV12.

[wonkey_monkey]

Some questions spring to mind:

Can we see the whole script, just to make absolutely sure nothing else is happening?
Did you compile both AviSynth+ and AVSResize with GCC? Have you made any other changes to either of them?

[Jamaika]

Originally Posted by wonkey_monkey

Did you compile both AviSynth+ and AVSResize with GCC? Have you made any other changes to either of them?

Everything is possible, but this is a curiosity. Is this a gcc, mingw64 bug? Others on this forum add codecs x264,x265,vvenc,...

[wonkey_monkey]

Originally Posted by Jamaika

Everything is possible, but this is a curiosity. Is this a gcc, mingw64 bug? Others on this forum add codecs x264,x265,vvenc,...

That doesn't answer my question. I think we may struggle here...

[StainlessS]

By Pinterf

This one is really tricky: I420 is a variant of YV1

I don't really think it is relevant. [But maybe]
It's the c code he's using somewhere [???, wherever he was using it, it WAS WRONG],
Don't know where he's using it.
On occasion some users change avs functions so they don't havta
provide fn args [ EDIT: bad idea ], me is guessing it's something like that.
{ Changes function, then wants help to make it work without telling what weird changes have been made/hard_coded }

Also, maybe should answer Wonkey Donkey questions.

[Emulgator]

Pinterf, hats off to you ! You did it. Beautiful.
Your AviSynth64+ version r4178-4182-uncommitted loads & unloads my reduced script in AvsPmod 2.7.9.2.
Processing finally with even CPU load, no more pulsing, and a beautiful speed gain !
And Topaz 2.6.4 eats the script happily and sees all frames. A dream came true.
Going deeper soon.

[pinterf]

Originally Posted by Emulgator

Pinterf, hats off to you ! You did it. Beautiful.
Your AviSynth64+ version r4178-4182-uncommitted loads & unloads my reduced script in AvsPmod 2.7.9.2.
Processing finally with even CPU load, no more pulsing, and a beautiful speed gain !
And Topaz 2.6.4 eats the script happily and sees all frames. A dream came true.
Going deeper soon.

... Somewhere I knew it I received a fabulous Sleep Score of 82 from my Garmin. Thanks for your time. I'll make these commits live now.

[tormento]

If only Dogway would take advantage of the new features in his scripts…

[pinterf]

Freshly built v4193.

- 32 and 64-bit XP compatible versions
- 64 bit Intel ICX compiled version (only Avisynth.dll, plugins were just copied)
May require Intel C++ 2025 redistributable: https://www.intel.com/content/www/us...y-version.html

Download Avisynth+ 3.7.3 r4193 test:
https://github.com/pinterf/AviSynthP...ag/v3.7.3.4193

Changes since official 3.7.3
https://avisynthplus.readthedocs.io/...gelist374.html
and
https://avisynthplus.readthedocs.io/...-v11-whats-new
and millions of updated documentation pages.