AviSynth+ thread Vol.2

[FranceBB]

Out of curiosity, what about propclearall() right after indexing?

[Selur]

ClearAutoloadDirs()
LoadPlugin("I:\INNOIN~1\64bit\Avisynth\AVISYN~1\LSMASHSource.dll")
LoadPlugin("I:\INNOIN~1\64bit\Avisynth\AVISYN~1\MosquitoNR.dll")
LWLibavVideoSource("G:\TESTCL~1\test.avi",cache=false,dr=true,format="YUV420P8", prefer_hw=0)
propclearall()
MosquitoNR()
ConvertToRGB32(matrix="Rec601")
return last

also crashes at the initial invoke call and without the 'ConvertToRGB32' it crashes when 'ConvertToRGB32' is later called.
-> no change

[FranceBB]

Ok, so I've tried to test a bit:

ColorBars(848, 480, pixel_type="YV12")
MosquitoNR()
ConverttoRGB(matrix="Rec601")

works.
So I tried with a real video, an XDCAM-50 file and it works too:

FFVideoSource("\\mibctvan000.avid.mi.bc.sky.it\Ingest\MEDIA\temp\Test9_UCN_manual_QC_SubITA_DolbyE_DolbyE_PCM_PCM.mxf")
propClearAll()
MosquitoNR()
ConverttoRGB(matrix="Rec601")

Last but not least, I've tried LWLibavVideoSource() which is the indexer you were trying to use and... it works:

LWLibavVideoSource("\\mibctvan000.avid.mi.bc.sky.it\Ingest\MEDIA\temp\Test9_UCN_manual_QC_SubITA_DolbyE_DolbyE_PCM_PCM.mxf")
propClearAll()
MosquitoNR()
ConverttoRGB(matrix="Rec601")

and even your exact same command line:




Avisynth 3.7.2 Stable x64
Windows 11 x64

Out of curiosity, are you using this build of MosquitoNR? Link

[Selur]

I know that it works in avspmod, problem is that it does not work in my code.

Out of curiosity, are you using this build of MosquitoNR?

Yes, I do.

Cu Selur

[pinterf]

Originally Posted by Selur

Using latest AviSynth+ 3.7.2

When I use:
...
my code crashes when loading the the file:

AVS_linkage = m_env->GetAVSLinkage();
    const char* infile = m_currentInput.toLocal8Bit(); //convert input name to char*
    std::cout << "Importing " << infile << std::endl;
    AVSValue arg(infile);
    m_res = m_env->Invoke("Import", AVSValue(&arg, 1)); // <- here it dies

see: https://github.com/Selur/avsViewer/b...iewer.cpp#L142
...
-> any idea?

Cu Selur

Just a faint guess. it is the first use of m_res. Maybe the crash is related to it.
In the avsViewer::avsViewer there is an initialization of AVSValue m_res in that initialization list. Here:
https://github.com/Selur/avsViewer/b...Viewer.cpp#L28
But the global variable const AVS_Linkage *AVS_linkage which is needed as a bridge to fill/initialize an AVSValue does not exist yet. I'd try to remove m_res from the initialization list. Otherwise your code seems to be correct: toLocal8Bit is providing a safe null-terminated buffer; I guess 'm_env' exists just fine, so GetAVSLinkage should work as well.

[Selur]

Sadly, removing m_res from the initialization list doesn't help.
The strange thing is that if the .avs script doesn't include any "ConvertTo..." calls the loading of the script works fine, but then it crashes when I call ConvertToRGB32. :/
When I use:

bool avsViewer::invokeFunction(const QString& name)
{
  try {
    std::cout << "invoking " << qPrintable(name) << std::endl;
    const char* function = name.toLocal8Bit();
    if (!m_env->FunctionExists(function)) {
       m_env->ThrowError(name.toLocal8Bit() + " does not exist!");
    }
    m_res = m_env->Invoke(function, AVSValue(&m_res, 1)); // invoking the function
    std::cerr << "invoked " << qPrintable(name) << std::endl;
    return true;
  } catch (AvisynthError err) { //catch AvisynthErrors
    std::cerr << "Avisynth error " << qPrintable(m_currentInput) << ": " << std::endl << err.msg << std::endl;
  } catch (...) { //catch the rest
    std::cerr << "Unknown C++ exception" << std::endl;
  }
  return false;
}

I see:

Initializing the avisynth script environment,..
loaded avisynth dll,..(I:/workspace/avsViewer/release/AviSynth.dll)
loaded CreateScriptEnvironment definition from dll,..
Importing c:\Users\Selur\Desktop\test.avs

Color: YV12, Resolution: 640x352, Frame rate: 25 fps, Length: 429 frames, PRO

Current color space: YV12
invoking ConvertToRGB32

so it dies in

m_res = m_env->Invoke(function, AVSValue(&m_res, 1)); // invoking the function

This is driving me nuts.

Cu Selur

[Ceppo]

I'm not in the right mind at the moment but:

m_res = m_env->Invoke(function, AVSValue(&m_res, 1)); // invoking the function

Is assigning a value to m_res and to use it with a reference at the same time... legit??

/I'mNotAProgrammer

[Selur]

Since the right side should be evaluated before the assignment I see no problem with it.

Cu Selur

Ps.: Can someone compile MosquitoNR with MVSC++ 2019?

[wonkey_monkey]

We should probably pop all this out into its own thread. But for now, I can confirm that

		temp = env->Invoke("colorbars", 1280); // how do you invoke a filter with no parameters?
		temp = env->Invoke("converttoyv12", AVSValue(&temp, 1));
		temp = env->Invoke("mosquitonr", AVSValue(&temp, 1));
		temp = env->Invoke("converttorgb32", AVSValue(&temp, 1));

crashes (MSVC2019, Avisynth+ 3.7.1), but doesn't crash if I remove the converttogrb32.

Yet putting ConvertToRGB32 directly in a script after MosquitoNR works fine. Very strange.

[Reel.Deel]

Originally Posted by Selur

Ps.: Can someone compile MosquitoNR with MVSC++ 2019?

For x64 it would have to be with the Intel compiler since the source contains assembly.

On a side note, for anyone with the means to do it. The following plugins were all compiled with the Intel compiler as well. Downside is that they are compiled for the 2.5 interface and may be problematic as stated here: https://github.com/AviSynth/AviSynthPlus/issues/272

Originally Posted by pinterf

Not only unaware of frame props.
SmoothD2 is an AviSynth 2.5 plugin which can use hardcoded ("baked") code for frame manipulation instead of Avisynth interface calls. Behavior is uncontrolled and random.

• Decomb
• IT_YV12
• MosquitoNR
• SmoothD
• SmoothD2

A 2.6 interface update for these plugins would be appreciated .

[Selur]

But for now, I can confirm that

Man I'm happy that this does not happen to just me.

crashes (MSVC2019, Avisynth+ 3.7.1), but doesn't crash if I remove the converttogrb32.

hmm,.. I'm using 3.7.2 and there "putting ConvertToRGB32 directly in a script after MosquitoNR" does not work fine here. :/

A 2.6 interface update for these plugins would be appreciated

Yup, that would be cool.

Cu Selur

[wonkey_monkey]

I'm trying to build 3.7.2 from source with MSVC 2019. I download the source, use "Open a local folder" and it imports everything fine. I then go to Manage Configurations... which gives me a GUI to make changes to CMakeSettings.json. I take out the default Debug build and replace it with x64-Release, and I change the Configuration type to Release.

When I try to build, I get a number of unresolved externals:

The funny thing is I can do the exact same thing on my work computer, and it works fine. But not at home. Does anyone know what's wrong with my setup? Am I missing some required part of MSVC?

Edit: I CAN successfully build an x64-Debug version. But not Release.

[wonkey_monkey]

Originally Posted by Selur

hmm,.. I'm using 3.7.2 and there "putting ConvertToRGB32 directly in a script after MosquitoNR" does not work fine here. :/

Does your program still invoke ConvertToRGB32 when it is already in the script?

What worked for me was putting ConvertToRGB32 in a script and then running the script with AVSMeter64. If I try to load the script in my viewer - which invokes ConvertToRGB32 a further time, regardless of what type the script produces - it crashes.

[Selur]

Does your program still invoke ConvertToRGB32 when it is already in the script?

Nope, ConvertToRGB32 is only invoked if the input isn't already RGB32.

[pinterf]

Originally Posted by wonkey_monkey

I'm trying to build 3.7.2 from source with MSVC 2019. I download the source, use "Open a local folder" and it imports everything fine. I then go to Manage Configurations... which gives me a GUI to make changes to CMakeSettings.json. I take out the default Debug build and replace it with x64-Release, and I change the Configuration type to Release.

When I try to build, I get a number of unresolved externals:

The funny thing is I can do the exact same thing on my work computer, and it works fine. But not at home. Does anyone know what's wrong with my setup? Am I missing some required part of MSVC?

Edit: I CAN successfully build an x64-Debug version. But not Release.

I've never used cmake from Visual Studio GUI.
I'm using CMakeGUI and using it to generate the .sln solution for all projects and dlls in Avisynth+.
https://avisynthplus.readthedocs.io/...from-cmake-gui
Then I open the generated sln and can use both debug and release build from Visual Studio IDE.

[Ceppo]

Might be unrelated, but when I used invoke with vinverse, when passing directly the value in the invoke call I got the float converted to int for no reason, then I declared first the array and then I set the value of each index individually and the problem was gone, give it a shot, you got nothing to lose after all...

3 nights without sleeping

[Selur]

On my way to bed, you mean like this?

AVSValue tmp[1] = { &m_res }; 
m_res = m_env->Invoke(function, tmp);

(will try tomorrow after work)

[pinterf]

Is it easy and straightforward to build and use avsviewer cloned from git? Does it have any prerequisites?

[Ceppo]

On my way to bed, you mean like this?

AVSValue tmp[1];
tmp[0] =  &m_res;

[Dogway]

I wonder if frame props are broken? I expect frame properties assigned to frame 0 be retrieved outside a runtime environment.

ScriptClip( function[] () {
SelectEvery(1,-current_frame)
AverageLuma() > 98 ? propSet("_TestFP", 4) : propSet("_TestFP", 1)
SelectEvery(1, current_frame)
subtitle(string(AverageLuma()),align=8,y=100)
} )

subtitle(string(propGetInt("_TestFP")),align=8)