Unable to compile an AviSynth C++ DLL

[Gavino]

Originally Posted by StainlessS

Methinks that the Gavino Bonus Points were aimed at Grouchy.

Not really, I just assumed Groucho had copied the example from somewhere else.

The problem with the code is that those variables should just be local variables inside GetFrame, especially since nothing else uses them. Putting them at the class level means that two threads cannot call GetFrame at the same time (on a single instance of the filter) without interfering with each other.

[StainlessS]

Apologies to the Grouchy man, Gavino, you seemed to me to be a Sort of teacher,
no longer. Why would you expect a newbie to consider multi threading, I dont understand that
and I consider myself not a total newbie.
Gavino, methinks you were not at your best there.
Appologies to the Grouchy man (He He).
Bit pissed at the moment, but, will, (god wiilling, [if there is such an object])
arise, again.

[Groucho2004]

Originally Posted by StainlessS

Bit pissed at the moment

That's obvious.

For tomorrow when you're sober: How to develop thread safe filters

[Gavino]

Originally Posted by StainlessS

Why would you expect a newbie to consider multi threading, I dont understand that
and I consider myself not a total newbie.

I wouldn't expect a newbie to be aware of the issues, but was flagging it for his attention at some later time.

At a simpler level, there was also the point that variables that were only required inside one function, and not needed to persist, were declared at the class level, which is bad practice regardless of the multithreading issue.