Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Usage

Reply
 
Thread Tools Search this Thread Display Modes
Old 2nd March 2022, 00:32   #981  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,134
@Dogway I think you don't need change name when result don't different. And i say again why need Dogway change name of plugin when he develope it from 2015??
https://github.com/Dogway/Avisynth-S.../QTGMC.avsi#L4
kedautinh12 is online now   Reply With Quote
Old 2nd March 2022, 01:09   #982  |  Link
coolgit
Registered User
 
Join Date: Apr 2019
Posts: 213
Currently the avisynth site QTGMC link doesn't work since realfinder change his link to STGMC. My point is that newbies need simple access and working links. If dogway QTGMC is the current version then the links need to reflect that. Broken links put newbies off. Avisynth is hard to learn step by step and broken links isn't going to help.

Staxrip has the ability to update avs filters but can not access QTGMC at the moment. It seems there are some communication breakdown. Perhaps realfinder changed QTGMC to STGMC too early. Better coordination of changes to links would be the way to go.
coolgit is offline   Reply With Quote
Old 2nd March 2022, 01:29   #983  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
It's a matter of coming to an agreement. My stance was it was ok to keep function name but now if we agree (given gispos issues) we can change the name if output differs purposefully, doesn't matter how you reach there code-wise.
So in those terms for me real.finder can keep name and I will change those that changed behaviour like LSFmod or QTGMC. An exception for SMDegrain since I built it from the ground up basically.

If other filters' output are the same or very near the same, like Deblock_QED(), NonlinUSM() (should be identical to original, currently further refining it for resolution-aware), etc for me it's fine to keep function name the same, albeit calling the filter blabla mod or something. Maybe we can also do the same for abandon-ware, an example is ChromaReconstructor_faster, I modified it to have different bicubic coefficients but the purpose is the same. Same with SPresso(), output should be the same I just extended it to support HD sources but keeping the intention.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 2nd March 2022, 03:02   #984  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by Dogway View Post
Didn't mean that, my point was (replying gispos) that despite QTGMC mod being a tiny bit slower than STGMC at 8-bit it's way faster for HBD which was it's main purpose for the mod to start with. I changed a few output related things some months back and plan to do further with Zopti findings so I'll be doing more changes.

I will change the name of QTGMC and LSFmod to start with since I added critical output improvement. Probably with 'plus' as suffix since now it supports also frameprops aside HBD.
well, my QTGMC mod based on your old mod, also I did make it use dither_luma_rebuild by default so it also not 100% same output and speed as the original one, so I will keep it as STGMC

Quote:
'plus' as suffix
this is the best option that will also let the user know that it is a version for avs+ only
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 2nd March 2022, 11:59   #985  |  Link
StvG
Registered User
 
Join Date: Jul 2018
Posts: 438
I agree that the duplicated names should be changed especially if both versions are still maintained.
And moreover not only if the output is different but also if the requirements are totally different. For example when I use X filter and see a newer or modded filter with the same name I'm assuming that I can just download the new X filter and use it directly out of the box, but this is not the case here - we have to download a whole new set of requirements.
StvG is offline   Reply With Quote
Old 2nd March 2022, 12:46   #986  |  Link
Reel.Deel
Registered User
 
Join Date: Mar 2012
Location: Texas
Posts: 1,664
Quote:
Originally Posted by StvG View Post
I agree that the duplicated names should be changed especially if both versions are still maintained.
And moreover not only if the output is different but also if the requirements are totally different. For example when I use X filter and see a newer or modded filter with the same name I'm assuming that I can just download the new X filter and use it directly out of the box, but this is not the case here - we have to download a whole new set of requirements.
I 100% agree with the requirement argument. If the "mod" script requires x amount of other supporting scripts/plugins to work then it should have a different name. I have always tried to maintain the QTGMC wiki page up-to-date but have not recently, not only because of other things I'm doing but because of the requirements changing. I remember when the script all of a sudden required SMDegrain to work, and then for YUY2 you needed PlanarTools (because converting to YV16 and and back to YUY2 at the end is waaaayyy too hard lol). For some other options you needed AnimeIVTC... and the list goes on. It will be one thing if at least it were documented, but sometimes it was not, and that is very off-putting and causes confusion. In those cases I think it's better for everyone if it has a different name.

TL;DR: if the modded script cannot be used as turnkey drop-in replacement, maybe it's best if it has a different name.
Reel.Deel is offline   Reply With Quote
Old 2nd March 2022, 12:50   #987  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,967
Yip, seems we are tryin' to emulate M$ DLL hell

DLL Hell:- https://en.wikipedia.org/wiki/DLL_Hell
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???
StainlessS is offline   Reply With Quote
Old 2nd March 2022, 18:26   #988  |  Link
gispos
Registered User
 
Join Date: Oct 2018
Location: Germany
Posts: 983
@Dogway, I think it's great what you are doing and some things I really like. But please, I don't want to be forced to use all of your filters if I only want to use one.

With time (if you modify even more filters) it will become even more confusing. And filters are replaced in the background without my knowledge.
But I would like to determine myself what I use and certainly not be forced to do so. Or I have to rename the filters myself or copy them to another avs.

If you do not know, as was the case with me, you wonder what is suddenly going on and is an eternity looking for why the settings no longer fit.
__________________
Live and let live
gispos is offline   Reply With Quote
Old 3rd March 2022, 02:00   #989  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,134
Dogway changed QTGMC to QTGMCp and LSFmod to LSFplus. When real.finder changed QTGMC to STGMC and don't change back QTGMC. I need download again old QTGMC which don't different STGMC, it's waste space for this. "Thank" anyone who request Dogway change name of QTGMC
kedautinh12 is online now   Reply With Quote
Old 3rd March 2022, 04:29   #990  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by kedautinh12 View Post
Dogway changed QTGMC to QTGMCp and LSFmod to LSFplus. When real.finder changed QTGMC to STGMC and don't change back QTGMC. I need download again old QTGMC which don't different STGMC, it's waste space for this. "Thank" anyone who request Dogway change name of QTGMC
avsi scripts take only few Kilobytes
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 3rd March 2022, 04:51   #991  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,134
Quote:
Originally Posted by real.finder View Post
avsi scripts take only few Kilobytes
I'm obsessive-compulsive personality disorder (OCPD)
kedautinh12 is online now   Reply With Quote
Old 3rd March 2022, 11:47   #992  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
I updated LSFmod to LSFplus and QTGMC to QTGMCp. For others I'm waiting for propCopy to support negative selection, since many of my next versions will fall in round numbers and I don't plan to touch them any further.
I took the last day to think about it, and I'm not sure you thought on the implications.

Quote:
Originally Posted by Reel.Deel View Post
I 100% agree with the requirement argument. If the "mod" script requires x amount of other supporting scripts/plugins to work then it should have a different name. (...) I remember when QTGMC all of a sudden required SMDegrain to work, and then for YUY2 you needed PlanarTools (because converting to YV16 and and back to YUY2 at the end is waaaayyy too hard lol). For some other options you needed AnimeIVTC... and the list goes on. It will be one thing if at least it were documented, but sometimes it was not, and that is very off-putting and causes confusion. In those cases I think it's better for everyone if it has a different name.

TL;DR: if the modded script cannot be used as turnkey drop-in replacement, maybe it's best if it has a different name.
I make a great effort on documenting dependencies (not always sub-dependencies though).

Quote:
Originally Posted by StvG View Post
...I'm assuming that I can just download the new X filter and use it directly out of the box, but this is not the case here - we have to download a whole new set of requirements.
Quote:
Originally Posted by StainlessS View Post
Yip, seems we are tryin' to emulate M$ DLL hell

DLL Hell:- https://en.wikipedia.org/wiki/DLL_Hell
I'm not sure if you are for or against. Would you rather have heavy plugin+script fragmentation? ie. only for variable gaussian/binomial blur: GBlur2, ablur, BinomialBlur, GBlur, FastBlur, GaussianBlur, FRC_GaussianBlur42, FastGaussBlur. All unmaintained and/or slower than ex_gaussianblur() or vsTCanny(). Then each script doing the same task (like Highlightlimiter and ex_highlightlimiter() ) but you would rather keep VariableBlur.dll (for gaussianblur) and all the hundreds of duplicate plugins because different scripts require different plugins, having half a thousand files in the plugins directory with filters that do the exact same task. For me this is extremely confusing, specially for beginners.

In contrast for most of my mods the only dependencies are ExTools and ResizersPack, not adding this dependencies on top but shifting them from masktools, rgtools and the myriad of blurring filters. That means, most of my scripts are VERY low on dependencies (more so in EX mods) since ExTools already includes a bunch of low level filters like mean/gaussian/median/bilateral blurs and spatial/temporal denoisers.

To put it in perspective, this is a change of paradigm because most of my mods (even those I rescued from the death) will have to change name, same for real.finder mods which also have external dependencies (mostly Zs_RF_Shared), and now we will end with 3 script versions of the same filter and the end user being further confused. QTGMC, STGMC and QTGMCp. Is this ok?

______________

On another note I refined NonlinUSM() the fit was mostly fine (was fine in a previous commit), but on my reference script I had at the end:
Code:
mt_lutxy(o,"x 0 > x y ? ")
Which I tried to trace back but didn't find any reference. So I removed it from the expression and now the filter gives 1:1 match to original.
Now comes the resolution issue and I need feedback because there are two approaches, mimic what it does at low resolution (I assumed it is designed around 480p), or adapt it for HD resolution. Comment and uncomment and let me know which one do you think fits best for HD.
Code:
function NonlinUSM(clip o, float "str", float "z", float "pow", float "rad", float "ldmp", int "UV") {

    rgb = isRGB(o)
    w   = width(o)
    h   = height(o)
    bi  = BitsPerComponent(o)
    fs  = propNumElements (o,"_ColorRange")  > 0 ? \
          propGetInt      (o,"_ColorRange") == 0 : rgb

    str = Default(str,  0.7)   # strength
    z   = Default(z,    6.0)   # zero point
    pw  = Default(pow,  1.6)   # power
    rad = Default(rad,  9.0)   # radius for "gauss"
    ldmp= Default(ldmp, 0.001) # damping for verysmall differences
    UV  = Default(UV,    rgb ? 3 : 1)

    z    = ex_bs(z,    8, bi, fulls=true, flt=true)
    ldmp = ex_bs(ldmp, 8, bi, fulls=true, flt=true)
    zd   = 1. / z
    pw   = 1. / pw

#    g = o.ex_GaussianBlur((w/720.)*rad*0.79-0.122,pad=true) # This is to match 480p
    g = o.ex_GaussianBlur((720./w)*rad*0.79-0.122,pad=true) # This is to adapt to HD sources (inversely proportional)

    p = Format(pw == 1 ? "{str}  * " : "{zd} * {pw} ^ {z} {str} * * ")
    ex_lutxy(o, g, Format("x dup y - A@ abs "+p+" A dup * dup {ldmp} + / * A sgn * +"), UV=UV, fulls=fs)
    }
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread

Last edited by Dogway; 3rd March 2022 at 11:55.
Dogway is offline   Reply With Quote
Old 3rd March 2022, 14:19   #993  |  Link
coolgit
Registered User
 
Join Date: Apr 2019
Posts: 213
Quote:
Originally Posted by Dogway View Post
To put it in perspective, this is a change of paradigm because most of my mods (even those I rescued from the death) will have to change name, same for real.finder mods which also have external dependencies (mostly Zs_RF_Shared), and now we will end with 3 script versions of the same filter and the end user being further confused. QTGMC, STGMC and QTGMCp. Is this ok?
I do not have a problem if you replace QTGMC with an improved version, if the original is no longer worked on, but my issue is this link http://avisynth.nl/index.php/QTGMC should be updated simultaneously if the page is going to be redirected from realfinder to yours. Otherwise newbies will be confused.

What about a QTGMC pack with all the other relevant filters according to the requirements, so newbies and others can download one file to unzip rather than 5, 10 15, 20 or so files separately.
coolgit is offline   Reply With Quote
Old 3rd March 2022, 14:34   #994  |  Link
kedautinh12
Registered User
 
Join Date: Jan 2018
Posts: 2,134
yeah, that's right, many versions with QTGMC when Dogway changed name. I think newbie hard to understand when looking for avs in first time
kedautinh12 is online now   Reply With Quote
Old 3rd March 2022, 18:15   #995  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by coolgit View Post
I do not have a problem if you replace QTGMC with an improved version, if the original is no longer worked on, but my issue is this link http://avisynth.nl/index.php/QTGMC should be updated simultaneously if the page is going to be redirected from realfinder to yours. Otherwise newbies will be confused.
I did update the wiki to freeze it on the last working QTGMC of my mod, but as I said, for people like gispos they have to set TV_range=false to get same output as Vit one
that all I can do for now

edit: @gispos check https://pastebin.com/raw/SYMD7ij5 the last update ever
__________________
See My Avisynth Stuff

Last edited by real.finder; 3rd March 2022 at 18:59.
real.finder is offline   Reply With Quote
Old 3rd March 2022, 20:11   #996  |  Link
coolgit
Registered User
 
Join Date: Apr 2019
Posts: 213
So when the time is right the present avisynth QTGMC link will direct to STGMC (still use TV_range=false) and a new page for updated dogway's QTGMC. Also http://avisynth.nl/index.php/External_filters deinterlacing section present QTGMC should be renamed STGMC (keeping description, plugin, colour format and author, the same) and a new addition for dogway's QTGMC (with new description, plugin, colour format and author).

Would the above be the best sensible way to go forwards?
coolgit is offline   Reply With Quote
Old 3rd March 2022, 20:38   #997  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
if gispos will be happy with https://pastebin.com/raw/SYMD7ij5 I will bring back the QTGMC to https://github.com/realfinder/AVS-Stuff and make the STGMC as a wrapper for QTGMC with TV_range as true by default
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 3rd March 2022, 23:13   #998  |  Link
coolgit
Registered User
 
Join Date: Apr 2019
Posts: 213
Dogway QTGMC requirements.

ExTools can't be found on main avisynth site. Also where is v8.0 or above, best i have found is 7.7.
SMDegrain avisynth link is dead, 404.
Zs_RF_Shared not in avisynth external filter page.
AddGrainC v1.8.4 avisynth page version number needs updating.
coolgit is offline   Reply With Quote
Old 3rd March 2022, 23:20   #999  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
Quote:
Originally Posted by coolgit View Post
Dogway QTGMC requirements.

ExTools can't be found on main avisynth site. Also where is v8.0 or above, best i have found is 7.7.
SMDegrain avisynth link is dead, 404.
Zs_RF_Shared not in avisynth external filter page.
AddGrainC v1.8.4 avisynth page version number needs updating.
That's not my issue but the wiki maintainers so report to them. In my repo you will find all you need.
As I said above I was waiting for propCopy to update (updated today) so I can update the rest of the filters.

As for updating the names, it looks like there's no agreement? real.finder back to QTGMC, and keeping function names, same as I.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 4th March 2022, 01:19   #1000  |  Link
coolgit
Registered User
 
Join Date: Apr 2019
Posts: 213
Quote:
Originally Posted by Dogway View Post
That's not my issue but the wiki maintainers so report to them.
I would have thought those who create filters/plugins inform the maintainers rather than the maintainers lurking around forums on the off chance someone done an update, etc.

Quote:
In my repo you will find all you need.
As I said above I was waiting for propCopy to update (updated today) so I can update the rest of the filters.
Does this updating the rest of the filters includes filters that QTGMC is relying on. I have downloaded all the necessary files and about to test your QTGMC and do some comparison. Should i hold off a bit until you finish your update or what?

Quote:
As for updating the names, it looks like there's no agreement? real.finder back to QTGMC, and keeping function names, same as I.
I think what realfinder is doing is temporary to fix broken link on avisynth site. I could be wrong.
coolgit is offline   Reply With Quote
Reply

Tags
avisynth, dogway, filters, hbd, packs

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 08:06.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.