Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Usage

Reply
 
Thread Tools Search this Thread Display Modes
Old 15th October 2021, 09:21   #561  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,500
Quote:
Originally Posted by Dogway View Post
I haven't installed VS
Don't give in to the dark side.
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 15th October 2021, 19:12   #562  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
No I won't. I look forward to Julia, much faster and probably easier to read (I hate the "X if true else false" of python).

Just updated SimilarityMetrics, vsSSIM had a few issues. Also finished BSSIM.
Also updated ResizersPack, main utility is nmod(), it converts any value to a set mod size, also has an option for minimum value (ie. nmod(n, 4, 16) ). You can also use bankers' rounding. New function PadBorders() pads the clip with borders in set 'mode', as in 'Dilate', 'Mirror' or a color '$000000'. And also updated MatteCrop() to work faster, the function still needs some work.

This weekend I will have a look at MatchClip() and update all the EX/MIX mods according.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 15th October 2021, 20:49   #563  |  Link
Julek
Registered User
 
Julek's Avatar
 
Join Date: Dec 2020
Posts: 83
I have a question about your ex_ContraSharpening, why do you use the result of "ssDD range_half -" or "ssD range_half -" to add to the denoised, and the original chooses between ssDD and ssD to then add to the denoised?

ex_CS: https://github.com/Dogway/Avisynth-S...Pack.avsi#L566
CS: https://github.com/realfinder/AVS-St...avsi#L603-L606
vs-CS: https://github.com/HomeOfVapourSynth...py#L5691-L5693
Julek is offline   Reply With Quote
Old 15th October 2021, 21:06   #564  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
The original version uses mt_adddiff() which does "ssDD range_half -" or "ssD range_half -" in itself, so their output needs to be range_half centered.
I do everything in a single step so no need to add (or keep) the centered values. This is faster.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 15th October 2021, 21:12   #565  |  Link
Julek
Registered User
 
Julek's Avatar
 
Join Date: Dec 2020
Posts: 83
But wouldn't mt_adddiff be like denoised + ssD (the whole ssD or ssDD)?

#EDIT: I guess I really didn't know how mt_adddiff works, I'll do some tests later.

Last edited by Julek; 15th October 2021 at 21:21.
Julek is offline   Reply With Quote
Old 15th October 2021, 21:24   #566  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
You want to add the pure difference. Centering the difference is to circumvent the unsigned nature of AviSynth+ int bitdepths.

mt_addiff() is actually "y range_half - x +".
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 16th October 2021, 11:53   #567  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,500
Quote:
Originally Posted by Dogway View Post
No I won't.
Can I make a request?

Something similar to RGBAdapt but more consistent and MT friendly, plus it still needs stacked to do HBD.

I have tried AutoAdjust too but it's just too slow to be useful on HD or 4K.

You made so many useful scripts that the only two things I can see missing is a motion stabilizer (a really working one, even for micromovements of film on the spool) and levels/gamma/RGB optimizer.

Those two can help a lot with old movies, directly ported to BD and even 4K with no restoration at all.
__________________
@turment on Telegram

Last edited by tormento; 16th October 2021 at 12:02.
tormento is offline   Reply With Quote
Old 16th October 2021, 19:01   #568  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
Did you try RGBAdapt or Gammac? The core principle is easy, the hard part is to work on scene bounds and temporally soften the effect to avoid chroma flicker. This has been done in plugins, I don't know of an easy way to do it at script level.

I usually apply a hue correction but at clip level so I avoid all those issues. Normally at two points, white level and grey level. Import the curve from Photoshop apply to RGB, convert to YUV and mergechroma with that.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 16th October 2021, 23:11   #569  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,500
Quote:
Originally Posted by Dogway View Post
Did you try RGBAdapt or Gammac?
Yes and yes. RGBAdapt is a script and I hope it could be improved, as it presents many limitations.
Quote:
Originally Posted by Dogway View Post
I usually apply a hue correction but at clip level so I avoid all those issues. Normally at two points, white level and grey level. Import the curve from Photoshop apply to RGB, convert to YUV and mergechroma with that.
Sorry, as I told, I am a noob with color spaces and conversion. Any available tutorial to the detailed steps?
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 17th October 2021, 14:17   #570  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,703
I've been getting Access Violation errors with SPresso. Extools.avsi line 3670, smdegrain.avsi line 622 and spresso.avsi line 38 are mentioned in the dialog box.

This is the script I can use to reproduce it, it usually starts occurring if I have to refresh the script often in VDub2 while tuning the settings. Closing the application and reopening it seems to help.
DGSource("columbo_s03e01.dgi")
TFM(slow=2).TDecimate(nt=1)
SPresso(bias=20, rgmodec=4, limit=0.65)
SelectEvery(400, 1)
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 17th October 2021, 14:51   #571  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
Interesting, looks like an avisynth bug. It's in the "smart" algo of ex_median(). Investigating. Read here.


EDIT: @tormento, look here for a simple color correction method, You can do 2 points, 3, 4, etc. Do over things you know should be neutral (opening, credits...). Then export as a .cube file.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread

Last edited by Dogway; 17th October 2021 at 21:39.
Dogway is offline   Reply With Quote
Old 18th October 2021, 16:14   #572  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
@Boulder: Did it work before, in previous versions of test AviSynth+ ? Since what version does it happen? Looks like an obscure memory bug.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 18th October 2021, 18:34   #573  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,703
Quote:
Originally Posted by Dogway View Post
@Boulder: Did it work before, in previous versions of test AviSynth+ ? Since what version does it happen? Looks like an obscure memory bug.
I've only started testing SPresso recently, so all tests have been done with test14. I actually forgot that there's more recent ones too, I guess I could try testing with the latest one once my current encode finishes.
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 18th October 2021, 19:02   #574  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,703
Looks like test20 works without issues, I tried refreshing and jumping around the video a lot but it didn't trigger anything. I'm good with that
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 18th October 2021, 19:40   #575  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
Ok, I was in test 20 and got the issue initially (although not today), so the bug traces back to at least test 14.

EDIT: Updated most EX/MIX mods, mainly maintenance rebasing to latest ExTools and ResizersPack.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread

Last edited by Dogway; 18th October 2021 at 20:29.
Dogway is offline   Reply With Quote
Old 19th October 2021, 05:03   #576  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,703
Quote:
Originally Posted by Dogway View Post
Ok, I was in test 20 and got the issue initially (although not today), so the bug traces back to at least test 14.

EDIT: Updated most EX/MIX mods, mainly maintenance rebasing to latest ExTools and ResizersPack.
I got it now with test20 as well, if it's a memory bug, no wonder it is quite random.
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 19th October 2021, 11:35   #577  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
I will update it with a workaround until it is fixed (if it gets fixed at all) since it is so critical (used in minblur) so for the time being you can edit the "smart" algo with an explicit var:

Where it says "E^ D^ H^" replace it with "E^ D^ H^ A^ A" and the bug shouldn't appear more.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 19th October 2021, 23:14   #578  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,500
Quote:
Originally Posted by Dogway View Post
@tormento
I was playing with lfr and contrasharpening.

The details recovered with lfr are terrific when compared to contrasharpening. How are them different and has contrasharpening any reason to exist anymore?
__________________
@turment on Telegram
tormento is offline   Reply With Quote
Old 20th October 2021, 00:04   #579  |  Link
Dogway
Registered User
 
Join Date: Nov 2009
Posts: 2,351
The lowpass recovery has an issue, it recovers everything under the cutoff (not exactly but more or less), so it's as if you didn't denoise low frequencies at all, this can be problematic for very grainy sources. That's why that's another reason to run two consecutive calls, the later cleaning up the remnant low frequency noise.

Another thing is that for LFR I'm comparing the behaviour of filtering twice (the original and the lowpassed). Maybe this is not necessary at all and can do as I did with MDegrain, simply compare the lowpassed original versus the lowpassed denoised. This would greatly improve performance.

Also there might be better filters for lowpassing, bessel, butterworth, etc. There's room for improvement.

ex_contrasharpening() doesn't recover anything, it's just acutance. I like to think in terms of LFR for low freq, and contra for high freq, so they are not mutually exclusive.
__________________
i7-4790K@Stock::GTX 1070] AviSynth+ filters and mods on GitHub + Discussion thread
Dogway is offline   Reply With Quote
Old 20th October 2021, 00:39   #580  |  Link
tormento
Acid fr0g
 
tormento's Avatar
 
Join Date: May 2002
Location: Italy
Posts: 2,500
Quote:
Originally Posted by Dogway View Post
Another thing is that for LFR I'm comparing the behaviour of filtering twice (the original and the lowpassed).
Any example to understand the behaviour is welcome. Please keep us informed!
Quote:
Originally Posted by Dogway View Post
LFR for low freq, and contra for high freq
So, wouldn't be possible to set a integer parameter for contra and call it something like hfr?
__________________
@turment on Telegram

Last edited by tormento; 20th October 2021 at 01:13.
tormento is offline   Reply With Quote
Reply

Tags
avisynth, dogway, filters, hbd, packs

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 13:49.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.