TemporalDegrainV2

[hello_hello]

Out of curiosity, which settings require Avisynth+? The defaults run fine on "classic" Avisynth.

[RieGo]

Very nice script. Well documented and easy to tune. nice job.
Thank you very much for this!

[StainlessS]

ErazorTT, report post #1 as having "waiting approval of attachment", or post on some file host eg PasteBin.
(or maybe this post will do it).

[tormento]

Originally Posted by ErazorTT

You will need Avisynth+ in a recent version.

Problem solved, now I have this:

[2018-10-29][18:16:26] error: ConvertToStacked: Input clip must be native 16 bit: YUV420P16, YUV422P16, YUV444P16, Y16

[Taurus]

Originally Posted by hello_hello

Out of curiosity, which settings require Avisynth+? The defaults run fine on "classic" Avisynth.

Here the same.
The only setting I could not get working was postFFT=4.
As far as I understand this will enable KNLMeansCL.
KNLMeansCL itself runs rockstable on this machine.
Groucho2004's AVSMeter silently crashes, preview on MPC-HC hangs and closes.
Virtualdub shows this:
[IMG][/IMG]

FFT3DGPU (aka postFFT=2) runs fine without any multithreading
in the script.
I think it's because I'm on avisynth 2.6.06 32bit and the script is calling for a stacked format.
But nevermind the only denoisers/degrainers I'm using are dfttest (aka postFFT=3) or FFT3DFilter (aka postFFT=1)
and they both are doing fine.
This was just for information and feedback.
Right now I'm struggeling with the settings compared to good ol TemporalDegrain.
I have used it quite a bit some years ago and made some templates of my favorit settings. But my memory is leaking about each knob and bells and whistles.
So I have to refresh my thinking and start a new.

Thanks for maintaining this wonderful script.
It saved my life a few times in the past

[ErazorTT]

@tormento, what are the exact parameters you are trying to use? This would help to figure out whats going on.

[ErazorTT]

@Taurus
Well I would actually suggest to not try to copy over the old setting used for TemporalDegrain v1.23, since the settings have changed considerably.
As a starting point I would use the recommended 5 step procedure together with the 5 parameters, which both are mentioned in the comments inside the script.
Only if one is willing to spend hours in testing should one start reviewing other settings. In which case however it would be great if people shared their findings!

[Taurus]

Originally Posted by ErazorTT

@Taurus
Well I would actually suggest to not try to copy over the old setting used for TemporalDegrain v1.23, since the settings have changed considerably.
As a starting point I would use the recommended 5 step procedure together with the 5 parameters, which both are mentioned in the comments inside the script.
Only if one is willing to spend hours in testing should one start reviewing other settings. In which case however it would be great if people shared their findings!

No,no,
I'm not copying the settings from old temporalgrain to v2!
I'm just comparing the final outcome of my old tweaked and approved temporalgrain settings with your suggested settings in new v2.
But because I forgot almost everything about good old temporalgrain, I have to rebuild a testing environment from scratch and start all over again .
But your attempt looks real promising.
Really appreciated.

[tormento]

Originally Posted by ErazorTT

@tormento, what are the exact parameters you are trying to use? This would help to figure out whats going on.

Here.

P.S: There is no reference to dfttest neither in the required plugins nor in the optional ones.

[Taurus]

Originally Posted by tormento

Here.

P.S: There is no reference to dfttest neither in the required plugins nor in the optional ones.

You are right, dfttest is not mentioned in the top lines of the temporaldegrain2 script.
But a few lines down ErazorTT explains exactly what and why you should use for postFFT=3 (dfttest).
Just verified with process exlorer: dfttestdll and dither.dll are correctly loaded when postFFT=3 is enabled.
Maybe ErazorTT should update the dependency list a little.....

[ErazorTT]

@tormento
Oh I see. Yeah, that was a pretty stupid f*ck up on my side..
Please checkout new version 2.1.2 from first post!

Oh and btw using degrainTR=4 AND postSigma=3 is a very severe overkill.

[tormento]

Originally Posted by ErazorTT

Please checkout new version 2.1.2 from first post!

[2018-10-31][09:26:01] error: Script error: There is no function named 'Dither_convert_8_to_16'.
[2018-10-31][09:26:01] (D:/Programmi/Media/AviSynth+/plugins64/TemporalDegrain-2.1.2—ErazorTT.avsi, line 241)
[2018-10-31][09:26:01] (E:\in\2_01 sacrificio del cervo sacro, Il\sacrificio_4td.avs, line 17)

Please get rid of old dither tools as was done by SMDegrain

Originally Posted by ErazorTT

Oh and btw using degrainTR=4 AND postSigma=3 is a very severe overkill.

Just trying to do a comparison with

SMDegrain (tr=4, thSAD=400, refinemotion=false, n16=true, mode=0, contrasharp=false, PreFilter=4, truemotion=false, plane=4, chroma=true)

Edit: tried to run under Simple x264 Launcher and results in a deadlock with Prefetch. Working (slow as hell) under VirtualDub. Tried again without prefetch under Simple x264 and I get something like 0.15 fps.

[ErazorTT]

Originally Posted by tormento

[2018-10-31][09:26:01] error: Script error: There is no function named 'Dither_convert_8_to_16'.

The function Dither_convert_8_to_16 is not part of dither.dll but of dither.avsi, which can also be found in the same archive (http://ldesoras.free.fr/src/avs/dither-1.27.2.zip), you will need both files in you path.

Originally Posted by tormento

Please get rid of old dither tools as was done by SMDegrain

Yes I am also no fan of this but as far as I see SMDegrain does still has this function call even in the newest version, so I do not know what you mean by "as was done by SMDegrain":

from SMDegrain v3.1.2.100s:

NL_in   = lsb && !lsb_in ? input.Dither_convert_8_to_16() : input

[tormento]

Originally Posted by ErazorTT

need both files in you path.

Did it.

Originally Posted by ErazorTT

as far as I see SMDegrain does still has this function call even in the newest version

With the command line I use, it doesn't use dither at all (I did not have in my Plugins64 directory), so I suppose it's only a optional condition trigger.

Any hint about speed?

[ErazorTT]

Well concerning speed I can for sure say that using dfttest as postFFT is slow.
For full HD and using TemporalDegrain2(degrainTR=2,postFFT=3,postSigma=3,postDither=-1) on one core and with the x264 instance on the other core, I am getting something around 1 fps.

I do have almost no experience with KNLMeans or using MtMode or Prefetch.

Do I assume correctly that you are testing with high bit input?

[tormento]

Originally Posted by ErazorTT

Well concerning speed I can for sure say that using dfttest as postFFT is slow.

I am using KNLMeansCL as postFFT(=4).

Originally Posted by ErazorTT

I do have almost no experience with KNLMeans or using MtMode or Prefetch.

Picture that with SMDegrain (the syntax I posted) I get 12-13 fps with Prefetch(6) getting similar results. As I saw you already looked at other script to get inspiration, I humbly suggest you to get a look to SMDegrain also and get the good things from it too. And please, play a bit with Prefetch too. 1 fps on nowadays processors is really slow. We have GPU sitting there too, let's use them I have been successful to make your script to work with Prefetch and the maximum I get is still 0.98fps.

Originally Posted by ErazorTT

Do I assume correctly that you are testing with high bit input?

No, I use 8 bit input, as you can see from DGDecNV syntax.

[ErazorTT]

Does it change something to set postDither to 0? What speed do you reach then?

is this (https://forum.doom9.org/showthread.p...62#post1856262) still the actual script you managed to make prefetch running?

[tormento]

Originally Posted by ErazorTT

Does it change something to set postDither to 0? What speed do you reach then?

Running and I am at 0.86 with Prefetch(6)

Originally Posted by ErazorTT

is this (https://forum.doom9.org/showthread.p...62#post1856262) still the actual script you managed to make prefetch running?

Yep. It hangs a bit in the begninning, so much that the x264 launcher complains:

[2018-10-31][17:59:54] Warning: encoder did not respond for 60 seconds, potential deadlock...

then it starts.

Please, if you want, give latest SMDegrain a run with my same parameters, i.e.

PHP Code:

SetMemoryMax(8000)
SetFilterMTMode("DEFAULT_MT_MODE", 2)
<your preferred decoder>
CompTest(1)
SMDegrain (tr=4, thSAD=400, refinemotion=false, n16=true, mode=0, contrasharp=false, PreFilter=4, truemotion=false, plane=4, chroma=true)
Prefetch(6) 


[ErazorTT]

So I made a perfomance test on my dual core 3Ghz Haswell with the following code with the colored expressions either being enabled or not:

SetFilterMTMode("DEFAULT_MT_MODE", 2)
LWLibavVideoSource("Z:\1080p.mkv")
TemporalDegrain2(...)
BilinearResize(480,270)
Trim(100,666)+Trim(9835,10000)
Prefetch(2)

These are the results:


Just using the BilinearResize without any other filter and the throughput is at 122 fps.
On one core TemporalDegrain2 is almost as fast as TemporalDegrain v1.23.
Using postFFT=3 decreases the speed dramatically and postFFT=4 is only any better if you have some usefull graphics card, not as my crappy internal Intel.
Increasing the number of threads using the parameter fftTreads helps somehow, it helps however more to use Prefetch.

@tormento: Could you please also test using postFFT=3 with your Prefetch of 6?
And, could it be that you also have an internal intel graphics card apart from your actual GPU? Because in this case I would guess that perhaps the KNLMeans runs on the wrong GPU. Could you give it another using KNLMeans with this version?

[ChaosKing]

Nice script. It's a good smdegrain alternative.
I tested TemporalDegrain2(degrainTR=4, postFFT=3, fftthreads=4) with Prefetch(2), 4 and 6 - DVD 720x480
Went from 3.2 fps to 5.8fps. The biggest jump was with Prefetch(2) to 5.4fps. The cpu is at 50% max. Ryzen @ 3.7ghz 8core.
With degrainTR=2 I get 15.4 fps


Any chance this gets ported to Vapoursynth one day?