x265 HEVC Encoder

[Barough]

x265 v3.5+87
Built on January 20, 2023, GCC 12.2.0

https://www.mediafire.com/file/iz8fqi7rqpi55sm

[benwaggoner]

Originally Posted by ShortKatz

Nope, the patch still does apply. So, I was wondering, if this bug is so big and there since (minimum) 2018, why did no one else notice?

Have been a before/after analysis to show the benefits of the fix?

[jpsdr]

I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.

[TDS]

Originally Posted by jpsdr

I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.

I have done a lot of testing, you maybe interested in the results:-

https://forum.doom9.org/showthread.p...17#post1981517
&
https://forum.doom9.org/showthread.p...53#post1981553

But only up to build 85.

[LeXXuz]

Originally Posted by jpsdr

I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.

jpsdr, I have been using v+75 with extra switches: "--aq-mode 5 --sbrc --sbrc-aq5 --sbrc-hyst" for 1080p SDR content.

Is this still valid with v+87? A lot of talk about new switch names here which confuses me a little.

[jpsdr]

@LeXXuz
For the same command line effect, you have to replace --sbrc --sbrc-aq5 --sbrc-hyst with --aq-auto 10 assuming you don't want the new sbrc (wich has totaly nothing to do with the first patch) and just keep the auto AQ feature.
(And still check with the log file )

[LeXXuz]

Originally Posted by jpsdr

@LeXXuz
For the same command line effect, you have to replace --sbrc --sbrc-aq5 --sbrc-hyst with --aq-auto 10 assuming you don't want the new sbrc (wich has totaly nothing to do with the first patch) and just keep the auto AQ feature.
(And still check with the log file )

Thank you jpsdr. Actually I'm not sure if I want or need the new sbrc as I don't fully understand what it does and if it is beneficial for my usage.

So with the latest version I just add "--aq-mode 5 --aq-auto 10", is that right?

EDIT: Btw the clang version shows "x265 [INFO]: build info [Windows][MSVC 1928][64 bit] 10bit", is that correct

[Boulder]

Originally Posted by LeXXuz

So with the latest version I just add "--aq-mode 5 --aq-auto 10", is that right?

If you want to use the automatic AQ mode with AQ5 + hysteresis enabled, just use --aq-auto 10. --aq-auto 6 for HDR (enables auto mode + hysteresis, no AQ3 or AQ5 used since it's counterproductive).

[jpsdr]

Originally Posted by LeXXuz

EDIT: Btw the clang version shows "x265 [INFO]: build info [Windows][MSVC 1928][64 bit] 10bit", is that correct

Yes, because it's build with llvm but still with Visual Studio (so using clang compiler instead).

[Boulder]

@jpsdr: I've seen mentioned in some places that AQ mode 4 needs a bit lower aq-strength than other modes. Would it be possible to have a separate aq-strength parameter for it in case aq-auto is enabled?

[jpsdr]

@Boulder
Euh... I don't know. I'll see but absolutely not promises... Don't have time for now.

[Boulder]

Originally Posted by jpsdr

@Boulder
Euh... I don't know. I'll see but absolutely not promises... Don't have time for now.

Thank you

I was thinking that it might be as simple as adding the parameter and then conditionally using it as the base strength when the mode for the frame is either X265_AQ_EDGE or X265_AQ_EDGE_BIAS.

[jpsdr]

@Boulder
For X265_AQ_EDGE the calcul is:

                            inclinedEdge = curFrame->m_lowres.edgeInclined[blockXY];
                            qp_adj = curFrame->m_lowres.qpCuTreeOffset[blockXY];
                            if(inclinedEdge && (qp_adj - avg_adj > 0))
                                qp_adj = ((strength + AQ_EDGE_BIAS) * (qp_adj - avg_adj));
                            else
                                qp_adj = strength * (qp_adj - avg_adj);

So, you want something that can change the value of strength when aq-auto is enabled ?
If it's that, 2 options. Somethings like strength2 = strength*coeff or strength2 = strength + bias with coeff=1 or bias=0 when aq-auto is disabled and use strength2 instead of strength in calcul.
And if i add some kind of AQ4 specific parameter, it can be applied to AQ 4 mode, with or without aq-auto enable, if default value keeps original behavior.

[Boulder]

What I was thinking was basically that - having AQ 4 its own strength parameter. Maybe making it equal to aq-strength in case aq-auto is not enabled so any command line would work normally.

I was wondering if it would make sense to just change the calculation of 'strength' here, I haven't had the time to get the whole idea to work because the compiled exe won't accept my new parameters for some reason. What I did was just carbon copy the existing aq-strength and aq-bias-strength parameters in various files and adjust the variable names accordingly, but probably I've missed something. In this example there's also a different value for AQ 5 bias strength.

                    if (param->rc.aqMode == X265_AQ_EDGE || param->rc.aqMode == X265_AQ_EDGE_BIASED)
                        strength = param->rc.aqStrengthEdge * avg_adj;
                    else
                        strength = param->rc.aqStrength * avg_adj;
                    avg_adj = avg_adj - 0.5f * (avg_adj_pow2 - modeTwoConst) / avg_adj;
                    if (param->rc.aqMode == X265_AQ_EDGE_BIASED)
                        bias_strength = param->rc.aqBiasStrengthEdge * param->rc.aqStrengthEdge;
                    else
                        bias_strength = param->rc.aqBiasStrength * param->rc.aqStrength;

[jpsdr]

Is it what you want ?
https://github.com/jpsdr/x265/commit...6dc36cef1d1880

[Boulder]

Originally Posted by jpsdr

Is it what you want ?
https://github.com/jpsdr/x265/commit...6dc36cef1d1880

Yes, that looks exactly what I thought of doing Thank you so much, I really appreciate it

[jpsdr]

I don't know when i'll be able to make a build (as it takes time), maybe this evening, maybe in few days, but you still can make your own build frommy github.

[Boulder]

Originally Posted by jpsdr

I don't know when i'll be able to make a build (as it takes time), maybe this evening, maybe in few days, but you still can make your own build frommy github.

No worries, I created a diff file to use for patching in Media Autobuild Suite so I got a compiled exe to test. First impression looks good, so I believe it's working. I didn't do any frame by frame compares but just watched an encoded clip to see if anything's weird.

[jpsdr]

If you have your own build, in that case, i'll realy take my time to make a new build...

[Boulder]

Originally Posted by jpsdr

If you have your own build, in that case, i'll realy take my time to make a new build...

Yeah, no problem with that

If anyone wants to test the modifications, here's the build I made. 10-bit only, and optimized for Zen 3. I can also provide the patch file I used if needed.

https://drive.google.com/file/d/1WGi...usp=share_link