Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 3rd January 2019, 10:28   #4661  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
That's not entirely impossible. A string dictionary would do the job. The thing is I'm not sure where that HDR info is coming from.
Zachs is offline   Reply With Quote
Old 3rd January 2019, 10:34   #4662  |  Link
Shiandow
Registered User
 
Join Date: Dec 2013
Posts: 753
A string dictionary would work, but it would be nicer if you could somehow request information by C# interface.
Shiandow is offline   Reply With Quote
Old 3rd January 2019, 10:40   #4663  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Any idea where that information comes from? We can decide how to pass that info to the scripts once we know where to get it from.

The thing with interfaces is they must be defined at compile time. I was thinking of something that would allow us to grab all info regardless of how useful they are and dump them into a dictionary. It's the scripts that will decide how useful the info is.
Zachs is offline   Reply With Quote
Old 3rd January 2019, 10:42   #4664  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Or do you mean COM interface? The metadata usually comes from it.
Zachs is offline   Reply With Quote
Old 3rd January 2019, 11:00   #4665  |  Link
Shiandow
Registered User
 
Join Date: Dec 2013
Posts: 753
No I meant something similar to:

Code:
IHDRParameters hdr_params = video.info as IHDRParameters;
although in practice you might end up with something closer to:

Code:
IHDRParameters hdr_params = video.requestInfo<IHDRParameters>();
which some other extension providing video information that implements IHDRParameters.

Sure the interfaces need to be known at compile time, but that's no different from needing to know the parameter names that the information would otherwise be in.

I might be overcomplicating things though, it's just that this would prevent a lot of guesswork when reading the parameters.
Shiandow is offline   Reply With Quote
Old 3rd January 2019, 11:42   #4666  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,359
Quote:
Originally Posted by Zachs View Post
The thing is I'm not sure where that HDR info is coming from.
From here:
https://github.com/Nevcairiel/LAVFil...ediaSideData.h

Note that if you provide a custom allocator (which renderers typically do), you'll need to make sure the IMediaSamples it allocates actually implement the IMediaSideData interface.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 3rd January 2019, 12:01   #4667  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Cheers Nev
Zachs is offline   Reply With Quote
Old 5th January 2019, 09:08   #4668  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Nev, do we need to copy and cache pData in STDMETHOD(SetSideData)(GUID guidType, const BYTE *pData, size_t size) PURE;
or can we simply hold the pointer and size to pData and expect pData to be valid throughout the lifetime of the IMediaSample?
Zachs is offline   Reply With Quote
Old 5th January 2019, 10:59   #4669  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,359
You need to copy and save it. The caller of SetSideData has no clue about the ultimate lifetime of the object, since its reference counted.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 5th January 2019, 11:23   #4670  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
Thanks Nev.
Zachs is offline   Reply With Quote
Old 10th January 2019, 08:41   #4671  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
We can't seem to get assfiltermod to call ISubRenderConsumer.Connect. Xysubfilter on the other hand has no problems doing so.

Nevermind. Found the problem after reading the source code of assfiltermod - it's expecting the consumer to implement ISubRenderConsumer2. IMHO it should be checking for ISubRenderConsumer interface, not ISubRenderConsumer2.

Last edited by Zachs; 10th January 2019 at 12:33.
Zachs is offline   Reply With Quote
Old 11th January 2019, 14:32   #4672  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,996
interesting it just worked out of the box with madVR. madshi didn't even know this renderer was a thing.
that'S the spec if i'm not mistaken:
http://madshi.net/SubRenderIntf.h
huhn is offline   Reply With Quote
Old 12th January 2019, 04:26   #4673  |  Link
Zachs
Suptitle, MediaPlayer.NET
 
Join Date: Nov 2001
Posts: 1,721
The documentation isn't ambiguous but it was misinterpreted by assfiltermod's author.

MPDN didn't need the Clear method so did not implement the ISubRenderConsumer2 interface. Assfiltermod however only looks for that interface, when the Connect method actually belongs to the ISubRenderConsumer interface.

Last edited by Zachs; 12th January 2019 at 04:29.
Zachs is offline   Reply With Quote
Old 28th January 2019, 12:04   #4674  |  Link
Metal-HTPC
Registered User
 
Join Date: Dec 2018
Posts: 58
This is by far the greatest player I ever tested. Never got MPC-HC or BE to work properly with madVR.
MPDN has all the usefull settings already integrated and works very stable. The playback is the best possible in my setup.

The only thing I'm missing is a way to play my DVD's. Is there an addon somewhere which makes VIDEO_TS folder playback including menus etc possible ?

I archived my whole music DVD collection in the regular dvd format (VTS/VOB files) and most of those shows will most likely never see a Blu-ray release.

thanks in adavnce for your help
regards
Metal-HTPC is offline   Reply With Quote
Old 28th January 2019, 20:13   #4675  |  Link
Shiandow
Registered User
 
Join Date: Dec 2013
Posts: 753
Not sure if the VTS files will work since DVD menus are not supported (and will probably remain unsupported for the near future). I'm pretty sure that the LAV filters should be able to handle the VOB files though, so those should work.
Shiandow is offline   Reply With Quote
Old 30th January 2019, 04:27   #4676  |  Link
avih
Capture, Deinterlace
 
avih's Avatar
 
Join Date: Feb 2002
Location: Right there
Posts: 1,971
Quote:
Originally Posted by Zachs View Post
Hi everyone,
... Both madVR and MPV use portions of code from MPDN Extensions.
Would you mind pointing out some MPDN extensions which are used in mpv (and the mpv code which uses things from MPDN)? I'm somewhat familiar with mpv code, and I don't recall anything which came from MPDN...
avih is offline   Reply With Quote
Old 30th January 2019, 04:45   #4677  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,996
here you go: https://gist.github.com/igv
these are the easy ones even i can find.
huhn is offline   Reply With Quote
Old 30th January 2019, 09:35   #4678  |  Link
avih
Capture, Deinterlace
 
avih's Avatar
 
Join Date: Feb 2002
Location: Right there
Posts: 1,971
Quote:
Originally Posted by huhn View Post
here you go: https://gist.github.com/igv
these are the easy ones even i can find.
But this is not mpv using anything from MPDN. These are shaders which presumably can work in mpv when loaded as external shaders.

It's like I'll write some JS code which can run in Firefox and then advertise/claim that Firefox is using my code...
avih is offline   Reply With Quote
Old 30th January 2019, 11:53   #4679  |  Link
huhn
Registered User
 
Join Date: Oct 2012
Posts: 7,996
aren't or at least wasn't they shipped with mpv builds?
huhn is offline   Reply With Quote
Old 30th January 2019, 12:02   #4680  |  Link
avih
Capture, Deinterlace
 
avih's Avatar
 
Join Date: Feb 2002
Location: Right there
Posts: 1,971
Quote:
Originally Posted by huhn View Post
aren't or at least wasn't they shipped with mpv builds?
Surely not with the official windows distribution at https://mpv.srsfckn.biz/ .

If you or some other third party wants to distribute an mpv build with a collection of shaders from MPDN, you can do that, but it cannot be considered part of mpv itself...
avih is offline   Reply With Quote
Reply

Tags
direct3d, mpdn, nnedi3, opencl, reclock

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 22:26.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.