MCTemporalDenoise [v1.4.20 - Update 2010/07/02]

[Adub]

Damn, the new version is way faster. I was getting about 3.98fps. Now I am getting 5.5fps. On one thread. If I use setmtmode(2), I get over 20fps. This is on 720x480 footage. Hell yes for MVtools2!! Now, I just need MC_Spuds to update as well and I will be one happy camper.

[mozzle]

Just to echo Merlin's sentiments, I'm thoroughly enjoying around a 20% speed improvement when using MCTemporalDenoise 1.1.23 along with MVTools 2.3.0.0

Major kudos to LaTo and fizick!!!

[totya]

Originally Posted by Merlin7777

If I use setmtmode(2), I get over 20fps

lol

MCTemporalDenoise support this?

[moviefan]

There seems to be an issue with "edgeclean=true". When I used it (the MVTools2 version), some frames were OK (no comment about the actual edge cleaning here), but some other frames were bleached... When I turned it off, the colors were fine again. I hope this bug report helps to further improve your amazing script, LaTo! Thanks for your efforts!

[Adub]

Originally Posted by totya

lol

MCTemporalDenoise support this?

Yep, it runs just fine. I just ran it on Constantine last night using MeGUI, and this morning I have a nice little mkv waiting for me. Works 100% okay.

I will test the edgeclean=true bug.

[pdadi]

Hi, Great work. I am getting there is no function named Msuper (line,650) with following settings

MCTemporalDenoise(settings="medium",gpu=false)

I appreciate your help

[thetoof]

Originally Posted by totya

MCTemporalDenoise support this?

sure does! MVTools2 is even more stable than v1 with setmtmode

Originally Posted by pdadi

Hi, Great work. I am getting there is no function named Msuper (line,650) with following settings

Do you have the latest version of MVTools2?

[pdadi]

Originally Posted by thetoof

Do you have the latest version of MVTools2?

Thanks works now. Can I delete mvtools v1 then?

[thetoof]

Unless you still use scripts that use mvtools1, yes. It'll take some time for the old scripts to be adapted to the new syntax (especially since it has just changed), so I think you'll still need v1 for a little while.

[pdadi]

Thanks thetoof, I am not seeing any performance improvments with setmtmode(2,0). Mine is a quadcore 9400 with 8 GB RAM. CPU is at 30%.

setmtmode(2,0)
MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)

Getting around 3FPS on x264 HQ profile first pass.

[LaTo]

Originally Posted by moviefan

There seems to be an issue with "edgeclean=true". When I used it (the MVTools2 version), some frames were OK (no comment about the actual edge cleaning here), but some other frames were bleached... When I turned it off, the colors were fine again. I hope this bug report helps to further improve your amazing script, LaTo! Thanks for your efforts!

Thanks for report, should be fixed in v1.1.24

For edgeclean=true, I recommend to try another thing that ECmode's default : it's a simple RemoveGrain by default... (dfttest is great but slow)



EDIT: Update 12/12/2008

v1.1.24:
fixed a chroma bug with PP

[sho_t]

Originally Posted by LaTo

For edgeclean=true, I recommend to try another thing that ECmode's default : it's a simple RemoveGrain by default... (dfttest is great but slow)

I think that TBilateral() is better than dfttest()　for animation source.　(I tried only by the animation source)
LaTo may have already tried it too...

[steptoe]

Originally Posted by pdadi

Thanks thetoof, I am not seeing any performance improvments with setmtmode(2,0). Mine is a quadcore 9400 with 8 GB RAM. CPU is at 30%.

setmtmode(2,0)
MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)

Getting around 3FPS on x264 HQ profile first pass.

If that is your script, then you are missing the important MT command that is needed to multi-thread filters

Try this :

MT("MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)")

or

MT("""
MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)
""")


The 2nd one just lets you run MT on a block of filters instead of applying it per filter or function

Not forgetting to copy the patched avisynth.dll to your windows\system32 folder in your C:\ drive or where you have Windoze installed

Otherwise nothing will happen again, and bear in mind that this patch only currently works on AviSynth 2.57, maybe he's waiting for a stable 2.58 to release the update


Also, try SETMTMode(2,4) to force is to use 4 threads, for a quad core, that way you know its running on 4 threads instead of letting the software decide how many threads to run on. Some also run it with SETMTMode(2,8) to force 8 threads with success

[Gavino]

Originally Posted by steptoe

If that is your script, then you are missing the important MT command that is needed to multi-thread filters. Try this :
MT("MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)")
or
MT("""
MCTemporalDenoise(settings="high",gpu=false,truemotion=false,sharp=0,ncpu=4)
""")
The 2nd one just lets you run MT on a block of filters instead of applying it per filter or function

The first one will give you a syntax error because the opening quote of "high" is taken as the closing quote of "MCTemporal...".
The second (triple-quote) form is required, to allow a string literal inside the complete string. It is unconnected with using a block of filters, since ordinary (single-quote) strings can also contain line breaks.

Bear in mind also that MT splits each frame in two and processes each half in a separate thread. Not all filters will work correctly doing this - I don't know enough about MCTemporalDenoise to say whether this is appropriate or not, but my instinct would say no (eg the clip could contain motion between the two halves).

It is not necessary to use the MT filter to get multi-threading, its action is complementary to SetMtMode.

[thetoof]

Exactly, setmtmode splits the clip temporally to multithread it, while mt splits it spatially. You do NOT want the latter with mo-comped processing.
Possible issues:
-Encoder is the bottleneck
-You could/should use more/less threads (check which # is faster (not higher CPU usage, faster)
-You don't have enough memory (use a higher SetMTmode, you can even go up to 1900... though I don't fully know the issues that could come up if the setting is too high)
Please post your full script and the CPU/speed results you get by varying the # of threads. Remember that x264 also works with many threads, so it's all about balancing which step gets more threads for optimal efficiency.

[steptoe]

I stand corrected, I always thought you had to use MT("") to get the filter to work with multi-threaded

Maybe I need to go back and study the MT docs on the wiki again and again to try and understand how it really works and when or when not to try and use it

[Digitals]

i am getting this error

"Msuper" (line 652),i hav installed mvtools2 still same prob

[thetoof]

Do you have MVTools 2.3.1?

[Digitals]

^ yes i hav installed MVtools 2.3.1 only

[Sagekilla]

Also, another issue is where you place SetMTMode.

Good:
SetMTMode()
Source("...")
MCTemporalDenoise()

Bad:
Source("...")
SetMTMode()
MCTemporalDenoise()