documentation help requested for new mediawiki

[StvG]

@Wilbert, the actions reported in the previous post are continuing.
Now are even worse:
- Raffriff42 talks are deleted - http://avisynth.nl/index.php?title=U...30&oldid=10170
- Main page is modified - http://avisynth.nl/index.php?title=M...31&oldid=12798 / http://avisynth.nl/index.php?title=M...33&oldid=13231 / http://avisynth.nl/index.php?title=M...35&oldid=13233 / http://avisynth.nl/index.php?title=M...36&oldid=13235
What's this discord channel?

[Wilbert]

Sorry for the mess. I banned several ip's and removed all their crap. I'm not sure if these people pass the captcha test (or that they register in other way but that should be impossible), so i made this unusable for now. Please send me a PM if this crap continues. If you do then i get notified by email and see it directly.

[StvG]

Thanks for cleaning the mess. I guess "Community Collaboration Page" at top of the Main page can be removed alongside http://avisynth.nl/index.php/Community ?

[Wilbert]

Ok i removed it. It could be interesting for some of you though. The discord channel is about video restoration (using AviSynth): https://disboard.org/server/1123729107553886218 Here is another one about video restoration with AviSynth: https://disboard.org/server/767288963912171550

I didn't joint to take a look. Does someone know about these channels?

[kedautinh12]

I can't access to sever from two links above

[Wilbert]

I think i solved it now. Anonymous users can't create pages anymore (only autoconfirmed users can, as intended).

[Wilbert]

I also disabled create talk pages for anonymous users today.

[StainlessS]

Error on Wiki page for External Filters ColorScreenMask:- http://avisynth.nl/index.php/ColorScreenMask

Syntax and Parameters

ColorKeyMask (clip, string "keymode", string "keycolor", int "gth", int "grm", int "ggm", int "gbm", int "contx", int "conty", int "cth", int "crm", int "cgm", int "cbm", int "pixv")

Above in red should be ColorScreenMask.

EDIT: Also, Internal Filter ColorKeyMask:- http://www.avisynth.nl/index.php/Layer

ColorKeyMask

AviSynth+
Up-to-date documentation: https://avisynthplus.readthedocs.io


Clears pixels in the alpha channel by comparing to a transparent color (default black).

Each pixel with a color differing less than (tolB,tolR,tolG) (default 10d) is set to transparent (black); otherwise it is left unchanged – note, it is NOT set to opaque (white). That's why you might need ResetMask before applying this filter. This behaviour allows an aggregate mask to be constructed with multiple calls to ColorKeyMask.

When tolR or tolG are not set, they get the value of tolB by default. Normally you start with a ResetMask, then chain a few calls to ColorKeyMask to cause transparent holes where each color of interest occurs. See Overlay for examples.

ColorKeyMask(clip clip, int color [, int tolB, int tolG, int tolR])

clip clip =

Source clip. Color format must be RGB32.
AVS+ also supports RGB64 and PlanarRGBA.

int color = black

Transparent color. Default black.

int tolB = 10d
int tolG = (tolB)
int tolR = (tolB)

in Red says that tolG and tolR default to tolB, whereas they all actually default to 10.

ie [from code:- https://github.com/AviSynth/AviSynth...layer.cpp#L420 ].

AVSValue __cdecl ColorKeyMask::Create(AVSValue args, void*, IScriptEnvironment* env)
{
  enum { CHILD, COLOR, TOLERANCE_B, TOLERANCE_G, TOLERANCE_R };
  return new ColorKeyMask(args[CHILD].AsClip(),
    args[COLOR].AsInt(0),
    args[TOLERANCE_B].AsInt(10),
    args[TOLERANCE_G].AsInt(args[TOLERANCE_B].AsInt(10)),
    args[TOLERANCE_R].AsInt(args[TOLERANCE_B].AsInt(10)), env);
}

The same errors for ColorKeyMask in Avisynth+ ReadTheDocs:- https://avisynthplus.readthedocs.io/...l#colorkeymask

EDIT: Also [BELOW for CODE not Wiki],
ColorKeyMask, arg color is supposed to be optional, but is not optional, and also all args are unnamed.
[Would perhaps be better if named:- https://forum.doom9.org/showthread.p...03#post1211003 ]

Colorbars().killaudio
ColorKeyMask()    # FAILS, color not optional and should be

Colorbars().killaudio
ColorKeyMask(0,10,10,10)    # OK

Colorbars().killaudio
ColorKeyMask(0,TolB=10)    # FAILS, TolB not Named optional arg

Must have spec as, clip, unnamed compulsory int color, and 3 unnamed optional ints for tolerances.

{ "ColorKeyMask", "ci[]i[]i[]i", ColorKeyMask::Create }

Should perhaps be (all int args as optional unnamed args)

{ "ColorKeyMask", "c[]i[]i[]i[]i", ColorKeyMask::Create }

or all int args as optional named args

{ "ColorKeyMask", "c[color]i[tolB]i[tolG]i[tolR]i", ColorKeyMask::Create }        # ColorKeyMask(clip c, int "color"=$00000000, int "tolB"=10, int "tolG"=10, int "tolR"=10)

[pinterf]

thanks for the report.

Originally Posted by StainlessS

EDIT: Also, Internal Filter ColorKeyMask:- http://www.avisynth.nl/index.php/Layer

in Red says that tolG and tolR default to tolB, whereas they all actually default to 10.

ie [from code:- https://github.com/AviSynth/AviSynth...layer.cpp#L420 ].

AVSValue __cdecl ColorKeyMask::Create(AVSValue args, void*, IScriptEnvironment* env)
{
  enum { CHILD, COLOR, TOLERANCE_B, TOLERANCE_G, TOLERANCE_R };
  return new ColorKeyMask(args[CHILD].AsClip(),
    args[COLOR].AsInt(0),
    args[TOLERANCE_B].AsInt(10),
    args[TOLERANCE_G].AsInt(args[TOLERANCE_B].AsInt(10)),
    args[TOLERANCE_R].AsInt(args[TOLERANCE_B].AsInt(10)), env);
}

1.) G and R are not set to 10, but they inherit the B value. Check again, they default to B:

args[TOLERANCE_B].AsInt(10)

2.) yes, in ColorKeyMask they are all unnamed arguments. Documentation would be nice to mention it. Or I can change the code, see 4.)

3.) Central doc is not ready yet, for example it mentions ColorKeyMask , Mask, ResetMask twice.

The old ones are in the yet-to-be-ported Layer page (layer.rst in gitgub).
https://avisynthplus.readthedocs.io/...l#colorkeymask

You can however find the updates in the "Mask Filters" section (mask.rst)
https://avisynthplus.readthedocs.io/...l#colorkeymask

When layer will be updated the duplicates will be removed.

4.) yes, color must be optional, but as you noticed, it's not.
Present parameter signature is "ci[]i[]i[]i" which requires an unnamed second parameter indeed.

EDIT: I've checked the history: 'color' was never optional at least since 2004. Documentation was wrong.

Your proposal that all parameters would have a real name makes sense. Signature would be: "c[color]i[tolB]i[tolG]i[tolR]i"

We all like when parameters have friendly names don't we. I suppose it helps AvsPMod users as well, no need to guess the meaning of the parameters.

[StainlessS]

1.) G and R are not set to 10, but they inherit the B value. Check again, they default to B:

Oops, my bad. I read my post before your reply and realized that I did not even look at the code before AsInt(10).