porting LSFmod for HBD in avs+ - Page 2

real.finder · 19th September 2019, 14:18

Quote:

Originally Posted by Tempter57

Thanks you for script updating, now all are normal, it was necessary to connect only still function

Code:

function Padding(clip c, int left, int top, int right, int bottom)
{
w = c.width()
h = c.height()
c.pointresize( w+left+right, h+top+bottom, -left, -top, w+left+right, h+top+bottom )
}

I have Padding as part of Advanced Denoising.avsi

anyway I plan to change this soon as I said here https://forum.doom9.org/showthread.p...72#post1884872

Tempter57 · 19th September 2019, 17:03

Quote:

Originally Posted by real.finder

I have Padding as part of Advanced Denoising.avsi

anyway I plan to change this soon as I said here https://forum.doom9.org/showthread.p...72#post1884872

Has understood, but there was a problem of application LSFmod with smode=1 and smode=2

real.finder · 19th September 2019, 18:41

Quote:

Originally Posted by Tempter57

Has understood, but there was a problem of application LSFmod with smode=1 and smode=2

that because not all filters updated yet to use avs 2.6 Y8

try this https://pastebin.com/eE37iYWZ

LSFmod(smode=2,avs26_optimize=false)

and if all filters updated later then you will not need to set avs26_optimize=false

Boulder · 25th May 2020, 14:37

Found a little problem with show=true: the AddBorders calls have an incorrect syntax. Fixed by removing ',true' off them.

real.finder · 25th May 2020, 14:43

Quote:

Originally Posted by Boulder

Found a little problem with show=true: the AddBorders calls have an incorrect syntax. Fixed by removing ',true' off them.

what settings and what LSFmod is used? since I got no problem with lsfmod(show=true)

Boulder · 25th May 2020, 15:32

HD source, AVS+ v3.6. The latest version of LSFMod, defaults="slow", show=true right after loading the source.

As far as I know, AddBorders doesn't have any Boolean variables.

real.finder · 25th May 2020, 15:47

Quote:

Originally Posted by Boulder

HD source, AVS+ v3.6. The latest version of LSFMod, defaults="slow", show=true right after loading the source.

As far as I know, AddBorders doesn't have any Boolean variables.

yes, it's copy/paste bug when I add it to crop, I will update it soon

Boulder · 26th May 2020, 11:59

While you're working on the script, is it possible to get a larger kernel to use with (U)HD sources? As far as I remember, the 3x3 kernel suits SD sources but HD would require a larger one for the same effect regarding detail enhancement.

real.finder · 26th May 2020, 12:08

Quote:

Originally Posted by Boulder

While you're working on the script, is it possible to get a larger kernel to use with (U)HD sources? As far as I remember, the 3x3 kernel suits SD sources but HD would require a larger one for the same effect regarding detail enhancement.

I think that need RemoveGrainHD

Boulder · 26th May 2020, 12:42

Ah, that one is still non-hbd

LeXXuz · 4th July 2020, 15:12

I'm playing around with LSFmod a little. I use latest avs+ and LSFmod v2.187.

I use either 10-bit or 16-bit scripts/filterchains and I've noticed the sharpening effect with the default value of 100 is rather subtle, if noticeable at all.
So just increase strength to your liking, right? Well that works fine on LBD. However on HBD I get artefacts.

For a little test I use this line on a 1080p source:

Code:

LSFmod(strength=400, defaults="slow")

I chose 400 (which is way too much, of course) to make the difference more visible.

8-bit looks okay, well oversharpened but okay. 10/16-bit looks, well see for yourself:

Why is this happening in HBD?

real.finder · 4th July 2020, 16:30

Quote:

Originally Posted by LeXXuz

I'm playing around with LSFmod a little. I use latest avs+ and LSFmod v2.187.

I use either 10-bit or 16-bit scripts/filterchains and I've noticed the sharpening effect with the default value of 100 is rather subtle, if noticeable at all.
So just increase strength to your liking, right? Well that works fine on LBD. However on HBD I get artefacts.

For a little test I use this line on a 1080p source:

Code:

LSFmod(strength=400, defaults="slow")

I chose 400 (which is way too much, of course) to make the difference more visible.

8-bit looks okay, well oversharpened but okay. 10/16-bit looks, well see for yourself:

Why is this happening in HBD?

with

Code:

ImageSource("2020-07-04123ckta.png")
converttoyv24
convertbits(16)
LSFmod(strength=400, defaults="slow")
convertbits(8)

LeXXuz · 4th July 2020, 16:33

Thanks for the quick response. So something seems to be wrong on my system?

But I wonder what.

real.finder · 4th July 2020, 16:40

Quote:

Originally Posted by LeXXuz

Thanks for the quick response. So something seems to be wrong on my system?

But I wonder what.

can you try with the same image I post? maybe the original frame has noise that case this

if it still has that artefacts then make sure that you use last rgtools https://github.com/pinterf/RgTools and masktools https://github.com/pinterf/masktools/

LeXXuz · 4th July 2020, 17:22

It seems I was NOT running the latest AVS+ version. My bad.

I had r3106, 3.5 (x64) installed. Now updated to r3300, 3.6 (x64)

But I can't get LSFmod to work anymore.
Some problem with version check:

My AvsPlusVersionNumber.avsi

Code:

function IsAvsPlus()
{
    FindStr(VersionString, "AviSynth+")  != 0
}

function AvsPlusVersionNumber()
{
    IsAvsPlus ? eval(MidStr(VersionString(),17,4)) : 0
}

My LSFmod.avsi:
https://pastebin.com/cZFKV0ab

Can't I just remove this version check thingy somehow?

real.finder · 4th July 2020, 17:27

Quote:

Originally Posted by LeXXuz

It seems I was NOT running the latest AVS+ version. My bad.

I had r3106, 3.5 (x64) installed. Now updated to r3300, 3.6 (x64)

But I can't get LSFmod to work anymore.
Some problem with version check:

My AvsPlusVersionNumber.avsi

Code:

function IsAvsPlus()
{
    FindStr(VersionString, "AviSynth+")  != 0
}

function AvsPlusVersionNumber()
{
    IsAvsPlus ? eval(MidStr(VersionString(),17,4)) : 0
}

My LSFmod.avsi:
https://pastebin.com/cZFKV0ab

Can't I just remove this version check thingy somehow?

update scripts from https://github.com/realfinder/AVS-Stuff

LeXXuz · 4th July 2020, 17:38

What exactly should I update?

I can only find this avsi on that page:
https://github.com/realfinder/AVS-St...up/LSFmod.avsi

Which looks to be the same.

Boulder · 4th July 2020, 17:49

Zs_RF_Shared.avsi is one to update as well, it contains a lot of helper functions etc.

LeXXuz · 4th July 2020, 18:10

Quote:

Originally Posted by Boulder

Zs_RF_Shared.avsi is one to update as well, it contains a lot of helper functions etc.

That's what I was missing. Thank you!

Quote:

Originally Posted by real.finder

can you try with the same image I post? maybe the original frame has noise that case this

if it still has that artefacts then make sure that you use last rgtools https://github.com/pinterf/RgTools and masktools https://github.com/pinterf/masktools/

Well I get the same result with this image as you do.
Then I took a picture of the source frame and ran your little script with it. Again no artefacts.

So, like you already assumed, something must be in the source vid that produces these artefacts. But why only in HBD? And how do I get rid of these?

I could downconvert to 8-bit, use LSFm and convert back up to 16-bit before using the next filter, but thats not really ideal, isn't it?

real.finder · 4th July 2020, 18:18

Quote:

Originally Posted by LeXXuz

Then I took a picture of the source frame and ran your little script with it. Again no artefacts.

then it should work with video too, did you tried after updating things?

anyway, sharpening should be after denoising

25th May 2020, 14:37	#24 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Found a little problem with show=true: the AddBorders calls have an incorrect syntax. Fixed by removing ',true' off them. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

25th May 2020, 15:32	#26 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	HD source, AVS+ v3.6. The latest version of LSFMod, defaults="slow", show=true right after loading the source. As far as I know, AddBorders doesn't have any Boolean variables. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

26th May 2020, 11:59	#28 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	While you're working on the script, is it possible to get a larger kernel to use with (U)HD sources? As far as I remember, the 3x3 kernel suits SD sources but HD would require a larger one for the same effect regarding detail enhancement. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

26th May 2020, 12:42	#30 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Ah, that one is still non-hbd __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...

4th July 2020, 15:12	#31 \| Link
LeXXuz 21 years and counting... Join Date: Oct 2002 Location: Germany Posts: 716	I'm playing around with LSFmod a little. I use latest avs+ and LSFmod v2.187. I use either 10-bit or 16-bit scripts/filterchains and I've noticed the sharpening effect with the default value of 100 is rather subtle, if noticeable at all. So just increase strength to your liking, right? Well that works fine on LBD. However on HBD I get artefacts. For a little test I use this line on a 1080p source: Code: LSFmod(strength=400, defaults="slow") I chose 400 (which is way too much, of course) to make the difference more visible. 8-bit looks okay, well oversharpened but okay. 10/16-bit looks, well see for yourself: Why is this happening in HBD?

4th July 2020, 16:33	#33 \| Link
LeXXuz 21 years and counting... Join Date: Oct 2002 Location: Germany Posts: 716	Thanks for the quick response. So something seems to be wrong on my system? But I wonder what.

4th July 2020, 17:22	#35 \| Link
LeXXuz 21 years and counting... Join Date: Oct 2002 Location: Germany Posts: 716	It seems I was NOT running the latest AVS+ version. My bad. I had r3106, 3.5 (x64) installed. Now updated to r3300, 3.6 (x64) But I can't get LSFmod to work anymore. Some problem with version check: My AvsPlusVersionNumber.avsi Code: function IsAvsPlus() { FindStr(VersionString, "AviSynth+") != 0 } function AvsPlusVersionNumber() { IsAvsPlus ? eval(MidStr(VersionString(),17,4)) : 0 } My LSFmod.avsi: https://pastebin.com/cZFKV0ab Can't I just remove this version check thingy somehow?

4th July 2020, 17:38	#37 \| Link
LeXXuz 21 years and counting... Join Date: Oct 2002 Location: Germany Posts: 716	What exactly should I update? I can only find this avsi on that page: https://github.com/realfinder/AVS-St...up/LSFmod.avsi Which looks to be the same.

4th July 2020, 17:49	#38 \| Link
Boulder Pig on the wing Join Date: Mar 2002 Location: Finland Posts: 5,733	Zs_RF_Shared.avsi is one to update as well, it contains a lot of helper functions etc. __________________ And if the band you're in starts playing different tunes I'll see you on the dark side of the Moon...