[Neo] FFT3D / DFTTest

[MeteorRain]

almosely: I figured out the issue. Please stand by for r8.

kedautinh12: Any reason why I should add them back?

[kedautinh12]

I will replace fft3dfilter with neo-fft3d in TemporalDegrain2 use for myself. But TemporalDegrain2 need them to work, can you add them back?

[MeteorRain]

I don't get it. Why TemporalDegrain2 needs them? The function of both parameters have been removed.

FFT3DFilter(plane=degrainPlane, sigma=limitSigma, sigma2=s2, sigma3=s3, sigma4=s4, bt=3, bw=limitBlksz, bh=limitBlksz, ow=overlap, oh=overlap, ncpu=fftThreads)

Change plane=degrainPlane to y=LumaNoise?3:2, u=ChromaNoise?3:2, v=ChromaNoise?3:2, and remove ncpu=fftThreads.

[kedautinh12]

Originally Posted by MeteorRain

I don't get it. Why TemporalDegrain2 needs them? The function of both parameters have been removed.

FFT3DFilter(plane=degrainPlane, sigma=limitSigma, sigma2=s2, sigma3=s3, sigma4=s4, bt=3, bw=limitBlksz, bh=limitBlksz, ow=overlap, oh=overlap, ncpu=fftThreads)

Change plane=degrainPlane to y=LumaNoise?3:2, u=ChromaNoise?3:2, v=ChromaNoise?3:2, and remove ncpu=fftThreads.

Thanks, sr for my noob requested

[kedautinh12]

Hi, i meet error when replace dfttest with neo_dfttest in TemporalDegrain2, i checked and findout neo_dfttest missing lsb. I was removed lsb but i meet error: "clip should be of same size!", can you add lsb again??

[DJATOM]

In general you don't need lsb stuff per filter, since avs+ provides filters to transform to/from stacked format. (conversion is lossless)
ConvertBits(16).neo_dfttest(...).ConvertToStacked() will be the same as dfttest(..., lsb=true)

[kedautinh12]

Originally Posted by DJATOM

In general you don't need lsb stuff per filter, since avs+ provides filters to transform to/from stacked format. (conversion is lossless)
ConvertBits(16).neo_dfttest(...).ConvertToStacked() will be the same as dfttest(..., lsb=true)

it's work, many thanks

[almosely]

Originally Posted by MeteorRain

almosely: I figured out the issue. Please stand by for r8.

kedautinh12: Any reason why I should add them back?

Thank you :-) I will test and report ...

- edit -

Tested the functionality and it works fine :-) I did not compare the outcome with fft3dfilter.

[Atlantis]

I want to try neo_FFT3D

I don't understand
y, u, v (AviSynth+ only)

Whether a plane is to be filtered.

1 - Do not touch, leaving garbage data
2 - Copy from origin
3 - Process

1 and 2 are the same thing! What's the difference? They both don't touch the plane.

[DJATOM]

Not really the same. 1 option will save time (no copy from src to dst), 2 option will do that copy and 3 option will actually process plane.

[Atlantis]

What would be the use case for option 1? Because even if you want to use different settings for each plane, you use a combination of option 2 and 3.

[StainlessS]

What would be the use case for option 1?

When you dont need any kind of result for that plane and speed is primary factor. [eg perhaps only interested in Luma plane, dont need U or V].
Other filters have the same type of options eg Masktools2.

Unprocessed planes will just contain whatever happened to be in that memory buffer before the filter processed that frame.

[MeteorRain]

Originally Posted by Atlantis

I want to try neo_FFT3D

I don't understand
y, u, v (AviSynth+ only)

Whether a plane is to be filtered.

1 - Do not touch, leaving garbage data
2 - Copy from origin
3 - Process

1 and 2 are the same thing! What's the difference? They both don't touch the plane.

Option 1 doesn't guarantee the data is meaningful.

For example, if you only process 1 plane, then it will just use the source memory buffer, and the data in the source memory area remains, and thus you will see the original data untouched.

However if you process 2 planes, the final memory is then copied from 2 process engines, while the 3rd plane has garbage data. It saves you a memory copy every frame.

Originally Posted by Atlantis

What would be the use case for option 1? Because even if you want to use different settings for each plane, you use a combination of option 2 and 3.

Because some filters would split luma and chroma, and process then separately. In those cases, you'll end up throwing unused planes away and combining the final results. 1 will save you a tiny bit of time.

In reality, frame copy is not slow, and I have put optimizations to avoid unnecessary copies. It's not a big deal anyway.

[Atlantis]

OK. So here is my use case. I want to use neo_fft3d and apply different sigmas to Y and U V. Please correct me if I'm wrong, I don't think that applying the same amount of noise reduction to all 3 planes is good. So what I have decided for myself is to add half of noise reduction I do on Y to U V.
I write this for example if this is correct

neo_fft3d(bt=5, sigma=4, u=2, v=2)
neo_fft3d(bt=5, sigma=2, y=2)

4 to Y and 2 to U V.
Is this correct and is the philosophy of adding half of Y to U V a good one?

One strange thing I noticed is that in the old FFT3DFilter if I apply the same sigma to all 3 planes, these is a little desaturation. The color of the picture is not as alive as if you apply it only to Y.
It seems in your filter neo_fft3d this doesn't happen. By default yours is processing all 3 planes and I see no desaturation which is good. Any idea why this happened in the old FFT3DFilter ?

[Atlantis]

I am also testing neo_dfttest.

dfttest(U=false, V=false, sigma=96, tbsize=5)
encoded 8496 frames in 6158.00s (1.38 fps), 10137.46 kb/s, Avg QP:24.56

neo_dfttest(sigma=96, tbsize=5, u=2, v=2)
encoded 8496 frames in 5636.64s (1.51 fps), 7649.91 kb/s, Avg QP:24.54

Any idea why there is such a huge difference in the final output? 10137.46 kb/s vs 7649.91 kb/s?

[crystalfunky]

Will this be available in the next Staxrip version?

[Atlantis]

Ask stax76 here to include it
https://forum.doom9.org/showthread.php?p=1917053
I was also going to ask him. I'm going to do more tests.

In real world x265 encoding 4K HDR, neo_fft3d is definitely faster and I'm going to use neo_fft3d.
With neo_dfttest I don't see much improvement in speed.

[Atlantis]

FFT3D is missing scene change detection.
https://github.com/pinterf/fft3dfilter/issues/2

Sometimes you get bad frames with scene change. Like the image is not denoised. With bt=5 you get 4 bad frames and with bt=3 you get 2 bad frames. I noticed DFTTest does the same.

I have no idea how hard it is, can you add this feature? Any workaround? I'm going to open a topic only about this.

[MeteorRain]

I only port filters and optimize existing code. No new feature is implemented due to lack of skills and time.

[real.finder]

Originally Posted by kedautinh12

i see your neo-fft3d missing plane and ncpu for fft3dfilter, can you add it again??

ncpu should back as DFTTest has threads parameter, as now neo_FFT3D either just single thread or has some setting for multi threads

also, seems I get ignored again https://github.com/HomeOfAviSynthPlu...FFT3D/issues/3

maybe I should start put some notice that neo_** plugin are not Recommended and not officially supported as dogway did back then in SMDegrain with cretindesalpes/Firesledge moded mvtools http://web.archive.org/web/201312101...p?topic=2178.0