Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 18th March 2021, 21:13   #161  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by StvG View Post
nnedi3_rpow2(a,rfactor=2).nnedi3_rpow2(rfactor=2) returns YV12.
asobel(a,thresh=255).ablur() returns i420. It seems asobel doesn't convert i420 to YV12.
That's why awarp4 is complaining.
This works:
Code:
a=LWLibavVideoSource(".\dolbyrain\dolbyrain.vob")
b=nnedi3_rpow2(a,rfactor=2).nnedi3_rpow2(rfactor=2)
c=asobel(a,thresh=255).propset("_FieldBased", 0).z_ConvertFormat(pixel_type="yv12").ablur()
awarp4(b,c,depth=6,threads=1)
so I think nnedi3_rpow2 need to change in this case to not convert i420 to YV12
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 18th March 2021, 21:45   #162  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
nnedi3_rpow2 splits and process the channels in "Y only", and after recomb using "YtoUV".
You can even if you want write an avs script using "PlaneToY", "nnedi3" and "YtoUV". So when "YtoUV" is used to "regroup" output data when inpiut data was checked Is420(), i think it's automaticaly tagged to YV12.
The nnedi3_rpow2 function is like an avs script.
I don't know if there is a function to put back original vi.pixel_type...
__________________
My github.
jpsdr is offline   Reply With Quote
Old 19th March 2021, 08:11   #163  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
For Avisynth it is all the same, YV12 or I420.
That's why VideoInfo::IsSameColorspace has a second test for colorspace. Both formats report "true" on IsYV12().
https://github.com/AviSynth/AviSynth...rface.cpp#L332
pinterf is offline   Reply With Quote
Old 19th March 2021, 12:41   #164  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
So, the proper way is not
Code:
if (vi.pixel_type!=vi2.pixel_type)
but
Code:
if (!vi.IsSameColorspace(vi2))
That's... logical... I'll change that.
I mean, if there is a IsSameColorspace function, using it is the proper way...
__________________
My github.

Last edited by jpsdr; 19th March 2021 at 13:21.
jpsdr is offline   Reply With Quote
Old 19th March 2021, 17:30   #165  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
It is sometimes nice to be able to see the Baked code in the original v2.58 header, to give a clue about what its gonna do.
I'm not suggesting that you use same as v2.58 header, just taking a peek into the black box is sometimes informative.
Here is from v2.58 header
Code:
  // Test for same colorspace
  bool IsSameColorspace(const VideoInfo& vi) const {
    if (vi.pixel_type == pixel_type) return TRUE;
    if (IsYV12() && vi.IsYV12()) return TRUE;
    return FALSE;
  }
EDIT: Oops, shoulda posted this too.
Code:
  bool IsYV12() const { return ((pixel_type & CS_YV12) == CS_YV12)||((pixel_type & CS_I420) == CS_I420); }
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???

Last edited by StainlessS; 19th March 2021 at 17:43.
StainlessS is offline   Reply With Quote
Old 29th March 2021, 18:55   #166  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Begin to investigate.
First thought ChromaPlacement was the issue, but it seems not. cplace parameter has no effet.
Put configuration to be on "C" codepath only (this is why "MPEG2").
This also has issue :
Code:
SetMaxCPU("SSE2")
ColorBars(width=640, height=480, pixel_type="yv24").PlaneToY("Y")
convertbits(16)
awarp4(Spline36Resize(640*4,480*4),asobel(thresh=255).ablur(),depth=6,threads=1,cplace="MPEG2")
So it seems that the warp_c function has issue with both 16 bits and SMAGL=2.
What is the unit of depth, how should it be changed (or not) accordinb bit depth...
Still investigatig.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 30th April 2021, 15:29   #167  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 1st May 2021, 07:14   #168  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
awarp4 bug with HBD seems fixed, thanks
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 2nd June 2021, 08:33   #169  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
I'll continue the aWarpsharp (well Sobel) issues here. I'll push something latter, i'll try to think at something a little different.

Edit
I'm working on something different, having a specific code for the first and last pixel, but keeping alignment.
__________________
My github.

Last edited by jpsdr; 2nd June 2021 at 10:59.
jpsdr is offline   Reply With Quote
Old 2nd June 2021, 18:25   #170  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
I've pushed a possible fix. Pinterf, can you build and test if it's still crashing ?
__________________
My github.
jpsdr is offline   Reply With Quote
Old 2nd June 2021, 20:17   #171  |  Link
pinterf
Registered User
 
Join Date: Jan 2014
Posts: 2,309
Quote:
Originally Posted by jpsdr View Post
I've pushed a possible fix. Pinterf, can you build and test if it's still crashing ?
PM sent with the issue.
pinterf is offline   Reply With Quote
Old 20th July 2021, 18:05   #172  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 21st July 2021, 00:51   #173  |  Link
GMJCZP
Registered User
 
GMJCZP's Avatar
 
Join Date: Apr 2010
Location: I have a statue in Hakodate, Japan
Posts: 744
Quote:
Originally Posted by jpsdr View Post
New version, see first post.
Thank you very much.
__________________
By law and justice!

GMJCZP's Arsenal
GMJCZP is offline   Reply With Quote
Old 23rd February 2022, 18:43   #174  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Finaly sooner than expected, new version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 20th November 2022, 15:05   #175  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 26th February 2023, 12:32   #176  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 22nd July 2023, 05:02   #177  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by real.finder View Post
I got some strange case

using dvd VOB and nnedi3_rpow2(rfactor=2) with awarp4
Code:
LWLibavVideoSource("VTS_01_4.VOB")
awarp4(nnedi3_rpow2(rfactor=2).nnedi3_rpow2(rfactor=2),asobel(thresh=255).ablur(),depth=6)

ffms2 show same problem, but DirectShowSource work! replace nnedi3_rpow2(rfactor=2).nnedi3_rpow2(rfactor=2) with Spline36Resize(width*4, height*4, 0.375, 0.375) also work!
There are same problem with awarp awarp(z_convertformat(pixel_type="yv12"),asobel(thresh=255).ablur(),depth=6)

As a reminder, awarp4 was fixed back then https://github.com/jpsdr/aWarpSharpM...f2990bf0a00cc9
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 24th July 2023, 18:36   #178  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Thanks, i've pushed a fix, don't know when i'll do a new build.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 20th November 2023, 21:51   #179  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
__________________
My github.
jpsdr is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 18:21.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.