Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
18th March 2021, 21:13 | #161 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
__________________
See My Avisynth Stuff |
|
18th March 2021, 21:45 | #162 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
nnedi3_rpow2 splits and process the channels in "Y only", and after recomb using "YtoUV".
You can even if you want write an avs script using "PlaneToY", "nnedi3" and "YtoUV". So when "YtoUV" is used to "regroup" output data when inpiut data was checked Is420(), i think it's automaticaly tagged to YV12. The nnedi3_rpow2 function is like an avs script. I don't know if there is a function to put back original vi.pixel_type...
__________________
My github. |
19th March 2021, 08:11 | #163 | Link |
Registered User
Join Date: Jan 2014
Posts: 2,314
|
For Avisynth it is all the same, YV12 or I420.
That's why VideoInfo::IsSameColorspace has a second test for colorspace. Both formats report "true" on IsYV12(). https://github.com/AviSynth/AviSynth...rface.cpp#L332 |
19th March 2021, 12:41 | #164 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
So, the proper way is not
Code:
if (vi.pixel_type!=vi2.pixel_type) Code:
if (!vi.IsSameColorspace(vi2)) I mean, if there is a IsSameColorspace function, using it is the proper way...
__________________
My github. Last edited by jpsdr; 19th March 2021 at 13:21. |
19th March 2021, 17:30 | #165 | Link |
HeartlessS Usurer
Join Date: Dec 2009
Location: Over the rainbow
Posts: 10,980
|
It is sometimes nice to be able to see the Baked code in the original v2.58 header, to give a clue about what its gonna do.
I'm not suggesting that you use same as v2.58 header, just taking a peek into the black box is sometimes informative. Here is from v2.58 header Code:
// Test for same colorspace bool IsSameColorspace(const VideoInfo& vi) const { if (vi.pixel_type == pixel_type) return TRUE; if (IsYV12() && vi.IsYV12()) return TRUE; return FALSE; } Code:
bool IsYV12() const { return ((pixel_type & CS_YV12) == CS_YV12)||((pixel_type & CS_I420) == CS_I420); }
__________________
I sometimes post sober. StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace "Some infinities are bigger than other infinities", but how many of them are infinitely bigger ??? Last edited by StainlessS; 19th March 2021 at 17:43. |
29th March 2021, 18:55 | #166 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
Begin to investigate.
First thought ChromaPlacement was the issue, but it seems not. cplace parameter has no effet. Put configuration to be on "C" codepath only (this is why "MPEG2"). This also has issue : Code:
SetMaxCPU("SSE2") ColorBars(width=640, height=480, pixel_type="yv24").PlaneToY("Y") convertbits(16) awarp4(Spline36Resize(640*4,480*4),asobel(thresh=255).ablur(),depth=6,threads=1,cplace="MPEG2") What is the unit of depth, how should it be changed (or not) accordinb bit depth... Still investigatig.
__________________
My github. |
1st May 2021, 07:14 | #168 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
awarp4 bug with HBD seems fixed, thanks
__________________
See My Avisynth Stuff |
2nd June 2021, 08:33 | #169 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,316
|
I'll continue the aWarpsharp (well Sobel) issues here. I'll push something latter, i'll try to think at something a little different.
Edit I'm working on something different, having a specific code for the first and last pixel, but keeping alignment.
__________________
My github. Last edited by jpsdr; 2nd June 2021 at 10:59. |
22nd July 2023, 05:02 | #177 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
As a reminder, awarp4 was fixed back then https://github.com/jpsdr/aWarpSharpM...f2990bf0a00cc9
__________________
See My Avisynth Stuff |
|
|