Media Player .NET (MPDN) - D3D HQ GPU Video Renderer [v2.49.0/v1.31.0 27 Dec 2018]

[Zachs]

Originally Posted by Dazog

Can I request a few more features?

A "On Top while playing only" setting.

File type associations in options.

Also in the minimalist mode, no way to tell how far we are into a video if we have to close it and come back and resume from that point.

I guess if you're not playing, then perhaps just minimize the MPDN window?

File associations is on my todo list, haven't had time to get to that.

Can you elaborate a little on what exactly you mean with the last one? If you move your mouse over the seek bar, doesn't that show you how far into the video?

Originally Posted by kostik

Is there gonna be pan and scan? I like your player so far but can't get along with it without having a way to zoom video
thanks

I have plans to do pan and scan that allows you to fill screen (i.e. no letterboxing) only. Or do you want something more than that?

[kostik]

Originally Posted by Zachs

I guess if you're not playing, then perhaps just minimize the MPDN window?

File associations is on my todo list, haven't had time to get to that.

Can you elaborate a little on what exactly you mean with the last one? If you move your mouse over the seek bar, doesn't that show you how far into the video?



I have plans to do pan and scan that allows you to fill screen (i.e. no letterboxing) only. Or do you want something more than that?

yeap to fill the screen is great. Thanks

[Anima123]

FineSharp has the following steps

ToYUV
RemoveGrain11
RemoveGrain4
FineSharpA
FineSharpB
FineSharpC
ToRGB

I wonder if the first and last step are obsolete when used within MPDN's script chain?

[Zachs]

No. If it is applicable to mpchc it's applicable to mpdn.
When you place a pre resize image processor and a post resize one in the chain, mpdn converts YUV to RGB before invoking the scripts. MPDN then expects the result of the render chain to be also in RGB.

[Zachs]

I've updated GitHub with a bunch of changes we (Shiandow and I) have made to improve the render scripts.

Feel free to head over to grab the updated version.

Cheers.

EDIT: Added linear light scaling support via ImageProcessor with the following render script chain:
ImageProcessor - When downscaling video: ConvertToLinearLight.hlsl
ImageProcessor - (Your Pre-scaled Shaders - swap with above if you want shaders to work in gamma light)
Resizer - Resize to: 100% of target size
ImageProcessor - (Your Post-scaled Shaders - swap with below if you want shaders to work in gamma light)
ImageProcessor - When downscaling video: ConvertToGammaLight.hlsl

[Anima123]

You guys are awesome!

Now I am encounter a new problem when playing a 720p file with full HD screen. Namely with NEDI and linear light, when play it in windows mode (target size is the same as original size), MPDN used to avoid NEDI in that case, now it's in full chain mode, which means every script in the chain is active.

Any thoughts to avoid unnecessary calculation power consumption in that case?

BTW my script chain is like the following:

NEDI
ImageProcessor - When downscaling video: ConvertToLinearLight.hlsl
esizer - Resize to: 100% of target size
ImageProcessor - When downscaling video: ConvertToGammaLight.hlsl

Edit: So is with 1080p file played in full HD screen resolution. Or I just has the wrong settings with NEDI?

Edit2: The other issue I noticed is that when use linear light without NEDI, playing 1080p file in windows mode, in which case it's downscaling after Resize, which triggers ConvertToGammaLight.hlsl, yet not trigger the ConvertToLinearLight.hlsl in first step, causes the color in windows mode like washed out.

[Zachs]

I think there's a bug that I've fixed in the best version of mpdn that is causing that.

To see if it is that bug, once you have set up the chain can you restart mpdn before testing?

[Shiandow]

I think I've managed to replicate this bug, it seems to occur when you add the shaders during playback, without resizing. I'll have a quick look to see if I can find what causes it.

Edit: Found it, apparently we forgot to allocate textures when Image Processor updated the filter, again. Let's try a more general fix this time.

[Zachs]

This should be fixed in the version where mpdn triggers output size changed event when apply button is pressed.

Haven't got time right now to release that version yet. But will do ASAP.

[Shiandow]

I actually prefer the method I just proposed on git, maybe have a look?

[Zachs]

I'll take a look.
But MPDN calls output size changed internally anyway to activate its settings
Anyway I'll take a look at git.

EDIT: I've merged your changes to master.

[Zachs]

Originally Posted by Anima123

Now I am encounter a new problem when playing a 720p file with full HD screen. Namely with NEDI and linear light, when play it in windows mode (target size is the same as original size), MPDN used to avoid NEDI in that case, now it's in full chain mode, which means every script in the chain is active.

Any thoughts to avoid unnecessary calculation power consumption in that case?

BTW my script chain is like the following:

NEDI
ImageProcessor - When downscaling video: ConvertToLinearLight.hlsl
esizer - Resize to: 100% of target size
ImageProcessor - When downscaling video: ConvertToGammaLight.hlsl

Edit: So is with 1080p file played in full HD screen resolution. Or I just has the wrong settings with NEDI?

Edit2: The other issue I noticed is that when use linear light without NEDI, playing 1080p file in windows mode, in which case it's downscaling after Resize, which triggers ConvertToGammaLight.hlsl, yet not trigger the ConvertToLinearLight.hlsl in first step, causes the color in windows mode like washed out.

Your last issue is fixed with latest render script / MPDN version.

With regards to the first issue, ImageProcessor isn't compatible to be used in that manner yet - When downscaling 'video' means comparing video size with target size, while NEDI doubles the video size before feeding it into ImageProcessor. What is supported at the moment is to have NEDI come after ImageProcessor. EDIT: Scratch that, your usage should be fine. Don't know what I was thinking. If video is being downscaled then NEDI shouldn't be active. In which case, there shouldn't be any problem with using video size vs target size to find out if we're downscaling.

EDIT2: There's still a bug that causes NEDI to be always active when used in that way. I'll fix that.

EDIT3: Fixed in git.

[Anima123]

Shiandow, is there any quality-wise problem with NEDI handled after being converted in linear light, as Zachs suggested right now?

[Zachs]

Originally Posted by Anima123

Shiandow, is there any quality-wise problem with NEDI handled after being converted in linear light, as Zachs suggested right now?

NEDI will be disabled if you don't force enable it in downscaling cases. It won't make a difference.

[Shiandow]

Originally Posted by Anima123

Shiandow, is there any quality-wise problem with NEDI handled after being converted in linear light, as Zachs suggested right now?

Well, as Zachs said there's no problem with the chain you posted since NEDI and linear light conversion won't be on at the same time.

That said I wouldn't recommend performing NEDI in linear light, it tends to make the artefacts more noticeable. And as far as I know there's not much benefit in doing NEDI in linear light. However I could be mistaken so you should probably at least give it a try if you want to be sure.

[Anima123]

I tried the latest version of the player and the script, it's behavior is still not ideal to me.

Let's assume Video Size as the original size of the video, Doubled Video Size is doubled size via NEDI, Target Size is the screen resolution (full screen) mode or a smaller one (windows mode), the following is the ideal behavior in my mind:

if (Video Size >= Target Size) { //which means downscaler should be used
    disable NEDI;
    trigger linear light if downscaler is used for real;
}
else { // Video Size < Target Size, in which case upscaler should be in use
    enable NEDI;
    if (Doubled Video Size  > Target Size) // in which case the downscaler should be in use
        trigger linear light if configured;
}

Any idea if this can be down?

The current latest version does not act like the ideal case, hence there's potential bug to me.

[Zachs]

I have an idea that will do that but I'll discuss with Shiandow in PM first.

[feelingblue]

I am very happy that after my suggestion to use the finesharp shader you have been considering to make it work better. thanks!!
For my setup is probably the best method of sharpness.

A little suggestion, is possible to implement various chroma resampling filters as Robidoux, blackman, Gaussian and Hermite?
Some of them are simlpy interpretation of bicubic style resize.

[Zachs]

Originally Posted by feelingblue

I am very happy that after my suggestion to use the finesharp shader you have been considering to make it work better. thanks!!
For my setup is probably the best method of sharpness.

A little suggestion, is possible to implement various chroma resampling filters as Robidoux, blackman, Gaussian and Hermite?
Some of them are simlpy interpretation of bicubic style resize.

MPDN's Softcubic and Bicubic covers a lot of the 'bicubic' style resize via the softness/sharpness parameter. Not sure about blackman but the last I tried gaussian, it's so similar to softcubic it's quite unnecessary.

[Zachs]

Originally Posted by Anima123

I tried the latest version of the player and the script, it's behavior is still not ideal to me.

Let's assume Video Size as the original size of the video, Doubled Video Size is doubled size via NEDI, Target Size is the screen resolution (full screen) mode or a smaller one (windows mode), the following is the ideal behavior in my mind:

if (Video Size >= Target Size) { //which means downscaler should be used
    disable NEDI;
    trigger linear light if downscaler is used for real;
}
else { // Video Size < Target Size, in which case upscaler should be in use
    enable NEDI;
    if (Doubled Video Size  > Target Size) // in which case the downscaler should be in use
        trigger linear light if configured;
}

Any idea if this can be down?

The current latest version does not act like the ideal case, hence there's potential bug to me.

The GUI script chain creator is always going to have limitations - it's just plain unintuitive to use for complicated situations.

As such, MPDN v2.9.3 allows you to write your own chain in a script, as an example:

PHP Code:

            protected override RenderScript[] GetScriptChain()
            {
                var result = new List<RenderScript>();

                // Pre resize shaders, followed by NEDI image doubler
                result.Add(PreProcess);

                var size = Renderer.VideoSize;

                // Use NEDI once only.
                // Note: To use NEDI as many times as required to get the image past target size,
                //       Change the following *if* to *while*
                if (IsUpscalingFrom(size)) // See RenderScriptChain for other comparer methods
                {
                    result.Add(Nedi);
                    size = DoubleSize(size);
                }

                if (IsDownscalingFrom(size))
                {
                    // Use linear light for downscaling
                    result.Add(ToLinear);
                    result.Add(ResizeToTarget);
                    result.Add(ToGamma);
                }
                else
                {
                    // Otherwise, scale with gamma light
                    result.Add(ResizeToTarget);
                }

                // Post resize shaders
                result.Add(PostProcess);

                return result.ToArray();
            } 


To activate it, choose the "Custom Render Script Chain" script. It must be the sole script in the chain, or its behaviour would be undefined.

Get the latest scripts from github. Example is shown in MyRenderScripts.cs.

You can customize it beyond what is shown by checking for VideoSize - for SD, do X, for super small video size, do Y, for HD, do Z.

Feel free to share your script in the forum!