Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
2nd December 2017, 12:07 | #61 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
edit: 3 should mean copy chroma, 0 like ignore chroma (fast and garbage like 1 in u or v in masktools) so cm in awarpsharp should be:- cm=0 -> chroma=1 cm=1 -> chroma=4 cm=2 -> chroma=3 cm=3 -> chroma=2
__________________
See My Avisynth Stuff Last edited by real.finder; 2nd December 2017 at 12:19. |
|
2nd December 2017, 12:31 | #62 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,309
|
Ok, i'll continue to investigate, and cheking the aWarpSharp2 from aWarpSharp_20120328 and my actual aWarpSharp. I didn't see any difference in the C part code, meaning i'll have to compare/check the asm code... Will be more troublesome, but if you said that the aWarpSharp2 from aWarpSharp_20120328 doesn't have the chroma issue, but the aWarpSharp2 from awarpsharp2-2015.12.30 have it, there must be a difference somewhere...
|
2nd December 2017, 14:46 | #64 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
left it at 1 cuz in old awarpsharp cm=1 is same as cm=3, there are some bugs in old awarpsharp and this one of them
__________________
See My Avisynth Stuff Last edited by real.finder; 2nd December 2017 at 14:53. |
4th December 2017, 14:14 | #67 | Link |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
yes, thank you
__________________
See My Avisynth Stuff |
4th December 2017, 15:48 | #68 | Link | |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,309
|
Quote:
The issue i probably see it's that it seems to have been forgoten that this function copy plane of same size, when in aWarp4 the input is 4 times the output, resulting in copy being just a quarter of the source. When source size is different from destination, from my point of view, the idea of "copying" make no sense. For me, there is nothing to fix, as these options should just not be avaible in aWarp4. If i had to do something, i would just throw an "not avaible" or "incompatible" error . |
|
4th December 2017, 21:40 | #70 | Link | |
Registered User
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
|
Quote:
what about adding PointResize(input.Width()/4,input.Height()/4) before use the CopyPlane in awarp4? it will do the job edit1: or PointResize(mask.Width(),mask.Height()) edit2: well, its not like the rpower=2, it not work as it should in rpower=4, it must use PointResize(input.Width()/2,input.Height()/2).PointResize(input.Width()/4,input.Height()/4) or PointResize(input.Width()/2,input.Height()/2).PointResize(mask.Width(),mask.Height()) and it will not work well for chroma if the chroma and luma in same clip (YUV), it should be used with Y/Y8 Grayscale separated chroma
__________________
See My Avisynth Stuff Last edited by real.finder; 4th December 2017 at 22:02. |
|
5th December 2017, 10:18 | #71 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,309
|
Yes for the "make it worst".
I'm not interested in wasting time adding a resampler, i just consider "copy" make no sense for aWarp4, so there will be no "copy" cases. When i do an update (not planed for now unless a bug is to be fixed), i'll update the readme and just "do nothing" in these cases (avoiding wasting time doing useless copy). It's at the user to do the proper things, and use whatever resampler he wants to make/create the missing planes. |
5th December 2017, 14:29 | #73 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,309
|
Only with aWarp4, that's it ? aWarp works fine ?
Can you test all the chroma mode (0 to 6), and tell me is all are crashing, or if some are crashing and some not ? x64 crashing and not x86 is typical of an issue in the asm code, but unfortunately, for now i've not been able to find the issue... Last edited by jpsdr; 5th December 2017 at 14:47. |
6th December 2017, 10:06 | #75 | Link |
Registered User
Join Date: Oct 2002
Location: France
Posts: 2,309
|
What..??? You told me in post #32 it was aWarp4...
Edit : Now that you told me it's aBlur, it took me only a few seconds to find the potential issue. Last edited by jpsdr; 6th December 2017 at 10:08. |
Thread Tools | Search this Thread |
Display Modes | |
|
|