Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 2nd December 2017, 12:07   #61  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by jpsdr View Post
I think the issue may come from the chroma mode.
According here, it seems there is some error in the documentation about the default chroma mode, so if the filters afterward where made using a wrong default chroma mode, it will not be surprising that there is differences in chroma. More troublesome, mapping for chroma original mode 3 doesn't exist in the new aWarpSharp function, and a call with the remaped actual aWarpSharp with a chroma mode of 3 will result in an error.
Otherwise, only in new chroma mode 3 and 5 the blur level chroma specific has an effect on the chroma, not on the default mode (4).
So, for now, try playing with cm parameter on the new aWarpSharp version, to see if you can get back the original result.
I tried but without any luck, only case that will be right is cm=0, the problem as I said in 2015 and up after added depthC, in awarpsharp() in awarpsharp2 dll it's always set to 0, just remove the depthC usage from awarpsharp() and it will be ok

edit: 3 should mean copy chroma, 0 like ignore chroma (fast and garbage like 1 in u or v in masktools)

so cm in awarpsharp should be:-
cm=0 -> chroma=1
cm=1 -> chroma=4
cm=2 -> chroma=3
cm=3 -> chroma=2
__________________
See My Avisynth Stuff

Last edited by real.finder; 2nd December 2017 at 12:19.
real.finder is offline   Reply With Quote
Old 2nd December 2017, 12:31   #62  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Ok, i'll continue to investigate, and cheking the aWarpSharp2 from aWarpSharp_20120328 and my actual aWarpSharp. I didn't see any difference in the C part code, meaning i'll have to compare/check the asm code... Will be more troublesome, but if you said that the aWarpSharp2 from aWarpSharp_20120328 doesn't have the chroma issue, but the aWarpSharp2 from awarpsharp2-2015.12.30 have it, there must be a difference somewhere...
jpsdr is offline   Reply With Quote
Old 2nd December 2017, 14:35   #63  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Thanks for your pm, i was looking in the wrong way.
According the wiki page, the default is cm=3, should i also change that, or left at 1 ?
jpsdr is offline   Reply With Quote
Old 2nd December 2017, 14:46   #64  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by jpsdr View Post
Thanks for your pm, i was looking in the wrong way.
According the wiki page, the default is cm=3, should i also change that, or left at 1 ?
left it at 1 cuz in old awarpsharp cm=1 is same as cm=3, there are some bugs in old awarpsharp and this one of them
__________________
See My Avisynth Stuff

Last edited by real.finder; 2nd December 2017 at 14:53.
real.finder is offline   Reply With Quote
Old 2nd December 2017, 18:27   #65  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
jpsdr is offline   Reply With Quote
Old 4th December 2017, 10:07   #66  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Is the chroma issue of post #22 fixed with this new version ?
jpsdr is offline   Reply With Quote
Old 4th December 2017, 14:14   #67  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by jpsdr View Post
Is the chroma issue of post #22 fixed with this new version ?
yes, thank you
__________________
See My Avisynth Stuff
real.finder is offline   Reply With Quote
Old 4th December 2017, 15:48   #68  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Quote:
Originally Posted by Motenai Yoda View Post
chroma values 2 5 6 are bugged as it doesn't scale back chroma/luma channels
maybe it can take them from last
At first glance, it seems that the code use the same "CopyPlane" function also in Warp4.
The issue i probably see it's that it seems to have been forgoten that this function copy plane of same size, when in aWarp4 the input is 4 times the output, resulting in copy being just a quarter of the source.
When source size is different from destination, from my point of view, the idea of "copying" make no sense. For me, there is nothing to fix, as these options should just not be avaible in aWarp4.
If i had to do something, i would just throw an "not avaible" or "incompatible" error .
jpsdr is offline   Reply With Quote
Old 4th December 2017, 18:37   #69  |  Link
GMJCZP
Registered User
 
GMJCZP's Avatar
 
Join Date: Apr 2010
Location: I have a statue in Hakodate, Japan
Posts: 744
I have not tried it but also thank you very much!
__________________
By law and justice!

GMJCZP's Arsenal
GMJCZP is offline   Reply With Quote
Old 4th December 2017, 21:40   #70  |  Link
real.finder
Registered User
 
Join Date: Jan 2012
Location: Mesopotamia
Posts: 2,587
Quote:
Originally Posted by jpsdr View Post
as these options should just not be avaible in aWarp4.
If i had to do something, i would just throw an "not avaible" or "incompatible" error .
that will make it worst I think

what about adding PointResize(input.Width()/4,input.Height()/4) before use the CopyPlane in awarp4? it will do the job

edit1: or PointResize(mask.Width(),mask.Height())

edit2: well, its not like the rpower=2, it not work as it should in rpower=4, it must use PointResize(input.Width()/2,input.Height()/2).PointResize(input.Width()/4,input.Height()/4)

or PointResize(input.Width()/2,input.Height()/2).PointResize(mask.Width(),mask.Height())

and it will not work well for chroma if the chroma and luma in same clip (YUV), it should be used with Y/Y8 Grayscale separated chroma
__________________
See My Avisynth Stuff

Last edited by real.finder; 4th December 2017 at 22:02.
real.finder is offline   Reply With Quote
Old 5th December 2017, 10:18   #71  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Yes for the "make it worst".
I'm not interested in wasting time adding a resampler, i just consider "copy" make no sense for aWarp4, so there will be no "copy" cases. When i do an update (not planed for now unless a bug is to be fixed), i'll update the readme and just "do nothing" in these cases (avoiding wasting time doing useless copy). It's at the user to do the proper things, and use whatever resampler he wants to make/create the missing planes.
jpsdr is offline   Reply With Quote
Old 5th December 2017, 11:48   #72  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 3,646
I've spent some more time on this.. the x86 version is okay it's just the x64 that crashes.
ryrynz is offline   Reply With Quote
Old 5th December 2017, 14:29   #73  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Only with aWarp4, that's it ? aWarp works fine ?

Can you test all the chroma mode (0 to 6), and tell me is all are crashing, or if some are crashing and some not ?
x64 crashing and not x86 is typical of an issue in the asm code, but unfortunately, for now i've not been able to find the issue...

Last edited by jpsdr; 5th December 2017 at 14:47.
jpsdr is offline   Reply With Quote
Old 5th December 2017, 21:02   #74  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 3,646
The problem is type=1 in ablur, setting to 0 fixes it.
I did try chroma 0-6, threads=1 as well on ablur but no change.

Last edited by ryrynz; 5th December 2017 at 21:29.
ryrynz is offline   Reply With Quote
Old 6th December 2017, 10:06   #75  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
What..??? You told me in post #32 it was aWarp4...

Edit :
Now that you told me it's aBlur, it took me only a few seconds to find the potential issue.

Last edited by jpsdr; 6th December 2017 at 10:08.
jpsdr is offline   Reply With Quote
Old 6th December 2017, 10:20   #76  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 3,646
Quote:
Originally Posted by jpsdr View Post
What..??? You told me in post #32 it was aWarp4
You wouldn't use it without awarp4 most times :P I didn't think to narrow down and test the individual components but whatever I got there in the end. Bring forth the fix.
ryrynz is offline   Reply With Quote
Old 6th December 2017, 10:39   #77  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
We have to wait that i have time to build and make a release to see if what i've found fix your issue.
jpsdr is offline   Reply With Quote
Old 6th December 2017, 21:47   #78  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
New version, see first post.
jpsdr is offline   Reply With Quote
Old 6th December 2017, 22:28   #79  |  Link
ryrynz
Registered User
 
ryrynz's Avatar
 
Join Date: Mar 2009
Posts: 3,646
Still crashing when I use type=1 on 1.0.2, tested with W7 build.
ryrynz is offline   Reply With Quote
Old 7th December 2017, 09:39   #80  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,309
Ah... I think i've found out what i've missed grrr...
jpsdr is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 07:10.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.