Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Video Encoding > High Efficiency Video Coding (HEVC)

Reply
 
Thread Tools Search this Thread Display Modes
Old 17th January 2023, 19:55   #8941  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,718
Quote:
Originally Posted by jpsdr View Post
Are these patches interesting (and correct, not adding issues) to commit in my custombuild ?
I checked my code, they are not implemented, so the bugs (if realy) are still here. As i'm using tskip, if the 1rst is to be commited, i'm very interested by a validation.

https://github.com/videolan/x265/pul...dbc25d50cec5d8 (very interested if this one is to be applyed)
https://github.com/videolan/x265/pul...0c8ffe57bc08b6
https://github.com/videolan/x265/pul...0cc988a0928a11 (this one is big... Maybe not so easy to check the effects ?)
https://github.com/videolan/x265/pul...953a189859ff8b
The third one could well be interesting to many. If you could do the first pass in like half the resolution of the actual encode in the second pass, it might speed things up considerably. Especially with 4K sources, that is.
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 17th January 2023, 22:04   #8942  |  Link
vpupkind
Registered User
 
Join Date: Jul 2007
Posts: 60
Quote:
Originally Posted by Boulder View Post
The third one could well be interesting to many. If you could do the first pass in like half the resolution of the actual encode in the second pass, it might speed things up considerably. Especially with 4K sources, that is.
I think (looking at GitHub) that the reason for non-inclusion is CLA (derived from the x265 CLA)
vpupkind is offline   Reply With Quote
Old 18th January 2023, 09:55   #8943  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
I think for now i'll not try to include the big one, but i need to be sure that the 3 others are validated to be bug fixes.

For aq-auto, what i'll see if easy to do is the following :
--aq-auto <integer>
0 : Default, disable. <>0 enabled.
Bit 1 : If set to 1 enable hysteresis.
Bit 2 : If set to 1 enable HDR mode.
Bit 3 : If set to 1 enable AQ5.
The others bits (0, 4 to 7) if set to 1 will just enable the aq-auto mode.
=>
--aq-auto 1 : Just enable the aq-auto mode.
--aq-auto 2 is exactly the same than --aq-auto 3.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 18th January 2023, 10:02   #8944  |  Link
LeXXuz
21 years and counting...
 
LeXXuz's Avatar
 
Join Date: Oct 2002
Location: Germany
Posts: 716
Anyone else having issues with x265 halting about 4 seconds before the actual source file ends? It doesn't happen every time but quite a few times now on different systems.
Currently using jp's version: 3.5+75+0-f3c013983 [Mod by Patman]
LeXXuz is offline   Reply With Quote
Old 18th January 2023, 19:58   #8945  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,750
Quote:
Originally Posted by jpsdr View Post
Are these patches interesting (and correct, not adding issues) to commit in my custombuild ?
I checked my code, they are not implemented, so the bugs (if realy) are still here. As i'm using tskip, if the 1rst is to be commited, i'm very interested by a validation.

https://github.com/videolan/x265/pul...dbc25d50cec5d8 (very interested if this one is to be applyed)
https://github.com/videolan/x265/pul...0c8ffe57bc08b6
https://github.com/videolan/x265/pul...0cc988a0928a11 (this one is big... Maybe not so easy to check the effects ?)
https://github.com/videolan/x265/pul...953a189859ff8b
#1 is certainly interesting to me. --tskip is a very valuable feature with a certain subset of content, like text and computer graphics. Using the wrong reconstruction sounds like a pretty big bug.

That said, it's from 2018. I wouldn't be surprised if it had already been fixed.
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 18th January 2023, 20:21   #8946  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
I've put the 2 first patches. And no, they were not fixed.
Also put the change on --aq-auto command. Now, i have to build and make my usual small quick encode test.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 18th January 2023, 21:27   #8947  |  Link
madey83
Guest
 
Posts: n/a
Quote:
Originally Posted by jpsdr View Post
I've put the 2 first patches. And no, they were not fixed.
Also put the change on --aq-auto command. Now, i have to build and make my usual small quick encode test.
Hi,

is this "--aq-auto-hdr" can be used for dolby vision encode use case?
  Reply With Quote
Old 18th January 2023, 23:23   #8948  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
@madey83
Yes.

New build with the modified --aq-auto command described in post #8949, and also include the two old bug fix patches. Check my Github.
Quick small encode test, seems fine.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 19th January 2023, 06:47   #8949  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,718
It's a bit confusing Are we talking about an 8-bit integer here? I was just quickly testing it, and expected --aq-auto 3 to enable hysteresis and HDR mode (calculated 1+2) but it only enabled hysteresis. --aq-auto 6 brought up the desired combination while I assumed it would enable all of the three.
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 19th January 2023, 09:42   #8950  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
With 3, you set Bits 0 & 1 at 1.
With 6, you set Bits 1 & 2 at 1.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 19th January 2023, 09:43   #8951  |  Link
Zebulon84
Registered User
 
Join Date: Apr 2015
Posts: 21
obsolete
Zebulon84 is offline   Reply With Quote
Old 19th January 2023, 19:04   #8952  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
What is obsolete ???
__________________
My github.
jpsdr is offline   Reply With Quote
Old 19th January 2023, 20:06   #8953  |  Link
Boulder
Pig on the wing
 
Boulder's Avatar
 
Join Date: Mar 2002
Location: Finland
Posts: 5,718
Quote:
Originally Posted by jpsdr View Post
With 3, you set Bits 0 & 1 at 1.
With 6, you set Bits 1 & 2 at 1.
Oh, I thought it was to calculate "0+1+2+4" for the first four bits. It's been 25 years since I practiced any of this stuff
__________________
And if the band you're in starts playing different tunes
I'll see you on the dark side of the Moon...
Boulder is offline   Reply With Quote
Old 19th January 2023, 21:07   #8954  |  Link
ShortKatz
Registered User
 
Join Date: Aug 2018
Location: Germany
Posts: 118
Quote:
Originally Posted by benwaggoner View Post

That said, it's from 2018. I wouldn't be surprised if it had already been fixed.
Nope, the patch still does apply. So, I was wondering, if this bug is so big and there since (minimum) 2018, why did no one else notice?
ShortKatz is offline   Reply With Quote
Old 20th January 2023, 11:09   #8955  |  Link
Barough
Registered User
 
Barough's Avatar
 
Join Date: Feb 2007
Location: Sweden
Posts: 480
x265 v3.5+87
Built on January 20, 2023, GCC 12.2.0

https://www.mediafire.com/file/iz8fqi7rqpi55sm
Barough is offline   Reply With Quote
Old 20th January 2023, 19:12   #8956  |  Link
benwaggoner
Moderator
 
Join Date: Jan 2006
Location: Portland, OR
Posts: 4,750
Quote:
Originally Posted by ShortKatz View Post
Nope, the patch still does apply. So, I was wondering, if this bug is so big and there since (minimum) 2018, why did no one else notice?
Have been a before/after analysis to show the benefits of the fix?
__________________
Ben Waggoner
Principal Video Specialist, Amazon Prime Video

My Compression Book
benwaggoner is offline   Reply With Quote
Old 20th January 2023, 21:52   #8957  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.
__________________
My github.
jpsdr is offline   Reply With Quote
Old 21st January 2023, 05:25   #8958  |  Link
TDS
Formally known as .......
 
TDS's Avatar
 
Join Date: Sep 2021
Location: Down Under.
Posts: 965
Quote:
Originally Posted by jpsdr View Post
I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.
I have done a lot of testing, you maybe interested in the results:-

https://forum.doom9.org/showthread.p...17#post1981517
&
https://forum.doom9.org/showthread.p...53#post1981553

But only up to build 85.
__________________
Long term RipBot264 user.

RipBot264 modded builds..
TDS is offline   Reply With Quote
Old 21st January 2023, 23:45   #8959  |  Link
LeXXuz
21 years and counting...
 
LeXXuz's Avatar
 
Join Date: Oct 2002
Location: Germany
Posts: 716
Quote:
Originally Posted by jpsdr View Post
I've made a new build of my custom version, small quick encode test seems fine.
Check my Github.
jpsdr, I have been using v+75 with extra switches: "--aq-mode 5 --sbrc --sbrc-aq5 --sbrc-hyst" for 1080p SDR content.

Is this still valid with v+87? A lot of talk about new switch names here which confuses me a little.
LeXXuz is offline   Reply With Quote
Old 22nd January 2023, 10:40   #8960  |  Link
jpsdr
Registered User
 
Join Date: Oct 2002
Location: France
Posts: 2,308
@LeXXuz
For the same command line effect, you have to replace --sbrc --sbrc-aq5 --sbrc-hyst with --aq-auto 10 assuming you don't want the new sbrc (wich has totaly nothing to do with the first patch) and just keep the auto AQ feature.
(And still check with the log file )
__________________
My github.

Last edited by jpsdr; 22nd January 2023 at 10:42.
jpsdr is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 09:25.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.