Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 21st July 2017, 14:40   #21  |  Link
clsid
Registered User
 
Join Date: Feb 2005
Posts: 4,645
Only if he cuts up his changes in small chunks and adds new custom renderers instead of replacing current ones. Otherwise the risk of things breaking are too high. He doesn´t seems to want to do it this way, so chance is probably zero.
clsid is offline   Reply With Quote
Old 23rd July 2017, 09:07   #22  |  Link
ShadyCrab
Registered User
 
Join Date: Jul 2015
Posts: 16
Is there a chance that the sanear WASAPI audio renderer could support Windows Sonic/Dolby Atmos for headphones? It doesn't need to use the new API's, but as its designed the renderer won't actually output 5.1 or 7.1 to Windows if Sonic is enabled.

The reason for it is that sanear uses the GetMixFormat API, which will only output 2.0 if Sonic is selected. If it uses the IsFormatSupported API, Windows should report 7.1 if Sonic is enabled and output surround sound for Sonic to mix.

Here's an explanation from a MSFT employee
Quote:
The output format will be stereo because Windows Sonic for Headphones and Dolby Atmos for headphones virtualize 7.1 speakers using an HRTF which outputs stereo. An HRTF positions sounds in a similar way as you would sound in the real world.
There are 2 WSASAPI APIs that a developer can use to determine what formats could be supported: IAudioClient::IsFormatSupported IAudioClient::GetMixFormat
IAudioClient::IsFormatSupported is the recommended API to determin what format to render. When Dolby Atmos for Headphones and Windows Sonic for headphones are enabled, most formats are supported.
IAudioClient::GetMixFormat returns what the device format is and will return stereo even when Dolby Atmos for Headphones or Windows Sonic for headphones is supported. So if a PC game/app uses this API, instead of the recommended one, it will unfortunately just send down stereo. We are looking at a clever way to better support these apps as well without eroding the true purpose and meaning of the IAudioClient::GetMixFormat API.
Windows Sonic for Headphones doesn't put stereo in the front. When the Windows Creators Update launched, Dolby Atmos for Headphones did out stereo in the FL and FR. That's also why FL and FR are not as pronounced there. We have an update for that in the pipeline.
ShadyCrab is offline   Reply With Quote
Old 26th July 2017, 13:10   #23  |  Link
chros
Registered User
 
chros's Avatar
 
Join Date: Mar 2002
Posts: 983
Quote:
Originally Posted by ShadyCrab View Post
Is there a chance that the sanear WASAPI audio renderer ...
@clsid: the built-in internal audio renderer needs to be updated ASAP to the current master branch of sanear. That's the biggest bug that MPC-HC has for more than a year!
(You tried to compile it with it couple of months ago, and as I recall it it went fine. I use it as an external filter for more than a year and it's flawless.)
__________________
MSI GE60(i73630QM,16GB,IntelHD4000(v10.18.10.4358)+GeForceGT650m(2GB,v355.98)+muxless,1920x1080@60Hz,Plextor M5M 256GB SSD,Win8.1x64+MPC-HCx64+LAV+MadVR)+Yamaha RX-830+LG 55LD650(1080p@24/25/30/60Hz)
chros is offline   Reply With Quote
Old 26th July 2017, 14:24   #24  |  Link
clsid
Registered User
 
Join Date: Feb 2005
Posts: 4,645
Sanear integration requires additional changes to get it to work properly with newer version. The current devs are all super busy, so help is needed/welcome.
clsid is offline   Reply With Quote
Old 27th July 2017, 13:07   #25  |  Link
chros
Registered User
 
chros's Avatar
 
Join Date: Mar 2002
Posts: 983
Quote:
Originally Posted by clsid View Post
Sanear integration requires additional changes to get it to work properly with newer version. The current devs are all super busy, so help is needed/welcome.
No worries, I just wanted to put it in the log
__________________
MSI GE60(i73630QM,16GB,IntelHD4000(v10.18.10.4358)+GeForceGT650m(2GB,v355.98)+muxless,1920x1080@60Hz,Plextor M5M 256GB SSD,Win8.1x64+MPC-HCx64+LAV+MadVR)+Yamaha RX-830+LG 55LD650(1080p@24/25/30/60Hz)
chros is offline   Reply With Quote
Old 6th August 2017, 19:15   #26  |  Link
holnap32
Registered User
 
Join Date: Jul 2017
Posts: 1
I just wanted to give a supportive comment. I really appreaciate that you are picking up the development of MPC-HC. This is by far my favourite player. I tried a lot VLC, MPC-BE, and many others, but in the end I always come back to MHC-HC.

Some features that I use a lot:
- Download subtitles from subtitle sites from the playing movie in the app itself (can this be done on VLC? I don't think so, I always have to go a web browser download, and load manually.)
- Easy to change subtitle and audio tracks (in MPC-BE it is still akward)
- Unified Remote Full on my Android phone to act as a remote control (doesn't exist for MPC-BE, it exists for VLC)

As for what features/bugs you develop: maybe make a wide table with scores on different criteria. Development time needed, complexity, urgency, usefullness, number of requests, etc. And from that table go for the low effort, high benefit development possibilities.

All in all, the feature I love the most in MPC-HC is how it handles subtitles. It's so convenient to press D, and select the subtitles file from the list, it's incredible.
My vote is to develop any features regarding subtitles, more sites, even more easier.

Then, if we could have a dedicated button for changing audio and subtitle tracks in Unified Remote on Android, that would be great, but probably for this I have to ask them directly.

Keep up the good work, and I'm looking forward to the next release! And a big thank you for keeping up the development!
holnap32 is offline   Reply With Quote
Old 7th August 2017, 15:10   #27  |  Link
clsid
Registered User
 
Join Date: Feb 2005
Posts: 4,645
Adding more subtitle sites is not possible because most sites do not provide an API for searching and downloading subtitles.

For remote control features you need to ask elsewhere.
clsid is offline   Reply With Quote
Old 9th August 2017, 14:54   #28  |  Link
ShadyCrab
Registered User
 
Join Date: Jul 2015
Posts: 16
I went ahead and made a pull request that allows sanear to support Windows Sonic/Dolby Atmos. Allows me to finally ditch the DirectSound/WaveOut renderers, and with the master branch it even supports enabling/disabling spatial sound during playback with live feedback.

https://github.com/alexmarsev/sanear/pull/19

I made a pull request here as well for MPC-HC's fork.

It works for my stereo 24bit 44.1khz device, with surround sound output for surround content when Dolby Atmos is enabled, and stereo output when Dolby Atmos is disabled, stereo content is playing or if 'Exclusive mode' is enabled. The only thing I haven't tested is 'Exclusive mode' native surround output (such as a HDMI 7.1 output). Easy to test, just need to enable 'Exclusive mode' on a 5.1/7.1 native device and test that sanear plays and outputs 5.1/7.1

Also quick note, 'ignoreSystemChannelMixer' option should be set to false, else it will not output surround sound with Windows Sonic/Dolby Atmos.

Last edited by ShadyCrab; 9th August 2017 at 15:17.
ShadyCrab is offline   Reply With Quote
Old 15th August 2017, 12:44   #29  |  Link
chros
Registered User
 
chros's Avatar
 
Join Date: Mar 2002
Posts: 983
Quote:
Originally Posted by holnap32 View Post
I just wanted to give a supportive comment. I really appreaciate that you are picking up the development of MPC-HC. This is by far my favourite player. I tried a lot VLC, MPC-BE, and many others, but in the end I always come back to MHC-HC.

...

- Easy to change subtitle and audio tracks (in MPC-BE it is still akward)
- Unified Remote Full on my Android phone to act as a remote control (doesn't exist for MPC-BE, it exists for VLC)
I just switched to MPC-BE.
For Android remote, the best is Remoti-co (I use it for about 4-5 years), I mentioned the modified version in mpc-hc main thread, search fort it. It also works with MPC-BE.
__________________
MSI GE60(i73630QM,16GB,IntelHD4000(v10.18.10.4358)+GeForceGT650m(2GB,v355.98)+muxless,1920x1080@60Hz,Plextor M5M 256GB SSD,Win8.1x64+MPC-HCx64+LAV+MadVR)+Yamaha RX-830+LG 55LD650(1080p@24/25/30/60Hz)
chros is offline   Reply With Quote
Old 15th August 2017, 16:44   #30  |  Link
clsid
Registered User
 
Join Date: Feb 2005
Posts: 4,645
Quote:
Originally Posted by ShadyCrab View Post
I went ahead and made a pull request that allows sanear to support Windows Sonic/Dolby Atmos. Allows me to finally ditch the DirectSound/WaveOut renderers, and with the master branch it even supports enabling/disabling spatial sound during playback with live feedback.

https://github.com/alexmarsev/sanear/pull/19

I made a pull request here as well for MPC-HC's fork.

It works for my stereo 24bit 44.1khz device, with surround sound output for surround content when Dolby Atmos is enabled, and stereo output when Dolby Atmos is disabled, stereo content is playing or if 'Exclusive mode' is enabled. The only thing I haven't tested is 'Exclusive mode' native surround output (such as a HDMI 7.1 output). Easy to test, just need to enable 'Exclusive mode' on a 5.1/7.1 native device and test that sanear plays and outputs 5.1/7.1

Also quick note, 'ignoreSystemChannelMixer' option should be set to false, else it will not output surround sound with Windows Sonic/Dolby Atmos.
I don't know if any of the developers has Atmos compatible hardware to test his. So perhaps you could make a test build and post it in the general MPC-HC discussion topic. That could speed up approval.
The integrated Sanear in MPC-HC is currently missing some options compared to standalone version. Maybe you are interested in adding those to settings window in MPC-HC?
clsid is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 09:05.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2017, vBulletin Solutions Inc.