L-SMASH Source

[wonkey_monkey]

Originally Posted by StvG

Try with installing it on the Windows-wide and reopen the ucrt64 shell from vs cmd to get nasm in the path.

Edit: I will try it myself now with cl (I always use clang-cl) to see if there are errors.

Done (and I added the path to the system-wide nasm.exe in environment variables), but with no change to the errors. MSYS2's nasm.exe was already in MSYS2's path.

Perhaps I should get clang...

[StvG]

Mmm. MSYS2 nasm shouldn't be issue because when I type in the ucrt64 shell "where nasm" I get "C:\msys64\ucrt64\bin\nasm.exe". You need "mingw-w64-ucrt-x86_64-nasm".

If you didn't see the other edits from my previous post I updated the script to be more friendly. Also you can use vcpkg to build ffmpeg with MSVC much more easily.

Edit: for vcpkg you can see an example here.

[wonkey_monkey]

Yup, that's the same result I get from "where nasm". But I haven't done anything to tell Visual Studio/cl.exe to use nasm when it finds inline assembler, if that can even be done...

I tried with the new version of script, with these changes:

compiler="cl"
cmake_path="/c/Program Files/CMake/bin/cmake"
dav1d_cross_file="/c/msys64/home/David/dav1d_cross.txt"

but still get the errors.

[StvG]

Share "config.log" from "ffmpeg\ffbuild".

Also "config.h" and "config_components.h", and "config.asm" from "ffmpeg".

[wonkey_monkey]

Originally Posted by StvG

Share "config.log" from "ffmpeg\ffbuild".

Also "config.h" and "config_components.h", and "config.asm" from "ffmpeg".

https://horman.net/avisynth/ffmpeg_stuff.zip

[StvG]

Thanks. Found the issue (I thought modifying mingw header was only necessary clang-cl). Use this script https://pastebin.com/gJTFMdzd

[wonkey_monkey]

Originally Posted by StvG

Thanks. Found the issue (I thought modifying mingw header was only necessary clang-cl). Use this script https://pastebin.com/gJTFMdzd

This gets me further, thanks (and thank you very much for your continued efforts and patience).

I was getting a few instances of this:

Cannot open include file: 'stdalign.h'

I haven't found a definite solution so far, but it seems stdalign.h isn't included/supported in Visual Studio. The file does exist within MSYS2 though - I added the path to --extra-cflags in PKG_CONFIG_PATH, and now I get:

Compiler lacks support for C11 static assertions

Here's ffbuild\config.log: https://pastebin.com/Fk7Feuc2

[StvG]

I have it - https://i.ibb.co/VcyPrtKQ/Untitled.png. Try to install the latest Windows SDK or reinstall the one you have.

[wonkey_monkey]

Originally Posted by StvG

I have it - https://i.ibb.co/VcyPrtKQ/Untitled.png. Try to install the latest Windows SDK or reinstall the one you have.

Yup, i installed the latest SDK and it has the file.

I'll try running the script again tomorrow to see if I still get the same C11 static error.

[StvG]

In case you didn't already you can delete from line 42 to 207 from the script in order to run only the ffmpeg part.

[wonkey_monkey]

Okay, that all seems to have worked!

So now I need to:

4. While you're still in the ucrt64 shell, download lsmash (vimeo) and obuparse and build them, install them in the same location as ffmpeg.

I don't actually know where ffmpeg has installed itself or how to install the other two things there (yes, I really am this clueless).

What are the files that L-SMASH Works will be looking for in "DCMAKE_PREFIX_PATH="path_to_folder_where_are_include/lib_directories" when I get that far?

[qyot27]

Originally Posted by wonkey_monkey

I don't actually know where ffmpeg has installed itself or how to install the other two things there (yes, I really am this clueless).

The value of --prefix is where ffmpeg gets installed when the 'make install' step is performed. If you don't know which directory that is (meaning, you didn't specify it), look inside the script to see what it was setting for that option.

What are the files that L-SMASH Works will be looking for in "DCMAKE_PREFIX_PATH="path_to_folder_where_are_include/lib_directories" when I get that far?

CMAKE_PREFIX_PATH sets a search path for an entire tree of headers, libs, and such, so it depends on what exactly the next steps actually look for. In some cases, it's the pkgconfig files in lib/pkgconfig, in others, the CMake modules in lib/cmake, in still other cases it's just a way of saying: look at this top-level directory and pull any .h and .a files from the include/ and lib/ folders.

[StvG]

Originally Posted by wonkey_monkey

I don't actually know where ffmpeg has installed itself or how to install the other two things there (yes, I really am this clueless).

The script creates folder "deps\x64-Release" next to the script. Search for it.

Originally Posted by wonkey_monkey

What are the files that L-SMASH Works will be looking for in "DCMAKE_PREFIX_PATH="path_to_folder_where_are_include/lib_directories" when I get that far?

FFmpeg include files/libraries, external libs/include files, liblsmash include file/lib, obuparse include file/lib...

[wonkey_monkey]

Okay... for obuparse, since it doesn't have a configure script, I edited the Makefile and just changed the first line to

PREFIX ?= ~/deps/x64-release

Then did make and make install.

For l-smash, I did

./configure --prefix="~/deps/x64-release" --extra-cflags=-I/home/david/deps/x64-Release/include --extra-ldflags=-L/home/david/deps/x64-Release/lib --includedir=~/deps/x64-Release/include --libdir=~/deps/x64-Release/lib

(I'm not sure why I couldn't use ~ as a prefix for the extra cflags and extra ldflags, but it didn't work so I specified the full path)

make/make install put .h and .a files in the x64-Release/include and x64-Release/lib directories.

Next:

cmake -B build_folder -DCMAKE_PREFIX_PATH="C:\msys64\home\David\deps\x64-Release" -DENABLE_VPX=OFF

This worked, although it complained about not finding Git or PkgConfig.

Trying to build the created .sln resulted in four unresolved externals:

__mingw_fprintf
__mingw_sprintf
___chkstk_ms
__mingw_vfprintf

[StvG]

Actually I build obuparse with created VS solution files and manually copy "obuparse.h" and the lib in "deps\x64-Release\relevant_dirs". Also I modified lsmash VS solution files to work correctly with vimeo version and again manually copy "lsmash.h" and "liblsmash.lib" to "deps\x64-Release\relevant_dirs". If you prefer VS solution files, I can share them so you can build them with VS.

[StvG]

Originally Posted by wonkey_monkey

__mingw_fprintf
__mingw_sprintf
___chkstk_ms
__mingw_vfprintf

This suggests that you're linking against ffmpeg/external libs created with GCC and not VS. For what libs are these errors?

Edit: Oh, for obuparse and liblsmash I guess you didn't explicitly used cl instead GCC. You can do in the shell: "export CC=cl".

[qyot27]

It's not necessary to specify --includedir= or --libdir= if you've set --prefix. Those are automatically populated by whatever the prefix is, and you only really want to change them if you deliberately want them somewhere else.

And the extra-{cflags,ldflags} arguments can understand $HOME, e.g., --extra-cflags=-I$HOME/deps/x64-Release/include.

Not finding Git or pkgconf sounds like you haven't added MSys2's /usr/bin to the %PATH% (or alternatively, launched MSys2 from within the VS Command Prompt so the MSys2 environment can see MSVC).

[wonkey_monkey]

Ah, all the errors are for liblsmash! I probably need to change the compiler to cl. Please hold...

[StvG]

Originally Posted by wonkey_monkey

Ah, all the errors are for liblsmash! I probably need to change the compiler to cl. Please hold...

obuparse has hardcoded GCC in the Makefile.

Here are the VS solution files for obuparse and l-smash. Extract them in the root of the relevant folders and build the libs from there.

Edit: Copy "obuparse.h" in the root of l-smash folder.

[StvG]

Originally Posted by qyot27

Not finding Git or pkgconf sounds like you haven't added MSys2's /usr/bin to the %PATH% (or alternatively, launched MSys2 from within the VS Command Prompt so the MSys2 environment can see MSVC).

For L-SMASH-Works - it checks if pkgconfig is available and if not it finds the libs with CMAKE_PREFIX_PATH. This is just warning that pkgconfig is not used. Part of the code.