Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Capturing and Editing Video > Avisynth Development

Reply
 
Thread Tools Search this Thread Display Modes
Old 7th February 2020, 08:14   #1241  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,255
Who ever would test it without a proper filename ... in the DVD Studio I worked for, long ago, we called this class of tests "janitor tests", because a janitor would have no clue which kind of parameter is sensible. Today it would be called "fuzzing", I believe
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Old 7th February 2020, 14:13   #1242  |  Link
HolyWu
Registered User
 
HolyWu's Avatar
 
Join Date: Aug 2006
Location: Taiwan
Posts: 755
https://github.com/HolyWu/L-SMASH-Wo...ks_20200207.7z
  • Update to FFmpeg-20200207-343ccfc.
  • LWLibav: Now only certain frames are marked as interlaced internally when enable repeat control. Although it had no effect on the decoded pictures whether the stream contain repeat flags or not, it did affect the value of frame property _FieldBased in VapourSynth for streams containing repeat flags.
  • LWLibav: Improve the logic of frame rate deduction.
  • LWLibav: Restore the functionality of opening index file as source.
  • AviSynth/LibavSMASH: Fix crash when open an invalid file path.
HolyWu is offline   Reply With Quote
Old 7th February 2020, 17:38   #1243  |  Link
StainlessS
HeartlessS Usurer
 
StainlessS's Avatar
 
Join Date: Dec 2009
Location: Over the rainbow
Posts: 8,466
Thanx HolyWu.
Of course '...' filename should never be used, but Access Violations should also never occur.
[I just checked AviSource("...") just to see if same happened, nope, no A.V. all OK].

Ah LigH, reminiscing about his days as a janitor, such a dreamer
[Fuzzing, also User Friendly, or Idiot Proofing(my favourite)]

EDIT: Fuzzing, automated providing of a mixture of random inputs intention to catch problems, [did not know that, not quite Idiot Proofing]:- https://en.wikipedia.org/wiki/Fuzzing
__________________
I sometimes post sober.
StainlessS@MediaFire ::: AND/OR ::: StainlessS@SendSpace

"Some infinities are bigger than other infinities", but how many of them are infinitely bigger ???

Last edited by StainlessS; 7th February 2020 at 18:22.
StainlessS is offline   Reply With Quote
Old 9th February 2020, 07:40   #1244  |  Link
hello_hello
Registered User
 
Join Date: Mar 2011
Posts: 4,315
Quote:
Originally Posted by HolyWu View Post
https://github.com/HolyWu/L-SMASH-Wo...ks_20200207.7z[*]LWLibav: Restore the functionality of opening index file as source.
Awesome! Thank you!
hello_hello is offline   Reply With Quote
Old 12th February 2020, 14:43   #1245  |  Link
dREV
Registered User
 
dREV's Avatar
 
Join Date: Jan 2019
Location: Antarctica
Posts: 65
Quote:
Originally Posted by HolyWu View Post
https://github.com/HolyWu/L-SMASH-Wo...ks_20200207.7z
  • Update to FFmpeg-20200207-343ccfc.
  • LWLibav: Restore the functionality of opening index file as source.
It's working on MeGUI's One-Click! Testing it out and so far the index file size is waaaay smaller too.

Thanks for including it back.
dREV is offline   Reply With Quote
Old 13th February 2020, 08:32   #1246  |  Link
FranceBB
Broadcast Encoder
 
FranceBB's Avatar
 
Join Date: Nov 2013
Location: Germany
Posts: 1,104
Quote:
Originally Posted by HolyWu View Post
https://github.com/HolyWu/L-SMASH-Wo...ks_20200207.7z
  • Update to FFmpeg-20200207-343ccfc.
  • LWLibav: Now only certain frames are marked as interlaced internally when enable repeat control. Although it had no effect on the decoded pictures whether the stream contain repeat flags or not, it did affect the value of frame property _FieldBased in VapourSynth for streams containing repeat flags.
  • LWLibav: Improve the logic of frame rate deduction.
  • LWLibav: Restore the functionality of opening index file as source.
  • AviSynth/LibavSMASH: Fix crash when open an invalid file path.
Thank you for the new version!
FranceBB is offline   Reply With Quote
Old 13th February 2020, 09:00   #1247  |  Link
Taurus
Registered User
 
Taurus's Avatar
 
Join Date: Mar 2002
Location: Krautland
Posts: 903
@HolyWu
As always:
A big Thank You from me.
Taurus is offline   Reply With Quote
Old 17th February 2020, 11:52   #1248  |  Link
Nico8583
Registered User
 
Join Date: Jan 2010
Location: France
Posts: 761
Hi, the same DLL is used for both AviSynth and VapourSynth ? Thank you.
Nico8583 is offline   Reply With Quote
Old 17th February 2020, 16:53   #1249  |  Link
poisondeathray
Registered User
 
Join Date: Sep 2007
Posts: 4,373
Quote:
Originally Posted by Nico8583 View Post
Hi, the same DLL is used for both AviSynth and VapourSynth ? Thank you.
Yes , same dll
poisondeathray is offline   Reply With Quote
Old 17th February 2020, 19:47   #1250  |  Link
Nico8583
Registered User
 
Join Date: Jan 2010
Location: France
Posts: 761
Quote:
Originally Posted by poisondeathray View Post
Yes , same dll
Thank you, I'll try it !
Nico8583 is offline   Reply With Quote
Old 20th March 2020, 12:31   #1251  |  Link
gpower2
gMKVExtractGUI author
 
gpower2's Avatar
 
Join Date: Aug 2003
Location: Greece / Thessaloniki
Posts: 224
Hey guys!

I run into a problem with LSmashSource by using the LWLibavAudioSource with AviSynth+ 3.5

The resulting audio script has significantly smaller length from the original file. (03:17 instead of 04:07)
The original audio track properties are:

Code:
Audio
ID                                       : 1
Format                                   : WMA
Format version                           : Version 2
Codec ID                                 : 161
Codec ID/Info                            : Windows Media Audio
Description of the codec                 : Windows Media Audio 9.2 -  20 kbps, 32 kHz, mono (A/V) 1-pass CBR
Duration                                 : 4 min 7 s
Bit rate mode                            : Constant
Bit rate                                 : 1 411 kb/s
Channel(s)                               : 1 channel
Sampling rate                            : 32.0 kHz
Bit depth                                : 16 bits
Stream size                              : 41.6 MiB (21%)
Language                                 : English (Great Britain)
After testing different versions, I finally managed to pinpoint the version that broke this particular script:

Code:
commit 2f9d49914f42c2ffe62a9fc20b48de4d3657ffd9 [revision 921]
Author: Yusuke Nakamura <muken.the.vfrmaniac@gmail.com>
Date:   Tue Dec 20 07:21:13 2016 +0900

    lwindex: Consider draining mode for actual audio decoding.
All the versions from r921 till the latest 20200207 have the wrong result.

I also tested with FFMS2 and I had no problem with that.

Could someone take a look?

Thank you very much!
gpower2 is offline   Reply With Quote
Old 21st March 2020, 05:47   #1252  |  Link
HolyWu
Registered User
 
HolyWu's Avatar
 
Join Date: Aug 2006
Location: Taiwan
Posts: 755
Quote:
Originally Posted by gpower2 View Post
The resulting audio script has significantly smaller length from the original file. (03:17 instead of 04:07)
Please provide a sample file, thanks.
HolyWu is offline   Reply With Quote
Old 21st March 2020, 10:29   #1253  |  Link
gpower2
gMKVExtractGUI author
 
gpower2's Avatar
 
Join Date: Aug 2003
Location: Greece / Thessaloniki
Posts: 224
Hi!

Unfortunately I can't share the file here, and you have disabled private messages here.

Is there any other channel I can reach you in order to share the file with you?
gpower2 is offline   Reply With Quote
Old 22nd March 2020, 11:07   #1254  |  Link
HolyWu
Registered User
 
HolyWu's Avatar
 
Join Date: Aug 2006
Location: Taiwan
Posts: 755
https://github.com/HolyWu/L-SMASH-Wo...ks_20200322.7z
  • Update to FFmpeg-20200322-ea46b45.
  • Update to dav1d 0.6.0.
  • AviSynth: Add Meson build system and fix compilation for non-Windows.
  • lwindex: Fix incorrect frame length being written into index file when decoding WMAv2.
HolyWu is offline   Reply With Quote
Old 22nd March 2020, 13:13   #1255  |  Link
gpower2
gMKVExtractGUI author
 
gpower2's Avatar
 
Join Date: Aug 2003
Location: Greece / Thessaloniki
Posts: 224
Quote:
Originally Posted by HolyWu View Post
https://github.com/HolyWu/L-SMASH-Wo...ks_20200322.7z
  • Update to FFmpeg-20200322-ea46b45.
  • Update to dav1d 0.6.0.
  • AviSynth: Add Meson build system and fix compilation for non-Windows.
  • lwindex: Fix incorrect frame length being written into index file when decoding WMAv2.
I confirm that the issue I had with WMAv2 is now fixed!

Thank you so much for the swift resolve HolyWu!
gpower2 is offline   Reply With Quote
Old 25th March 2020, 09:44   #1256  |  Link
Morku
Registered User
 
Join Date: Jul 2012
Posts: 183
Can someone help me, please?
When I load this kind of video (e.g. in VirtualDub2) with l-smash as avs: https://www.dropbox.com/s/nq65dc8ha0ogww7/x.mov?dl=1

using:
Code:
vid = LSMASHVideoSource("x.mov", format="YUV420P10")
aud = LSMASHAudioSource("x.mov")

AudioDub(vid, aud)
the audio is distorted. I am using latest HolyWu build. What I am doing wrong?
Thank you!
Morku is offline   Reply With Quote
Old 25th March 2020, 13:18   #1257  |  Link
LigH
German doom9/Gleitz SuMo
 
LigH's Avatar
 
Join Date: Oct 2001
Location: Germany, rural Altmark
Posts: 6,255
Video: AVDH 1280x720 29.97fps 97223kbps [V: Apple Video Media Handler [eng] (dnxhd dnxhr hqx, yuv422p10le, 1280x720, 97223 kb/s)]
Audio: PCM 48000Hz stereo 1536kbps [A: Apple Sound Media Handler [eng] (pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s)]

Codec ID: sowt

My guess would be that the endianness of the PCM audio was not correctly respected.
__________________

New German Gleitz board
MediaFire: x264 | x265 | VPx | AOM | Xvid
LigH is offline   Reply With Quote
Old 25th March 2020, 23:12   #1258  |  Link
qyot27
...?
 
qyot27's Avatar
 
Join Date: Nov 2005
Location: Florida
Posts: 1,219
Quote:
Originally Posted by HolyWu View Post
  • AviSynth: Add Meson build system and fix compilation for non-Windows.
A couple of things I found when trying to actually build/use LSMASHSource on Ubuntu (although I'm pretty sure I also saw it do these on macOS and FreeBSD; I just haven't tested whether the below fixes it on those systems):

Without an install prefix set, it installs to what I guess is meson's default $libdir, so it gets installed to /usr/local/lib/x86_64-linux-gnu/avisynth/ instead of /usr/local/lib/avisynth. Since AviSynth+ installs a pkg-config file with the relevant information, it can pretty much mirror the meson.build for VapourSynth that uses pkg-config to set those values. Or does that cause some kind of conflict with MSVC builds?

The plugin entry point isn't visible, so AviSynth+ can't load it. Setting -fvisibility=default in CPPFLAGS fixed it, although since meson.build has the gnu_symbol_visibility field, that might be a better place for it, or the exact symbols could be marked visible in the source.
qyot27 is offline   Reply With Quote
Old 26th March 2020, 00:49   #1259  |  Link
sl1pkn07
Pajas Mentales...
 
Join Date: Dec 2004
Location: Spanishtán
Posts: 476
in ubuntu pkg-config see the path /usr/local/lib/pkgconfig by default?

if is no, you need set PKG_CONFIG_LIBDIR or PKG_CONFIG_PATH pounts to "/usr/local/lib/pkgconfig:" for meson can look at it

EDIT: good cat about -fvisibility=default !

edit2: patch

Code:
diff --git a/AviSynth/meson.build b/AviSynth/meson.build
index b20c0d4..97c0255 100644
--- a/AviSynth/meson.build
+++ b/AviSynth/meson.build
@@ -57,6 +57,7 @@ sources = [
 includes = include_directories('../include')
 
 deps = [
+  dependency('avisynth'),
   dependency('liblsmash'),
   dependency('libavcodec', version : '>=58.18.0'),
   dependency('libavformat', version : '>=58.12.0'),
@@ -78,5 +79,5 @@ shared_module('lsmashsource', sources,
   include_directories : includes,
   install : true,
   install_dir : join_paths(get_option('libdir'), 'avisynth'),
-  gnu_symbol_visibility : 'hidden'
+  gnu_symbol_visibility : 'default'
 )
__________________
[AUR] Vapoursynth Stuff
[AUR] Avisynth Stuff

Last edited by sl1pkn07; 26th March 2020 at 01:47.
sl1pkn07 is offline   Reply With Quote
Old 26th March 2020, 02:50   #1260  |  Link
qyot27
...?
 
qyot27's Avatar
 
Join Date: Nov 2005
Location: Florida
Posts: 1,219
I'm logged in under Windows at the moment, but as I do have WSL with Ubuntu 19.10 set up,
Code:
$ pkg-config --variable pc_path pkg-config
/usr/local/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig
So yes, it sees both (and more), with the path meson used at the front. But it appears like the reason it picks that one first for installing liblsmashsource.so is because while FFmpeg and L-SMASH are both detected via pkgconfig, AviSynth is not. As soon as I hook AviSynth up into the pkg-config queries in meson.build¹, it does install to /usr/local/lib/avisynth just like ConvertStacked does.

¹
Code:
diff --git a/AviSynth/meson.build b/AviSynth/meson.build
index b20c0d4..75a92fa 100644
--- a/AviSynth/meson.build
+++ b/AviSynth/meson.build
@@ -56,7 +56,10 @@ sources = [
 
 includes = include_directories('../include')
 
+avisynth_dep = dependency('avisynth').partial_dependency(compile_args : true, includes : true)
+
 deps = [
+  dependency('avisynth'),
   dependency('liblsmash'),
   dependency('libavcodec', version : '>=58.18.0'),
   dependency('libavformat', version : '>=58.12.0'),
@@ -77,6 +80,6 @@ shared_module('lsmashsource', sources,
   dependencies : deps,
   include_directories : includes,
   install : true,
-  install_dir : join_paths(get_option('libdir'), 'avisynth'),
-  gnu_symbol_visibility : 'hidden'
+  install_dir : join_paths(avisynth_dep.get_pkgconfig_variable('libdir'), 'avisynth'),
+  gnu_symbol_visibility : 'default'
 )
Make sure to check the .so with nm -D to make sure that AvisynthPluginInit3 is exported.
qyot27 is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 22:13.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.