FineSharp for VapourSynth

[Selur]

I thing the point is that https://gist.github.com/4re/8676fd350d4b5b223ab9 works and https://gist.github.com/chikuzen/6103665 doesn't
Whether another sharpener (minsharp, AWarpSharp2) might be better suited for whatever sharpening hydra3333 wants to perform shouldn't really matter,..

[Are_]

finesharp 2016.08.21, updated for Vapoursynth R33, ~10% faster for 8bit input, no difference for 16bit.

[Selur]

Thanks.

[hydra3333]

Thank you.

Originally Posted by ~SimpleX~

This script needs an upgrade, it uses avisynth functions instead of VS equivalents. Why do you even need finesharp? It's designed for realtime sharpening of upscaled (720 -> 1080) videos. Not quite suitable for video processing.

Was just comparing it to LSFmod's output, however with the default settings it appears to be a tad brutal for my needs. Oh well. I see some posts spelling is about as fine as my lazy efforts

[hydra3333]

Originally Posted by Are_

fiensharp 2016.08.21, updated for Vapoursynth R33, ~10% faster for 8bit input, no difference for 16bit.

Thanks. R33 hasn't a formal release. Does it work with R32 ?

edit: no it doesn't.

T:\HDTV\WDTVlive\MP4-VS\1>"C:\SOFTWARE\Vapoursynth\VSPipe.exe" "T:\HDTV\WDTVlive\MP4-VS\1\test.mpg.2016.08.22.01.28.50.60.vpy" - --y4m   | "C:\SOFTWARE\ffmpeg\0-homebuilt-x64\x264-mp4.exe" - --stdin y4m --thread-input --frames 45810 --profile high --level 4.1 --preset slow --interlaced --tff --no-cabac --crf 14 --sar 64:45 --colormatrix bt470bg -o "s:\HDTV\WDTVlive\MP4-VS\1\test-temp.2016.08.22.01.28.50.60.h264"
Script evaluation failed:
Python exception: VapourSynth version should be 33 or greater.
Traceback (most recent call last):
  File "src\cython\vapoursynth.pyx", line 1491, in vapoursynth.vpy_evaluateScript (src\cython\vapoursynth.c:26897)
  File "T:\HDTV\WDTVlive\MP4-VS\1\test.mpg.2016.08.22.01.28.50.60.vpy", line 469, in <module>
    main()
  File "T:\HDTV\WDTVlive\MP4-VS\1\test.mpg.2016.08.22.01.28.50.60.vpy", line 154, in main
    video = finesharp.sharpen(video,mode=1,sstr=1.0)
  File "C:\SOFTWARE\Vapoursynth\finesharp.py", line 109, in sharpen
    raise EnvironmentError('VapourSynth version should be 33 or greater.')
OSError: VapourSynth version should be 33 or greater.

[Are_]

This version of finesharp would be too slow on vapoursynth 32

[hydra3333]

OK, am trying x64 VS R33 (it released today)

[Selur]

Haven't used finesharp for a while, but calling:

# Imports
import os
import sys
import vapoursynth as vs
core = vs.get_core()
# Import scripts folder
scriptPath = 'G:/Hybrid/vsscripts'
sys.path.append(os.path.abspath(scriptPath))
# Loading Plugins
core.std.LoadPlugin(path="G:/Hybrid/vsfilters/Support/fmtconv.dll")
core.avs.LoadPlugin(path="G:/Hybrid/vsfilters/SourceFilter/DGDecNV/DGDecodeNV.dll")
# Import scripts
import finesharp as finesharp
# Loading H:\to convert\test.mkv using DGSource
clip = core.avs.DGSource("H:/Temp/mkv_7ddb2a359f7f3ecc066d816f3985a1f6_14604.dgi")
# sharpening using FineSharp
clip = finesharp.sharpen(clip=clip, mode=3)

# Output
clip.set_output()

(using VS R40)
I get:

Failed to evaluate the script:
Python exception: float() argument must be a string or a number, not 'vapoursynth.VideoNode'

Traceback (most recent call last):
  File "src\cython\vapoursynth.pyx", line 1830, in vapoursynth.vpy_evaluateScript (src\cython\vapoursynth.c:36860)
  File "H:\Temp\tempPreviewVapoursynthFile19_09_28_896.vpy", line 17, in <module>
    clip = finesharp.sharpen(clip=clip, mode=3)
  File "G:\Hybrid\vsscripts\finesharp.py", line 155, in sharpen
    c2 = core.std.Median(clip).std.Convolution(clip, matrix=[1, 2, 1, 2, 4, 2, 1, 2, 1])
  File "src\cython\vapoursynth.pyx", line 1702, in vapoursynth.Function.__call__ (src\cython\vapoursynth.c:34634)
  File "src\cython\vapoursynth.pyx", line 530, in vapoursynth.typedDictToMap (src\cython\vapoursynth.c:12921)
TypeError: float() argument must be a string or a number, not 'vapoursynth.VideoNode'

The finesharp script I use is Rev 2016-08-21.
-> tested a bit more and when I'm not using 'mode=..' it works, but using mode = 2 or mode = 3 causes the crash. Did I miss something or did this never work?

Cu Selur

[Are_]

Yeah, brainfart, try it again.

[Selur]

Found it, changing line 155, from

        c2 = core.std.Median(clip).std.Convolution(clip, matrix=[1, 2, 1, 2, 4, 2, 1, 2, 1])

to

        c2 = core.std.Median(clip).std.Convolution(matrix=[1, 2, 1, 2, 4, 2, 1, 2, 1])

fixes the issue.
Thanks for fixing.

Cu Selur

[Are_]

I meant I brainfarted while coding that part and already fixed it in the gist, sorry for the misunderstanding.

[poisondeathray]

I get error with some sstr values like 0.1, 0.2

But 0.25, or 0.3, or 1, or 1.2 etc... will work

File "PATH\finesharp.py", line 133, in sharpen
cstr = float(cstr)
TypeError: can't convert complex to float

Using this version 2019-10-10
https://gist.github.com/4re/8676fd350d4b5b223ab9

clip = core.std.BlankClip(width=640, height=480, format=vs.YUV420P8, fpsnum=24, fpsden=1, length=240, color=[128, 128, 128])
fs = finesharp.sharpen(clip, sstr=0.2)

[Are_]

Avisynth version doesn't return an error there? (No windows right here so I can't check it).

I don't know anything about math, but at some point in the code cstr becomes a complex number, and that is a problem for the rest of the script.
I think the proper solution is to put a check somewhere to tell you not to go so low with sstr if cstr is not defined.

[poisondeathray]

Originally Posted by Are_

Avisynth version doesn't return an error there? (No windows right here so I can't check it).

I don't know anything about math, but at some point in the code cstr becomes a complex number, and that is a problem for the rest of the script.
I think the proper solution is to put a check somewhere to tell you not to go so low with sstr if cstr is not defined.

No error with avs version when using sstr=0.2 or 0.1

[Are_]

It should be "fixed" now.
All vapoursynth finesharp scripts had a typo, truth is avisinth also throws an error when sstr goes too low and you use a mode lower than 0.

[poisondeathray]

Originally Posted by Are_

It should be "fixed" now.
All vapoursynth finesharp scripts had a typo, truth is avisinth also throws an error when sstr goes too low and you use a mode lower than 0.

Thanks working now