Doom9's Forum - View Single Post - GradCurve VapourSynth plugin port of virtualdub Gradation Curves plugin

16th December 2016, 17:45

Code:

LUTTable(LUTTable &&obj) {
	RGBToLab = obj.RGBToLab;
	LabToRGB = obj.LabToRGB;
	obj.RGBToLab = nullptr;
	obj.LabToRGB = nullptr;
}

Code:

auto &operator=(LUTTable &&obj) {
	if (this != &obj) {
		RGBToLab = obj.RGBToLab;
		LabToRGB = obj.LabToRGB;
		obj.RGBToLab = nullptr;
		obj.LabToRGB = nullptr;
	}
	return *this;
}

So a C idiom is bad coding style, but setting data within an object to null within a copy constructor is good code? lolwut? A copy constructor is only meant to clone an object, it's not meant to modify the original object. Adding side-effects to a copy constructor is horrendous.

16th December 2016, 17:45	#28 \| Link
captaiŋadamo Guest Posts: n/a	Code: LUTTable(LUTTable &&obj) { RGBToLab = obj.RGBToLab; LabToRGB = obj.LabToRGB; obj.RGBToLab = nullptr; obj.LabToRGB = nullptr; } Code: auto &operator=(LUTTable &&obj) { if (this != &obj) { RGBToLab = obj.RGBToLab; LabToRGB = obj.LabToRGB; obj.RGBToLab = nullptr; obj.LabToRGB = nullptr; } return *this; } So a C idiom is bad coding style, but setting data within an object to null within a copy constructor is good code? lolwut? A copy constructor is only meant to clone an object, it's not meant to modify the original object. Adding side-effects to a copy constructor is horrendous.