View Single Post
Old 31st May 2022, 23:00   #127  |  Link
DTL
Registered User
 
Join Date: Jul 2018
Posts: 1,070
"What do you want me to test with the test build exactly?"

If it not crash at your system with your 16bit (>8bit) clips (frame size, colour format, etc).

"AVX2
time=15.412s
SSE2
time=40.264s"

Oh - it is so great difference. The non-optimized SSE2 really very slow. I think it will be only a bit slower because it uses SSE2 intrinsics internally. I hope not many users will run nowdays at SSE2 only CPUs with >8bits MAnalyse. To found what is wrong with 'normally optimized' SSE2 builds may take unknown time.

"Unfortunately thSAD2=0.9*thSAD is not a valid parameter. "

I think more comfortable to user to enter short 'far end thSAD multiplier' as script param and it can be applied to both thSAD2 and thSADC2 equally. Something like

Code:
function EZdenoise(clip Input, int "thSAD", float "far_thSAD_mul", int "TR", int "thSADC", int "BLKSize", int "Overlap", int "Pel", bool "Chroma", bool "HBD")
{
thSAD = default(thSAD, 150)
thSADC = default(thSADC, thSAD)
far_thSAD_mul = default(far_thSAD_mul, 0.9)
thSAD2 = Int(thSAD * far_thSAD_mul)
thSADC2 = Int(thSADC * far_thSAD_mul)
In real use it is easy to call like EZdenoise(200, 0.8, 10). Not set 4 params of th-s in some fixed ratio between values every time when need to adjust 'base thSAD'.

Name far_thSAD_mul is not short and nice - may be something shorter possible.

Also HBD is not clear about 'internal conversion' of 8bit input to 16bit output. May be better name 'toHBD'.

Last edited by DTL; 31st May 2022 at 23:05.
DTL is online now   Reply With Quote