Quote:
Originally Posted by Trahald
All... Problem is I dont want x264 thinking 'i only have 24 frames to work with.'
|
What do you mean? x264 only cares about the number of frames it has to "work with" in two places:
1. B-frame decision, in which this doesn't help, since you're still forced to end the GOP, even if it's on an open GOP.
2. Scenecut decision, in which what you are doing is outright lying to the scenecut algorithm about where the last keyframe actually was. I will not accept a patch that does this for any reason whatsoever. If you think that the scenecut algorithm is suboptimal, fix it separately.
Quote:
Originally Posted by Trahald
in either scenario, max_keyint_i is done away with and there is only max key int
in scenarion 1. its a cosmetic removal as im just hardcoding the larger value.
|
Why have a larger value at all if you're not going to allow it to be adjusted? Why do we have to force IDR frames every once in a while?
Quote:
Originally Posted by Trahald
scenario 2. here again, there is only one max_keyint . but here we remove any scenecut decisioning that relies on the distance between keyintervals, whatever that interval is. scenecuts in streams at max_keyint 24 would be in the same spots as streams with max_keyint 50, etc.
|
This is a bad idea and will reduce encoding efficiency.
What is wrong with my original suggestion of just doing it the sensible way--leaving scenecut as it is, and treating all open GOPs as keyframes? Why do we have to munge the scenecut algorithm like this, independent of what your patch is actually doing?