x284 crashed when ICCompressEnd is called

[Kyle_Katarn]

Using x264 Core 34 svn 287
Crash type : Systematic.

Abstract : After compressing frames (any count) using ICCompress, ICCompressEnd generates an exception.

[Kyle_Katarn]

Up...

[MeteorRain]

seems you should explain more things....

[Kyle_Katarn]

Ok, here comes the details.

I create my stream, set the format...

Then I call ICCompressBegin, ICCompress to compress my videoframes and when everything is compress and written into my stream, i call ICCompressEnd and x264 raises an Invalid Operation exception.

Do you need more details ?

[Sirber]

Does it work in VDub? ;)

[Kyle_Katarn]

The exception is only raised at design time (debug version in Delphi) - at least on my project.

"Ebola" (I don't know his nick on this board) who made some patches for x264 told me that it was a known issue....

[ian8210]

I got into the same situation today. I wrote a programme using ICCompressEnd to terminate the compression and it works well, but when I tried to make it into a .dll so that my programme can call, it crashes~~~ . I don't know why, I don't think there r any difference between these two.
And BTW, who's Ebloa?

[Kyle_Katarn]

Nice to see that i'm not the only one ;-)

I can't remember Ebola's nickname on Doom9 but he from the x264 Dev team (or at least he told me he wrote some patches)

[Sharktooth]

It's my nickname on MSN and i told you im not on the dev team.
However i've heard that problem from other devs too... it's weird...
Just a thought but... do you all (the ones who have that problem) use delphi?

[Kyle_Katarn]

Hi Sharktooth !

I use Delphi 7.

[ian8210]

No, actually , I use C++. But this situation doesn't always happen. I wrote a programm with x264 as the encoder, and it serves well, but when it comes to the .dll , which I created based on the same programme code, crashed when ICCompressEnd is called

Hi, Sharktooth,my MSN:ian8210@hotmail.com.

[Kyle_Katarn]

up...

[Sharktooth]

Maybe this will be usefull: http://forum.doom9.org/showthread.php?t=98763

[Kyle_Katarn]

Not really since me problem only occurs at encoding time (no matter FFDShow isinstalled or not) and only with ICCompressEnd, and only with x264

Do you have access to some debug version of x264 that can help us troubleshooting this case ?

[zombi55]

I got this problem since awhile now but nobody answer me as if I was silly. Anyhow, you can see a kinda answer there : http://forum.doom9.org/showthread.php?t=97069

yours
Zombi55

[Kyle_Katarn]

I hope that someone from the dev team will get the message ;-)

[Kyle_Katarn]

up...

[Kyle_Katarn]

still occurs with v291

[Kyle_Katarn]

akupenguin has shown me a patch that would fix this issue... would it be possible to see it integrated in the next build ?

[Sharktooth]

Sure, post a link where i can download the patch. I'll make a test build.

[Kyle_Katarn]

I'll try to ask akupenguin for the link. Thank you !

[Kyle_Katarn]

Index: vfw/codec.c
===================================================================
--- vfw/codec.c (revision 291)
+++ vfw/codec.c (working copy)
@@ -348,6 +348,8 @@
}

free( codec->hCons );
+ codec->hCons = NULL;
+
return ICERR_OK;
}

[Sharktooth]

on my way.

[Kyle_Katarn]

Thank you !

[Sharktooth]

http://www.webalice.it/f.corriga/x264/x264test.7z

[Kyle_Katarn]

Thank you very much .... Nice try but bug still occurs !

If you want to "see" it : ftp://ftp2.kcsoftwares.com/kcsoftwa/beta/P2FV2.zip

[Kyle_Katarn]

What about replacing


free( codec->hCons );
codec->hCons = NULL;


by


if(codec->hCons!=NULL)
{
free( codec->hCons );
codec->hCons = NULL;
}


?

[Sharktooth]

done: http://www.webalice.it/f.corriga/x264/x264test2.7z

[Kyle_Katarn]

Thank you, i'll test this as soon as i'm back to the office

[Kyle_Katarn]

Still crashes at the same point... i'm desperate ;)

[zombi55]

I've been testing the two releases 292 and there is no more "crash" of the codec at the end of the pass, but the codec shows an "Error console" windows that doesn't respond. This window doesn't botter the encoding wich follows with the next pass. The "not responding" window is killed at the end of the encoding process.

Cordially yours
zombi55

Nb : I hope this correction will proceed in all new versions.

[Kyle_Katarn]

Are these changes in 293 ?

[Sharktooth]

No, coz it doesnt fix the issue. However if you need a build with that patch i can always compile it.

[Kyle_Katarn]

I'll give a look to x264 source code and try to find another possible cause for this issue... thanks !

[Sharktooth]

new builds are going to be patched with this: http://forum.doom9.org/showpost.php?p=710250&postcount=22

[Kyle_Katarn]

Ok thank you, i'll try next build.

[ian8210]

I wonder if this problem still occurs on the current version ?

[Kyle_Katarn]

It does.