IfoEdit Bug: VTSM_VOBS Video attributes

[CMatt]

Hi,
i found a bug in IfoEdit (i hope that the ifoedit author also reads it =) )

There is somthing wrong with the second byte of the Video attributes structure.

The bytes looks like:
Bit
0 Camera Mode
1 reserved
2 Letterboxed
3-5 Source resolution
6 Line21-1
7 Line21-2

The Bug:
Enter 0x02 as value and IfoEdit shows the Letterbox flag is true, but that's wrong, bit1 isn't the Letterboxed flag. Same for the source resolution. Enter 0x10 as second byte and IfoEdit shows you 720x576 (if it's pal) as resolution ==> it's wrong. It's 352x576.

[2COOL]

Originally posted by CMatt
i found a bug in IfoEdit We know. ;) http://forum.doom9.org/showthread.php?s=&threadid=82824

[Derrow]

(i hope that the ifoedit author also reads it =)

I've read it now :D

Will fix it. Thanx for the info :)

[2COOL]

Originally posted by Derrow
I've read it now :D

Will fix it. Thanx for the info :) Fix it? Sounds like we'll be seeing another version in the future? Yippie!!!:D:D

So what else is new/fix/enhanced? You can't just put out a new version on just one fix?

[Derrow]

Originally posted by CMatt

The Bug:
Enter 0x02 as value and IfoEdit shows the Letterbox flag is true, but that's wrong, bit1 isn't the Letterboxed flag. Same for the source resolution. Enter 0x10 as second byte and IfoEdit shows you 720x576 (if it's pal) as resolution ==> it's wrong. It's 352x576.

Indeed.
Thanx alot for the report.
The next release will have the bug fixed.

[Derrow]

Originally posted by 2COOL
Fix it? Sounds like we'll be seeing another version in the future? Yippie!!!:D:D

So what else is new/fix/enhanced? You can't just put out a new version on just one fix?

Why not? It's a least a new release :D

[2COOL]

Originally posted by Derrow
Why not? It's a least a new release :D I'm sure mpucoder has a list for you but a new release is progress! ;) At least we know you're still there for us. :)

[Derrow]

Yep, I'm still there :)

If somebody else has a list with bugs, then please let me know about it.

[2COOL]

I wish I had kept a living list. Since you're a moderator here, maybe you can make a sticky on IfoEdit bug reporting?

I'm curious. You seem to come and go for a long period of time. Are you going to be more active with us or more inactive? A lot of us members are always hanging to know what's going on with you and IfoEdit's development.

[Derrow]

Originally posted by 2COOL
I'm curious. You seem to come and go for a long period of time. Are you going to be more active with us or more inactive? A lot of us members are always hanging to know what's going on with you and IfoEdit's development.

Yep, I have a lot of things going on at the same time :p
It's hard to find some free time :rolleyes:

But IfoEdit needs an update now because of the new copy protection for DVDs. It uses to crash on some IFO files, and that need to be fixed :)

[Msc_Alex]

Great to see you back, make sure you have a donation button on your next release;)

[Video Dude]

Originally posted by Derrow
If somebody else has a list with bugs, then please let me know about it. Thanks for all the work and tools you have contributed Derrow.

Perhaps I can help by compiling a list of potential bugs that I found searching the forums.



Reported audio track stripping bug.
http://forum.doom9.org/showthread.php?s=&threadid=72291#post455604


Another commonly reported problem (or wish) is RFF and NTSC.
http://forum.doom9.org/showthread.php?s=&threadid=64060


PgcEdit reports the following IfoEdit error:
http://forum.doom9.org/showthread.php?s=&threadid=82153#post543298

[r0lZ]

Hi Derrow :)

Also, it is not possible to insert a command after command #9. (This is why I started to write PgcEdit ;))

And there are often bugs/crashes when pasting a command in the hex dialog.

[Derrow]

Originally posted by r0lZ
Also, it is not possible to insert a command after command #9. (This is why I started to write PgcEdit ;))


Oh really ?
I never noticed. Will fix it right now :D
Thanx for the report r0lZ!

[Derrow]

Originally posted by Video Dude
Perhaps I can help by compiling a list of potential bugs that I found searching the forums.


Thanx Video Dude!
I'll have a look through the list :p

[Derrow]

Originally posted by Msc_Alex
make sure you have a donation button on your next release;)

Excellent idea!
Thanx for that hint :p

[MvB]

Hi Derrow,

it's great to see around here again :) Your tool is absolutely nice.

Just wanted to add another 'what i think is a bug':

When you're authoring NTSC DVDs, the resulting discs won't play on a lot of standalones. You can jump to the next chapter, it plays for about half a second, then the picture freezes and nothing can be done anymore than powering off the standalone. Got this behaviour in 2 out of 3 standalones.
If I let InstantCopy 7 run over the newly authored dvd (without compression) the resulting dvd will play on every standalone.

So i conclude, something must be wrong at least with NTSC-DVD authoring.

Can't be more specific because i don't know enough to recognise what's going wrong.

MvB

[r0lZ]

I have noticed a similar problem after joining different segments of PAL video. The standalone hangs when going from one part to the next one. Note that I have the same problem if I join the segments with some other programs (like Womble MPEG VCR).

Also, it is not possible to insert a command after command #9.BTW, forget about that. I can't reproduce this bug now. So, I suppose it was in an old release... :confused:

[jsoto]

Hi Derrow,
You are back again!! Fantastic!.
First of all, thanks for your tools and your support. IMHO, IFOEdit is "THE TOOL" for everyone who works with DVDs.

And I'd like to report a problem (not sure if it is supported) in authoring mode. Using graphics subs (BOV ones or just graphic like Men In Black ones) you always get a buffer under-run error.

jsoto

[D3s7]

Welcome Back Derrow...

always nice to see people coming back to life

One on the top of my list is the "have to delete the .ini file occationally" issue...

That and maybe an option to shutoff showing the found decoders when clicking "dvd play"

[jippiejajee]

Hi Derrow,
one more you may have a look into, hope you have the time to read it all

Below my analysis of list index out of bounds (0) problem encountered after using delete playback button in ifoedit when stripping the video_ts.ifo file.

When loading the stripped files in IC7 I noticed that IC7 gave the LIOOB (0) error message just after starting analyzing the title sets. so I guessed the video_ts.ifo was the problem. Then I did something bold, I just copied the original video_ts.ifo and bup file to the directory with the stripped ifo's and vob's and fired up IC7 and it did not complain on LIOOB (0) and completed its work without problem. So indeed the stripped video_ts.ifo was the problem. As I could not found any error in the stripped ifo, I loaded the stripped and and original video_ts.ifo in wincommander and compared the content of the files. It showed differences but those were exactly on places were ifoedit made its modification and these were in line with what I stripped and wanted to change, and as such still no reasons found to get an LIOOB error. Hmmm... what next I wondered.
Then I noticed that as well original video_ts.ifo as stripped one had exactly same size althoug some stripping was done.
What I did during the stripping this ifo was simply pressing deleted playback to get rid of some logo's played in during starting up the DVD in the Menu language Unit section of this ifo, just exactly as described by Derrow in his guide to remove annoying warnings. And iIFOEDIT did it is job it changed the program and cells numbers for that menu in "0" and on PC playback the logo was no longer shown. In comparing the original and stripped video_ts.ifo with wincommander it showed indeed only changes on these places where you would expect them to found. So what is overlooked here ? After detailed study with hex editor of IFOEDIT I finnally found the problem which is that IFOEDIt forgets to update the coresponding PGC Program Map, Cell Playback Information Table and Cell Position Information table. In fact it leaves them untouched. Funny is that the content is no longer shown in the standard view of IFOEDIT after the strip but it is still there as it was in the original ifo containing the old program and cell numbers which are now out of bounds. You can see them with the hex editor of IFOEDIT. IC7 apparently reads these (hidden) map and tables and find these original numbers of programs and cells which are now of course out of bounds. Typically is that in the stripped ifo IFOEDIT still shows the names of PGC Program Map, Cell Playback Information Table and Cell Position Information table just below PCG command table but with no content information anymore although it is still there in the ifo. remark: in case a menu contains originally no programs and cells IFOEDIT reports that there is NO PGC program map, NO cell playback information table and NO cell position table. In case you delete playback by purpose the text is slightly different, the word NO is missing, and no content information is displayed anymore.
To solve my list index out of bounds (0) problem I just edited, with a hex editor this map and tables to correct values (program number and cells to zero. Hell of job and easy to make mistake. In standard view IFOEDIT this editing is no longer possible as content is no longer shown. After doing this loaded in IC7 and did not have a LIOOB problem anymore.

So the bottom line in this case was that IFOEDIT when deleting playback does not update the PGC Program Map, Cell Playback Information Table and Cell Position Information table, it just hides it and leaves it as it is. result a LIOOB error when loaded in IC7. To my opinion a bug or at least an improvemt opportunity. Maybe it is no problem for playback of the titleset on PC or standalone DVD player but IC7 has a problem with it, it simple stops working with a LIOOB error.

I strongly believe the same happens when you completely remove a PCG from an IFO with IFOEDIT. Life could become easier if we could find an easy fix for this.

The question is now how to make IFOEDIT to updating the PGC Program Map, Cell Playback Information Table and Cell Position Information table, or is there another program with could do this.
Another lesson learned, do not use deleteplayback button in IFOEDIT as you will encounter a LIOOB (0) error when loading your ifo's in IC7.

The reproduce the problem just pick a video_ts.ifo and delete some menu playback with the delete playback button of IFOEDIT.


Cheers, Jippie

[jsoto]

Hi jippiejajee,
I'm doing exactly the same than IFOEDIT in VobBlanker's delete playback feature. so it must show the same problem. But I do not understand the paragragh where you describe how to fix the problem.

To solve my list index out of bounds (0) problem I just edited, with a hex editor this map and tables to correct values (program number and cells to zero. Hell of job and easy to make mistake. In standard view IFOEDIT this editing is no longer possible as content is no longer shown. After doing this loaded in IC7 and did not have a LIOOB problem anymore.

Program and cell numbers are cleared by IFOEdit :confused:

So, taking into account the rest of the post, seems you fix the problem changing to zero the program map, playback and position offsets, and keeping the rest of the data as it is. In summary, clear to zero the following double byte words:

00E6 offset within PGC to program map
00E8 offset within PGC to cell playback information table
00EA offset within PGC to cell position information table

Could you confirm this?

jsoto

EDIT: Sorry, I had included command table ofsset, and, obviously, his table should be kept as it is.

[jippiejajee]

@jsoto

yes program and cells numbers are set by IFOedit to zero in video manager information table but not in the corresponding PGC program table map in the video manager menu PGCI unit table.
Thats left as it is and causing the LIOOB error. As I desribe unfortunately you can not see the content of this table anymore in IFOedit after pressing delete playback, but it is still there, just not shown anymore. You can still see the content using the IFOedit hex editor and edit the program map on the places where program, and cell numbers are present, only those bytes must be set to zero. Same hold for cell playback and position tables.
As I said hell of a job and easy to make a mistake.
Found that it was easier not to use the delete playback button anymore ;)

[jsoto]

@jippiejajee

I still do not understand well your problem.

Please do the following in IFOEdit:
1.- Delete playback.
2.- Go to you Menu PGC under VMGM_PGCI_UT or VTSM_PGCI_UT
3.- Go to the address e6 "PGC program map start byte"
4.- doubleclick and change to zero
5.- Repeat step 4 with address e8 and ea
6.- Refresh your view in IFOedit

Now you will see the words "NO" in the pgc program, playback and position tables.

Does this new DVD have any problem in IC7? Please check, I do not have access to IC7...

As you can see, there is no need of Hex editing....

jsoto

[jippiejajee]

jsoto

I follow your logic and will try your suggestion and see what happens. But with your proposal the false info in the program map table remains present but maybe with the setting as you propose IC7 will no longer bother and do its job, as said I will give it a try.

[jippiejajee]

@jsoto

I tried it today and your suggestion works !
I just picked a DVD and used the deleted playback button in IFOedit to butcher an annoying trailer from a menu PGC.
The stripped file did no show the program map table anymore but as I described earlier the word "no" was missing.
When loading this set into IC7 it gave as expected the LIOOB (0) error. Then I followed your instruction to set the e6, e8 and ea byte to zero instead the painfull hex editing of the program table and, as you described, the word "no" now appeared in front of the program map table when loading the edited file again in IFOedit.
When loading this file set in IC7 it proceeded without giving the LIOOB (0) error.
Apperently now IC7 thinks that there is no program table and does not read it (note: in reality it is still there with the wrong info).
Would be nice if IFOedit would set these bytes to zero by itself when using the playback button. But maybe it is dependent on which PGC you want to delete.

[dave2003]

Originally posted by jsoto
@jippiejajee

Please do the following in IFOEdit:
1.- Delete playback.
2.- Go to you Menu PGC under VMGM_PGCI_UT or VTSM_PGCI_UT
3.- Go to the address e6 "PGC program map start byte"
4.- doubleclick and change to zero
5.- Repeat step 4 with address e8 and ea
6.- Refresh your view in IFOedit

Now you will see the words "NO" in the pgc program, playback and position tables.

Does this new DVD have any problem in IC7? Please check, I do not have access to IC7...

As you can see, there is no need of Hex editing....

jsoto

I have only just begun dabbling with the various DVD-related tools, IFOEdit more than any other tool thus far. Thank you for your post. You've probably saved me from some really bad headaches! I'm sure glad I encountered this thread. As an experiment, I used the "delete playback" function on some menu entries in a couple of IFOs I was currently working with (after backing them up, of course), and I did indeed observe that the PGC program map and cell table start bytes had not changed to reflected the deleted menu item. This is definitely an item to keep for future reference. Perhaps the moderator(s) would make your post "sticky," at least until a new version of IFOEdit that addresses this issue is released.

Dave

[r0lZ]

Just found this bug in IfoEdit:

The PGC Still Time and the PG Playback Mode values are inverted: Still time must be at offset 0xA3 and PB Mode at 0xA2 in the PGC header.

[Derrow]

Thanx a lot r0lZ!

Will be fixed in next release :p

[r0lZ]

Oh, also, there is a problem in DVD Play with the display of the GPRM values: last digit of the number is not displayed if value >= 10000.

Similar problem for chapter numbers >= 10.

And I remember a problem with the cell commands numbers (and maybe also with the cell type flags) being lost when doing a strip, or a DVD split. I don't remember exactly.

[2COOL]

@Derrow

Can you do something about automatically refreshing the window whenever we do any changes? I hate always to manually refresh the screen and scroll all the way down to see my changes. :(

[blutach]

Hi Derrow,

I usually never ask for new features - esp in freeware. However, it does appear you are doing a new version, so I thought I might make this suggestion.

I think that it would be great, if, after doing a mock strip (or any strip for that matter), for all the new IFOs to be loaded up in IfoEdit immediately after the strip has concluded.

Don't worry if this is too difficut to implement - it's not that much manual work to press Open. Thanks

Regards

[Video Dude]

Derrow might need a vacation after all of these fixes and improvements. ;)

Great work Derrow. I'm waiting excitingly by my computer screen for the next release.

[vav]

Hi Derrow,
something very small:
the Hebrew identification symbol should be 'iw' and not 'he'.
correct dec value is 26999.
ifoedit puts 'he' when you select a hebrew subtitle or audio track, which after compilation is shown on the player as 'unknown'...

if it's not too much of a trouble...

thanks in advance,

[Derrow]

Originally posted by 2COOL
@Derrow

Can you do something about automatically refreshing the window whenever we do any changes? I hate always to manually refresh the screen and scroll all the way down to see my changes. :(

Yep, that sucks.
I'll fix that :D

[Derrow]

Originally posted by vav
Hi Derrow,
something very small:
the Hebrew identification symbol should be 'iw' and not 'he'.
correct dec value is 26999.
ifoedit puts 'he' when you select a hebrew subtitle or audio track, which after compilation is shown on the player as 'unknown'...


IfoEdit already has both versions 'iw' and 'he'.
You just need to select the second occurance of 'Hebrew' instead of the first. ;)
It's just hard to find the second, because the language-list is not sorted alphabetically.

But thanx for the tip. I'll try to sort the language list tho.

[Derrow]

Originally posted by D3s7
Welcome Back Derrow...

That and maybe an option to shutoff showing the found decoders when clicking "dvd play"

Very good point. It pisses me off too :)

[Derrow]

Originally posted by MvB
Hi Derrow,
Just wanted to add another 'what i think is a bug':

When you're authoring NTSC DVDs, the resulting discs won't play on a lot of standalones. You can jump to the next chapter, it plays for about half a second, then the picture freezes and nothing can be done anymore than powering off the standalone. Got this behaviour in 2 out of 3 standalones.
If I let InstantCopy 7 run over the newly authored dvd (without compression) the resulting dvd will play on every standalone.

So i conclude, something must be wrong at least with NTSC-DVD authoring.

Can't be more specific because i don't know enough to recognise what's going wrong.

MvB

Did anybody track down this problem, and can tell me what bug it's causing this prob with NTSC-movies?

[2COOL]

Originally posted by Derrow
Did anybody track down this problem, and can tell me what bug it's causing this prob with NTSC-movies? Nic, ReJig's author, should be able to tell you that since ReJig can do NTSC. There should be a post on his finding somewhere.

[Video Dude]

Originally posted by Derrow
Did anybody track down this problem, and can tell me what bug it's causing this prob with NTSC-movies? This thread is about the NTSC problem and gives a possible cause. It also suggests why ReJig works with NTSC.
http://forum.doom9.org/showthread.php?s=&threadid=64060

I'm not sure if that could provide any help in fixing the bug.

[vav]

Originally posted by Derrow
IfoEdit already has both versions 'iw' and 'he'.
You just need to select the second occurance of 'Hebrew' instead of the first. ;)
It's just hard to find the second, because the language-list is not sorted alphabetically.]

:o you mean it was there all time? gosh, embarrassed to my teeth.


[B]But thanx for the tip. I'll try to sort the language list tho.

muchas muchas gracias (and indeed - welcome back :D )

[Derrow]

Originally posted by Video Dude
This thread is about the NTSC problem and gives a possible cause. It also suggests why ReJig works with NTSC.
http://forum.doom9.org/showthread.php?s=&threadid=64060

I'm not sure if that could provide any help in fixing the bug.

It helped a lot.
Thanx very much Video Dude ;)
I've got the problem solved now. NTSC authoring problem will be fixed in next release :p

[Video Dude]

Thats great news.

On behalf of all those in NTSC land, a big thank you.

[2COOL]

@Derrow

Can you enhance your Create IFO macro, "Create a new PGC for each new VOBid", so that it would create new Titles per created PGC instead of keeping them all at Title 1?

Also, why is that everytime I create new IFOs, I have to manually Get VTS Sectors? Shouldn't IfoEdit correct the sectors during the process?

Update: The Titleset start sectors in VMGM_PTT_SRPT are not right.

[Derrow]

Good idea about the title numbering.
I'll keep that in mind.

[jsoto]

Can I do one request more?

I'll really appreciate IFOEdit CLI support for authoring. I've automated the process with an autoit script, but it will be much better to have the "native" option, and why not, running in background (no dialogs in the screen).

jsoto

[2COOL]

I want to add another PGC Title in PTT_SRPTI but IfoEdit crashes most of the time. I'm referring to "Number of Title Unit Search Pointers (TTUs) in the VTSTI"

[2COOL]

@Derrow

(SetSTN) Set Subpicture Stream: 30(On) should really say “Off”. ;)

[51 00 00 00 be 00 00 00]

You might want to double check for other subpicture settings. On > Off and Off > On.

[r0lZ]

Well, seems the bug list is increasing, so here are some more (GUI related).

- Pasting in the hex field of a command crash sometimes.

- When you close the preview window with the standard Windows close button, strange things happends: the main window is not reopened, and the next time you launch IfoEdit, the main window is left iconified.

- When you quit IfoEdit with his windows maximized, if you launch it again with a filename as CLI argument, IfoEdit don't load the file. Strange! :confused:

Also, could you add an option to remove the "No valid DVD volume could be located..." dialog when launching the preview?

[2COOL]

@Derrow

Can't confirm right now if this (http://forum.doom9.org/showthread.php?threadid=33812) was fixed in 0.96 but if it is, you can get rid of this sticky.

Wishful thinking: I wish our *_VOBU_ADMAPs had two extra columns, VOB ID and Cell ID. Of course, you would have to need the VOBs in question to parse that. The reason for my insanity is that in VobEdit, we have to scroll alot and then check each for VOB and Cell ID to find what we need to edit. BTW, are you EVER going to update VobEdit too?

@jsoto

Maybe this could be another small tool for you to come up with. To inquire on our VOBU's VOB and Cell IDs. I know you can parse the VOBs.