DVD2AVIdg/MPEG2DEC3dg 1.1.0 Release Version

[Guest]

EDIT 4-28-2004: I've updated this first post with the most recent 1.1.0 release information. The remainder of the thread now serves as an archive for the development discussion. Thank you to all particiapants for your valuable assistance.

As promised, I have made a new release 1.1.0 with some fixes. Please post feedback to this thread. Thank you.

Some further fixes are still in progress and, of course, many enhancements can be started when the fixes are complete.

Get version 1.1.0 here:

http://neuron2.net/fixd2v/decodefix.html

Following are the changes for this version:

---------------------------------------------------------
DVD2AVIdg/MPEG2DEC3dg Functional Changes
(versus DVD2AVIdg/MPEG2DEC3dg 1.0.0)
---------------------------------------------------------

DVD2AVIdg/MPEG2DEC3dg Version 1.1.0

1. Correct the version string reported in the About box.
1.1.0RC4.

2. Fix or disable "Save AVI" functionality. (see below)
Disabled.

3. Uninitialized motion_type in macroblock_modes() [Lord KiRon]
Fixed in both DVD2AVIdg and MPEG2DEC3dg.

4. Improved random navigation performance.
Greatly improved. Works only for dg-style D2V files. Requires
new versions of both DVD2AVIdg and MPEG2DEC3dg.

5. Fix case presentation for CLI file names (don't map to all upper case).
Fixed.

6. Better auto-loading of multiple VOBs [Cyberia]
a) Auto-load more than 0-9 files at a time
Fixed.
b) Ability to disable auto-loading on Open dialog
Fixed.

7. Fix drag-and-drop loading [Cyberia]
a) Always load ALL dropped files
Fixed (but still needs sorting).
b) Never auto-load from drag-and-drop (load ONLY dropped files)
Fixed.

8. CLI support for selection of 1.76 vs. dg style project files.
Fixed. Use -DF=0 for 1.76 style; -DF=1 for new style.

9. Change trackbar pitch from 500 to 2000. Gives better trackbar
resolution for large files. [DG]
Fixed.

10. Because of the changes you made to NextFile() in getbit.c,
the last file now "wraps around" as indicated by your comment.
However this doesn't stop the audio from being demuxed. As a result,
if the VOB has audio packets before the first video packet (mostly
happens when processing VOBs demuxed by CellId), audio frames from
the start will be appended. The resulting file is not accepted by
Maestro, for instance. Fixed by adding a check for Dry == true in
the audio demuxing code. [RB]
Fixed.

11. Fix "Cannot step backwards across VOB boundary" [Cyberia]
Fixed.

12. Add a delete all files button to the file list dialog. [Cyberia]
Fixed.

13. Maximum number of frames per GOP increased from 50 to 500 (some
nonstandard streams were failing). [Fred Thompson]
Fixed.

14. Trackbar positioning and marking is quirky. E.g.,
after loading, the trackbar is not positioned on the first GOP, and
putting the trackbar at the end does not position to the last GOP. [Cyberia]
Fixed. Still not perfect but much better.

15. Record aspect ratio information in the D2V file.
Added for new style D2V file format only.

16. Video item of menu bar stays grayed after file load until the mouse
is placed over it.
Fixed.

17. The "Save BMP" command now does not require the color space to be set
to RGB24 (it now sets it automatically and restores it to YUV if needed),
it was moved to the File menu, and a file dialog now allows specification of
the save file name and location.
Fixed.

18. Need a Play command that starts playing from the current trackbar position
to the end, regardless of the left and right mark positions.
Fixed.

19. Add a link to my web site on the Help menu.
Fixed.

20. Rearranged menu layout and made the menu enables/disables more rational.
Fixed.

21. Added versions of ParseD2V and FixD2V that work with the new release. ParseD2V now shows much more information.

[Guest]

The backward VOB stepping is not yet fully reliable. Back to the drawing board. :confused:

[Cyberia]

Definately faster seeking! Much improved, but there are still a few issues:

Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0

Do we need Auto Open on the File menu? It doesn't save a single click even. It does let you perform a double-click rather than two single clicks, but that's not much. I don't mean to be critical of this, just I don't see any real benefit. ;)

It would also be nice to have a 'Clear All' button on the Open dialog. I realized this by auto-adding a VOB with 245 segments. "Now, how do I rid of all these?" :0

Are you just disabling SaveAVI, or removing it entirely? You could probably also disable 'Colorspace' and 'YUV -> RGB'.

On that note, there are a number of other GUI options of dubious value. This would be mostly cosmetic.

[Guest]

Originally posted by Cyberia
Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0 Can't duplicate. Please either explain better or make the VOB available for download. Does it fail like this in version 1.0.0?

Do we need Auto Open on the File menu? It doesn't save a single click even. It does let you perform a double-click rather than two single clicks, but that's not much. I don't mean to be critical of this, just I don't see any real benefit. ;) Huh? If I have spider_0.vob and spider_1.vob, I can get both into my list with one open dialog. What are you talking about??????????

It would also be nice to have a 'Clear All' button on the Open dialog. I realized this by auto-adding a VOB with 245 segments. "Now, how do I rid of all these?" :0 I'll make one.

Are you just disabling SaveAVI, or removing it entirely? You could probably also disable 'Colorspace' and 'YUV -> RGB'. OK.

[Cyberia]

quote:
--------------------------------------------------------------------------------
Originally posted by Cyberia
Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0
--------------------------------------------------------------------------------

Can't duplicate. Please either explain better or make the VOB available for download. Does it fail like this in version 1.0.0?


I cant find a VOB where it doesn't happen. Here's whats happening: When you click 'End Marker' with the slider positioned at the end of the the bar, the slider moves back to the last GOP. It might be hard to see in large VOBs. Try opening one split by cell-id. Also try opening a small VOB and then just click 'End Marker' and watch the slider.

I can make a sample available if necessary.

When the file opens, should the slider bar be positioned at the first GOP, not at the first frame? (I believe it should be)

Now the Auto-open issue:
Ahh I see the advantage. Its on the backside of selecting the file, not the frontside. ie: Double-click the start file and your done! Got it.

[zettai]

I'm getting lots of macroblocks that are parts of a frame that was at least 30 frames previous to this one, so possibly from the gop before?

http://www.amvs.34sp.com/ewwblocks.jpg

This only flashes up for a frame before disappearing but it's a recurring problem.

This is in a lot of different places in the first thing I tested when using the new versions, so I'm surprised it wasn't spotted. I can make a sample if required but I'm expecting that it should appear on a lot of different things.

This was a hybrid source, no RFF flags so no force film - I just made the new project file as I always do. This same rip worked fine with the 1.0.0 version the other day.

[Wilbert]

"You could probably also disable 'Colorspace' and 'YUV -> RGB'."

OK.

Why? There are still people who use vfapi?

[Guest]

Originally posted by zettai
I'm getting lots of macroblocks that are parts of a frame that was at least 30 frames previous to this one, so possibly from the gop before? I need to fix this first.

Which D2V format are you using? Do you see it in DVD2AVI preview, or only after decoing with MPEG2DEC3dg? If the latter, what is your script?

Please make a VOB available for downloading.

[zettai]

OK, I'm cutting a vob now, once I find a small section that shows the problem.

I made a new type d2v and decoded simply with

MPEG2Source("J:\SUPER_GALS_2\VIDEO_TS\supernew.d2v")

just give me a min to get the vob done.

I dont seeit in the preview but I'm not likely to if that's all keyframes.

[zettai]

OK, I've worked out that the frames only appear when scrubbing the trackbar in virtualdubmod.

Here's a vob:

http://www.amvs.34sp.com/test2.rar

If you frame advance forwards it's fine but if you do a lot of scrubbing you will often see this happen in frame 75 and some other frames too.

[puschpull]

Hallo!

I have bug, why i load *.d2v project in GordianKnot 0.28.8 !!
:-)

Normal, why i use d2v in Avisynth/VDubMod is all OK

[Cyberia]

I have uploaded a sample VOB here (http://home.insightbb.com/~cyberia-1/VOB/vts_04_31.vob)

[Guest]

Originally posted by zettai
Here's a vob:

http://www.amvs.34sp.com/test2.rar
My WinRAR says the file CRC is bad and the file is corrupt. Can you check it please?

[Guest]

Originally posted by puschpull
I have bug, why i load *.d2v project in GordianKnot 0.28.8 !!
:-)

Normal, why i use d2v in Avisynth/VDubMod is all OK Any chance you could tell me what the bug is? Thank you.

[Guest]

Originally posted by Wilbert
Why? There are still people who use vfapi? Please elaborate as I didn't get your point.

[Guest]

Originally posted by Cyberia
I have uploaded a sample VOB here (http://home.insightbb.com/~cyberia-1/VOB/vts_04_31.vob) Thanks, Cyb. I'll address this after zettai's nasty bug find. BTW, I've added the delete all button and got backward stepping across files finally nailed down.

[Guest]

Originally posted by neuron2
My WinRAR says the file CRC is bad and the file is corrupt. Can you check it please? Strangely enough, I've duplicated your issue using Cyberia's VOB! Still, if you correct the file I'll ensure that the fix works with it also.

[puschpull]

neuron2: Sorry ! :-)

The Bug:

When i make *.d2v with "old" DVD2AVI
http://puschpull.org/root/problem_new_dvd2avi_2.png

If i open this project in Gordion knot
http://puschpull.org/root/problem_new_dvd2avi_3.png

http://puschpull.org/root/problem_new_dvd2avi_4.png

then is all normal, OK

But, when i make *.d2v with "new: DVD2AVI
http://puschpull.org/root/problem_new_dvd2avi_1.png

Gordian Knot has problem:
http://puschpull.org/root/problem_new_dvd2avi_5.png


If i use "new" *.d2v file in VirtualDubMod /Avisynth, so isn't no problem

:-)

puschpull
(http://puschpull.org)

[zettai]

Originally posted by neuron2
Strangely enough, I've duplicated your issue using Cyberia's VOB! Still, if you correct the file I'll ensure that the fix works with it also.

Ack! Sorry, I didnt check the upload... it hadn't fully uploaded :(

It's uploaded fully now. ><

[Guest]

Thanks, zettai.

I've fixed this bug and released beta 2. It also includes the new delete all button on the file list dialog, suggested by Cyberia.

http://neuron2.net/fixd2v/decodefix110b2.zip

[zettai]

Excellent! It all looks great from here, I'll let know know if I find any more bugs but that one has definitely been squished.

[Wilbert]

Please elaborate as I didn't get your point.
That setting "corrects" the luma range ([16,235]->[0,255]), when opening this d2v in vfapi/tmpgenc (which needs rgb24). This setting is stored in the d2v.

I was quite sure you knew that :confused:

[Cyberia]

The selection markers are still acting funny. You didn't mention it, so I assume you didn't fix it. (I am a master of deductive reasoning)

Anyways, here is some more info about it:
If you move the slider quickly all the way right, the frame displayed is not necessarliy the frame at the current marker position. I can duplicate this easily by moving the slider quick enough.

If you do this, and then click 'end marker' then the selection is marked at the displayed frame, not the slider position. Thats whats happening.

[Cyberia]

This is a enhancement suggestion: right-clicking on the display area currently does nothing. How about toggling Preview/Stop on a right-click. If it's currently stopped, a right-click starts it, and vice versa.

[DDogg]

Really good to see you back, Don :-D

I regret a problem report (Beta2).

1> Prepared D2V using standard VOB source, FF, no audio.
2> Noticed MPC would not "play" this D2V
3> Used script:
loadplugin("d:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("d:\wutemp\testDG.d2v")
4> Got unrecognized exception line #2

[Guest]

Originally posted by DDogg
Really good to see you back, Don :-D

I regret a problem report (Beta2).

1> Prepared D2V using standard VOB source, FF, no audio.
2> Noticed MPC would not "play" this D2V
3> Used script:
loadplugin("d:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("d:\wutemp\testDG.d2v")
4> Got unrecognized exception line #2 WHat is MPC and where do I get it?

[zettai]

MPC is just Media Player Classic - gabest's MP6.4 alternative. It should be the same error in virutaldub, windows media player etc.

In my experience the unrecognized exception error is usually one of two things:

1) Project file format incompatible with mpeg2dec

2) Project created with processor settings that are not suitable for the user's cpu (sometimes sue to using a bad dvd2avi.ini or setting it up wrong).

[DDogg]

Originally posted by Neuron2
WHat is MPC and where do I get it? That was really an aside comment, as I normally first check a d2v with Gabest's Media Player Classic (http://gabest.org/).

The error reported was when the script was played as normal in WMP or VDub.

/add:zettai, note I said MPC would not "play" the D2V

[zettai]

Originally posted by DDogg
/add:zettai, note I said MPC would not "play" the D2V

It's not likely to as the d2v format has changed with this beta and Media Player Classic has not been updated to acknowledge these changes in its internal d2v processor.

[DDogg]

jeeze, I'm sorry I confused the issue by mentioning it.

[ssjkakaroto]

thx a lot for continue developing dvd2avi neuron2 :)

[Guest]

Originally posted by DDogg
jeeze, I'm sorry I confused the issue by mentioning it. Don't be sorry. Whoever writes MPC needs to be aware of it!

[DDogg]

Don, just to clarify, you do understand I was saying that beta2 crashes in normal use? Any d2v created by it is unusable in any application on my AMD XP machine.

[Guest]

I had to release a beta 3. The fix for zettai's issue had actually negated the improved random navigation speed! So now that is back and hopefully zettai's issue is not. :) It also may fix DDogg's issue. Please advise.

I have noted the enhancement requests.

I suggest that the GK incompatibility be deferred until we have a good stable version. It is too early to be thinking about revising the other tools.

So now I will look at Cyberia's marking/positioning strangenesses and the other outstanding fixes requiring submission of VOBs (Fred and Lord KiRon). Of course if DDogg is still suffering we'll have to throw him a bone.

http://neuron2.net/fixd2v/decodefix110b3.zip

[Guest]

Originally posted by ssjkakaroto
thx a lot for continue developing dvd2avi neuron2 :) Thank you for the kind words and thanks to all for assisting me with feedback, enhancement ideas, and patience with early betas. :p

[DDogg]

Don, same thing, Exception error. It seems strange that nobody else has reported this. I hope it is not one of those one-off conflict things. They are a bear to chase down.

I suppose I should check non FF. Will do and edit back. This is just the most basic test I could imagine. -

loadplugin("D:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("D:\wutemp\testDG.d2v")


DVD2AVIProjectFile
6
24 I:\VIDEO_TS\VTS_04_1.VOB
24 I:\VIDEO_TS\VTS_04_2.VOB
24 I:\VIDEO_TS\VTS_04_3.VOB
24 I:\VIDEO_TS\VTS_04_4.VOB
24 I:\VIDEO_TS\VTS_04_5.VOB
24 I:\VIDEO_TS\VTS_04_6.VOB

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=1 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=23976
Location=0,0,5,2394

7 0 0 12 13 10 11 12 13 10 11 12 13
7 0 B 0 1 12 13 10 11 12 13 10 11 12 13
7 0 26 0 1 12 13 10 11 12 13 10 11 12 13
7 0 4E 10 11
7 0 59 12 13 10 11 12 13 10 11 12
7 0 E3 3 10 11 12 13 10 11 12 13 10 11
7 0 18D 12 13 10 11 12 13 10 11 12 13 10 11
7 0 241 12 13 10 11 12 13 10 11 12 13 10 11
7 0 2F5 12 13 10 11 12 13 10 11 12 13 10 11
7 0 3A7 12 13 10 11 12 13 10 11 12 13 10 11
7 0 458 12 13 10 11 12 13 10 11 12 13 10 11
7 0 50A 12 13 10 11 12 13 10 11 12 13 10 11
7 0 5BF 12 13 10 11 12 13 10 11 12 13 10 11
7 0 672 12 13 10 11 12 13 10 11 12 13 10 11
7 0 724 12 13 10 11 12 13 10 11 12 13 10 11
7 0 7D6 12 13 10 11 12 13 10 11 12 13 10 11
7 0 887 12 13 10 11 12 13 10 11 12
7 0 912 13 10 11 12 13 10 11 12 13 10 11 12 13 10
7 0 9D9 11 12 13 10 11 12 13 10 11 12
7 0 A78 13 10 11 12 13 10 11 12 13 10
7 0 B0F 11 12 13 10 11 12 13 10 11 12 13 10
7 0 BE1 1 2 13 10 11 12 13 10 11 12 13 10
7 0 CC5 1 2 13 10 11 12 13 10 11 12 13 10
<snip>

[Guest]

Are you SURE SURE SURE you are using the correct MPEG2Dec3dg.dll? Please triple check. Use a full path to load it.

Go down to one VOB only (the first) to try to reduce variables. You're going to have to create a scenario I can duplicate. Does the error occur on initial loading? Try to make a single VOB as small as possible that exhibits the problem.

And yes, try no FF also.

Note I have AMD XP also and see no problems.

[DDogg]

It works with FF turned off. I wanted to get that info to you, but will try to pin it down more now that it sounds more specific to my situation. If you notice the script, I did take pains to isolate and load the correct mpeg2dec3DG.dll that I specifically took from the beta 3 build.

/Add1: Grabbing a single VOB down the chain is working FF, back in a bit

[Guest]

Right, sorry, I didn't notice your path.

I doubt it's so specific to you. It's just that you've stumbled on an error case, I'd guess. The key is to get me a VOB that I can use to duplicate the issue. Thanks.

[Cyberia]

@Neuron2: I have a sample VOB demonstrating this problem here (http://home.insightbb.com/~cyberia-1/VOB/vts_01_223.vob)

Build a project with Force-Film turned on.

[Guest]

Originally posted by Cyberia
@Neuron2: I have a sample VOB demonstrating this problem here (http://home.insightbb.com/~cyberia-1/VOB/vts_01_223.vob)

Build a project with Force-Film turned on. Dead link. :(

[Cyberia]

Fixed. Try again, please.

[Guest]

Got it. Thank you.

EDIT: Ooh, a tiny VOB. I love you man! No stepping through 100's of iterations of the parsing loop. :D

EDIT2: Now why would the esteemed Cyberia be applying FF to a VOB with no repeat flags set? Sheer perverseness I am sure. :) Nevertheless, it does show me where I went wrong. It affects only FF. This one will take a day or two as I forgot how FF works. :)

DDogg, relax. This VOB tells me everything I need to know.

[DDogg]

Cool, the odd thing seemed to be that only when all 6 vobs were processed together would the problem appear. Each by themselves would not, although I had not quite finished checking it properly.

Cyberia, WTG.

[Cyberia]

Thanks. I think it happens when you try to apply FF to NTSC material. Most movies contain some of this footage at some point.

I was able to isolate it by using smaller and smaller sets of VOBs (cause I often split by cell-id) until I had just one VOB that crashed.

[Guest]

OK, here's the fix. :)

This beta also fixes these:

1. After file load, trackbar is now on the first GOP.
2. Begin marking ([ button) works sensibly.

I still need to do the end marking and trackbar stuff.

http://neuron2.net/fixd2v/decodefix110b4.zip

[DDogg]

Yep, working fine. So much for "This one will take a day or two as I forgot how FF works." - FF must be like a bicycle? :)

[puschpull]

neuron2:

In this version (Beta4)
load *.dv2 in GordianKnot without this message:
http://puschpull.org/root/problem_new_dvd2avi_5.png

but screen is empty (black)
http://puschpull.org/root/problem_new_dvd2avi_6.png
and project "No Frames"

In previous version: "1.77.3dg1.0.0 RC2" load GK files d2v correct
http://puschpull.org/root/problem_new_dvd2avi_7.png


DVD2AVIProjectFile
1
37 D:\Project_Filmy\HPIIVob\vts_01_8.vob

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=0 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=25000
Location=0,0,0,91D0

7 0 0 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 10 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 20 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 30 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2



in this new version: "1.77.3dg1.1.0 beta4" load GK d2v file with null frames



DVD2AVIProjectFile
1
37 D:\Project_Filmy\HPIIVob\vts_01_8.vob

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=0 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=25000
Location=0,0,0,91D0

7 0 0 12 12 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 10 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 20 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 30 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12


Is this problem with GK (0.28.8) ?
Otherwise with 1.77.3dg1.1.0 ?

:-)

[zettai]

Gordian Knot uses it's own (older) version of mpeg2dec.dll so you can't expect it to work with the new d2v files.

[puschpull]

zettai: OK !

Problem is in side Gordian Knot, yes?

[zettai]

Yes. Gknot will need updating to use the new d2v files - unless replacing the mpeg2dec file in gknow with the new one will work (gordian knot will have its own mpeg2dec file somewhere in its directory). I can't be sure that will work but it's worth a try.

[RB]

Originally posted by neuron2
12. DVD2AVI (AFAIK all versions) will crash if there is a "false"
SEQUENCE_HEADER_CODE (0x1B3) at the start of the VOB (i.e. for
some reason there's a 0x1B3 code but it's not followed by a valid
sequence header). I have just seen this with a menu VOB demuxed by
VobId. Fixed by adding a global VideoStream_Flag variable (global.h)
that gets set to true in Next_Packet() in getbit.c when we find a
VIDEO_ELEMENTARY_STREAM packet. Then modified switch statement in
Get_Hdr() in gethdr.c and mpeg2dec.c to decode sequence headers only
if VideoStream_Flag == true. [RB]
Fixed

Uh, it just occured to me that this fix will break support for MPEG2 elementary streams because there are no VIDEO_ELEMENTARY_STREAM (0x1E0) headers in a raw M2V file... Just tested with your latest beta 4, and yes, M2V files won't work anymore. Sorry :)

[puschpull]

zettai: yes

I put MPEG2Dec3dg.dll in the GK directory
delete MPEG2Dec3.dll
and rename MPEG2Dec3dg.dll to MPEG2Dec3.dll

And now is this problem OK !
:-))

Thanks!

[Guest]

Originally posted by RB
Uh, it just occured to me that this fix will break support for MPEG2 elementary streams because there are no VIDEO_ELEMENTARY_STREAM (0x1E0) headers in a raw M2V file... Just tested with your latest beta 4, and yes, M2V files won't work anymore. Sorry :) Ouch. Please let me know if you think of an alternate solution. Meanwhile, I'll back that out and start thinking about how to fix it properly. Thank you for bringing it to my attention.

EDIT: RB, can you possibly post a link to a small VOB that shows the original problem?

[Guest]

Originally posted by DDogg
Yep, working fine. So much for "This one will take a day or two as I forgot how FF works." - FF must be like a bicycle? :) Glad to hear it is OK for you now.

I thought of a slick way to finesse the problem without having to know how FF actually works. :sly:

[Guest]

Originally posted by puschpull
I put MPEG2Dec3dg.dll in the GK directory
delete MPEG2Dec3.dll
and rename MPEG2Dec3dg.dll to MPEG2Dec3.dll

And now is this problem OK !
Thanks puschpull for bringing this up and reporting your successful results. Thanks zettai for the suggestion.

In case anyone is curious... That extra '1' digit on some of the D2V flag bytes means "this frame can be decoded just by decoding the GOP that the frame is in, i.e., it is not necessary to decode the previous GOP." This is the extra information that enables faster random access.

[RB]

Originally posted by neuron2
Ouch. Please let me know if you think of an alternate solution. Meanwhile, I'll back that out and start thinking about how to fix it properly. Thank you for bringing it to my attention.
I think it's best to simply determine whether the current file is MPEG2 ES rather than VOB and if so, just set VideoStream_Flag = true unconditionally.

MPEG2 ES files always appear to start with a SEQUENCE_HEADER_CODE (00 00 01 B3) right away whereas VOB files start with a PACK_START_CODE (00 00 01 BA). This could be used in addition to a check on the file extension (MPV/M2V vs. VOB).

[Cyberia]

Gosh Neuron2, I'm sorry, I appear to have found a new bug :(

When you drag-and-drop multiple files they get loaded in random order, not ascending order.

You'd almost think I was a senior tech support guy and did this kind of stuff for a living. :)

[Guest]

You think the order is real important, huh?

[Cyberia]

Oh I see! It's a *feature*! Lets call it the 'Tarantino' Now you can watch any movie in randomly ordered sections, and *you* can figure out the timeline. Just like Quentin Tarantino filmed it himself. Nice.

WARNING: Do not attempt to use this feature on movies made by QT!

(If you aren't a Quentin Tarantino fan, this post will be lost on you. Can you tell I just got Kill Bill v1?)

[Guest]

I wonder if you detected my implicit sarcasm.

A straight alphanumeric sort would put vts_10.vob before vts_2.vob. Given that the general form is xxx_Nyyy.vob, where xxx and yyy are arbitrary (except that yyy does not contain a _) and N is a number, how would you define the sort order? Would you first do alphanumeric sort ignoring N, and then sort numerically by N?

[zettai]

I'd order like this:

VOB_01_01 to VOB_01_99

then

VOB_02_01 to vob_02_99

so find the first vob, then all the parts of that and then find the next. Repeat until everything is in order.

Is that doable?

If the input isn't in the form VOB_xx_xx then I guess it will have to be ordinary alphanumerical.

[Cyberia]

I detected the sarcasm, but thought it was a retorical question. Order is important, yes.

The current drag-and-drop loading is _useless_ for dragging multiple files.

I'd *really* prefer that they be ordered they way I dropped them, whatever that is. Thats all. You don't have to sort them at all just don't re-arrange them. Thats probably not as easy as it sounds. It's probably Windows itself handing them to you in random order.

If you have to sort, try this:
Assume the general form is VTS_xx_yy.vob
Assume the "VTS_" part will remain constant
Sort by xx, then by yy (force xx and yy to triple-digits before sorting, so VTS_2.VOB sorts as VTS_002.vob)

I don't know, do what you want. This is a low priority fix I guess, but it'd be nice.

[Guest]

OK, I drew the line for a formal release. Please beat up on this release candidate. Compared to the previous beta, it improves trackbar handling, fixes M2V (by backing out RB's changes -- see below), allows for a larger number of pictures per GOP, and adds the aspect ratio information to the D2V file.

RB, I'll need a VOB to address your crashing issue with "false" headers.

http://neuron2.net/fixd2v/decodefix110RC1.zip

[Cyberia]

@the trackbar issue:

I agree at loading that the trackbar/marker should be positioned at the first GOP, but should the last GOP be the where the end marker stops? Frames after that point (until EOF) should be decodeable shouldn't they?

[Guest]

I agree. I'll see if it is not too hard to do that. The last frames are in fact decoded and included, but the marker currently stops at the start of the GOP.

[Cyberia]

I guess the right way to say it is that the Start marker should be have GOP resolution, but the End marker should have frame resolution.

The trackbar should therefore also have frame resolution, and when you set the Start marker it jump to the previous GOP.

My best friend just told me she is going to have a baby! I can't even describe how I feel now, let alone concentrate. Wow, awesome.

(no not mine)

[Dark-Cracker]

hi,

nice work :)
it's me or the video button (in the menu) was grey even after opening a .vob file and it was un-greyed only when u put the mouse on ?

a little suggestion is to grey the options like dolby downmix or dynamic range control when u select demux mode, same for the track number when u select demux all.

and i have also a bug report.

in the command line u enter multiple path name (for the -IF option)
however the character "," is an alowed character for the pathname.
even if it's rarely used.

for exemple if i have a path like this : "c:\my,dvd\"

if i use the option : dvd2avi ... -IF [c:\my,dvd\vts_01_1.vob,c:\my,dvd\vts_01_2.vob]

this will failed. i think u must use a separator forbidden in the path name or use the double quote.

Bye.

[Guest]

I've fixed the ungreying of the Video menu item. That's irritated me for a while too. There was a missing DrawMenuBar() call after the item was enabled.

Regarding the comma, it would break applications that use the command line if I change it.

[Cyberia]

GUI Issues:

How about moving the Pause command from the Options/Process Priority menu to the File menu (where the Stop command is)

Does the Save BMP option work? Appears disabled. It would be nice to have this work. It should also be under the File menu.

[Dark-Cracker]

@neuron2

>Regarding the comma, it would break applications that use the command line if I change it.

sure but i think if u use the double quote ("") i think the modification to add in the applications who use the command line will be little. if u have start to fix dvd2avi bugs why not fix this bug in the command line ?

in any case do as u want :) and thank u for your work :) (and of course all the other people fixing dvd2avi).

PS : perhaps should u update the link and changelog in the first post.

Bye.

[Guest]

Originally posted by Cyberia
How about moving the Pause command from the Options/Process Priority menu to the File menu (where the Stop command is) Done.

Does the Save BMP option work? Appears disabled. It would be nice to have this work. It should also be under the File menu. It works but you had to set color space to RBG24. I changed it to do that automatically so that it is always enabled (it saves and restores the original color space). I also moved it to the file menu and made it do a file dialog popup to allow the user to specify the directory and filename.

Thank you for your suggestions.

Here is RC2:

http://neuron2.net/fixd2v/decodefix110RC2.zip

[Cyberia]

Good Work Neuron2! This looks very good.

I have one very minor irritation left. When you first open the program before loading a file, Video is still greyed. For consistency sake, either:
Grey out the audio menu also, until a file loads, or don't grey the Video before a file loads.

Thats it, very very good work Don.

[Cyberia]

Oh crap, I just redicovered a few more GUI issues I wanted to mention.

What is up with the SIMD Technology menu? I am baffeled as to how it works. I know what it is supposed to do, but not how it works. Let me explain:

That menu has 5 items:
MMX (checked, checkable)
SSE MMX (checked, checkable)
3DNOW! (checked, greyed)
SSE FPU (checked, greyed)
SSE2 (unchecked, uncheckable, ungreyed)

Now I have an Athlon 2200, so I would think SSE2 should be unchecked and greyed (Implying I CAN'T use it). But why are 3DNOW! and SSE FPU both greyed out? They can't be mandatory, what if I have a Pentium? Also, why are there bars between some of the items?

Am I misunderstanding how this works?

Also, move the SIMD (lose the 'Technology' part), DirectDraw and VFAPI options to the OPTIONS menu, where they belong.

If you wanted to add an item or two to the Help menu, like for the Readme, or for the changelog. Not that it needs much documentation, but what little is documented is quite old. The Help dialog even points to Jackei's original page. Anyway the HELP menu is VERY low priority, just wanted to put my thoughts on the record. (You should still move some of the item to Options)

[Guest]

If you guys keep making new requests for RC loads, we'll never have a release. :)

An RC release is to ensure that things are OK for the feature set in existence when the line is drawn. There will be future releases. Nevertheless, I have noted your requests for future releases.

Now, because I have the balls to ignore my own advice, I'll tell you of a new feature I am adding for the release. It always annoyed me that Preview only plays from the left mark position. I always wanted a way to just play from the current location. So we will have Preview (plays between the mark points, as before) and Play (plays from current position to the end).

[jorel]

neuron2

few seconds after your first post i was reading your thread.
i don't want to came here interpose after each new version.
then, this is my present and future grace for what you do in this job!

thank you for that great work!
:cool:

[RB]

Originally posted by neuron2
RB, I'll need a VOB to address your crashing issue with "false" headers.
I'll try to come up with one again.

But really, it's a general problem that's IMHO really obvious when looking at the source. In brief, the problem is that at least the initializing code in mpeg2dec.c just blindly scans the input file for a SEQUENCE_HEADER_CODE. That's fine if it's MPEG2 ES or in case of a VOB file, the VOB file starts with a video packet. But if the VOB starts with audio/subs/nav packs, it is not only theoretically possible that one of these packs contains a 0x000001B3 byte sequence somewhere, just as part of the data in the packets. In this case DVD2AVI will obviously crash.

[Guest]

@RB

I wasn't doubting you; rather, just saying I'll need a VOB to fix it and test the fix. If you can provide one, it will be appreciated. Thank you for your interest in making the program better.

EDIT: How about if I look for a valid sequence header start code by ensuring that it is followed by a sequence extension start code? This is mandatory for MPEG2, and we don't support MPEG1. We could revisit it if and when MPEG1 support is added (probably never).

[Cyberia]

Clarification:

Upon further review, I believe the Video menu should never be greyed out. It should be OK to set these options before opening a file.

The File menu already greys the required items.

@neuron2 - [innocent voice] I never said any of these had to be added immediately :) [/innocent voice]

[Guest]

@jorel

You're most welcome and thank you.

@Cyberia

OK, I'll not grey it out then. Your other suggestions have been noted and added to my current worklist.

[Guest]

OK, let's get this sucker released!

Here is RC3. It has the Play feature and a link to my website.

http://neuron2.net/fixd2v/decodefix110RC3.zip

Please report only problems with features I've added or claimed to have fixed (see changes file).

After this is released, we'll plan the next release.

[RB]

Will the new Mpeg2Dec3DG.dll still work with D2V files generated by DVD2AVIdg 1.0.0?

[Guest]

Originally posted by RB
Will the new Mpeg2Dec3DG.dll still work with D2V files generated by DVD2AVIdg 1.0.0? If the D2V file is 1.76-style, yes. If new-style, no.

This aspect hadn't occurred to me. I'll give it some thought. Thanks for pointing it out. At a minimum, a warning in the documentation is called for, as well as a version ID in the D2V file.

The thing is, I anticipate continued evolution of the D2V file and I don't want to have exploding code for backward compatibility. What do you think?

EDIT: Actually, testing and stepping in the debugger shows that 1.0.0 D2V files do work. The issue is how the missing Aspect_Ratio line is dealt with. It seems that fscanf() just fails to find it and subsequent fscanf()'s do work. I'm not sure why, given the definition of fscanf(), but that is what I see.

[RB]

Actually I was asking because of the new "12" codes in the D2V :) The new Mpeg2Dec3DG.dll doesn't absolutely require these, I suppose.

However I agree, don't bother with backward compatibility. But you may want to stay in contact with jdobbs as he's generating his own, uh, tweaked D2V files for DVD-Rebuilder. You guys may want to make sure the new DLL doesn't choke on them :)

[Guest]

The extra 0x10 flags OR'ed into the flag bytes will be missing with the 1.0.0 format. The result will simply be that random access will be as slow as the 1.0.0 release. Believe it or not, I carefully chose the bit polarity for just this reason. :sly:

How tweaked?

[RB]

Originally posted by neuron2
How tweaked?

D2V is written in 1.76 style but no skipping of initial B-Frames
RFF and BFF flags are never written to the D2V, regardless whether or not the source is like that, always writes "2" to the D2V
for NTSC, Force Film is always activated (yes, even if there are no RFF flags)
This way he only gets the "real" frames at 23.976 fps (25 for PAL), undisturbed by mixed telecined/interlaced content. RFF/TFF flags and original frame rate codes are then rebuilt during remuxing of the newly encoded stream into original VOBs. Very clever :)

Maybe I should point jdobbs at this thread.

[Guest]

I put out one more (and hopefully last) RC for version 1.1.0.

This version rewrites all the GUI object enabling and disabling stuff. It is now centralised and easy to maintain. The thing is, though, you guys have to check whether what I did is reasonable. I hope that the venerable Cyberia will have a good look at it.

Speaking of which, Cyberia, you need an avatar.

And oh, I also rearranged the menus to be more rational and organized, at least as I see it. :p

Your feedback will be appreciated as we approach closure on 1.1.0.

http://neuron2.net/fixd2v/decodefix110RC4.zip

[Cyberia]

Yes, I need an Avatar. How the heck do I get one?

[Guest]

Originally posted by Cyberia
Yes, I need an Avatar. How the heck do I get one? Edit Options in the Control Panel. Want me to pick one and send it to you? :)

[Cyberia]

tada

[Guest]

Awesome, dude. :eek:

[Cyberia]

The Colorspace option does not default to any value, nor does it remember it's check if you re-open the program.

[Guest]

Originally posted by Cyberia
The Colorspace option does not default to any value, nor does it remember it's check if you re-open the program. Good catch! It does get set after a VOB is loaded, when the DirectDraw overlay can be checked and initialized if possible. I'll default it to YUV in the resources so it at least doesn't appear unchecked. This item is not currently stored in the INI file so it will be forgotten. I'd rather not break INI file backward compatibility just for this.

[Cyberia]

I'm not sure if this is a new issue or not, but I can't check (or uncheck) ANY of the 'options' under Help.

VFAPI can't uncheck
DirectDraw can't check
SIMD can't check or uncheck anything.

I checked and RC2 also does this, so now I'm confused. Are these supposed to be Options? or indicators only?

[Cyberia]

Why would it break backwards compatibility? You'd be adding a new parameter to the existing format. If ANY of the parameters are missing they should revert to the default anyway. Right?

[Guest]

Originally posted by Cyberia
Are these supposed to be Options? or indicators only? They're indications only. That is why they are not in the Option menu. ;)

[Guest]

Originally posted by Cyberia
Why would it break backwards compatibility? You'd be adding a new parameter to the existing format. If ANY of the parameters are missing they should revert to the default anyway. Right? Actually, the Color Space setting affects only "Save AVI", "Play", and "Preview". Now that "Save AVI" is gone, this arguably should not even be configurable, and should be set automatically according to the DirectDraw overlay capability.

Does anyone object to my doing just that?

[Cyberia]

Lose everything not needed.

Is SaveAVI gone forever, or just disabled for the forseeable future? If gone forever, remove SaveAVI from the file menu too.

[DDogg]

If I understand your post completely, I don't see how anybody could object. Certainly none on this end. LIke Cyberia
said, you might as well pull the save avi for now too.

[Guest]

Version 1.1.0 has been released! See the top of the thread for links and the final change log.

Planning for the next release now begins. Please revert to Cyberia's development thread for that and use this thread for any residual bugs found in version 1.1.0.

Thank you to all who participated. :)

[Moitah]

Originally posted by neuron2
Version 1.1.0 has been released!
Excellent, thank you :).

[Cyberia]

Looks good.

[Zarxrax]

Neuron, here's another problem that still persists in DVD2AVI. I read through the thread and don't think it was mentioned yet, so...
I sometimes load in a bunch of vobs, make a small selection, save a project file, then go to make another selection. If you have a selection made, you are unable to set a new in point for a new selection unless you first set a new outpoint. Could you make it so that when you try to set a new in point, it will first clear both existing in/out points? I think that should fix it.

[Guest]

Can't duplicate that in 1.2.0. Please give an exact sequence of operations.

[Cyberia]

I'm sure he means he cant set a start marker past the current end marker. I can duplicate this, but I think this is how it should work.

[Zarxrax]

Yep thats what I meant, Cyberia. What I'm talking about is it would be nice if you could set the markers like you do in virtualdub. If you tell it you want your in point there, then it sets it there, regardless if you already have an out point somewhere. Its jsut annoying if you wanna make multiple selections, to have to set your out point, then search around again for the start point you want.
And I didn't notice the 1.2 yet :p

[Guest]

@Zarxrax

That makes sense. I'll do it.

[Guest]

Originally posted by zettai
I'd order like this:

VOB_01_01 to VOB_01_99

then

VOB_02_01 to vob_02_99

so find the first vob, then all the parts of that and then find the next. Repeat until everything is in order.

Is that doable? Sure. I found the function strverscmp() in the GNU C Library that does this in a general way. I propose to add a sort button in the open dialog. When pressed it sorts all the names in the list using this method. Any thoughts?

[zettai]

A sort button sounds good. (as would move selected up and move selected down but they are probably much more work)

[Cyberia]

DVDDecrypter produces output files with this naming scheme, which does not auto-load in DGIndex: VTS_01_VOBID_003_CELLID_001_1.VOB

I propose allowing muliple selections in the Open Dialog as a workaround. These files could then be sorted with your new button.

[Guest]

Originally posted by Cyberia
DVDDecrypter produces output files with this naming scheme, which does not auto-load in DGIndex: VTS_01_VOBID_003_CELLID_001_1.VOB

I propose allowing muliple selections in the Open Dialog as a workaround. These files could then be sorted with your new button. Those will sort fine using strverscmp(). Why would I want multiple selections?

[Cyberia]

So you can get them in the list quickly. autoloading fails on this naming scheme, requiring you to add each file.

Conversley, you could add an 'Add All' button, but multi-select is more versatile and I think it should be easier to code, since it's just a different parameter on the API call.

[Guest]

Oh, duh. I forgot I have to get them into the list box before I can sort them.

How about drag and drop?

What exactly do you mean by "multi-select"?

[Cyberia]

Originally posted by neuron2
What exactly do you mean by "multi-select"?
When the user clicks "Add", and the File Select dialog appears, I can use SHIFT, CTRL and a mouse box to select/deselect files. Then when I click OPEN, all selected files are added to the list on the File Open dialog.

From there the user can proceed normally. (and sort if necessary)

Originally posted by neuron2
How about drag and drop?
Yet another related issue. I don't mean to dump multiple issues on you here, but this is another issue in the same vein that needs adddressed. I imagine that drag-and-droped file(s) should automatically open the File Open dialog and add all dragged files to the list.

From there the user can proceed normally. (and sort if necessary)

Those would be the two primary ways to load the GUI. Both of these methods forever eliminate all issues related to naming conventions. They should both be easy to write I think (really really easy in VB :) )

They may also make the "Add Auto" button redundant.

Finally, you mentioned a Sort button. Good idea. Please give some though to the "Move Up" and "Move Down" button idea.

I think we can cover all the bases (forever) if the File Open dialog has these options:
Add
Delete
Delete All
Sort
Move Up
Move Down

I can't imagine a scenario this doesn't cover.

[Guest]

@Cyberia

I like your proposal. Thank you.

[Zarxrax]

I just downloaded the 1.1.0 release version, and I am having a great deal of difficulty with it. If I scroll the frame indicator past the end, it wraps back over to the beginning! For instance, if I set the In Point to somewhere around the middle, and I want to set the Out Point at the very end, this appears to be very difficult to do now. If I drag past the end, the marker goes back over to the beginning. If I drag NEAR the end, and then use the right arrow key to scroll, it will still go back around to the beginning. If I want to get to the VERY end, it seems the only thing you can do is scroll to the last recognizable frame, then count how many more you can go before it rolls back around to the beginning, and then go back and go 1 less than that :|

[Guest]

Oops. I'll fix that straight away. Your workaround: position as close to the end as you can, hit F6 and wait until the end, and then hit ].

[dragongodz]

hmmm wouldnt it have made more sense to close this thread and not the "DGMPGDec 1.1.0 final" thread ? i mean that is what the 1.1.0 release is and not DVD2Avidg as the name of this thread says.

anyway since i can not post in the final thread i will do it here. this is for people who want a working(turns off and on) horizontal scrollbar in the open files dialog of DGIndex.

now it is a simple solution and just goes on length of the filenames. now neuron2 pointed out he uses system fonts and not specific ones. this means a persons windows fonts settings may screw this up. such as a thin font may cause the Hscroll to activate before the filenames reach the edge, not a big deal. or a really wide font may cause HScroll not to activate until a few letters are already past the edge.
now i tried a few things and couldnt get these to happen so i am releasing this test version to see if anyone can so they can let us know. if nobody can show how to do it then it should be safe to use as-is really.

included in the zip is the source file i changed with comments above the changes so they are easy for anyone to find.
also included is some source(thanks to neuron2 for the link to it) for doing it properly so it doesnt matter what font would be used. why havent i done it that way ? i have not had any time because of personal matters. so i release this as i said for people to test and report.

WARNING - this is for testing the horizontal scroll only. it is a debug compile etc and should not be used beyond said testing. the download will only be available for a few days for this reason aswell.

http://www.pcpages.com/dragongodz2/

[Cyberia]

Tried it, and it works fine.

Why does the H scroll bar scroll so far beyond the text?

[Guest]

Dragon, I can easily make it fail. I am not happy to have you releasing stuff like that. We've been in touch, I am aware of the issue. There is currently not a solution. When you have one, you can send it to me.

I'm sorry I am working on much more serious trackbar issues right now, and I didn't get around to telling you how to break your change. Just make a really extreme font change. I sent you the code to query the system font metrics to do it properly, but I guess you didn't think it was needed.

Anyway, do we really need a development branch to address this? What are you trying to prove and is this the right way?

[dragongodz]

I am not happy to have you releasing stuff like that
why ? it is a short term release which i gave a heap of warnings that it was to test 1 gui thing only and should not be used for anything else.

I sent you the code to query the system font metrics to do it properly, but I guess you didn't think it was needed.
to quoute my previous message
also included is some source(thanks to neuron2 for the link to it) for doing it properly so it doesnt matter what font would be used. why havent i done it that way ? i have not had any time because of personal matters. so i release this as i said for people to test and report.
so i already said its not the 100% proper way and included the source if someone wants to take a stab at it.

I didn't get around to telling you how to break your change. Just make a really extreme font change.
yes you said making an extreme font change may break it but what font change ? infact i will quote my last post again
this means a persons windows fonts settings may screw this up. such as a thin font may cause the Hscroll to activate before the filenames reach the edge, not a big deal. or a really wide font may cause HScroll not to activate until a few letters are already past the edge.
now i tried a few things and couldnt get these to happen

do we really need a development branch to address this?
i wouldnt call 1 short term test release for 1 specific gui problem a development branch.

What are you trying to prove and is this the right way?
prove ? not a thing. i simply wanted to know if anyone could give me an actual example on how to make the changes i did fail. if i cant see it failing i cant see it being fixed either.

fine though it has been removed and i will leave it at that.