DVD2AVIdg/MPEG2DEC3dg 1.1.0 Release Version

[Guest]

EDIT 4-28-2004: I've updated this first post with the most recent 1.1.0 release information. The remainder of the thread now serves as an archive for the development discussion. Thank you to all particiapants for your valuable assistance.

As promised, I have made a new release 1.1.0 with some fixes. Please post feedback to this thread. Thank you.

Some further fixes are still in progress and, of course, many enhancements can be started when the fixes are complete.

Get version 1.1.0 here:

http://neuron2.net/fixd2v/decodefix.html

Following are the changes for this version:

---------------------------------------------------------
DVD2AVIdg/MPEG2DEC3dg Functional Changes
(versus DVD2AVIdg/MPEG2DEC3dg 1.0.0)
---------------------------------------------------------

DVD2AVIdg/MPEG2DEC3dg Version 1.1.0

1. Correct the version string reported in the About box.
1.1.0RC4.

2. Fix or disable "Save AVI" functionality. (see below)
Disabled.

3. Uninitialized motion_type in macroblock_modes() [Lord KiRon]
Fixed in both DVD2AVIdg and MPEG2DEC3dg.

4. Improved random navigation performance.
Greatly improved. Works only for dg-style D2V files. Requires
new versions of both DVD2AVIdg and MPEG2DEC3dg.

5. Fix case presentation for CLI file names (don't map to all upper case).
Fixed.

6. Better auto-loading of multiple VOBs [Cyberia]
a) Auto-load more than 0-9 files at a time
Fixed.
b) Ability to disable auto-loading on Open dialog
Fixed.

7. Fix drag-and-drop loading [Cyberia]
a) Always load ALL dropped files
Fixed (but still needs sorting).
b) Never auto-load from drag-and-drop (load ONLY dropped files)
Fixed.

8. CLI support for selection of 1.76 vs. dg style project files.
Fixed. Use -DF=0 for 1.76 style; -DF=1 for new style.

9. Change trackbar pitch from 500 to 2000. Gives better trackbar
resolution for large files. [DG]
Fixed.

10. Because of the changes you made to NextFile() in getbit.c,
the last file now "wraps around" as indicated by your comment.
However this doesn't stop the audio from being demuxed. As a result,
if the VOB has audio packets before the first video packet (mostly
happens when processing VOBs demuxed by CellId), audio frames from
the start will be appended. The resulting file is not accepted by
Maestro, for instance. Fixed by adding a check for Dry == true in
the audio demuxing code. [RB]
Fixed.

11. Fix "Cannot step backwards across VOB boundary" [Cyberia]
Fixed.

12. Add a delete all files button to the file list dialog. [Cyberia]
Fixed.

13. Maximum number of frames per GOP increased from 50 to 500 (some
nonstandard streams were failing). [Fred Thompson]
Fixed.

14. Trackbar positioning and marking is quirky. E.g.,
after loading, the trackbar is not positioned on the first GOP, and
putting the trackbar at the end does not position to the last GOP. [Cyberia]
Fixed. Still not perfect but much better.

15. Record aspect ratio information in the D2V file.
Added for new style D2V file format only.

16. Video item of menu bar stays grayed after file load until the mouse
is placed over it.
Fixed.

17. The "Save BMP" command now does not require the color space to be set
to RGB24 (it now sets it automatically and restores it to YUV if needed),
it was moved to the File menu, and a file dialog now allows specification of
the save file name and location.
Fixed.

18. Need a Play command that starts playing from the current trackbar position
to the end, regardless of the left and right mark positions.
Fixed.

19. Add a link to my web site on the Help menu.
Fixed.

20. Rearranged menu layout and made the menu enables/disables more rational.
Fixed.

21. Added versions of ParseD2V and FixD2V that work with the new release. ParseD2V now shows much more information.

[Guest]

The backward VOB stepping is not yet fully reliable. Back to the drawing board. :confused:

[Cyberia]

Definately faster seeking! Much improved, but there are still a few issues:

Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0

Do we need Auto Open on the File menu? It doesn't save a single click even. It does let you perform a double-click rather than two single clicks, but that's not much. I don't mean to be critical of this, just I don't see any real benefit. ;)

It would also be nice to have a 'Clear All' button on the Open dialog. I realized this by auto-adding a VOB with 245 segments. "Now, how do I rid of all these?" :0

Are you just disabling SaveAVI, or removing it entirely? You could probably also disable 'Colorspace' and 'YUV -> RGB'.

On that note, there are a number of other GUI options of dubious value. This would be mostly cosmetic.

[Guest]

Originally posted by Cyberia
Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0 Can't duplicate. Please either explain better or make the VOB available for download. Does it fail like this in version 1.0.0?

Do we need Auto Open on the File menu? It doesn't save a single click even. It does let you perform a double-click rather than two single clicks, but that's not much. I don't mean to be critical of this, just I don't see any real benefit. ;) Huh? If I have spider_0.vob and spider_1.vob, I can get both into my list with one open dialog. What are you talking about??????????

It would also be nice to have a 'Clear All' button on the Open dialog. I realized this by auto-adding a VOB with 245 segments. "Now, how do I rid of all these?" :0 I'll make one.

Are you just disabling SaveAVI, or removing it entirely? You could probably also disable 'Colorspace' and 'YUV -> RGB'. OK.

[Cyberia]

quote:
--------------------------------------------------------------------------------
Originally posted by Cyberia
Selection Buttons - When a VOB loads the whole file is selected and slider is at zero. Move the slider about an inch to the right and press 'End Marker'. Now move slider all the way right and press 'End Marker' again. Not all the file gets selected, in fact the slider bar moves left too. :0
--------------------------------------------------------------------------------

Can't duplicate. Please either explain better or make the VOB available for download. Does it fail like this in version 1.0.0?


I cant find a VOB where it doesn't happen. Here's whats happening: When you click 'End Marker' with the slider positioned at the end of the the bar, the slider moves back to the last GOP. It might be hard to see in large VOBs. Try opening one split by cell-id. Also try opening a small VOB and then just click 'End Marker' and watch the slider.

I can make a sample available if necessary.

When the file opens, should the slider bar be positioned at the first GOP, not at the first frame? (I believe it should be)

Now the Auto-open issue:
Ahh I see the advantage. Its on the backside of selecting the file, not the frontside. ie: Double-click the start file and your done! Got it.

[zettai]

I'm getting lots of macroblocks that are parts of a frame that was at least 30 frames previous to this one, so possibly from the gop before?

http://www.amvs.34sp.com/ewwblocks.jpg

This only flashes up for a frame before disappearing but it's a recurring problem.

This is in a lot of different places in the first thing I tested when using the new versions, so I'm surprised it wasn't spotted. I can make a sample if required but I'm expecting that it should appear on a lot of different things.

This was a hybrid source, no RFF flags so no force film - I just made the new project file as I always do. This same rip worked fine with the 1.0.0 version the other day.

[Wilbert]

"You could probably also disable 'Colorspace' and 'YUV -> RGB'."

OK.

Why? There are still people who use vfapi?

[Guest]

Originally posted by zettai
I'm getting lots of macroblocks that are parts of a frame that was at least 30 frames previous to this one, so possibly from the gop before? I need to fix this first.

Which D2V format are you using? Do you see it in DVD2AVI preview, or only after decoing with MPEG2DEC3dg? If the latter, what is your script?

Please make a VOB available for downloading.

[zettai]

OK, I'm cutting a vob now, once I find a small section that shows the problem.

I made a new type d2v and decoded simply with

MPEG2Source("J:\SUPER_GALS_2\VIDEO_TS\supernew.d2v")

just give me a min to get the vob done.

I dont seeit in the preview but I'm not likely to if that's all keyframes.

[zettai]

OK, I've worked out that the frames only appear when scrubbing the trackbar in virtualdubmod.

Here's a vob:

http://www.amvs.34sp.com/test2.rar

If you frame advance forwards it's fine but if you do a lot of scrubbing you will often see this happen in frame 75 and some other frames too.

[puschpull]

Hallo!

I have bug, why i load *.d2v project in GordianKnot 0.28.8 !!
:-)

Normal, why i use d2v in Avisynth/VDubMod is all OK

[Cyberia]

I have uploaded a sample VOB here (http://home.insightbb.com/~cyberia-1/VOB/vts_04_31.vob)

[Guest]

Originally posted by zettai
Here's a vob:

http://www.amvs.34sp.com/test2.rar
My WinRAR says the file CRC is bad and the file is corrupt. Can you check it please?

[Guest]

Originally posted by puschpull
I have bug, why i load *.d2v project in GordianKnot 0.28.8 !!
:-)

Normal, why i use d2v in Avisynth/VDubMod is all OK Any chance you could tell me what the bug is? Thank you.

[Guest]

Originally posted by Wilbert
Why? There are still people who use vfapi? Please elaborate as I didn't get your point.

[Guest]

Originally posted by Cyberia
I have uploaded a sample VOB here (http://home.insightbb.com/~cyberia-1/VOB/vts_04_31.vob) Thanks, Cyb. I'll address this after zettai's nasty bug find. BTW, I've added the delete all button and got backward stepping across files finally nailed down.

[Guest]

Originally posted by neuron2
My WinRAR says the file CRC is bad and the file is corrupt. Can you check it please? Strangely enough, I've duplicated your issue using Cyberia's VOB! Still, if you correct the file I'll ensure that the fix works with it also.

[puschpull]

neuron2: Sorry ! :-)

The Bug:

When i make *.d2v with "old" DVD2AVI
http://puschpull.org/root/problem_new_dvd2avi_2.png

If i open this project in Gordion knot
http://puschpull.org/root/problem_new_dvd2avi_3.png

http://puschpull.org/root/problem_new_dvd2avi_4.png

then is all normal, OK

But, when i make *.d2v with "new: DVD2AVI
http://puschpull.org/root/problem_new_dvd2avi_1.png

Gordian Knot has problem:
http://puschpull.org/root/problem_new_dvd2avi_5.png


If i use "new" *.d2v file in VirtualDubMod /Avisynth, so isn't no problem

:-)

puschpull
(http://puschpull.org)

[zettai]

Originally posted by neuron2
Strangely enough, I've duplicated your issue using Cyberia's VOB! Still, if you correct the file I'll ensure that the fix works with it also.

Ack! Sorry, I didnt check the upload... it hadn't fully uploaded :(

It's uploaded fully now. ><

[Guest]

Thanks, zettai.

I've fixed this bug and released beta 2. It also includes the new delete all button on the file list dialog, suggested by Cyberia.

http://neuron2.net/fixd2v/decodefix110b2.zip

[zettai]

Excellent! It all looks great from here, I'll let know know if I find any more bugs but that one has definitely been squished.

[Wilbert]

Please elaborate as I didn't get your point.
That setting "corrects" the luma range ([16,235]->[0,255]), when opening this d2v in vfapi/tmpgenc (which needs rgb24). This setting is stored in the d2v.

I was quite sure you knew that :confused:

[Cyberia]

The selection markers are still acting funny. You didn't mention it, so I assume you didn't fix it. (I am a master of deductive reasoning)

Anyways, here is some more info about it:
If you move the slider quickly all the way right, the frame displayed is not necessarliy the frame at the current marker position. I can duplicate this easily by moving the slider quick enough.

If you do this, and then click 'end marker' then the selection is marked at the displayed frame, not the slider position. Thats whats happening.

[Cyberia]

This is a enhancement suggestion: right-clicking on the display area currently does nothing. How about toggling Preview/Stop on a right-click. If it's currently stopped, a right-click starts it, and vice versa.

[DDogg]

Really good to see you back, Don :-D

I regret a problem report (Beta2).

1> Prepared D2V using standard VOB source, FF, no audio.
2> Noticed MPC would not "play" this D2V
3> Used script:
loadplugin("d:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("d:\wutemp\testDG.d2v")
4> Got unrecognized exception line #2

[Guest]

Originally posted by DDogg
Really good to see you back, Don :-D

I regret a problem report (Beta2).

1> Prepared D2V using standard VOB source, FF, no audio.
2> Noticed MPC would not "play" this D2V
3> Used script:
loadplugin("d:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("d:\wutemp\testDG.d2v")
4> Got unrecognized exception line #2 WHat is MPC and where do I get it?

[zettai]

MPC is just Media Player Classic - gabest's MP6.4 alternative. It should be the same error in virutaldub, windows media player etc.

In my experience the unrecognized exception error is usually one of two things:

1) Project file format incompatible with mpeg2dec

2) Project created with processor settings that are not suitable for the user's cpu (sometimes sue to using a bad dvd2avi.ini or setting it up wrong).

[DDogg]

Originally posted by Neuron2
WHat is MPC and where do I get it? That was really an aside comment, as I normally first check a d2v with Gabest's Media Player Classic (http://gabest.org/).

The error reported was when the script was played as normal in WMP or VDub.

/add:zettai, note I said MPC would not "play" the D2V

[zettai]

Originally posted by DDogg
/add:zettai, note I said MPC would not "play" the D2V

It's not likely to as the d2v format has changed with this beta and Media Player Classic has not been updated to acknowledge these changes in its internal d2v processor.

[DDogg]

jeeze, I'm sorry I confused the issue by mentioning it.

[ssjkakaroto]

thx a lot for continue developing dvd2avi neuron2 :)

[Guest]

Originally posted by DDogg
jeeze, I'm sorry I confused the issue by mentioning it. Don't be sorry. Whoever writes MPC needs to be aware of it!

[DDogg]

Don, just to clarify, you do understand I was saying that beta2 crashes in normal use? Any d2v created by it is unusable in any application on my AMD XP machine.

[Guest]

I had to release a beta 3. The fix for zettai's issue had actually negated the improved random navigation speed! So now that is back and hopefully zettai's issue is not. :) It also may fix DDogg's issue. Please advise.

I have noted the enhancement requests.

I suggest that the GK incompatibility be deferred until we have a good stable version. It is too early to be thinking about revising the other tools.

So now I will look at Cyberia's marking/positioning strangenesses and the other outstanding fixes requiring submission of VOBs (Fred and Lord KiRon). Of course if DDogg is still suffering we'll have to throw him a bone.

http://neuron2.net/fixd2v/decodefix110b3.zip

[Guest]

Originally posted by ssjkakaroto
thx a lot for continue developing dvd2avi neuron2 :) Thank you for the kind words and thanks to all for assisting me with feedback, enhancement ideas, and patience with early betas. :p

[DDogg]

Don, same thing, Exception error. It seems strange that nobody else has reported this. I hope it is not one of those one-off conflict things. They are a bear to chase down.

I suppose I should check non FF. Will do and edit back. This is just the most basic test I could imagine. -

loadplugin("D:\wutemp\MPEG2Dec3dg.dll")
mpeg2source("D:\wutemp\testDG.d2v")


DVD2AVIProjectFile
6
24 I:\VIDEO_TS\VTS_04_1.VOB
24 I:\VIDEO_TS\VTS_04_2.VOB
24 I:\VIDEO_TS\VTS_04_3.VOB
24 I:\VIDEO_TS\VTS_04_4.VOB
24 I:\VIDEO_TS\VTS_04_5.VOB
24 I:\VIDEO_TS\VTS_04_6.VOB

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=1 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=23976
Location=0,0,5,2394

7 0 0 12 13 10 11 12 13 10 11 12 13
7 0 B 0 1 12 13 10 11 12 13 10 11 12 13
7 0 26 0 1 12 13 10 11 12 13 10 11 12 13
7 0 4E 10 11
7 0 59 12 13 10 11 12 13 10 11 12
7 0 E3 3 10 11 12 13 10 11 12 13 10 11
7 0 18D 12 13 10 11 12 13 10 11 12 13 10 11
7 0 241 12 13 10 11 12 13 10 11 12 13 10 11
7 0 2F5 12 13 10 11 12 13 10 11 12 13 10 11
7 0 3A7 12 13 10 11 12 13 10 11 12 13 10 11
7 0 458 12 13 10 11 12 13 10 11 12 13 10 11
7 0 50A 12 13 10 11 12 13 10 11 12 13 10 11
7 0 5BF 12 13 10 11 12 13 10 11 12 13 10 11
7 0 672 12 13 10 11 12 13 10 11 12 13 10 11
7 0 724 12 13 10 11 12 13 10 11 12 13 10 11
7 0 7D6 12 13 10 11 12 13 10 11 12 13 10 11
7 0 887 12 13 10 11 12 13 10 11 12
7 0 912 13 10 11 12 13 10 11 12 13 10 11 12 13 10
7 0 9D9 11 12 13 10 11 12 13 10 11 12
7 0 A78 13 10 11 12 13 10 11 12 13 10
7 0 B0F 11 12 13 10 11 12 13 10 11 12 13 10
7 0 BE1 1 2 13 10 11 12 13 10 11 12 13 10
7 0 CC5 1 2 13 10 11 12 13 10 11 12 13 10
<snip>

[Guest]

Are you SURE SURE SURE you are using the correct MPEG2Dec3dg.dll? Please triple check. Use a full path to load it.

Go down to one VOB only (the first) to try to reduce variables. You're going to have to create a scenario I can duplicate. Does the error occur on initial loading? Try to make a single VOB as small as possible that exhibits the problem.

And yes, try no FF also.

Note I have AMD XP also and see no problems.

[DDogg]

It works with FF turned off. I wanted to get that info to you, but will try to pin it down more now that it sounds more specific to my situation. If you notice the script, I did take pains to isolate and load the correct mpeg2dec3DG.dll that I specifically took from the beta 3 build.

/Add1: Grabbing a single VOB down the chain is working FF, back in a bit

[Guest]

Right, sorry, I didn't notice your path.

I doubt it's so specific to you. It's just that you've stumbled on an error case, I'd guess. The key is to get me a VOB that I can use to duplicate the issue. Thanks.

[Cyberia]

@Neuron2: I have a sample VOB demonstrating this problem here (http://home.insightbb.com/~cyberia-1/VOB/vts_01_223.vob)

Build a project with Force-Film turned on.

[Guest]

Originally posted by Cyberia
@Neuron2: I have a sample VOB demonstrating this problem here (http://home.insightbb.com/~cyberia-1/VOB/vts_01_223.vob)

Build a project with Force-Film turned on. Dead link. :(

[Cyberia]

Fixed. Try again, please.

[Guest]

Got it. Thank you.

EDIT: Ooh, a tiny VOB. I love you man! No stepping through 100's of iterations of the parsing loop. :D

EDIT2: Now why would the esteemed Cyberia be applying FF to a VOB with no repeat flags set? Sheer perverseness I am sure. :) Nevertheless, it does show me where I went wrong. It affects only FF. This one will take a day or two as I forgot how FF works. :)

DDogg, relax. This VOB tells me everything I need to know.

[DDogg]

Cool, the odd thing seemed to be that only when all 6 vobs were processed together would the problem appear. Each by themselves would not, although I had not quite finished checking it properly.

Cyberia, WTG.

[Cyberia]

Thanks. I think it happens when you try to apply FF to NTSC material. Most movies contain some of this footage at some point.

I was able to isolate it by using smaller and smaller sets of VOBs (cause I often split by cell-id) until I had just one VOB that crashed.

[Guest]

OK, here's the fix. :)

This beta also fixes these:

1. After file load, trackbar is now on the first GOP.
2. Begin marking ([ button) works sensibly.

I still need to do the end marking and trackbar stuff.

http://neuron2.net/fixd2v/decodefix110b4.zip

[DDogg]

Yep, working fine. So much for "This one will take a day or two as I forgot how FF works." - FF must be like a bicycle? :)

[puschpull]

neuron2:

In this version (Beta4)
load *.dv2 in GordianKnot without this message:
http://puschpull.org/root/problem_new_dvd2avi_5.png

but screen is empty (black)
http://puschpull.org/root/problem_new_dvd2avi_6.png
and project "No Frames"

In previous version: "1.77.3dg1.0.0 RC2" load GK files d2v correct
http://puschpull.org/root/problem_new_dvd2avi_7.png


DVD2AVIProjectFile
1
37 D:\Project_Filmy\HPIIVob\vts_01_8.vob

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=0 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=25000
Location=0,0,0,91D0

7 0 0 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 10 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 20 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
7 0 30 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2



in this new version: "1.77.3dg1.1.0 beta4" load GK d2v file with null frames



DVD2AVIProjectFile
1
37 D:\Project_Filmy\HPIIVob\vts_01_8.vob

Stream_Type=1,0,0
iDCT_Algorithm=2 (1:MMX 2:SSEMMX 3:FPU 4:REF 5:SSE2MMX)
YUVRGB_Scale=1 (0:TVScale 1:PCScale)
Luminance_Filter=0,0 (Gamma, Offset)
Picture_Size=0,0,0,0,0,0 (ClipLeft, ClipRight, ClipTop, ClipBottom)
Field_Operation=0 (0:None 1:ForcedFILM 2:SwapOrder)
Frame_Rate=25000
Location=0,0,0,91D0

7 0 0 12 12 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 10 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 20 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12
7 0 30 2 2 12 12 12 12 12 12 12 12 12 12 12 12 12


Is this problem with GK (0.28.8) ?
Otherwise with 1.77.3dg1.1.0 ?

:-)

[zettai]

Gordian Knot uses it's own (older) version of mpeg2dec.dll so you can't expect it to work with the new d2v files.

[puschpull]

zettai: OK !

Problem is in side Gordian Knot, yes?