Log in

View Full Version : TIVTC for VapourSynth


jackoneill
13th March 2021, 15:23
What do you think?

https://github.com/dubhater/vapoursynth-tivtc

ChaosKing
13th March 2021, 16:08
Nice!
But isn't vivtc = tivtc?

jackoneill
13th March 2021, 16:28
Nice!
But isn't vivtc = tivtc?

Not completely. Mostly VIVTC does fewer things.

Izuchi
14th March 2021, 16:17
So is this meant to supersede VIVTC?

DJATOM
14th March 2021, 18:22
Is it final? I compiled it yesterday and tried to make 2pass vfr, but it writes empty metric files. I didn't reported since assumed it might be a WIP.

ChaosKing
14th March 2021, 19:07
I tested it with my "problematic" DVD and I must say vivtc performed better (with same settings, maybe some other default values are different). TIVTC missed some frames. Both seem equally fast.

Bonus point for tivtc: d2v input (idk what it does exactly but at least it reported the correct field order :p)

jackoneill
14th March 2021, 20:08
@Izuchi: It's not meant to supersede VIVTC. I don't know, use whichever you prefer.

@DJATOM: It's final in the sense that I thought I was done. But I only tested TDecimate with modes 0 and 1, with default settings. I tested mode 4 just now and it wrote the metrics in the output file. Can you step through TDecimate::~TDecimate to see where it fails?

@ChaosKing: If the Avisynth version makes the same mistakes, then it's okay.

DJATOM
14th March 2021, 20:19
It seems with doodle1 version TDecimate::~TDecimate is never called. Weird. Vanilla VS works as expected.

Selur
14th March 2021, 20:28
Nice!

ChaosKing
14th March 2021, 23:18
@ChaosKing: If the Avisynth version makes the same mistakes, then it's okay.

I just re-checked and the avisynth version does not have these mistakes.

EDIT:
See PM for sample vob.

Myrsloik
15th March 2021, 10:54
Nice!
But isn't vivtc = tivtc?

VIVTC is basically a reimplementation of TIVTC and only borrows two (I think) heavily refactored field matching metric calculation functions. The rest is implemented more or less based on common sense/TIVTC documentation description which means it doesn't match the actual TIVTC behavior at all.

jackoneill
17th March 2021, 18:38
v2 fixes this bug (https://github.com/dubhater/vapoursynth-tivtc/releases/tag/v2):

I tested it with my "problematic" DVD and I must say vivtc performed better (with same settings, maybe some other default values are different). TIVTC missed some frames.

And DJATOM added frame durations for modes 5 and 6.

ChaosKing
17th March 2021, 18:53
Nice. The bug is gone now. I love this kind of typos. Everything seems to work but not really and you spend hours to figure out what is wrong :D
Output looks now identical to avs ivtc :cool:

p.s. ivtc package added to vsrepo git, but not uploaded yet!