Log in

View Full Version : KPassFilterCL and PassFilter


real.finder
3rd December 2020, 11:13
since KPassFilterCL is removed by Khanattila and the source code is missed as said here http://avisynth.nl/index.php/KPassFilterCL

can someone build PassFilter https://github.com/Khanattila/PassFilter/ ? I think it made as replacement for KPassFilterCL

DJATOM
3rd December 2020, 17:40
https://mega.nz/file/j0k2iaiB#q4hKrjUrjgUdyh8FuB6lTPy3gDw2QccdoGEda1hMmus - x64 build.

real.finder
3rd December 2020, 22:23
https://mega.nz/file/j0k2iaiB#q4hKrjUrjgUdyh8FuB6lTPy3gDw2QccdoGEda1hMmus - x64 build.

thanks, but I got
https://i.postimg.cc/fbp3MLvd/New-File-5-001531.png (https://postimages.org/)

noisyfart
3rd December 2020, 23:24
thanks, but I got
https://i.postimg.cc/fbp3MLvd/New-File-5-001531.png (https://postimages.org/)
Run avsmeter -avsinfo, it should tell you what is missing.

StainlessS
3rd December 2020, 23:34
Run avsmeter -avsinfo, it should tell you what is missing.

From AvsInfoTool [x64 mode], {avsmeter64 avsinfo produces pretty much same message. [dont use -avsinfo, no hyphen(-) in recent versions]}
Cannot load file 'C:/VideoTools/AvisynthRepository/AVSPLUS_x64/plugins/PassFilter.dll'. Platform returned code 126:
The specified module could not be found.

Dependencies that could not be loaded:
fftw3f.dll

Problem is that it is [the x64 plugin] looking for fftw3f.dll in system32, where it should be looking for fftw3.dll or libfftw3f-3.dll,
if one renames/copies the file in system32 to "fftw3.dll" then works OK, # EDIT: ""fftw3f.dll"" Was typo, see below EDIT
however, that is NON-STANDARD name and do not suggest doing so long term, as will result in yet another
duplicate file with another alternate dll name.

Name needs to be fixed in source code.

EDIT: Fixed, was fftw3f.dll

if one renames/copies the file in system32 to "fftw3.dll" then works OK,

noisyfart
4th December 2020, 01:17
[dont use -avsinfo, no hyphen(-) in recent versions]}.I think this was changed again recently due to user request, for me only -avsinfo works in latest version.

StainlessS
4th December 2020, 01:36
Thanks, I've got current version but am using old one, that G2K4, such a ditherer. [so as to speak]

real.finder
4th December 2020, 09:27
it seems this plugin not finished yet, it only has LowPassFilter while the old KPassFilterCL has LowPass, HighPass, BandPass, MergeLow, MergeHigh, and MergeBand

fftw3 better be called when the filtter is used (called in script) not when plugin loaded, like how mvtools and ff3dfilter did

ChaosKing
4th December 2020, 11:57
architecture: x86_64
machine name: AMD AMD64 (x64)
subsystem: Windows GUI
DLL: yes
stripped: no
file version: 0.0
minimum Windows version: 6.0
IMPORTS
fftw3f.dll
VCRUNTIME140_1.dll
VCRUNTIME140.dll
api-ms-win-crt-heap-l1-1-0.dll
api-ms-win-crt-runtime-l1-1-0.dll
KERNEL32.dll
api-ms-win-crt-math-l1-1-0.dll
EXPORTS
PassFilter.dll: AvisynthPluginInit3 @ 1
PassFilter.dll: VapourSynthPluginInit @ 2

I had to rename libfftw3f-3.dll to fftw3f.dll, but it crashes in vapoursynth.
Maybe libfftw3f-3 is not fftw3f? :/

StainlessS
4th December 2020, 13:57
I had to rename libfftw3f-3.dll to fftw3f.dll, but it crashes in vapoursynth.
Maybe libfftw3f-3 is not fftw3f? :/

OOps sorry lads, typo. I cocked it up good. :(

if one renames/copies the file in system32 to "fftw3f.dll" then works OK,
Should have been
if one renames/copies the file in system32 to "fftw3.dll" then works OK,

Fixed in post.
Good names in BLUE

Problem is that it is [the x64 plugin] looking for fftw3f.dll in system32, where it should be looking for fftw3.dll or libfftw3f-3.dll

Some filters use name fftw3.dll , and others use name libfftw3f-3.dll , and some [recent ones] can use either name.

DJATOM
4th December 2020, 13:58
https://mega.nz/file/X5tkiIqC#yL0Yfm92A8RW8NOvBzuCeOitR6iggD7IIPDI1Orxh7s
Try that dll, I have linked against self-compiled lib.

StainlessS
4th December 2020, 14:31
DJATOM,
Try that dll, I have linked against self-compiled lib.
That fftw3f.dll will only be used by your PassFilter.dll, and not eg FFT3DFilter or DftTest or other filters accessing that library.

The problem is that the x64 system32 dll should be using the same name as already used by other existing filters,
you are just making a requirement for another identical functioning dll with a third alternative name, ie "fftw3f.dll".
Names already in-use by other plugins are fftw3.dll , and libfftw3f-3.dll , the dll should maybe simply be named eg fftw3.dll,
and accessed as such from within Passfilter.dll source code. [so that it looks for fftw3.dll].
[More recent plugins are now loading the dll by either names fftw3.dll / libfftw3f-3.dll, so will work if either named dll is present in system32]

Everytime there is an update to the http://www.fftw.org/ dll, then users now have to copy/rename to two dlls for system32,
unless fixed, then they would have to copy/rename to three alternative dll names.
[two is a bits nuts, three is just silly]

EDIT: And remove the link to fftw3f.7z in prev post, it will just cause future confusion.
[the dll's people already have in system32 will work just fine]

Here is where the original x64 PassFilter problem is [in x64 Dependency Walker : Should be fftw3.dll, EDIT: or libfftw3f-3.dl]
https://i.postimg.cc/59KgSGz5/Untitled.jpg (https://postimages.org/)

DJATOM
5th December 2020, 10:57
It will require new compilation of fftw3 library which I don't want to do. Perhaps someone else want to do that and provide lib files which I can link against...

StainlessS
5th December 2020, 17:24
OK, I thought it would be just a simple change of text in PassFilter source code,
I can't do it, I got way too much on my plate at the moment.
I guess people could [if they really wanted it] just copy the fftw3.dll to required fftw3f.dll in system32 and hope somebody
does it proper at some point, to get rid of the third alternate named dll.

Khanattila
19th December 2020, 12:18
Enjoy it: https://github.com/Khanattila/KPassFilterCL

real.finder
3rd February 2021, 06:16
Enjoy it: https://github.com/Khanattila/KPassFilterCL

thanks, but seems both PassFilter and KPassFilterCL are unfinished, I just play with it to remove only Rainbow and Dot Crawl without much damage, info=true are not work at least in KMergeLow, "phase" mode not work with opencl of intel cpu

also have same questions as https://forum.doom9.org/showpost.php?p=1806849&postcount=1192