TCanny

[HolyWu]

https://github.com/HomeOfVapourSynthEvolution/VapourSynth-TCanny

As the Canny filter in GenericFilters has line shift problem and the plugin is likely to be obsolete, hence here is the port.

[Myrsloik]

TCanny-r1.7z (https://github.com/HomeOfVapourSynthEvolution/VapourSynth-TCanny/releases/latest)
https://github.com/HomeOfVapourSynthEvolution/VapourSynth-TCanny

As the Canny filter in GenericFilters has line shift problem and the plugin is likely to be obsolete, hence here is the port.

I do plan to make canny a part of the core. Just need a bit of time to write a sane implementation. The old one isn't going away until then...

[HolyWu]

Update r2.


Skip direction calculation for mode=1.
Add op parameter.


Update r3.


Add "gaussian blur only" mode.
Support 32-bit float input.

[HolyWu]

Update r4.


The parameter value is now scaled in a saner way.
Speed up gaussian blur's code and add SIMD optimization.


Update r5.


Fix an error in SIMD code of the Sobel operator.

[HolyWu]

Update r6.


Add the Scharr operator.
Remove the nms parameter.
Optimize the gaussian blur function.
Vectorize the non-maximum suppression function.
Vectorize the output functions of mode -1, 0 and 1.
Now uses per thread buffer allocation instead of per frame.

[Mystery Keeper]

Thank you for your great work. Could you please not make several libs, but instead do CPU detection in plugin initialization and choose the best available optimizations?

[HolyWu]

Thank you for your great work. Could you please not make several libs, but instead do CPU detection in plugin initialization and choose the best available optimizations?

Done in r7 and added opt parameter.

[Mystery Keeper]

Great! Thank you very much!

[HolyWu]

Update r8.


Change sigma parameter to array type.

[hydra3333]

Thank you.

[groucho86]

I'm unable to compile on OS X (10.9.5). I'm using default autogen.sh + configure.

I get the following error:
CXX TCanny/TCanny.lo
error: invalid value 'c++14' in '-std=c++14'
make: *** [TCanny/TCanny.lo] Error 1

[Are_]

Outdated compiler (almost sure).

[groucho86]

g++ --version
gives me:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin13.4.0
Thread model: posix

I'll see if I can upgrade.

[KingLir]

I am getting the following errors when building on macOS, after autogen and configure. Anyone can assist ?

$ g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

$ make
TCanny/TCanny.cpp:579:27: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (buffer)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:586:27: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (blur)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:594:31: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (gradient)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:605:31: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (direction)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:616:31: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (label)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:622:38: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
} catch (const std::string & error) {
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:681:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "only constant format 8-16 bits integer ...
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:684:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "the clip's height must be greater than ...
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:688:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "more sigma given than the number of planes" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:728:23: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "sigma must be greater than or equa...
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:732:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "t_h must be greater than t_l" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:735:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "mode must be -1, 0, 1, 2 or 3" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:738:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "op must be 0, 1, 2 or 3" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:741:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "gmmax must be greater than or equal to 1.0" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:744:19: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "opt must be 0, 1, 2, 3 or 4" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:755:23: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "plane index out of range" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:758:23: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "plane specified twice" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:792:27: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
throw std::string { "malloc failure (weights)" };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
TCanny/TCanny.cpp:808:34: error: implicit instantiation of undefined template
'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >'
} catch (const std::string & error) {
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note:
template is declared here
class _LIBCPP_TYPE_VIS_ONLY basic_string;
^
19 errors generated.

[HolyWu]

I am getting the following errors when building on macOS, after autogen and configure. Anyone can assist ?

Try the latest commit. Somehow clang is somewhat stricter than gcc.

[KingLir]

Try the latest commit. Somehow clang is somewhat stricter than gcc.

Thanks. It's seems to fix the previous issues. Now getting:

CXXLD libtcanny.la
Undefined symbols for architecture x86_64:
"binarizeCE<float>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"binarizeCE<unsigned char>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"binarizeCE<unsigned short>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"discretizeGM<float>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"discretizeGM<unsigned char>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"discretizeGM<unsigned short>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"gaussianBlurVertical<float>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"gaussianBlurVertical<unsigned char>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"gaussianBlurVertical<unsigned short>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"copyData<float>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"copyData<unsigned char>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"copyData<unsigned short>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"outputGB<float>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"outputGB<unsigned char>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
"outputGB<unsigned short>", referenced from:
tcannyCreate(VSMap const*, VSMap*, void*, VSCore*, VSAPI const*) in TCanny.o
tcannyGetFrame(int, int, void**, void**, VSFrameContext*, VSCore*, VSAPI const*) in TCanny.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[HolyWu]

Thanks. It's seems to fix the previous issues. Now getting:

ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Does it make any difference if you use clang++ instead of clang for compilation and linking?

[KingLir]

Does it make any difference if you use clang++ instead of clang for compilation and linking?

This is what I have:
$ clang --version
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

You want me to test something else ? What exactly to change in configure ?

[Are_]

CC=clang CXX=clang++ ./configure
make V=1
That make switch will give better output for debugging your problem.

Oh, and it is usually better if you paste your _full_ log and your _full_ configure log when you want assistance with stuff like that (with some paste-site instead of raw printing it in the forums).

[KingLir]

CC=clang CXX=clang++ ./configure
make V=1
That make switch will give better output for debugging your problem.

Oh, and it is usually better if you paste your _full_ log and your _full_ configure log when you want assistance with stuff like that (with some paste-site instead of raw printing it in the forums).

Thanks and sorry for not doing it before. Here are the new logs:
http://pastebin.com/KLWSV1ZH

[jackoneill]

<nevermind>

[KingLir]

Anyone have an idea ?

[HolyWu]

Anyone have an idea ?

It should have been fixed now.

[KingLir]

It should have been fixed now.

Thanks! Seems to build OK.

[HolyWu]

Update r10.


Now the very border pixels are processed rather than zeroed out.
Remove mode 2 and 3.
Remove clamping for float sample type in mode -1 and 1.
Add TCannyCL filter.

[HolyWu]

Update r11.


TCannyCL: Fix build program failure in some locales.
TCannyCL: Store the compiled binary for reuse in the offline cache located in $HOME/.boost_compute on UNIX-like systems and in %APPDATA%/boost_compute on Windows.
TCannyCL: Change filter mode to completely parallel execution.

[edcrfv94]

Is it possible separate sigma_w and sigma_h? like muvsfunc sharpen.

[HolyWu]

Update r12.


Add parameter sigma_v.

[edcrfv94]

Update r12.


Add parameter sigma_v.


Thanks.