KNLMeansCL: OpenCL NLMeans de-noising algorithm [2018-01-29]

[Khanattila]

Same thing with the latest driver. Here is what Dep Walker has to say:
http://s21.postimg.org/wy7zauiiv/Image1.png

OpenCL 1.2 function is missing... great.

[Groucho2004]

Simply use KNLMeansCL(d=0) instead default KNLMeansCL(d=1).
Very definitely it does not work the same but is an attempt.
I can't try it because the mere presence of KNLMeansCL.dll in the autoload directory produces the error mesage. Using KNLMeans in a script produces the usual "There is no function named KNLMeansCL()".

[Groucho2004]

OpenCL 1.2 function is missing... great.
Do you think this is specific to the XP driver? I also have XP64, I might give that a try later.

[Reel.Deel]

I also get the same error as Groucho2004, when I put KNLMeansCL in the autoload folder. I'm on 64-bit Windows 7 using AviSynth+ r1576.

http://gpuz.techpowerup.com/15/10/14/x3m.png

[Sparktank]

Win7 (x64)
x86: AviSynth 2.60, build:Feb 20 2015 [03:16:45] (2.6.0.5)
http://i.imgur.com/CCgKDIg.gif

The new autoload picked NVidia by default.
Even though my old Intel supports OpenCL 1.2 FULL_PROFILE. (GPU Caps Viewer).

CPU: Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz
OpenCL 1.2 FULL_PROFILE.
ver: OpenCL 1.2 (Build 57)
driver: 5.0.0.57

GPU: NVIDIA CUDA
OpenCL 1.2 CUDA 7.5.0 FULL_PROFILE
ver: OpenCL 1.2 CUDA
Driver: 355.82

Same messy remux of Scream (Canada/Alliance)
Click pics to follow to original size (resized for forum).

KNLMeansCL (info=true)
http://i.imgur.com/4jmi0s2l.png (http://imgur.com/4jmi0s2)

KNLMeansCL ()
http://i.imgur.com/4ac12zyl.png (http://imgur.com/4ac12zy)

DGSource("E:\Work\Clips\Scream\Scream.dgi", crop_t=132, crop_b=140, debug=true)
http://i.imgur.com/HW3afhLl.png (http://imgur.com/HW3afhL)

DGSource("E:\Work\Clips\Scream\Scream.dgi", crop_t=132, crop_b=140, debug=false)
http://i.imgur.com/fAIDsWel.png (http://imgur.com/fAIDsWe)

Remuxed just opening scene with Barrymore for testing.
I hit cancel when it reached 10K frames.

[General info]
Log file created with: AVSMeter 2.1.1 (x86)
Script file: E:\Work\Clips\Scream\Scream.avs
Avisynth version: AviSynth 2.60, build:Feb 20 2015 [03:16:45] (2.6.0.5)
Avisynth Interface Version: 6
Avisynth.dll linker/compiler version: 12.0 (VC 2013)
Avisynth DLL location: C:\Windows\SysWOW64\avisynth.dll
PluginDir2_5 (HKLM, x86): C:\AVS\AVS_Ver\AVS260_MT\plugins

[Clip info]
Number of frames: 18672
Length (hh:mm:ss.ms): 00:12:58.779
Frame width: 1920
Frame height: 816
Framerate: 23.976 (239760/10000)
Colorspace: YV12
Active MT Mode: 0

[Runtime info]
Frames processed: 10010 (0 - 10009)
FPS (min | max | average): 5.470 | 14.18 | 13.71
TPF (max | min | avg): 182.8 | 70.54 | 72.96 ms
Memory usage (phys | virt): 471 | 582 MB
Thread count: 13
CPU usage (average): 25%
GPU usage (average): 92%
Video engine load (average): 3%
GPU memory usage: 356 MB
Time (elapsed | estimated): 00:12:10.305 | 00:22:42.263


[Script]
SetMemoryMax(512)
LoadPlugin("E:\Downloads\AviSynth\KNLMeansCL-v0.7.0\KNLMeansCL.dll")
DGSource("E:\Work\Clips\Scream\Scream.dgi", crop_t=132, crop_b=140, debug=false)
#KNLMeansCL (info=true)
KNLMeansCL ()



[Graphics card info]
Card name: NVIDIA GeForce GTX 750 Ti
GPU name: GM107
Memory size: 2048
OpenCL version: OpenCL 1.2 CUDA
Driver version: 10.18.13.5582 WHQL (ForceWare 355.82) / Win7 64
Info collected with: GPU-Z 0.8.5

[Khanattila]

Do you think this is specific to the XP driver? I also have XP64, I might give that a try later.

I also get the same error as Groucho2004, when I put KNLMeansCL in the autoload folder. I'm on 64-bit Windows 7 using AviSynth+ r1576.

http://gpuz.techpowerup.com/15/10/14/x3m.png

Please use GPU Caps Viewer v1.25.0.0.

Example: http://pastebin.com/ZkFeSBTQ

[Groucho2004]

Please use GPU Caps Viewer v1.25.0.0.
Here's mine (http://pastebin.com/F22M74q0).

[Khanattila]

Here's mine (http://pastebin.com/F22M74q0).

It looks fine. A crazy idea. Try replacing OpenCL.dll? It is provided by Khronos.

C:\Windows\System32\
C:\Windows\SysWOW64\


EDIT. This is the version I got from AMD / Intel.
http://www.mediafire.com/download/oanw1yptvnu9x08/OpenCL-v2.0.0.zip

EDIT2. If it works, I hope NVIDIA fails.

[Groucho2004]

It looks fine. A crazy idea. Try replacing OpenCL.dll? It is provided by Khronos.

C:\Windows\System32\
C:\Windows\SysWOW64\


EDIT. This is the version I got from AMD / Intel.
http://www.mediafire.com/download/oanw1yptvnu9x08/OpenCL-v2.0.0.zip

EDIT2. If it works, I hope NVIDIA fails.
I got it working. I used the OpenCL.dll that is copied by the NVidia driver install to "Program Files\NVIDIA Corporation\OpenCL".

[Khanattila]

I got it working. I used the OpenCL.dll that is copied by the NVidia driver install to "Program Files\NVIDIA Corporation\OpenCL".

You can make a new test? Try to copy the OpenCL.dll into the AviSynth folder. If it works, I add it to the package.

[Groucho2004]

You can make a new test? Try to copy the OpenCL.dll into the AviSynth folder. If it works, I add it to the package.
Doesn't work. The DLL has to be in a directory to which the "PATH" variable points. Most importantly, KNLMeans will go through the standard Windows search hierarchy which means that the one from System32/SysWOW64 is loaded first (which is the one the driver installs).

[Khanattila]

Doesn't work. The DLL has to be in a directory to which the "PATH" variable points. Most importantly, KNLMeans will go through the standard Windows search hierarchy which means that the one from System32/SysWOW64 is loaded first (which is the one the driver installs).

It seems that NVIDIA does not update the loader (OpenCL.dll).
The loader is vendor-independent. AMD, Intel and NVIDIA redistribute it only.

[Groucho2004]

It seems that NVIDIA does not update the loader (OpenCL.dll).
If there's no opencl.dll in the system32 directory, the NVIDIA installer will copy the correct DLL.
I experimented with driver versions recently so that may be the reason why the last install did not update the file.

[Reel.Deel]

Please use GPU Caps Viewer v1.25.0.0.

Example: http://pastebin.com/ZkFeSBTQ

Ok, here it is: http://pastebin.com/QdeuLtyQ

This is my work computer, when I get home I'll try it on my personal computer...


Edit: it works on my home computer, the one at work mush have outdated drivers. Will update drivers tomorrow, sorry for any inconvenience.

[Khanattila]

Ok, here it is: http://pastebin.com/QdeuLtyQ

This is my work computer, when I get home I'll try it on my personal computer...


Edit: it works on my home computer, the one at work mush have outdated drivers. Will update drivers tomorrow, sorry for any inconvenience.

Updated drive here.

[Groucho2004]

Nice speedup of the temporal mode:
colorbars(width = 1024, height = 512, pixel_type = "yv12").killaudio().assumefps(25, 1).trim(0, 499)
KNLMeansCL(d = 2, a = 2)

0.6.4: 17.68 fps
0.7.0: 22.27 fps

[Khanattila]

I added 'OpenCL.dll' in release for those who have trouble.

[luigizaninoni]

What should I do in Vapoursynth64 ?

Error:
Failed to evaluate the script:
Python exception: knlm.KNLMeansCL: VapourSynthCreate error (clSetKernelArg)!
Traceback (most recent call last):
File "src\cython\vapoursynth.pyx", line 1484, in vapoursynth.vpy_evaluateScript (src\cython\vapoursynth.c:26808)
File "E:/Temp/prova temp files/prova.vpy", line 5, in <module>
core.std.LoadPlugin(r'C:\Users\admin\Desktop\Stax64\Apps\Plugins\vs\fmtconv\fmtconv.dll')
File "src\cython\vapoursynth.pyx", line 1376, in vapoursynth.Function.__call__ (src\cython\vapoursynth.c:25123)
vapoursynth.Error: knlm.KNLMeansCL: VapourSynthCreate error (clSetKernelArg)!

Script:
import vapoursynth as vs
core = vs.get_core()
core.std.LoadPlugin(r'C:\Users\admin\Desktop\Stax64\Apps\Plugins\vs\vslsmashsource\vslsmashsource.dll')
clip = core.lsmas.LWLibavSource(source = r'E:\Temp\prova temp files\prova.m2v')
clip = core.knlm.KNLMeansCL(clip = clip, d=2, a=2)
clip.set_output()

Intel Hd4600 Windows 8.1 64 bit

Is it the same issue with opencl.dll as above ? What should I do ? I tried putting the new dll (the one in x64 folder) in system32 but it doesn't solve the issue.

[Khanattila]

What should I do in Vapoursynth64 ?

Error:
Failed to evaluate the script:
Python exception: knlm.KNLMeansCL: VapourSynthCreate error (clSetKernelArg)!
Traceback (most recent call last):
File "src\cython\vapoursynth.pyx", line 1484, in vapoursynth.vpy_evaluateScript (src\cython\vapoursynth.c:26808)
File "E:/Temp/prova temp files/prova.vpy", line 5, in <module>
core.std.LoadPlugin(r'C:\Users\admin\Desktop\Stax64\Apps\Plugins\vs\fmtconv\fmtconv.dll')
File "src\cython\vapoursynth.pyx", line 1376, in vapoursynth.Function.__call__ (src\cython\vapoursynth.c:25123)
vapoursynth.Error: knlm.KNLMeansCL: VapourSynthCreate error (clSetKernelArg)!

Script:
import vapoursynth as vs
core = vs.get_core()
core.std.LoadPlugin(r'C:\Users\admin\Desktop\Stax64\Apps\Plugins\vs\vslsmashsource\vslsmashsource.dll')
clip = core.lsmas.LWLibavSource(source = r'E:\Temp\prova temp files\prova.m2v')
clip = core.knlm.KNLMeansCL(clip = clip, d=2, a=2)
clip.set_output()

Intel Hd4600 Windows 8.1 64 bit

Is it the same issue with opencl.dll as above ? What should I do ? I tried putting the new dll (the one in x64 folder) in system32 but it doesn't solve the issue.

This is another type of error. It does not have anything to do with it. For now uses the old version. I have to check the source code.

[evilr00t]

Intel Hd4600 Windows 8.1 64 bit

Is it the same issue with opencl.dll as above ? What should I do ? I tried putting the new dll (the one in x64 folder) in system32 but it doesn't solve the issue.

I have the same issue on Win7 64 bit / Avisynth 32 bit / Intel HD 4000 / 10.18.10.4226 driver.

const cl_image_desc image_desc = { (cl_mem_object_type) (d ? CL_MEM_OBJECT_IMAGE2D_ARRAY : CL_MEM_OBJECT_IMAGE2D),
(size_t) idmn[0], (size_t) idmn[1], 1, 2 * (size_t) d + 1, 0, 0, 0, 0, NULL };

The varying type of image_desc causes issues with the opencl types:
image2d_array_t
image2d_t

if d is non-zero, clSetKernelArg fails on:
nlmSpatialDistance[arg0, arg1]
nlmSpatialHorizontal[arg0, arg1]
nlmSpatialVertical[arg0, arg1]
nlmSpatialAccumulation[arg0, arg2]
nlmSpatialFinish[arg0]
and if d is zero, clSetKernelArg fails on:
nlmDistanceLeft[arg0, arg1]
nlmDistanceRight[arg0, arg1]
nlmHorizontal[arg0, arg1]
nlmVertical[arg0, arg1]
nlmAccumulation[arg0, arg2]
nlmFinish[arg0]

Looks like Intel's driver is pretty strict and won't convert between the two? I didn't see this issue on nVidia or AMD.
For those platforms I generally see a 14-24% speed improvement on 1080p between 6.11 and 7.0 with D=1, A=2, S=4. Nice work!

[Khanattila]

I have the same issue on Win7 64 bit / Avisynth 32 bit / Intel HD 4000 / 10.18.10.4226 driver.

const cl_image_desc image_desc = { (cl_mem_object_type) (d ? CL_MEM_OBJECT_IMAGE2D_ARRAY : CL_MEM_OBJECT_IMAGE2D),
(size_t) idmn[0], (size_t) idmn[1], 1, 2 * (size_t) d + 1, 0, 0, 0, 0, NULL };

The varying type of image_desc causes issues with the opencl types:
image2d_array_t
image2d_t

if d is non-zero, clSetKernelArg fails on:
nlmSpatialDistance[arg0, arg1]
nlmSpatialHorizontal[arg0, arg1]
nlmSpatialVertical[arg0, arg1]
nlmSpatialAccumulation[arg0, arg2]
nlmSpatialFinish[arg0]
and if d is zero, clSetKernelArg fails on:
nlmDistanceLeft[arg0, arg1]
nlmDistanceRight[arg0, arg1]
nlmHorizontal[arg0, arg1]
nlmVertical[arg0, arg1]
nlmAccumulation[arg0, arg2]
nlmFinish[arg0]

Looks like Intel's driver is pretty strict and won't convert between the two? I didn't see this issue on nVidia or AMD.
For those platforms I generally see a 14-24% speed improvement on 1080p between 6.11 and 7.0 with D=1, A=2, S=4. Nice work!
Yes, just add an 'if' and go on. Tomorrow v0.7.1 LTS is coming.

[Khanattila]

Nice speedup of the temporal mode:
colorbars(width = 1024, height = 512, pixel_type = "yv12").killaudio().assumefps(25, 1).trim(0, 499)
KNLMeansCL(d = 2, a = 2)

0.6.4: 17.68 fps
0.7.0: 22.27 fps


For those platforms I generally see a 14-24% speed improvement on 1080p between 6.11 and 7.0 with D=1, A=2, S=4. Nice work!

That's what I've worked on.

[Khanattila]

I do not have a compatible intel gpu, but this should fix it.
https://github.com/Khanattila/KNLMeansCL/releases

[littlepox]

There is a issue of memory leak after v7.0; it often consumes ~10GB of memory, regardless of the vs.max_cache_size.

Suspected to be related with cmode=True.

[Khanattila]

There is a issue of memory leak after v7.0; it often consumes ~10GB of memory, regardless of the vs.max_cache_size.

Suspected to be related with cmode=True.

Careful not to give some useful information :rolleyes:

[Khanattila]

Somehow I found and fixed the problem.
https://github.com/Khanattila/KNLMeansCL/releases

[luigizaninoni]

I do not have a compatible intel gpu, but this should fix it.
https://github.com/Khanattila/KNLMeansCL/releases

Works fine now with Intel HD4600, thanks

[yup]

Hi Khanattila!
:thanks: for update.

Advice minimum requirement for Geforce, my 560 GTX do not work.
My card do not support OpenCL 1.2 and new version work only with 1.2?

yup.

[Reel.Deel]

Advice minimum requirement for Geforce, my 560 GTX do not work.
My card do not support OpenCL 1.2 and new version work only with 1.2?

The minimum requirements are listed in the GitHub page.
NVIDIA GeForce GT 640 or greater. At least NVIDIA driver 350.12 WHQL.

Since your card is not supported you're stuck using v0.6.11.

[Khanattila]

Hi Khanattila!
:thanks: for update.

Advice minimum requirement for Geforce, my 560 GTX do not work.
My card do not support OpenCL 1.2 and new version work only with 1.2?

yup.

It is not really necessary that the device is OpenCL 1.2, just the platform is required.
NVIDIA simply has no suitable drivers for GT/GTX 500 series.
Can you tell me that it is a stupid, because GT 640 is much slower than GTX 560, but it was released in 2012 as opposed to 2011.
NVIDIA seems to support the cards of the last three years.

[yup]

Reel.Deel and Khanattila!
Thanks for explanation.
Nvidia prefer CUDA not OpenCL because CUDA closed project.

yup.

[CruNcher]

Cuda is engineered specifically for their Hardware they have total control this way Software should support both a optimized OpenCL Kernel for AMD/Intel and a Optimized Cuda Kernel for Nvidia.

The OpenCL part in their Driver is not Native it's just a Wrapper to Cuda and costs efficiency

[~ VEGETA ~]

I get this: "there is no function named knlmeanscl" in my server (windows 7 x64bit). I installed vc++redis 2013, but I don't know which opencl driver should I install... I tried intel and it didn't work, so I installed AMD. it is an intel atom cpu.

I wanted to use this because dfttest is very slow even on my server.

[foxyshadis]

I get this: "there is no function named knlmeanscl" in my server (windows 7 x64bit). I installed vc++redis 2013, but I don't know which opencl driver should I install... I tried intel and it didn't work, so I installed AMD. it is an intel atom cpu.

I wanted to use this because dfttest is very slow even on my server.

Intel only supports OpenCL on Bay Trail and Cherry Trail Atoms, which are normally found in tablets, laptops, and mini-PCs. Older Atoms are all DX9 parts with no OpenCL. If yours is an actual server Atom, then it has no GPU at all and you have to figure out what the chipset contains. What's the part number?

[~ VEGETA ~]

Intel only supports OpenCL on Bay Trail and Cherry Trail Atoms, which are normally found in tablets, laptops, and mini-PCs. Older Atoms are all DX9 parts with no OpenCL. If yours is an actual server Atom, then it has no GPU at all and you have to figure out what the chipset contains. What's the part number?

https://www.online.net/en/dedicated-server/dedibox-xc

[foxyshadis]

https://www.online.net/en/dedicated-server/dedibox-xc

Yup, no GPU in a C2750. Even the chassis of the blade server it's housed in probably only has a minimal VGA GPU.

[~ VEGETA ~]

Yup, no GPU in a C2750. Even the chassis of the blade server it's housed in probably only has a minimal VGA GPU.

So? what to do now? is there any KNLMeans without OpenCL to use? TNLMeans is VERY slow and I don't trust other denoisers very much.

[Khanattila]

So? what to do now? is there any KNLMeans without OpenCL to use? TNLMeans is VERY slow and I don't trust other denoisers very much.

Use TNLMeans compiled by Groucho2004 (http://forum.doom9.org/showthread.php?t=168090).
Non-local means denoising algorithm is slow. You can not do otherwise.

[~ VEGETA ~]

Use TNLMeans compiled by Groucho2004 (http://forum.doom9.org/showthread.php?t=168090).
Non-local means denoising algorithm is slow. You can not do otherwise.

is it faster than knl or close? i hope it is faster than original tnl by noticeable amount.

i didn't find a better denoiser overall than knlmeanscl.

[Groucho2004]

is it faster than knl or close? i hope it is faster than original tnl by noticeable amount.
It's faster than the original but still very slow compared to KNLMeansCL.
I did some tests here (http://forum.doom9.org/showthread.php?p=1739321#post1739321).

[Khanattila]

A few more slight adjustment.

https://github.com/Khanattila/KNLMeansCL/releases/tag/v0.7.3

KNLMeansCL v0.7.3
* Removed 'default' and 'all' device_type.
* More controls of the OpenCL platform.
* Better error handling.
* VapourSynth: fixed frame properties.

[Reel.Deel]

Hi Khanattila,

KNLMeansCL works fine with AviSynth+ r1576 but with x64 I get this error message:
Avisynth read error: KNLMeansCL: fatal error! (AviSynthGetFrame)

[Khanattila]

Hi Khanattila,

KNLMeansCL works fine with AviSynth+ r1576 but with x64 I get this error message:
Script?

[Reel.Deel]

Script?

ColorBars(pixel_type="YV12")
KNLMeansCL()

[~ VEGETA ~]

It's faster than the original but still very slow compared to KNLMeansCL.
I did some tests here (http://forum.doom9.org/showthread.php?p=1739321#post1739321).

I used dfttest rather than tnlmeans and it was extremely slow! is it at least faster than this?

[Groucho2004]

I used dfttest rather than tnlmeans and it was extremely slow! is it at least faster than this?
It mostly depends on your CPU. Also, it takes less time to try it out than to write all these posts.

[Groucho2004]

KNLMeansCL works fine with AviSynth+ r1576 but with x64 I get this error message:
Avisynth read error: KNLMeansCL: fatal error! (AviSynthGetFrame)
Works for me (WinXP64SP2):
[General info]
Log file created with: AVSMeter 2.1.5 (x64)
Script file: F:\test.avs
Command line switches: -log -gpu
Avisynth version string: AviSynth+ 0.1 (r1576, x64)
Avisynth file version: 2.6.0.5
Avisynth Interface Version: 5
Avisynth MT support: No
Avisynth.dll linker/compiler version: 11.0
Avisynth.dll location: D:\WINNT\system32\AviSynth.dll
Avisynth.dll time stamp: 2014-01-03, 17:11:18
PluginDir2_5 (HKLM, x64): E:\Apps\VideoTools\AvisynthRepository\AVSPLUS_x64\plugins


[Clip info]
Number of frames: 107892
Length (hh:mm:ss.ms): 00:59:59.996
Frame width: 640
Frame height: 480
Framerate: 29.970 (30000/1001)
Colorspace: YV12
Audio channels: 2
Audio bits/sample: 16
Audio sample rate: 48000
Audio samples: 172799827


[Runtime info]
Frames processed: 320 (0 - 319)
FPS (min | max | average): 64.64 | 65.75 | 65.49
Memory usage (phys | virt): 34 | 73 MB
Thread count: 8
CPU usage (average): 25%
GPU usage (average): 95%
Video engine load (average): 0%
GPU memory usage: 61 MB
Time (elapsed): 00:00:04.887


[Script]
ColorBars(pixel_type="YV12")
KNLMeansCL()



[Graphics card info]
Card name: NVIDIA GeForce GTX 750
GPU name: GM107
Memory size: 1024
OpenCL version: OpenCL 1.2 CUDA
Driver version: 6.14.13.5012 (ForceWare 350.12) / XP64
Info collected with: GPU-Z 0.8.6

[Reel.Deel]

Works for me (WinXP64SP2)

That's odd, it also works on my work computer. Last time I had problems with KNLMeansCL (http://forum.doom9.org/showthread.php?t=171379&page=26#post1742841) my home computer worked but not my work computer :confused:. If it's a driver issues, it's kinda weird that it works in 32-bit but not 64-bit. Anyways when I get home I'll update drivers and report back.

Edit: It turned out out to be a drive issue. Sorry for another false alarm :o. The drivers were not that outdated but I guess it requires the latest and greatest.

[kalehrl]

Hi Khanattila,
I complained some time ago that knlmeanscl didn't work when using x264 encoder with MeGUI.
I just tested the latest version and it works now.
In the meantime, I updated my AMD driver to the latest beta instead of the latest release which I used before.
Also, there were some MeGUI updates as well.
Not really sure what fixed it but the important thing is, it works now!

[Khanattila]

Happy that everything seems to be working.