Log in

View Full Version : FineSharp for VapourSynth


Pages : 1 [2]

Are_
17th December 2017, 12:12
I meant I brainfarted while coding that part and already fixed it in the gist, sorry for the misunderstanding.

poisondeathray
30th October 2019, 17:23
I get error with some sstr values like 0.1, 0.2

But 0.25, or 0.3, or 1, or 1.2 etc... will work


File "PATH\finesharp.py", line 133, in sharpen
cstr = float(cstr)
TypeError: can't convert complex to float



Using this version 2019-10-10
https://gist.github.com/4re/8676fd350d4b5b223ab9


clip = core.std.BlankClip(width=640, height=480, format=vs.YUV420P8, fpsnum=24, fpsden=1, length=240, color=[128, 128, 128])
fs = finesharp.sharpen(clip, sstr=0.2)

Are_
31st October 2019, 01:33
Avisynth version doesn't return an error there? (No windows right here so I can't check it).

I don't know anything about math, but at some point in the code cstr becomes a complex number, and that is a problem for the rest of the script.
I think the proper solution is to put a check somewhere to tell you not to go so low with sstr if cstr is not defined.

poisondeathray
31st October 2019, 01:39
Avisynth version doesn't return an error there? (No windows right here so I can't check it).

I don't know anything about math, but at some point in the code cstr becomes a complex number, and that is a problem for the rest of the script.
I think the proper solution is to put a check somewhere to tell you not to go so low with sstr if cstr is not defined.

No error with avs version when using sstr=0.2 or 0.1

Are_
3rd November 2019, 05:06
It should be "fixed" now.
All vapoursynth finesharp scripts had a typo, truth is avisinth also throws an error when sstr goes too low and you use a mode lower than 0.

poisondeathray
3rd November 2019, 05:32
It should be "fixed" now.
All vapoursynth finesharp scripts had a typo, truth is avisinth also throws an error when sstr goes too low and you use a mode lower than 0.

Thanks working now