x264 r2207 - request for old style progress indicator

[Atak_Snajpera]

r2204
Print elapsed time in encoding progress indicator

new progress indicator added by Alexander Prikhodko
x264 [info]: using SAR=1/1
x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 FastShuffle SSE4.1 Cache64
x264 [info]: profile High, level 4.0
frames fps kb/s elapsed remain
[ 3.9%] 89/2272 15.98 2840.95 0:00:05 0:02:16

I prefer more older style where everything was in one line...

[ 3.9%] 89/2272 frames, 15.98 fps, 2840 kbps, ela 0:00:05, eta 0:02:16

Another problem is that title on console is now just showing "some" raw numbers without proper labels.
http://i.imgur.com/JniS0.png

[Selur]

I second that request, because parsing something like:
2985 650.47 5033.36 0:00:04
is a pain for GUIs
-> an option for old style progress would be nice

[Atak_Snajpera]

Maybe someone with C++ skills could modify source and revert that change.
I would like to have something like this instead

[ 3.9%] 89/2272 frames, 15.98 fps, 2840 kbps, ela 0:00:05, eta 0:02:16

[Kurtnoise]

x264 uses plain C, not C++...

Blame Komisar for this patch (http://article.gmane.org/gmane.comp.video.x264.devel/8901).

[Groucho2004]

Maybe someone with C++ skills could modify source and revert that change.As someone who claims to be a developer, you should be familiar with the concept of version control which prevents the source code to be modified by "someone".

[ 3.9%] 89/2272 frames, 15.98 fps, 2840 kbps, ela 0:00:05, eta 0:02:16"ela"?

[Atak_Snajpera]

As someone who claims to be a developer, you should be familiar with the concept of version control which prevents the source code to be modified by "someone".

"ela"?
short for elapsed ?

BTW. Who says that I'm a developer? I'm just a GUI creator. Period.

I just need an unofficial patch.

[kemuri-_9]

you already know how to get the source, so all you need to do is revert the changes for
http://git.videolan.org/?p=x264.git;a=commit;h=8b535d9006d87e32c4ff939691b920da823ae85a
in your local copy...
using patch -R or some similar process.
I don't see why you need someone to do this for you.

[Atak_Snajpera]

I don't see why you need someone to do this for you.
My knowledge about C is almost zero. Also I don't have an C compiler.

[Groucho2004]

short for elapsed ?Ah, then "eta" should consequently be changed to "est", right?

Period.Yeah, that can make people cranky... :)

[Atak_Snajpera]

Ah, then "eta" should consequently be changed to "est", right?
Frankly I don't care about that as long as everything is printed in single line. Now you are just nibbling...

[Dark Shikari]

If I don't commit this patch, the author of it will harass me endlessly and complain until I go crazy. If I do commit this patch, someone else complains that it isn't good enough. What am I supposed to do?

[Groucho2004]

If I don't commit this patch, the author of it will harass me endlessly and complain until I go crazy. If I do commit this patch, someone else complains that it isn't good enough. What am I supposed to do?

I think it was fine before this commit. How about some sort of poll?

Another thought - As it is right now on two lines, the alignment of the labels and values is an eyesore. Some are right-aligned, some left-aligned and for some it's not even obvious. So yes, I also think it should be on one line.

[burfadel]

Two simple alternative solutions:
1. Add the fps, eta labels etc to the same line, maybe with a comma after each item to separate them
2. Add an option such as -oldindicator. Displays using the old method instead.

I think having an ETA is a good idea, but I also think labels on the same line would be a good idea too.

[Atak_Snajpera]

If I don't commit this patch, the author of it will harass me endlessly and complain until I go crazy. If I do commit this patch, someone else complains that it isn't good enough. What am I supposed to do?

there is saying "if ain't broken don't fix it"
old progress indicator has been with us for years but now someone decided that old one is not cool anymore.

[06_taro]

there is saying "if ain't broken don't fix it"
old progress indicator has been with us for years but now someone decided that old one is not cool anymore.

And most cool stuffs having been with you for years were also made by that *someone*

[SassBot]

And most cool stuffs having been with you for years were also made by that *someone*

Which doesn't mean that everything they do is perfect. Even the best of people change things in ways that they think is great but other's won't agree.

[Keiyakusha]

Which doesn't mean that everything they do is perfect. Even the best of people change things in ways that they think is great but other's won't agree.
other's won't agree sure, but why you think your opinion matters? Developer's opinion = opinion_of_one_user*1000, so bring army with you :D

EDIT: by "you" i mean any user, not SassBot personally

P.S.
Personally I like new style pretty much as i don't have any useless gui's

[SassBot]

other's won't agree sure, but why you think your opinion matters? Developer's opinion = opinion_of_one_user*1000, so bring army with you :D

P.S.
Personally I like new style pretty much as i don't have any useless gui's

I have no opinion on it at all, but to try to act like someone is above criticism because they're a developer of the program is completely silly.

[Atak_Snajpera]

other's won't agree sure, but why you think your opinion matters? Developer's opinion = opinion_of_one_user*1000, so bring army with you :D

EDIT: by "you" i mean any user, not SassBot personally

P.S.
Personally I like new style pretty much as i don't have any useless gui's

you remember me users who like metro interface and removed start from taskbar in windows 8.

regarding useless guis.
guis are suppose to simplify encoding process.

[MasterNobody]

Stop this complaining, please. It was already reverted back in r2208. So you again have one line without elapsed time and without total duration after encoding.

[Atak_Snajpera]

uff...good news finally
can jeeb compile r2208?

[JEEB]

can jeeb compile r2208?
Already did, uploading and moving files atm. Am in the middle of the woods of Kirkkonummi at the moment, so I'm currently not on the fastest line in the world :) .

Edit: Done, should be mirrored during the next run of the x264.nl auto-updater.

[Atak_Snajpera]

thank you.