Converting Fraps footage with x264, output file's colors become brighter?

[mzso]

To further that. Why not try running it through x264 instead of ffmpeg. I didn't want to say anything earlier, as I assumed it was just preference. But if there are quality issues with ffmpeg in this situation, then yeah try another encoder.

Well, I'm unfamiliar with that one, but it can't convert full AV files, can it?

EDIT:
Well, it seems be working for the 1 sec sample with this CL:
x264 --preset slow --crf 20 --output-csp rgb --keyint 30 -o out.mkv in.mkv

[mzso]

New problem. :)
The image turns blue quite often.
"Brown" wooden door:
http://abload.de/img/blue-264-1onqny.png

[mzso]

Had to downgrade to an older build of x264. It seems like the never ones can't decode fps1 properly just like the never builds of ffmpeg...

[mzso]

It seems like I get some blue stuff anyways. I give up.

http://abload.de/img/blue-264-2wcukl.png

[STaRGaZeR]

Had to downgrade to an older build of x264. It seems like the never ones can't decode fps1 properly just like the never builds of ffmpeg...

What do you mean when you say they can't decode fps1 properly?

[mzso]

What do you mean when you say they can't decode fps1 properly?

Whole bunch of errors while decoding. Huge gaps in the encoded file. Didn't bother to investigate the errors, since I knew ffmpeg enough to just try older builds.

[STaRGaZeR]

Whole bunch of errors while decoding. Huge gaps in the encoded file. Didn't bother to investigate the errors, since I knew ffmpeg enough to just try older builds.

If you mean that the decoded fraps stream is not constant frame rate, completely destroying motion when encoding it afterwards, then yes, I'm afraid you're screwed. Some time ago I had a discussion with the ffmpeg developer that changed this but he didn't listen when I said that by doing what he did he'd make the decoder useless for anything else than playing the original Fraps file in a player.

I even made a patch to correct it but he didn't accept it. LAV Filters included it until a big ffmpeg update some time ago, but nev hasn't included it since. I use it with my own builds thou. I can give you both the patch and a LAV Filters build, so you can compile an updated ffmpeg or LAV with a working (and multithreaded) fraps decoder.

[mzso]

If you mean that the decoded fraps stream is not constant frame rate, completely destroying motion when encoding it afterwards, then yes, I'm afraid you're screwed. Some time ago I had a discussion with the ffmpeg developer that changed this but he didn't listen when I said that by doing what he did he'd make the decoder useless for anything else than playing the original Fraps file in a player.

I even made a patch to correct it but he didn't accept it. LAV Filters included it until a big ffmpeg update some time ago, but nev hasn't included it since. I use it with my own builds thou. I can give you both the patch and a LAV Filters build, so you can compile an updated ffmpeg or LAV with a working (and multithreaded) fraps decoder.

Interesting, I didn't hear new removing a fix before. :) Anyway. I don't do patching and compiling, and ffmpeg failed at transcoding fullrange too.

Did you experience anything like the blueishness (the second one)?

[Snowknight26]

Did you experience anything like the blueishness (the second one)?

http://trac.ffmpeg.org/ticket/75

Though I submitted that bug to ffmpeg over 2 years ago, it seems as if it was only just fixed recently.

[mzso]

http://trac.ffmpeg.org/ticket/75

Though I submitted that bug to ffmpeg over 2 years ago, it seems as if it was only just fixed recently.

That's "awesome". They fixed that meanwhile rendered the decoder useless, with the other thing. -_-

Edit:
Ouch, that's very recent. (17 hours ago) I was thinking of trying to find a build where both's fixed.

[osgZach]

It couldn't have been more than a year or so ago (probably less) that I had tried FRAPS out, and I didn't have these kinds of issues???
I suppose my workflow could have been different though.

Frankly, I'd just get rid of FRAPS and use a better program. FRAPS seems very restricted an non-configurable in a lot of ways.

[mzso]

http://trac.ffmpeg.org/ticket/75

Though I submitted that bug to ffmpeg over 2 years ago, it seems as if it was only just fixed recently.

Did you report it to the Libav devs? It apparently has the same issue atm, but they didn't bork fps1 decoding otherwise. (yet)

[STaRGaZeR]

Interesting, I didn't hear new removing a fix before. :) Anyway. I don't do patching and compiling, and ffmpeg failed at transcoding fullrange too.

Did you experience anything like the blueishness (the second one)?

You know what's funny? The patch doesn't work anymore with LAV, something changed in ffmpeg between 0.56.2 and 0.57 that breaks it. It now looks something like this (http://www.imagebam.com/image/aa7f19256004998) lol. I'll have to check what happened. I did experience some chroma weirdness, like shifting, but not that blue mess.

http://trac.ffmpeg.org/ticket/75

Though I submitted that bug to ffmpeg over 2 years ago, it seems as if it was only just fixed recently.

Is that supposed to be fixed by this (http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b9ea6a84143a2a8fb5d1ba891e7378924ec76b6b)commit? I guess not, that just changes a hardcoded number for a constant of the same value, and there are no more commits to fraps.c

[nevcairiel]

LAV Filters included it until a big ffmpeg update some time ago, but nev hasn't included it since.

I haven't included it because the latest version of the patch you gave me was still crashing rather randomly, and you even commented on that fact, iirc.
I didn't have time to look into that problem myself because it isn't a high priority for me.

PS:
I would also prefer a patch over a pre-patched full source file. =)

Is that supposed to be fixed by this (http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b9ea6a84143a2a8fb5d1ba891e7378924ec76b6b)commit? I guess not, that just changes a hardcoded number for a constant of the same value, and there are no more commits to fraps.c

I guess its actually this (http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=b1bbd715d8c42f4236f3bceac061f81da2c31a35) commit, which changes the constant introduced in the previous commit.

[STaRGaZeR]

I haven't included it because the latest version of the patch you gave me was still crashing rather randomly, and you even commented on that fact, iirc.
I didn't have time to look into that problem myself because it isn't a high priority for me.

PS:
I would also prefer a patch over a pre-patched full source file. =)

Yep, but I removed the avutil dependency some time ago and since then it hasn't crashed on me, YMMV, so feel free to commit it if you feel like it. I still think that there's a problem in ffmpeg after the thread update that the code triggered, but heh. The way to reproduce it was to play a file in a loop until it crashed, totally random. Error was that a thread tried to read from or write to an invalid address. I made it into a patch here: http://www.mediafire.com/?mv5vl3zw9uj1xf7

I guess its actually this (http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=b1bbd715d8c42f4236f3bceac061f81da2c31a35) commit, which changes the constant introduced in the previous commit.

That huffman commit actually fixes all weirdness I had with chroma in fraps, great stuff :)

[nevcairiel]

Yep, but I removed the avutil dependency some time ago and since then it hasn't crashed on me, YMMV, so feel free to commit it if you feel like it. I still think that there's a problem in ffmpeg after the thread update that the code triggered, but heh. The way to reproduce it was to play a file in a loop until it crashed, totally random. Error was that a thread tried to read from or write to an invalid address. I made it into a patch here: http://www.mediafire.com/?mv5vl3zw9uj1xf7


I'll have a look at that again, thanks.
I'll probably refactor it a bit to make the diff smaller, so that future changes can be merged more easily, otherwise its always a PITA. :)

[mzso]

That huffman commit actually fixes all weirdness I had with chroma in fraps, great stuff :)

But you still can't encode anything because of the other issue, right? :)

[STaRGaZeR]

I'll have a look at that again, thanks.
I'll probably refactor it a bit to make the diff smaller, so that future changes can be merged more easily, otherwise its always a PITA. :)

Thanks! ;)

But you still can't encode anything because of the other issue, right? :)

What other issue? Since chroma stuff is fixed and all frames are there thanks to the patch, I can use the ffmpeg decoder as if it was the original fraps decoder (a lot faster though) :)