PGCEdit- Jump to nowhere

[mikenadia]

The only "Jump to Nowhere" was
"Jump to Title 63" which does not exist.

[00 B1 00 09 00 0E 00 26] 36 if ( gprm(9) != 14 ) then { Goto line 38 }
[30 02 00 00 00 3F 00 00] 37 (JumpTT) Jump to Title 63

I NOP that command and PGCEdit tells me that the NOP command is totally useless with the If command.

Any additionnal check I shoud do before deleting both lines or could it be done automatically.

Thx

P.S. The "Jump to Nowhere" command catches the "Jumpto Title 37" where Title 37 does not exist but not the " Goto Line 38" where Line 38 does not exist (even if that command is highlighted in pink/red as Illegal).

[blutach]

You can delete both lines of just make line 37 into a NOP. Some players don't like a conditional NOP.

Regards

[mikenadia]

Thank you. In some rips, I have a lot conditional NOP (more than 40). Probably the ripper could have done a better job.

Unrelated, in another rip, the "Call cross references" log indicates 2 uncalled PGCs.But if I run "Find Uncalled PGCs", I have 3 of them (the third one can only be called by one of the first 2 uncalled). And if , after that, I rerun "Call cross references", I am getting 3 ,now.

It seems , by the message in "Call cross references" that we should run that function before "Find Uncalled PGCs".

[blutach]

Find uncalled PGCs is automatically iterative. It finds the first 2 then from them, the 3rd. Calls X-Refs is a single function and it won't find them all unless you clear the VM Commands in the useless PGCs like it offers to and you re-run it till there are no more to find. Must admit, it's been a while since I used Calls X-Refs, as Find Uncalled PGCs is a one step version (although Calls X-Refs does have a broader functionality).

As for conditonal NOPs, I meant something like this:if x (logical operator) y then NOPFor one, that is meaningless and for two, some players choke on it (notably, IFOEdit's player). However, the structure in your first post is perfectly fine.

Regards