Log in

View Full Version : X264 Git917


wyti
25th July 2008, 00:27
Hello i have some question about the 917Git number.
The changelog said :

Split into a separate commit because this changes rounding, and thus changes output slightly.

In which way output is modified ? Better ? Worse ? Different (Better in some cases worse in others ?)
and i don't understand why he said "Split into a separate commit" this modification is in the GIT now ? right ?

LoRd_MuldeR
25th July 2008, 00:34
Obviously it's in the git now, otherwise you wouldn't see on the git log :p

As the log said: It's a separate commit, because it changes the output (slightly) and thus they didn't want to merge it with another commit.
Since the log talks about "rounding" and "slightly", I highly doubt you will even see the difference, although (technically) there is a very small difference...

Dark Shikari
25th July 2008, 00:43
It should absolutely minimally improve output, because it introduces more correct rounding for temporal motion vector prediction. The effect is probably immeasurable--the change was made because this method was faster.

Its split into a separate commit because it is very important to split commits that aren't supposed to change output from those that are supposed to; otherwise, debugging can get difficult.

wyti
25th July 2008, 00:57
OK thanks for the explanations.