MCTemporalDenoise [v1.4.20 - Update 2010/07/02]

[tormento]

I will try some tests later with GradFun2DBmod and GradFun2db vs f3kdb to replace GradFun2db (but enhance for HBD will stay false by default)
Please do some tests with Neo plugins too.

[real.finder]

Please do some tests with Neo plugins too.

what you mean? Neo plugins already used now (Neo FFT3D / DFTTest even for HBD are optional, others are not optional in HBD but they not used in this script in first place)

exactly the same for vsXXX plugins that asd did, but since old plugins for these plugins don't has HBD then they are not optional if you work with HBD

the summary is, if it not required then it's recommended to use them unless you see some problems

keep in mind I didn't update the description of the scripts (yet) including the required plugins

[tormento]

keep in mind I didn't update the description of the scripts (yet) including the required plugins
#this #til

[real.finder]

f3kdb can't be a compatibility replacement so I used SmoothGrad from Dither tools

so I did another updates (will use modded GradFun2DBmod for more color formats but not HBD) and make sure it not use any deband in HBD (forgotten GradFun2db make it crash after seek when use HBD)

[tormento]

f3kdb can't be a compatibility replacement so I used SmoothGrad from Dither tools
Dither tools are as old as stone age. :p

Do they support AVS+ new header?

A new compile with HBD support and newer header would be welcome.

[real.finder]

Dither tools are as old as stone age. :p

Do they support AVS+ new header?

A new compile with HBD support and newer header would be welcome.

dither for avs 2.5 work fine, anyway, it will not be used in HBD by default

instead of port all things in dither, there are some functions from dither tools are useful like https://forum.doom9.org/showthread.php?p=1907352#post1907352

[gispos]

MCTemporalDenoise crashes regularly with the settings 'high' and 'very high'.
I think I have to update something, just what?

[real.finder]

MCTemporalDenoise crashes regularly with the settings 'high' and 'very high'.
I think I have to update something, just what?

it's fine here

ColorBars(width=720, height=480, pixel_type="yv12")
MCTemporalDenoise(settings="very high")

[gispos]

it's fine here

ColorBars(width=720, height=480, pixel_type="yv12")
MCTemporalDenoise(settings="very high")
No, immediately a crash

Edit: Not always, sometimes it works sometimes not

Edit2: I think TTempSmooth is the culprit
https://i.ibb.co/nzsvFKy/Error.jpg (https://imgbb.com/)

[gispos]

It's getting annoying with all these versions. :mad:
I downloaded this (https://github.com/Asd-g/AviSynth-vsTTempSmooth), and now

Script error: There is no function named 'TTempSmoothF'.
(D:\Tools\AviSynth\plugins64\MCTemporalDenoise\MCTemporalDenoise.avs, line 1083)


Now I've loaded this one (http://avisynth.nl/index.php/TTempSmooth) and didn't want to use it at first.
DLL description: For Avisynth 2.5

But it works, man oh man, why is the information on certain things handled so sloppily.

[kedautinh12]

No, immediately a crash

Edit: Not always, sometimes it works sometimes not

Edit2: I think TTempSmooth is the culprit
https://i.ibb.co/nzsvFKy/Error.jpg (https://imgbb.com/)

Use vsTTempSmooth replaced
https://github.com/Asd-g/AviSynth-vsTTempSmooth

[real.finder]

gispos, my edit can use both vsTTempSmooth and TTempSmooth, if you have both it will use vsTTempSmooth

[gispos]

gispos, my edit can use both vsTTempSmooth and TTempSmooth, if you have both it will use vsTTempSmooth
'My Edit', what do you mean by that?

I think you mean MCTDmod and I ask myself whether the result with this version is comparable with the original.
With the settings of MCTD I always try hard and do not want any other results for my existing scripts
Are the settings comparable?

About TTempSmooth:
I had a port from 'Joshua Duncan' who was causing the problems, with the normal TTempSmooth.dll everything works.

[real.finder]

'My Edit', what do you mean by that?
in signature or https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/MCTemporalDenoise.avsi

to use it, you will need https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/Zs_RF_Shared.avsi if you don't have it

[gispos]

in signature or https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/MCTemporalDenoise.avsi

to use it, you will need https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/Zs_RF_Shared.avsi if you don't have it
My version that doesn't work with vsTempSmooth:
### v1.4.20 : tweaked some settings
### updated QED_Deblock version

Yours in the link.
### v1.4.20 : tweaked some settings
### updated QED_Deblock version

:D

With yours it also works with vsTempSmooth (thanks for that), but please note an update in the changelog

[real.finder]

My version that doesn't work with vsTempSmooth:
### v1.4.20 : tweaked some settings
### updated QED_Deblock version

Yours in the link.
### v1.4.20 : tweaked some settings
### updated QED_Deblock version

:D

With yours it also works with vsTempSmooth (thanks for that), but please note an update in the changelog

I was lazy to add these things :D, well, at least I did add
### 27 June 2020 ###

[gispos]

MCTemporalDenoise crashed with deblock = True. Can someone tell me what could be the cause?
I can't remember swapping the plugins I needed for MCTemporalDenoise.

I still use the older version because the latest version is about 2 fps slower for me.

Edit
Just found out if I set useQED = False there is no crash. But have not changed the Deblock_QED.avs. Strange.

Edit2
The 'Deblock_QED.avs' is the culprit but can't find another. Is there a newer one?

[manolito]

The 'Deblock_QED.avs' is the culprit but can't find another. Is there a newer one?

The latest one I use is this one:
# Changes 2016-5-8: (Motenai Yoda)
# - Added internal variable uvp for skip chroma post processing when uv!=3
# - Replaced most (chroma=uv>2?"process":"copy") and all U=uv,V=uv by U=uvp,V=uvp to trash chroma planes when uv!=3
# - Replaced last (chroma=uv>2?"process":"copy") by (U= uv<2 ? 1 : uv,V= uv<2 ? 1 : uv) to trash chroma planes when uv=1|-1
https://forum.doom9.org/showthread.php?p=1767112#post1767112

FWIW if you use AVS+ in MT mode the crash can most likely be avoided if the MCTemporalDenoise call is followed by a RequestLinear call.

[real.finder]

MCTemporalDenoise crashed with deblock = True. Can someone tell me what could be the cause?
I can't remember swapping the plugins I needed for MCTemporalDenoise.

I still use the older version because the latest version is about 2 fps slower for me.

Edit
Just found out if I set useQED = False there is no crash. But have not changed the Deblock_QED.avs. Strange.

Edit2
The 'Deblock_QED.avs' is the culprit but can't find another. Is there a newer one?

for me it's faster in new one and I have no problem with deblock, maybe you want to try my plugins folder https://forum.doom9.org/showthread.php?t=181989

[gispos]

The latest one I use is this one:

https://forum.doom9.org/showthread.php?p=1767112#post1767112

FWIW if you use AVS+ in MT mode the crash can most likely be avoided if the MCTemporalDenoise call is followed by a RequestLinear call.
Doesn't help either. Still crashing. If useQED is True is 'Deblock_QED.avs' used?
If so, the error can only be caused by Deblock_QED.avs. Maybe I'll find out.

for me it's faster in new one and I have no problem with deblock, maybe you want to try my plugins folder https://forum.doom9.org/showthread.php?t=181989
The new version is slower for me, but I will look at your plugins and experiment with them. Thanks for that.

[StainlessS]

MCTemporalDenoise crashed with deblock = True
Maybe some further clues would be good, eg error message.
Also, particularly if no error message, then anything in Windows Logs ?
[Maybe also cause fault with DebugView running, some s/w may output debug text prior to collapse.]
Also try via Vdub2, maybe it puts up error debug stuff.

[gispos]

Maybe some further clues would be good, eg error message.
Also, particularly if no error message, then anything in Windows Logs ?
[Maybe also cause fault with DebugView running, some s/w may output debug text prior to collapse.]
Also try via Vdub2, maybe it puts up error debug stuff.

VirtualDub shows the same error message. Crash in 'ucrtbase.dll'
But I can't understand.
1.) I have installed all C ++ runtimes (and installed it again)
2.) A call to deblock() does not cause an error, only with 'QED_deblock.avs' it pops. I looked at the QED_deblock, there a few calculations are made and basically deblock is also called. ( I am overlooking something ?)

I have tested the deblock.dll version 1.3 with the QED version linked by manolito, then comes the error message 'Deblock_deblock' does not exist.
Now I'll take a look at the real_finder plugins, but I can't understand that.

[pinterf]

VirtualDub shows the same error message. Crash in 'ucrtbase.dll'
But I can't understand.
1.) I have installed all C ++ runtimes (and installed it again)
2.) A call to deblock() does not cause an error, only with 'QED_deblock.avs' it pops. I looked at the QED_deblock, there a few calculations are made and basically deblock is also called. ( I am overlooking something ?)

I have tested the deblock.dll version 1.3 with the QED version linked by manolito, then comes the error message 'Deblock_deblock' does not exist.
Now I'll take a look at the real_finder plugins, but I can't understand that.
1.) Deblock_deblock means: calls deblock plugin from deblock.dll
2.) which dctfilter version are you using? chikuzens' version was replaced by Asd-g's build (v0.5.1)

[gispos]

1.) Deblock_deblock means: calls deblock plugin from deblock.dll
2.) which dctfilter version are you using? chikuzens' version was replaced by Asd-g's build (v0.5.1)
DCTFilter, was the correct guess.:)
Thank you!

[Mugiiya]

in signature or https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/MCTemporalDenoise.avsi

to use it, you will need https://github.com/realfinder/AVS-Stuff/blob/master/avs%202.5%20and%20up/Zs_RF_Shared.avsi if you don't have it

I had problems with your version.
Script error: There is no function named 'gradfun2db3'. Line 711

Also, this version have multi-threading support?

Loaded script:

LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\mvtools2.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\masktools2.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\RgTools.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\variableblur.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\warpsharp.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\fft3dfilter.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\TTempSmooth.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\Deblock.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\DCTFilter.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\EEDI2.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\AddGrainC.dll")
LoadPlugin("C:\Program Files (x86)\AviSynth+\plugins64+\gradfun2db.dll")
Import("C:\Program Files (x86)\AviSynth+\plugins64+\Zs_RF_Shared.avsi")
Import("C:\Program Files (x86)\AviSynth+\plugins64+\LSFmod.v1.9.avsi")
Import("C:\Program Files (x86)\AviSynth+\plugins64+\Deblock_QED_MT2Mod.avsi")
Import("C:\Program Files (x86)\AviSynth+\plugins64+\GradFun2DBmod.v1.5.avsi")
Import("C:\Program Files (x86)\AviSynth+\plugins64+\MCTemporalDenoise.avsi")

MCTemporalDenoise(radius=1, sigma=1, twopass=false, useTTmpSm=false, limit=-1,chroma=false, GPU=false, interlaced=false, sharp=true, adapt=true, strength=150, SHmode=3, SHmethod=3, Slimit=0, Sovershoot=0, Tlimit=false, Tovershoot=0, protect=false, cutoff=64, threshold=127, maxdiff=0, AA=true, useEEDI2=true, reduc=1, maxd=12, AAthr=16, method=0, deblock=false, useQED=true, quant1=40, quant2=80, edgeclean=true, ECrad=8, ECthr=32, ECmode="RemoveGrain(4,4)", stabilize=false, maxr=1, TTstr=1, enhance=true, GFthr=1.1, AGstr=0, bias=-1, bwbh=48, owoh=16, blksize=16, overlap=8, truemotion=false, MVglobal=false, bt=1, ncpu=12, precision=2, pel=2, pelsearch=2, search=-1, searchparam=-1, MVsharp=0, DCT=0)


Solved adding: fixband=false
But still can't use multi-threading.

[kedautinh12]

Please updated gradfun2dbmod of real.finder here:
https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/GradFun2DBmod.avsi
And some script with community branch:
https://github.com/realfinder/AVS-Stuff/tree/Community/avs%202.5%20and%20up
Update new ver of filters&scripts requested from here:
http://avisynth.nl/index.php/MCTemporalDenoise

[Mugiiya]

Please updated gradfun2dbmod of real.finder here:
https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/GradFun2DBmod.avsi
And some script with community branch:
https://github.com/realfinder/AVS-Stuff/tree/Community/avs%202.5%20and%20up
Update new ver of filters&scripts requested from here:
http://avisynth.nl/index.php/MCTemporalDenoise

Missing only his version of GradFun2DBMod, the rest is all updated in x64. I tried and the multi-threading still doesn't work, using only 20% of my processor. I'm using a Ryzen 5 3600.

[Boulder]

Do you have the Prefetch call at the end of your script? Otherwise Avisynth itself won't do any multithreading, only individual plugins may.

[Mugiiya]

Do you have the Prefetch call at the end of your script? Otherwise Avisynth itself won't do any multithreading, only individual plugins may.

Don't know how to do this. Can you please explain?

EDIT
I looked around and found how to use it. Thanks a lot for the help.

Script without loaded plugins and imported avsi:

SetFilterMTMode("DEFAULT_MT_MODE", 2)
SetFilterMTMode("LWLibavVideoSource", 3)

LWLibavVideoSource("D:\Encode\GitS SAC 01.mkv", format="YUV420P8")

MCTemporalDenoise(radius=1, sigma=1, twopass=false, useTTmpSm=false, limit=-1, post=0, chroma=false, GPU=false, fixband=false, interlaced=false, sharp=true, adapt=true, strength=150, SHmode=3, SHmethod=3, Slimit=0, Sovershoot=0, Tlimit=false, Tovershoot=0, protect=false, cutoff=64, threshold=127, maxdiff=0, AA=true, useEEDI2=true, reduc=1, maxd=12, AAthr=16, method=0, deblock=false, useQED=true, quant1=40, quant2=80, edgeclean=true, ECrad=8, ECthr=32, ECmode="RemoveGrain(4,4)", stabilize=false, maxr=1, TTstr=1, enhance=true, GFthr=1.1, AGstr=0, bias=-1, temp=100, bwbh=48, owoh=24, blksize=16, overlap=8, truemotion=false, MVglobal=false, bt=1, ncpu=12, precision=2, pel=2, pelsearch=2, search=-1, searchparam=-1, MVsharp=0, DCT=0)

aWarpSharp2(thresh=100, blur=2, type=1, depth=9, chroma=4)

FFT3DFilter(sigma=1.0, beta=1.0, plane=0, bt=3, sharpen=1.0, ncpu=12)

Prefetch(threads=12)

[Selur]

for example:
SetFilterMTMode("DEFAULT_MT_MODE", MT_MULTI_INSTANCE)
# loading plugins&co
....
# loading source
FFVideoSource("F:\TESTCL~1\files\test.avi",cachefile="E:\Temp\avi_078c37f69bb356e7b5fa040c71584c40_853323747_1_0.ffindex",fpsnum=25,colorspace="YV12")
# filtering
....
PreFetch(8)
return last
see: http://avisynth.nl/index.php/SetFilterMTMode

[kedautinh12]

You missed new ver of Zs_RF_Shared.avsi cause your link only v1.150 and my link v.1.152

[Boulder]

If you use Prefetch, remove the ncpu parameters from your script. Otherwise you'll be multithreading on the script and function level simultaneously, which is inefficient.

[kedautinh12]

Asd-g creat a script GradFun3dbMod base GradFun2dbMod. I think we can replace it in MCTemporalDenoise

[guest]

Asd-g creat a script GradFun3dbMod base GradFun2dbMod. I think we can replace it in MCTemporalDenoise

Hi ked,

I thought I'd have a look on this section of the Forum, and found this post:-

http://forum.doom9.net/showthread.php?p=1942127#post1942127

has a problem with Line 711, but different.

I might try that script....why would it work with Staxrip, and not RipBot ?!?!?

EDIT:- I got it to work :)

[kedautinh12]

Hi ked,

I thought I'd have a look on this section of the Forum, and found this post:-

http://forum.doom9.net/showthread.php?p=1942127#post1942127

has a problem with Line 711, but different.

I might try that script....why would it work with Staxrip, and not RipBot ?!?!?

EDIT:- I got it to work :)

Oh, how you do that work?? (Reel.Deel won't complain at here :D)

[guest]

Oh, how you do that work?? (Reel.Deel won't complain at here :D)

If you go to where that link takes you, you'll see a script, then Solved adding: fixband=false, and that fixed it..

[kedautinh12]

If you go to where that link takes you, you'll see a script, then Solved adding: fixband=false, and that fixed it..

Maybe relate you won't update GradFun2DBMod cause GradFun2DBMod had gradfun2db3 function. And Gradfun2db3 need dither_tool.avs to work

[guest]

Solved adding: fixband=false


I'd really like to know where you found the "fix" for this, I had been trying to get MCTemporalDenoise to work, and couldn't, but this did :)

[guest]

Maybe relate you won't update GradFun2DBMod cause GradFun2DBMod had gradfun2db3 function. And Gradfun2db3 need dither_tool.avs to work

So should I try 3 instead of 2, with dither ???

[kedautinh12]

So should I try 3 instead of 2, with dither ???

No, just update latest ver and remove fixband=false

[guest]

No, just update latest ver and remove fixband=false

I'm pretty sure I'm running the latest, tho..I'll check. :thanks:

So which one should I use:-

http://avisynth.nl/index.php/GradFun2DBmod

OR

https://github.com/Asd-g/AviSynthPlus-Scripts/blob/master/GradFun3DBmod.avsi

[kedautinh12]

I'm pretty sure I'm running the latest, tho..I'll check. :thanks:

So which one should I use:-

http://avisynth.nl/index.php/GradFun2DBmod

OR

https://github.com/Asd-g/AviSynthPlus-Scripts/blob/master/GradFun3DBmod.avsi

Wrong, here:
https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/GradFun2DBmod.avsi

[guest]

Wrong, here:
https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/GradFun2DBmod.avsi

Excellent, I had the older version from 2009, and this is from 2020 :)

Going to "play" with "UnBand" tomorrow.

Thankyou again, my friend.

[kedautinh12]

Excellent, I had the older version from 2009, and this is from 2020 :)

Going to "play" with "UnBand" tomorrow.

Thankyou again, my friend.

I said you need update to latest ver from here but you forgot that
https://forum.doom9.org/showthread.php?p=1974926#post1974926

[guest]

I said you need update to latest ver from here but you forgot that
https://forum.doom9.org/showthread.php?p=1974926#post1974926

Yes, yes, you did, I didn't pay enough attention to the version numbers :(

[Stereodude]

How do I get the this new MCTD version working? From here: https://github.com/Asd-g/AviSynthPlus-Scripts/blob/master/MCTD_.avsi

I started down the rabbit hole of updating all the dependencies... I got to it complaining about ex_lut missing. Got the ExTools.avsi from here (https://github.com/Dogway/Avisynth-Scripts/blob/master/ExTools.avsi) and now:

https://i.imgur.com/YwCFg46.png

Edit: Fixed. I guess my AVSynth+ version was too old. I updated to 3.7.2 and now that error went away and I can use MCTD_.

[Stereodude]

What are you guys doing about LSFmod? If you have sharpening enabled in MCTD, LSFmod will puke on something that's not YV12.

The LSFmod version linked from the wiki (http://latoninf.free.fr/d9/LM/LSFmod.v1.9.avsi) has an explicit check for YV12.

The newer version here (https://github.com/avisynth-repository/LSFmod/blob/master/LSFmod.avsi) from TheChaosCoder has a statement on line 419 of:

sisphbd = AvsPlusVersionNumber > 2294

That throws an error

"I don't know what 'AvsPlusVersionNumber' means."

I can modify LSFmod to force sisphbd = true and then MCTD works with sharpening enabled, but it feels pretty half baked.

[StainlessS]

I think you need current Zs_RF_Shared.avsi for 'AvsPlusVersionNumber'.
(real.finder)

EDIT: Maybe here:- https://github.com/realfinder/AVS-Stuff

[Stereodude]

I think you need current Zs_RF_Shared.avsi for 'AvsPlusVersionNumber'.
(real.finder)

EDIT: Maybe here:- https://github.com/realfinder/AVS-Stuff
Thanks! That works.

https://raw.githubusercontent.com/realfinder/AVS-Stuff/Community/avs%202.5%20and%20up/Zs_RF_Shared.avsi

[Stereodude]

While I'm excited to finally have a high bit depth capable version of MCTD, I have to nitpick a bit. No newbie is ever going to get this version up and running chasing down all the right version of all the dependencies.

Also, how well tested is the high bit depth support?

Like I noticed the sharpening becomes less apparent the higher the bit depth. At 16 bits you can't even see it. At 8-bit it's very obvious.