x264's nr filter did'nt work in multi-thread ?

[akiza]

Recently I start using X264's nr to replace mplayer/mencoder's HQDN3D filter... ^^

But after I did some test,I found if I enable X264's multi-thread encoding ( thread=0 or >=2 ) then nr didn't work. ( output file same as without nr)



Does X264's nr only work in single-thread mode ?


~~~~~~~~

app:mencoder svn-25962 ( sherpya )
cpu:intel 65nm e2140 (dual core)

[akiza]

I download the latest X264.exe (rev 808 from x264.nl) and did some test...

I found x264's nr only work when threads=1...

If threads=0 /2 ... then nr won't work.

Have any patch to fix the problem ?

[bob0r]

I can confirm this.
Now pray the x264 devs will fix it :)

Edit:
The error occurs when pthreads code was added, revision 608-610 (info from Dark_Shikari)
Thanks for reporting and let's hope pengvado has the time AND mood to fix it for you :D

[akiza]

I can confirm this.
Now pray the x264 devs will fix it :)

The error occurs when pthreads code was added, revision 608-610 (info from Dark_Shikari)


Thanks for your info and I will pray for the patch .. :)

~~~~~~~~~~~~~~

One more question :D

Is there any doc about NR ?

I've read some mplayer/mencoder/x264 docs. Most of them only say " 100~1000" is usefull range.

Could anyone give some advice about nr ? Thanks :D

[Gabriel_Bouvigne]

Quite strange, as it seems to me that it's working. Just tried rev818:

--threads 2: SSIM Mean Y:0.8934126
--threads 2 --nr 1000: SSIM Mean Y:0.8957503
--threads 4: SSIM Mean Y:0.8951335
--threads 4 --nr 1000: SSIM Mean Y:0.8951289

[akiza]

Quite strange, as it seems to me that it's working. Just tried rev818:

--threads 2: SSIM Mean Y:0.8934126
--threads 2 --nr 1000: SSIM Mean Y:0.8957503
--threads 4: SSIM Mean Y:0.8951335
--threads 4 --nr 1000: SSIM Mean Y:0.8951289


Could u try --crf and compare the output file size?

[vmrsss]

This thread seem to have died. Yet I confirm that even with the latest GIT build --nr does not work with multiple threads, not with --crf, not with --bitrate. Perhaps some of the developers --Dark Shikari?-- can confirm whether this is a bug or a feature?

[Dark Shikari]

This thread seem to have died. Yet I confirm that even with the latest GIT build --nr does not work with multiple threads, not with --crf, not with --bitrate. Perhaps some of the developers --Dark Shikari?-- can confirm whether this is a bug or a feature?Its a bug that pengvado doesn't care about because adding nr was just on a whim anyways (it was copied from lavc) and its not very important, nor does he feel like figuring out where the threading bug is.

[bob0r]

patch: x264.859.nr.fix.01.diff (http://files.x264.nl/x264_patches/x264.859.nr.fix.01.diff) (by astrange)
file: x264.859M.nr.threads.fix.exe (http://files.x264.nl/x264.859M.nr.threads.fix.exe)

@akiza
Please try, so far it seems to work! (If you look at the patch, all you can do is LOL :))

Hope it works....