PgcEdit 8.5 - Delete Uncalled PGCs (Possible Bug)

[Video Dude]

I found something that causes PGCEdit to freeze up and crash. I am able to replicate it everytime on Win XP Pro.


Crash:
Open DVD
Enter DVD TEXT with a colon ":" somewhere in the entered text.
Run Delete Uncalled PGCs
Invalid File Name message box followed by PGCEdit program freeze
Must ctl+alt+dlt to exit.


No Crash:
Open DVD
Run Delete Uncalled PGCs
Prompt to save User Comments
Enter DVD TEXT with a colon ":" somewhere in the entered text.
Save

[r0lZ]

OK, thanks for the report. I will verify that.

[Video Dude]

I narrowed the problem to the colon : in the DVD TEXT.

When I call Delete Uncalled PGCs in 8.5 it prompts to save User Comments in the middle of the operation. But if there is a colon it will just freeze and crash after displaying the error box. PgcEdit autonames the user comments according to the DVD TEXT? This might explain the crash since the colon is an invalid character in Windows.

Here is the crash log:


Application Error
Error: Invalid File Name "PgcEdit Test: Disc 1"

invalid filename "PgcEdit Test: Disc 1"
invalid filename "PgcEdit Test: Disc 1"
while executing
"tk_getSaveFile -filetypes {{"User's PGC comments" {*.upc}} {"all files" {*.*}}} -parent .

-initialdir $::config(import_initialdir) -initialfile $de..."
(procedure "::utils::export_pgc_comments" line 72)
invoked from within
"::utils::export_pgc_comments $export_pgc_comments_auto_mode"
(procedure "::main::Write_DVD" line 92)
invoked from within
"::main::Write_DVD false"
(procedure "remove_menu" line 65)
invoked from within
"remove_menu true"
(procedure "::utils::delete_all_uncalled" line 135)
invoked from within
"::utils::delete_all_uncalled"
(menu invoke)

[r0lZ]

PgcEdit autonames the user comments according to the DVD TEXT?Yes, when Options -> Input/Output -> Automatically Load and Save User Comments and Labels in Backup Folder is not ticked.
In fact, it's a Tcl/Tk bug with their tk_getSaveFile function (that opens the Save File dialog.) It should convert the filename to something legal, or use it anyway as the default and let Windows complain if it is invalid, bit it crashes. I have to verify the filename myself. I do that already for the default filename of the ISO in the Burn DVD function, but I forgot to do it here. Sorry, and thanks again for your help! It is now really easy to fix the bug.

[EDIT] The bug is now fixed. The fix will be available in the next version. In the meantime, simply do not use characters that are illegal in a filename in the DVD-Text General Name, or enable the option to save the comments automatically.

[Video Dude]

:thanks:

Thanks for all your hard work making PgcEdit.