Log in

View Full Version : strange problem when modifying x264 source code


land
23rd August 2007, 11:53
Hi,
I want to make some changes in the source code of x264, but in some parts of the code the lines I write are ignore.
When I write something in x264.c all works perfectly, but when I write something in encoder.c my lines are ignore.
I even write things like:
jkdsoe
kejsog
and the project links without errors!!!
It seems that the encoder is using another encoder.c.
Any ideas about how can I fix that?

I'm working with MSVC6 and I have obtain the code using TortoiseSVN.

DarkZell666
23rd August 2007, 20:17
I'm not sure how you're trying to build x264, but are you sure the temporary .o files (if any) really are deleted and recompiled ?

Linking is one thing, compiling is another. If you modify the source and re-link the previously generated .o files and libraries together, no wonder the compiler never complains ... (please slap my fingers hard if I'm wrong, anyone, just do it, now).

LoRd_MuldeR
23rd August 2007, 20:38
Just a wild speculation: AFAIK x264 is heavily assembler optimized. Maybe you just changed the plain C version of the function, but x264 still used the (unmodified) assembler version of that function?

Dark Shikari
23rd August 2007, 20:40
Just a wild speculation: AFAIK x264 is heavily assembler optimized. Maybe you just changed the plain C version of the function, but x264 still used the (unmodified) assembler version of that function?
Almost all the assembly is for the functions in pixel.c, I believe. SAD, SSD, SATD, etc.

land
3rd September 2007, 09:25
I was linking the project with a library that's wasn't the one that I modify.
Also I have noticed that I must link the library and then link the project x264, if I only link the project it doesn't work.
Thank you for your answers.