Thread Edit buttons dead - 3.6.6 upgrade problem

[IanB]

Since the 3.6.6 upgrade the thread edit button are all dead.

All pages now have Java script errors relating to undefined variables like is_IE, is_NS, vBulletin, etc.

Edit by Swede: I can't reproduce that error.

[Swede]

As you can see I can edit posts without any error, using either FF or IE.

[check]

As you can see I can edit posts without any error, using either FF or IE.

Actually we can't :) vbulletin doesn't show the 'edited on' text unless you've passed the grace period, which is about 120 seconds. It might also be related to whether or not another user has viewed the thread. No errors here either - you aren't using greasemonkey or something are you?

[foxyshadis]

Might just be an old version of the javascripts cached. Seems more got moved into external scripts, thankfully, though they're called vbulletin_global.js?v=366, so it should stop any cache issues... odd.

Check, look at Ian's post. :p

[IanB]

Ah finally I can respond (mail server outage got me).

@Swede,

Well it's an IE 5.5 problem. :(

vBulletin 3.6.6 does support IE 5.5, I can quite happily navigate their test site with full functionality.

My guess is some of your customizations are causing the grief.

I fed the home page thru http://validator.w3.org/#uri and it reports a few errors in your custom texts that should be very easy to fix.

[ChronoCross]

Ah finally I can respond (mail server outage got me).

@Swede,

Well it's an IE 5.5 problem. :(

vBulletin 3.6.6 does support IE 5.5, I can quite happily navigate their test site with full functionality.

My guess is some of your customizations are causing the grief.

I fed the home page thru http://validator.w3.org/#uri and it reports a few errors in your custom texts that should be very easy to fix.

why are you using IE 5.5?

[IanB]

Because I am an unusual software developer who actually tests his code. IE 5.5 is the latest version available for Solaris Sparc architecture. If web pages display correctly on IE 5.5 they display correctly on almost everything else. etc etc etc

Why do you find this strange? Is it unreasonable to expect a vBulletin site to work correctly after customizations?

Why do people blindly accept fault with software. If a web server emits erroneous pages people just accept it and race around installing a different web client to work around the problem. If the petroleum companies suddenly added sugar to gasoline would you race out and buy a new car with a whizz bang catalysing filter to use the new "improved" fuel, I don't think so.

[ChronoCross]

I'm not defending the validation errors it's just 5.5 is very vulnerable to exploits. I haven't seen anyone other than you whose using it in quite some time

[IanB]

@Swede,

Can you please apply this patch to vbulletin_global.js$ diff vbulletin_global.js.orig vbulletin_global.js
86a87,90
> if (typeof length == 'undefined')
> {
> return this.substr_orig( (start < 0 ? this.length + start : start));
> }A prepatched version is available in this .zip file vbulletin_global.zip (http://avisynth2.sourceforge.net/vbulletin_global.zip)

[Shinigami-Sama]

I wasn't even aware there was a SPARC build of IE; and I use Solaris software often... I'll have to look into it
I fail to see why people still use deprecated software; by your car analogy we should still be using leaded fuel but thats you prerogative.

[4Dude]

I see we are on 3.6.7 now!!

It loads super fast for me and looks good :)

Keep up the good work guys!