DVD2AVI Sourceforge Project

[Nic]

No its just for ripping...encoding straight from DVD has never been a good idea. :)

-Nic

[trbarry]

Nic -

Are you going to release changes to Sourceforge then? I'd love to have a copy of the version that builds a qwik avs script and executes it (if I remember all this right from another post of yours).

As far as stepping on toes, I don't know if anyone was even spending any time at all on save-oe/dvd2avi until a flurry of activity got touched off by pcdvdguy's interesting changes. I know I wasn't.

But that got me feeling guilty and I thought I should at least finish a couple of the things I'd talked about.

- Tom

[Nic]

Of course it will all be released...ill implement it into your changes or vice versa (I love liaor's Transport stream mod :) I want to work on making that a bit more user friendly...I deal in TS more than I do PS - So it was a very useful addition)

Cheers,
-Nic

[trbarry]

Nifty. My DVD2AVI stuff (and liaor's) is all in CVS now, so have at it. ;)

- Tom

[int 21h]

http://phreak404.virtualave.net/mpeg2dec2.dll

that's compiled with the Intel Compiler.

I'm not sure my system is the best to benchmark with, because I'm pretty sure something isn't right... Can anyone give me a CCE speed they get with X mhz with that so I can compare?

[trbarry]

int 21h -

I don't use CCE but on my system your dll ran 214 seconds on my last bench test above, 3 seconds longer than what I got earlier. But still faster for P4's than the Doom9 binary.

So it's not just a difference of the Intel compiler. I've been tinkering since yesterday so I'll recheck if I get exactly the same results from the zip I posted as I did in my testing this morning.

- Tom

edit: I just retested the one in the zip I had previously posted and it came out exactly the same as yours, 214 seconds. So the compiler doesn't matter, at least in this case. I have no idea which of my tweakings in the last day gave the extra 1.5% improvement in my own current test copy so I just replaced the one on my web page.

at www.trbarry.com/mpeg2dec2.zip

[int 21h]

Time taken for a 3:08 clip in CCE. No resize or cropping.

Time | Library | IDCT | Compiler
2:45 mpeg2dec.dll 2 Intel

2:37 mpeg2dec2.dll 5 Intel

2:39 mpeg2dec2.dll 2 Intel

2:35 mpeg2dec2.dll 5 MSVC



Weird, I'm sure I passed it the right options I think :confused: (/O3 /G7 /QxW).

Did you change code in your tweakings or just Project Options in MSVC?

[trbarry]

The new source is out there so you could compare the Getpic.cpp function and header, but I'm not sure what I did.

I think I was only playing with which combination of form_prediction functions are stated to be inlined in the header but I may also have reordered the functions in the source.

I do not understand the restrictions on inlining functions in VS6/C++ but some combinations would cause a crash, so I tried a few.

I also turned on automatic inlining under the optimizatins tab in the project settings once I had a combination that seemed to work. But at the time I was doing all this I was counting crashes, not seconds and it doesn't make enough difference in time to notice if you aren't keeping track carefully.

So it's still sort of mystery. ;)

- Tom

[int 21h]

After I finish this code for Uni, I'll look at it some more. I know that Intel Compiler is capable of out preforming MSVC.

[Nic]

Ive pretty much finished the BeSweet code in DVD2AVI. It works really well, very quick, no intermediate files...very slick :)

-Nic

[A_Pleite]

Originally posted by Nic
No its just for ripping...encoding straight from DVD has never been a good idea. :)

-Nic
Why (I´m not an expert in "encoding straight from DVD", because only my first Backup ;), which I made about one year ago, was made with flask. I know it´s not the best "program" :D, but ...) ?

[trbarry]

Ive pretty much finished the BeSweet code in DVD2AVI. It works really well, very quick, no intermediate files...very slick

Very slick indeed. This is getting an awful lot of attention for something declared dead only a couple weeks ago. ;)

- Tom

[int 21h]

The BeSweet interface works with .mp2 also right? (For SVCD people like me) When I was working on it, I was never quite clear on if that worked. (Vob->SSRC->Normalize->Toolame->MP2)

[macdaddy]

Ive pretty much finished the BeSweet code in DVD2AVI. It works really well, very quick, no intermediate files...very slick

Wow, nic, you are like the Energizer rabbit (keeps coding, and coding). I can't wait to give the new BeSweet features a whirl. Thanks to all of you.

[ShinerSpoon]

Just in case Nic is not an SVCD'er. Here is an example command line from dvd2svcd using BeSweet to create an mp2


C:\Program Files\DVD2SVCD\BeSweet\BeSweet.exe -core( -input C:\temp_avi\Extracted_audio_1.ac3 -output C:\temp_avi\Encoded_audio_1.mp2 -logfile C:\temp_avi\Encoded_audio_1.log ) -azid( -L -3db -c normal -g max ) -ota( -d -110 ) -2lame( -e -b 192 -m s )

[int 21h]

So I would assume that same commandline is available in the .dll that DVD2AVI is using also...

[Nic]

Im pretty definite it supports mp2, ill make sure you can select it inside DVD2AVI...Ill test it later today :)

@A_pleite: :) Its not high on my list...but maybe towards the end ill add it (I think there is a version of DVD2AVI with DeCSS support...ill go scout for it :)

-Nic

ps
@Shiner: Thanx, I need all the examples, hadn't used BeSweet until two days ago...Have never used 2lame in any capacity. :)

[ShinerSpoon]

Nic, as I am sure you know, there is a plugin for dvd2avi that allows opening the vobs from disk:
http://www.doom9.org//Soft21/Rippers/OpenDVD.zip

The only problem is it cannot handle multiangle. I hope you consider adding something like it as dvd drives are now much cheaper and I would think a large buffer would keep the wear and tear down to a minimum. I did notice what looked like some special source in the dvd2avi 1.85 source package from the Doom9 source page.

Also, dspguru was nice enough to reply to a question I had:

"principly, the mp2 output should be as easy as the mp3 output, but with one exception - it's impossible to do one-pass normalization with mp2"

[Nic]

DG & I have already spoken about the 2pass problem...he is working on it & I thank him a (25^3*(25^2+15))/10 for it :)
(sorry private joke)

I know about 1.85, ive looked thru the source...still don't like it. I think Ill leave it for someone else to implement. (Also nowadayz harddrives cost very little :) )

If I were to do it, I'd make DVD2AVI do the splitting/demuxing inside DVD2AVI....As I think thats the best way. :)

Cheers,
-Nic

[int 21h]

I would not mind seeing Vstrip or some other ripping procedure integrated into DVD2AVI (i.e. SAVE), but I agree that ripping from the actual DVD is not worth the time at this point.

I'd rather see a FairUse like interface (which I had begun work on before all this Uni homework caught up with me), to rip the vobs, generate the project, make your sound files, and write your .avs for CCE. >:)

I didn't have the ripping part done yet, but I had some other stuff done. I'll add it eventually. The biggest problem with ripping the vobs is no IFO parsing, I really like IFO parsing ;)

[Nic]

At present, ive put a "Rip DVD" option in the file menu...clicking this: Authenticates the disc, finds the main movie & displays all the ifo information for. You can then select PGC, audio stream you want & where you want to save the rip to...then click rip. Its basic but is enough for most people (there is also a little combo box so you can select the other titles on the DVD other than the main one)

-Nic

[Kyo]

@Energizer rabbit

Thanks for your work in ALL, keep coding:p

@all developers

You're doing great stuff

Nice work!
:cool:

[ShinerSpoon]

I'd rather see a FairUse like interface (which I had begun work on before all this Uni homework caught up with me), to rip the vobs, generate the project, make your sound files, and write your .avs for CCE. >

To state the obvious (not being a smartass), isn't that called dvd2svcd? If you want to finish your svcd by hand you can check the "edit as part of video encoding" in the frameserver tab of dvd2svcd which stops the process and brings up an edit window with the avs. At that stage the vobs will be ripped, the best possible audio, via besweet, is produced, the d2v is prepared, and the avs is ready to be edited and saved. Just kill the program after that (if you want to hand finish) and you should be good to go with all the drudge work done for you.

I hope I can get away with saying, IMHO, I do think any program like this project can suffer from feature creep if developers are not on their guard. Sure, I can see dvd2avi doing most of the divx process but not the svcd. IMO, if you guys try to make dvd2avi too simple (edit: dumbed down do it all) you will end up making it too complicated. Perhaps it would not be a good idea to change the simple interface we all know and love too much?

Again, I hope I have not offended anybody. That is not my intention.

[Nic]

I agree on not changing the interface, but I can see DVD2AVI creating the MP2 Audio & the AVS Script & D2V for SVCD. (as it does all the above already in my version)

(I assume thats what you need for SVCD conversion...unfortunatly don't know anything about it :( )

-Nic

[ShinerSpoon]

but I can see DVD2AVI creating the MP2 Audio & the AVS Script & D2V for SVCD.

Yes, that would work well for hand creation of a simple svcd. People that wanted more like menus, subs, etc., would have the basics of what they need (mp2,d2v,avs)to use additional tools of their choice.

Most would agree that project design is always about the target audience anyway. Those people that are NOT interested in hand creation but that NEEDED complex svcd structures would want to use dvd2svcd anyway. It does this well, very well actually, and automates the whole process.

The point being that they would not be the target audience of this project. People that like to manually do the process and tweak (like using RobShots method) are the target as I see it. Personally, I would like to have both methods available to me. They have different purposes and would compliment each other depending on the mission.

[int 21h]

I detest the sendkeys and other 'hacks' of DVD2SVCD. I'm only saying I would enjoy a version of DVD2AVI that I feed vob files, and it outputs an mp2 (or two), a d2v, and an avs. I don't want it doing anything else. I don't need it to open CCE, run CCE, calculate bitrate or anything.

Of course, if someone has issues with this, I'll just make a variant and keep it to myself and the other blackhats I associate with in the other part of the 'scene' :sly:

I'm not looking for ways to 'simplify' ripping, I'm looking for ways to batch rip, where I can rip multiple DVDs quicker. Just the fact that DVD2AVI will be generating my mp2 files will save me at least 10 or so minutes of just commandline typing.

[ShinerSpoon]

I detest the sendkeys and other 'hacks' of DVD2SVCD.
OT, but man, you must have not seen it for a long, long time. You can actually switch users now in XP and allow D2V to function independently. The next version pending has a batchmode limited only by the size of your HD. It's a strong program now, quite different from its roots.
I'm only saying I would enjoy a version of DVD2AVI that I feed vob files, and it outputs an mp2 (or two), a d2v, and an avs.
We are saying the same thing. Sorry, I must have misunderstood your comments above when you mentioned a FU type interface. Now I think I understand that you were talking about another project, not a modification of Dvd2avi.

[int 21h]

I just meant the Wizard like interface.

In any event, its not important.

[ShinerSpoon]

Would there be a possibility of allowing the audio tracks to be previewed? That would sure come in handy.

[vlad59]

I'm sorry, I'm a little off the topic.
When I compile the CVS of Save-oe I get strange warning about ddraw.h. I have the latest Windows SDK with only a pre-release of DirectX 8.1 SDK. I'm currently downloading another DirectX SDK to check this out (It's so slow, I think it will be finished tomorrow).
Do I really need the latest DirectX SDK ??
Is there any other trick I must know ??
A last hint, I compiled Mpeg2dec.dll without any problem.

Thanks in advance

[trbarry]

Offhand, I don't remember any DirectX specific warnings. I do have it in my libraries but that is because it was already there from other projects.

For some reason VS6 seems to remember the same library for all workspaces. I don't know how to override this but wish I did.

- Tom

[vlad59]

I found the problem, I thought it was a Directdraw problem but it is a CPU detection problem.
At home, VS6 is installed on an old K6-400 (With MMX, 3DNow and no SSE) : when I load a vob file it crash.
I tested the same exe on my laptop (P3-750 with SSE) and no crash at all.
I'll check this precisely later (I have to sleep). In fact I should be the last one to have an oldy CPU like that ;)

[trbarry]

I think there is a quirk in DVD2AVI about remembering what type of processor to use. If the DVD2AVI.ini file says you want SSE IDCT process then it will try to use that even if you are now on a new machine that does not support it. The fix is to delete the DVD2AVI.ini file.

- Tom

[vlad59]

In fact IDCT_CONST_PREFETCH is called in getpic.c without checking IDCT_Flag. IDCT_CONST_PREFETCH use the prefetchnta instruction so the program don't work on my K6-400 (it has no SSE and not extended 3Dnow).
I will have to test the program on my P3-750 ;).

[trbarry]

vlad -

Yep, that's an obvious bug. I meant to fix that today and also check in mpeg2dec but other things came up. I'll try to fix them tomorrow if you haven't already. It wasn't meant to restrict either program to P3 or higher.

- Tom

[vlad59]

I'm sorry but I don't think I'll be able to correct the problem myself. I'm mainly a Java programmer, I can read and eventually fix C or C++ code but I'm a real newbie in MMX, SSE, 3DNow, ...
I just found (with google help) that prefetchnta was not available in K6 CPU.
I'm trying to learn MMX and SSE but I begin ........
Sorry again :(

Edit : I fact prefetch is not so hard to understand, I think I can try to fix it as soon as I come home (in about 8 hours)

[trbarry]

vlad59 -

I did a bit of testing and that particular prefetch call did not help performance even on P4's, so I took it out of DVD2AVI & MPEG2DEC. Also it should be okay now if you load someone else's dvd2avi.ini file without trying to use sse2 code on a P2 or K6-II.

The source is in Sourceforge. You can find TEST versions of both (with source) at:

www.trbarry.com/DVD2AVIT3.zip and
www.trbarry.com/MPEG2DEC2.zip

- Tom

[vlad59]

OK, no more crash. Thanks.

[trbarry]

Oops. Someone just contacted me and let me know that I'd left the file DVD2AVI2.exe out of the zip above. It should be there now.

It looks like I was over zealous in cleaning out intermediate files to make the zip smaller.

- Tom

[DrKnowLittle]

Hello ,

I just tested the build that TBarry posted but it crashes on my compu.

After I load a mpeg2 file I get a msg "You video card cannot handle YUV display. Conversion will work, but you will not get any display in YUV mode" and when I pres ok it crashes.

Im running W2K on a P3 550 with 256MB ram.

/DrKnowlittle

[trbarry]

DrKnowLittle -

I'm typing this on a P3 and yes indeed it does crash. ;)

There are two problems here. I've seen the YUV video message off and on since 1.82. The solution seems to be to switch to RGB mode if you want to see your video for crop/resize etc. and then switch back before saving it. The whole thing may have something to do with an image bigger than your overlay can handle, I'm not sure but not currently working on it.

The other problem I thought I'd fixed, but apparently not completely. The easy solution is to delete the DVD2AVI.ini file you probably found in the downloaded zip, which is from my P4. It fixed it for me.

I'll put out a fix for that one, but the delete should solve it for now.

- Tom

[DrKnowLittle]

Tbarry thanks , that did solve the problem :)

[Kyo]

I have tested your version(not sure if it is the same you post pages up?)

I tested with dvds and no problem, the resize not work, the crop ...
not remember(i will post later this), but all the other ok...

thanks guys for your work!

:D

[trbarry]

Kyo -

To make DVD2AVI cropping work with frameserving to Avisynth you will also need the mpeg2dec2.dll that I listed above.

But maybe folks should hold off on my test version now. There is a new Doom9 sanctioned DVD2AVI 1.86 posted today by someone (Nic?). That may be a tested production release that has all the same features. I haven't tried it yet but there is no real purpose in dualing DVD2AVI's and I don't really want to support my test version if another complete version is already available.

- Tom

[Nic]

No, keep up the great work Tom!

Gloval's version is nice, but I think mine is more what people want, but is far from polished...It does work though (intergrated MP3 using BeSweet...problem with gloval's is its still using AC3Dec...not good)

I might release mine earlier just to "compete", My twopass code is pretty good & because im using AviSynth inside DVD2AVI, I can use all the filters :) (Decomb & temporal smoother are the only ones added as yet)


Cheers,
-Nic

[trbarry]

Errrr, ummmmmm, Uh, everybody disregard my previous comment.

Nic -

I thought that one WAS yours, so if all the wonderful things you have promised are true then it would have pretty much subsumed my efforts here. ;)

Will yours be able to write ac3 into Xivd by any chance? Or at least some sort of 5.1 sound of some sort? (I'm still allergic to audio programming and quite helpless there)

- Tom

[DSPguru]

Hi Tom,
it is possible to encode to 5.1 ogg vorbis using BeSweet(.dll), but until the vorbis devs tweak their codec to 5.1 i think you should stick to the original ac3 stream.

the biggest thing about BeSweet(.dll), is the fact that it does one-pass normalizaion for mp3 & (just added to exe release) ogg.
this means that the ac3 stream is being demuxed from the vob only once, and there's no need for h.d. temporary
space, since it doesn't create any intermediate file.

btw, to find more about BeSweet capabilities, i advise that you download the latest gui and find all available features.

Dg,

[trbarry]

Dg -

Actually I don't mind sticking to ac3 at all but then I can't automatically have DVD2AVI put it into Xvid. And there is something peculiar about my ATSC HDTV captures that seems to often make the audio sync wrong if I add it later using Nandub or Vdub_ac3.

Just using the DVD2AVI Delay parm written into the name doesn't seem to get it sometimes.

Someday I will absolutely force myself to learn how audio works. ;)

- Tom

[ShinerSpoon]

I think the Nic, Tom, int 21h collaboration will be much more holistic for both Divx'ers and SVCD'ers and very much look forward to seeing it when the time is right. Thanks to all of you for your work on our behalf.

[maven]

trbarry:

if you want to do audio better than anyone else (and probably correct for that matter), you'll have to compare the timestamps in the video- and audio streams (PTS) and align them continuously...