Log in

View Full Version : 1.08.1 filter editor inserts before trim(). Bug?


kumi
8th March 2006, 23:19
I was testing some encoder settings in 1.08.1 with SelectRangeEvery(1200,12) added in the Filter Editor window. I noticed some of the segments were only 1-frame long, so I took a look at the .AVS files prepared by DVDRB:
#------------------
# AVS File Created by DVD Rebuilder
# VOBID:01, CELLID:02
#------------------
LoadPlugin("C:\Program Files\DVD-RB PRO 1.08.1\DGDecode.dll")
mpeg2source("G:\DVDRB WORKING\D2VAVS\V01.D2V",idct=7)
SelectRangeEvery(1200,12)
trim(510,9160)
ConvertToYV12()

I noticed that DVDRB is adding my filters before the trim statement. Isn't this incorrect behaviour? I remember older versions adding filters after the trim() statement, and the filter editor window states:
Any text entered below will appear in all AVS files after the trim() statement and before any resizing or color conversion.

Video Dude
9th March 2006, 01:35
Its not a bug. It was changed so filters like temporal smoothers would work correctly.

Rippraff
9th March 2006, 02:01
For more take a look at this thread (http://forum.doom9.org/showthread.php?t=105040).

Cu Rippraff

kumi
9th March 2006, 02:30
Thanks, I see now why it was changed.

It seems that there is a subset of filters that are best placed after trim(), and a subset that are best placed before trim(). Maybe someone more knowledgeable can chime in on this.

Regardless, since I am using SelectRangeEvery(), running consecutive encodes requires manual, time-consuming modification of each segment AVS file after each prepare phase. IMO, this is a step backwards in terms of usability (but a step forward for users of temporal filters ;) .)

For this reason, I humbly suggest to jdobbs that the filter editor include two entry fields: "Insert before trim()" and "Insert after trim()". An explanatory text could advise the user which general type of filter should go where.

Any thoughts?

jdobbs
9th March 2006, 02:42
You can't use the SelectRangeEvery() filter with DVD-RB. It changes the framecount and that isn't allowed.

kumi
9th March 2006, 02:44
Ooop, thanks for the info, I didn't know that.