x264 VfW Patch submission ?

[Kyle_Katarn]

Still on my way to solve the Vfw Crashed here comes a new patch :
In vfw/codec.c

/* */
LRESULT compress_end(CODEC * codec)
{
if( codec->h != NULL )
{
x264_encoder_close( codec->h );
codec->h = NULL;
}

free( codec->hCons );
codec->hCons = NULL;
return ICERR_OK;
}


replaced by

/* */
LRESULT compress_end(CODEC * codec)
{
if( codec->h != NULL )
{
x264_encoder_close( codec->h );
codec->h = NULL;
}

if( codec->hCons != NULL )
{
free( codec->hCons );
codec->hCons = NULL;
}
return ICERR_OK;
}

[Sharktooth]

the two "if"s are quite useless...

[Kyle_Katarn]

Why ? I'm still looking for the cause of the crash when calling compressEnd.

The fact is that this is not the key since the exception is "floating point error"....