Small bug found in the AVS scripts

[SAPSTAR]

Just discovered something...in CCE mode, if the AVS Option 'ConvertToYUY2()' is unchecked, and if your movie is interlaced, the following line is kept in the AVS script : ConvertToYUY2(interlaced=true).

It's not a big deal, but it shouldn't be there...Less color modifications you have, less risk of color distortion you could have.....

Anyway...keep up the great work jdobbs...all my movies are now reencoded using DVDRB....the best of the best !!!! :thanks:

[jdobbs]

If you don't convert to YUY2 -- you can't use CCE. It doesn't accept YV12.

The "Interlaced=True" is necessary to ensure proper color conversion for an interlaced source.

[SAPSTAR]

If you don't convert to YUY2 -- you can't use CCE. It doesn't accept YV12.

The "Interlaced=True" is necessary to ensure proper color conversion for an interlaced source.
I never said I was using CCE ;) ...anyway, if the movie is not interlaced and you uncheck the option, you wont have the convert command in the script ?!? So why is it kept in interlaced but not in progressive ?!

[jdobbs]

You said: "in CCE mode" -- why would you be in CCE mode if you weren't using CCE?

The line is added when CCE is the selected encoder, regardless of whether or not it is interlaced. Of course the "Interlaced=True" option isn't there for progressive sources.

[SAPSTAR]

You said: "in CCE mode" -- why would you be in CCE mode if you weren't using CCE?

The line is added when CCE is the selected encoder, regardless of whether or not it is interlaced. Of course the "Interlaced=True" option isn't there for progressive sources.
OK so the error is that the ConvertYUY2() is not there when not interlaced...What I meant is it's not consistent.....
(I'm using AutoQMatEnc instead of CCE, which is using the same ECL files, and which doesn't need ConvertYuY2())

[spyhawk]

OK so the error is that the ConvertYUY2() is not there when not interlaced...What I meant is it's not consistent.....I think you misinterpret jdobb's explanation. ConvertToYUY2() is needed when using CCE in CCE mode, and the "Interlaced=True" option isn't there for progressive sources. Since you're using AutoQMatEnc (which does not need ConvertToYUY2() as you said) in CCE mode, DVD-RB does not know that; it assumes you're using CCE, unless jdobbs writes a check if AutoQMatEnc is used. Well, that's up to him. ;)

[SAPSTAR]

I think you misinterpret jdobb's explanation. ConvertToYUY2() is needed when using CCE in CCE mode, and the "Interlaced=True" option isn't there for progressive sources. Since you're using AutoQMatEnc (which does not need ConvertToYUY2() as you said) in CCE mode, DVD-RB does not know that; it assumes you're using CCE, unless jdobbs writes a check if AutoQMatEnc is used. Well, that's up to him. ;)
No no that's perfectly clear, let's try again to explain :

CCE mode on ; AVS Option ConvertYUY2() off :
The current AVS scripts are :
for progressive movie : no convertYUY2()
for interlaced movie : convertYUY2(interlaced=true)

To be consistent here are the 2 possibilities :
First possibility:
for progressive movie : convertYUY2()
for interlaced movie : convertYUY2(interlaced=true)

Second one :
for progressive movie : no convertYUY2()
for interlaced movie : no convertYUY2(interlaced=true)

[spyhawk]

ok, so you're listing the possibilities for CCE with AVS Option ConvertToYUY2() off, right?

[SAPSTAR]

ok, so you're listing the possibilities for CCE with AVS Option ConvertToYUY2() off, right?
I'm not listing...I'm just saying that to be consistent, we should have either both with Convert or both without it...but not a mix.

[jdobbs]

SAPSTAR

Bottom line:

Something else must be changing it, because DVD-RB always writes the ConvertYUY2() line when CCE is selected. It would be obvious if that weren't true, because everyone who uses CCE would be getting errors right now and the screaming would be very loud. CCE fails without it.


[Edit - corrected spelling]

[danpos]

@All

Of course that in using CCE the colorspace conversion is inevitable because CCE accepts YUY2 inputs only. By the other hand, in the way suggested by SAPSTAR, anyone that wanna try AQE (great SAPSTAR's encoder which uses a ECL file like CCE and others stuffs related) wouldn't mind with such colorspace conversion cos AQE already all necessary colorspace. BTW, using RB-OPT is possible to eliminate the conversion line from script and maybe this be the way to go.

Cya!

[SAPSTAR]

SAPSTER

Bottom line:

Something else must be changing it, because DVD-RB always writes the ConvertYUY2() line when CCE is selected. It would be obvious if that weren't true, because everyone who uses CCE would be getting errors right now and the screaming would be very loud. CCE fails without it.
SAPSTAR...not SAPSTER...anyway...You're absolutly right !!! My fault I didn't check correctly, Mea Culpa Mea Maxima Culpa !!! :eek:

[jdobbs]

I'd love to see the results of a double blind test and see if there is anyone on the planet who can actually tell whether a single color conversion has occurred on the finished product... no return fire, please -- just an observation.

[jdobbs]

SAPSTAR...not SAPSTER...anyway...You're absolutly right !!! My fault I didn't check correctly, Mea Culpa Mea Maxima Culpa !!! :eek:Whoops... my apologies for misspelling your name.

Do you want me to add the ability to remove it even with CCE? I only worry that someone will forget they set it -- and the bug reports will start flying.

[Carpo]

use really big letters in the warning should they turn it off - that should cover you :devil:

[jdobbs]

use really big letters in the warning should they turn it off - that should cover you :devil:Hmm... nobody reads warnings. Come look at my e-mail box and I can prove it.

[Carpo]

then they have no reason to complain :D

[Rippraff]

Do you want me to add the ability to remove it even with CCE? I only worry that someone will forget they set it -- and the bug reports will start flying.
I think you had a good reason when you introduced this with 0.79 Pro. ;)
(...)This was causing some problems for folks who mistakenly unchecked it.

As an idea maybe you can implement it as a hidden setting in RB.ini, for example
Auto_ConvertToYUY2=1 #Add the line
Auto_ConvertToYUY2=0 #Do not
This might also be helpful for people who are dealing with filters which need YUY2 colorspace.
Another example:
#------------------
# AVS File Created by DVD Rebuilder
# VOBID:04, CELLID:02
#------------------
LoadPlugin("C:\Programme\DVD-RB PRO\DGDecode.dll")
mpeg2source("G:\RIPPEN\name des filmes\D2VAVS\VI0100004002.D2V")
trim(0,5291)
t = GripCrop(720,576,overscan=0)
a = width(t)%8
b = height(t)%8
Crop(t,(a/2)*2,(b/2)*2,0-a+((a/2)*2),0-b+((b/2)*2))
Undot()
asharp(1,3)
ConvertToYUY2()
TemporalSoften(1,6,4,15,2)
AddBorders((720-width)/2,(576-height)/2,(720-width)/2,(576-height)/2)
ConvertToYUY2()

In this case the blue one isn't needed, on the other hand it isn't bothering. ;)

Cu Rippraff

[jptheripper]

as a side note, if your filter needs YUY, cant you just add that as the first line of the filter editor?

[jdobbs]

Yes -- and it will not get converted twice. If already working in the correct colorspace, the conversion filter exits with no action. It is a good idea that you logically stack your filters in a way that reduces the number of conversions. For example if you have filters that require or can work with YV12, put them first because the default input is YV12. Then if you are also doing filters that require YUY2 -- you can do the conversion for those once, and put all the filters after.

I believe that is the case in RippRaff's example

[Rippraff]

@jptheripper
The whole example above from line t =... to AddBorders... is realized with RB's filter editor. ;)
But that doesn't prevent RB from inserting the last blue line.

Cu Rippraff

[jdobbs]

@jptheripper
The whole example above from line t =... to AddBorders... is realized with RB's filter editor. ;)
But that doesn't prevent RB from inserting the last blue line.

Cu RippraffAs it should. :)

[SAPSTAR]

Whoops... my apologies for misspelling your name.

Do you want me to add the ability to remove it even with CCE? I only worry that someone will forget they set it -- and the bug reports will start flying.
I think you're right, or maybe it could be deactivated with a hidden setting as suggested by Rippraff?!
Your choice, of course I would like to have it deactivated, but I don't want you to be annoyed by pbs due to that !!!!