nnedi3 plugin for VapourSynth

[jackoneill]

Source: https://github.com/dubhater/vapoursynth-nnedi3

DLLs can be found in the "releases" section.

Please test and report back. Patches are welcome too.

nnedi3_rpow2 can be found here: http://forum.doom9.org/showthread.php?t=172652

[kolak]

8bit precision only or also 10bit (16) ?

[jackoneill]

Originally Posted by kolak

8bit precision only or also 10bit (16) ?

Precision?... If you're asking what bit depths it accepts for input, only 8. (This might change in the future.) Internally it does the same as the avisynth filter. It's mostly the same code.

[Revgen]

I notice that there is no "Threads" option for this filter like there is for the avisynth filter. So it can't do multi-threading internally?

[mandarinka]

Nice job!

[Reel.Deel]

@ jackoneill
Thank you very much for taking time to port NNEDI3, Histogram, and TemporalSoften. Awesome work .
I'll test them out and report back if I find any discrepancies.
=============================================
@ Revgen
This post might answer your question on multi-threading.

[jackoneill]

Originally Posted by Revgen

I notice that there is no "Threads" option for this filter like there is for the avisynth filter. So it can't do multi-threading internally?

Indeed, there is no internal threading anymore. There is no need for it, because Vapoursynth makes it process several frames in parallel.

[lansing]

just ran a speed test against the avisynth nnedi3 on a 720x480 clip, encode with x264 ultrafast preset, the avisynth one's got 30+ fps, and the vs' got only 3.x fps, something must be wrong

[jackoneill]

Originally Posted by lansing

just ran a speed test against the avisynth nnedi3 on a 720x480 clip, encode with x264 ultrafast preset, the avisynth one's got 30+ fps, and the vs' got only 3.x fps, something must be wrong

Nothing is wrong. The avisynth version has optimised SSE2 code. Mine doesn't.
You'll get about the same low speed from the avisynth version with opt=1.

[jackoneill]

Hi!

A new build is available for testing, now with more speed. Use opt=2, but keep the other parameters at their default values, for now (or it will eat your cat). I have only converted a few of the asm functions — those that are used when all parameters are at their default values (except for opt, of course).

opt=2 requires SSE2, obviously.

This new build also requires VapourSynth R15.

Also, it now accepts any colorspace with 8 bits per sample, not just YUV.

https://github.com/dubhater/vapoursy...edi3/downloads

[Revgen]

Quick test. Played back through vdub using a 1920x1080i mpeg2 source and compared vapoursynth SSE2 version (using version R15) and the latest avisynth version (using an avisynth script) with my Q6850 quadcore cpu & WinXP pro. Vapoursynth version runs most optimally with vs.Core(threads=5). Changing it to threads=6 didn't seem to be much better. Avisynth version worked optimally at threads=4. Vapoursynth version runs about 2-3fps faster than avisynth version.

Vapoursynth script

import vapoursynth as vs
import sys
core = vs.Core(threads=5)
core.avs.LoadPlugin(path=r'C:\dgindex\DGDecode.dll')
core.std.LoadPlugin(path=r'C:\Program Files\VapourSynth\nnedi3-testing.dll')
ret = core.avs.MPEG2Source(r'E:\mympeg2.d2v')
ret = core.nnedi3.nnedi3(clip=ret,opt=2,field=3)
last = ret

17fps-18fps

Avisynth scrpt

mpeg2source("E:\mympeg2.d2v")
nnedi3(opt=2,field=3,threads=4)

15fps-16fps

[kolak]

Interesting

[Keiyakusha]

Can you also check CPU usage? Because when we'll do actual encoding something like 18fps and 50% cpu load won't make things faster than 10fps and 25% load

Also I posted it before but deleted suggestion cause I'm not sure anymore, but to utilize vapoursynth's MT better, maybe it is good idea to add more filters. Like 2 consecutive nnedi or something (but make sure that it doesn't bottlenecks elsewhere, like overly high resolution...)

[Revgen]

Vapoursynth is running at 98-99% load and avisynth is running at 87-88% load.

[Revgen]

Tried double NNEDI3. Had to bump it up to vs.Core(threads=7) to optimally use vapoursynth this time. Threads=4 was stilll the most optimal for avisynth. Avisynth CPU load was 90% to 91%. Vapoursynth was 97% to 98%. Avisynth was about .5 to 1fps slower than vapoursynth. Vapoursynth ran 12.5fps-13fps while avisynth ran 12fps to 12.5fps. However, there was a huge discreprancy in memory usage. Avisynth was using about 1gb of RAM before I stopped playback. Vapoursynth was always consistently at 200mb of usage.

[Myrsloik]

Originally Posted by Revgen

Tried double NNEDI3. Had to bump it up to vs.Core(threads=7) to optimally use vapoursynth this time. Threads=4 was stilll the most optimal for avisynth. Avisynth CPU load was 90% to 91%. Vapoursynth was 97% to 98%. Avisynth was about .5 to 1fps slower than vapoursynth. Vapoursynth ran 12.5fps-13fps while avisynth ran 12fps to 12.5fps. However, there was a huge discreprancy in memory usage. Avisynth was using about 1gb of RAM before I stopped playback. Vapoursynth was always consistently at 200mb of usage.

The ram difference is just because of different cache strategies. Avisynth caches everything until it bumps into the set memory limit. VS keeps track of the cache request history as well and is decent at detecting linear scans and minimizing cache sizes then.

[Revgen]

Okay, I used SetMemoryMax(250) this time. Memory usage is under control and avisynth performance is still the same.

[jackoneill]

Thank you all for testing. I'm glad to see it's working.

I'm done with the asm. The new build should be fully functional now. opt=2 is default. Please try your favourite combination of exotic parameters.

[Reel.Deel]

Originally Posted by jackoneill

Internally it does the same as the avisynth filter. It's mostly the same code.

If I understand this correctly, this means NNEDI3 works in 16-bit internally, then dithers/rounds/truncates(?) to 8-bit. Correct?
High bit depth input/output would be lovely.

*edit*
My previous question (NNEDI3 internal processing) is irelevant. I (somehow) misinterpreted the quoted statement and thought that NNEDI3 works like avisynth's internal resizing filters. Sorry for being dumb.

[jackoneill]

Originally Posted by Reel.Deel

If I understand this correctly, this means NNEDI3 works in 16-bit internally, the dithers/rounds/truncates(?) to 8-bit. Correct?
High bit depth input/output would be lovely.

No idea. Investigating the possibility of high bit depth input and output is on my todo list.