NAL HRD has been committed!

[kieranrk]

Patch has now been committed.

Features

• Writing of pic_timing and buffering_period SEI units as required by Blu-Ray etc.
• libx264 returns hrd timing information. This means muxers don't have to parse the bitstream to utilise this information (new)
• CBR (filler rbsp) and VBR HRD
• Valid support for pulldown
• VFR VBV and VFR ratecontrol

[sneaker_ger]

"pthreadGC2.dll not found" on start even with standard settings. Windows XP SP3.

[bnshrdr]

Originally Posted by sneaker_ger

"pthreadGC2.dll not found" on start even with standard settings. Windows XP SP3.

You will need to either obtain the specified pthread dll or use the patch to compile your own static x264 build. The OP hast just provided a x264 build with that dependency.

@kieranrk: Also what else is in your binary, just vanilla + your patch?

[moviefan]

What is the difference of this patch to the x264_hrd_interlace_xxxx.diff?

[sneaker_ger]

Thx, works now. (Get pthreadGC2.dll here, if anyone else needs it)

[shon3i]

Originally Posted by moviefan

What is the difference of this patch to the x264_hrd_interlace_xxxx.diff?

and

1. Who is author
2. Did this patch are completly different to Alex or Trahald
3. Did you work for x264 team? i mean did this after some testing get finaly into git. I won't give my feedback if this is another try. I want to know if this is for merging into git.
4. please somebody do a normal compile

[kieranrk]

Originally Posted by moviefan

What is the difference of this patch to the x264_hrd_interlace_xxxx.diff?

Cleaned up and minor things fixed up.

1. Who is author
2. Did this patch are completly different to Alex or Trahald
3. Did you work for x264 team? i mean did this after some testing get finaly into git. I won't give my feedback if this is another try. I want to know if this is for merging into git.
4. please somebody do a normal compile

1/2 - Zmgorynych == Alex Giladi. I added the hrd timing parts.
3. Yes. Yes this is for merging into git. Alex isn't going to be around much so I'm going to push to get this patch merged.
4. Sorry about that. EDIT: new one should be static.

@kieranrk: Also what else is in your binary, just vanilla + your patch?

Yes. Just vanilla and the patch.

[sneaker_ger]

New build works fine without the dll. Two typos in the help:

--nal-hrd, Signal HRD information (needed e.g. for blu-ray compliance
requires vbv-maxrate and vbv-bufsize

1. ","
2. missing ")"

[VFR maniac]

Hi Kieranrk, your patch doesn't write Buffering Period SEI unless the muxer is raw.

[shon3i]

Ok, patch working corectly, muxing passes, BD verification passes. What we need to test more?

[kieranrk]

Originally Posted by shon3i

Ok, patch working corectly, muxing passes, BD verification passes. What we need to test more?

I've changed it a bit now, fixed some bugs and am adding CBR HRD. Possibly this might have introduced a bug so I'll upload a new patch either tonight or tomorrow.

[komisar]

kieranrk, build 1400 version of x264 with you patch get failure...
checkasm report:

x264: SSSE3
 - pixel ssd :           [OK]
 - pixel satd :          [OK]
 - pixel sa8d :          [OK]
 - pixel var2 :          [OK]
 - pixel hadamard_ac :   [OK]
 - intra satd_x3 :       [OK]
 - intra sad_x3 :        [OK]
 - esa ads:              [OK]
 - sub_dct4 :            [OK]
 - sub_dct8 :            [OK]
 - add_idct4 :           [OK]
 - zigzag_frame :        [OK]
 - zigzag_field :        [OK]
 - mc chroma :           [OK]
 - mc wpredb :           [OK]
 - hpel filter :         [OK]
 - lowres init :         [OK]
predict_16x16[3] :  [FAILED]
30 69 9d 71 4d 5d 71 a0 c4 b1 8d 86 a0 af 9e ae cf
4e 51 57 5d 62 68 6e 74 7a 80 86 8c 92 98 9e a3 a9
8f 58 5e 64 6a 70 76 7c 81 87 8d 93 99 9f a5 ab b1
85 5f 65 6b 71 77 7d 83 89 8f 95 9b a0 a6 ac b2 b8
37 67 6d 73 79 7e 84 8a 90 96 9c a2 a8 ae b4 b9 bf
2d 6e 74 7a 80 86 8c 92 97 9d a3 a9 af b5 bb c1 c7
70 75 7b 81 87 8d 93 99 9f a5 ab b1 b6 bc c2 c8 ce
87 7d 83 89 8f 94 9a a0 a6 ac b2 b8 be c4 ca d0 d5
5d 84 8a 90 96 9c a2 a8 ae b3 b9 bf c5 cb d1 d7 dd
 0 8c 91 97 9d a3 a9 af b5 bb c1 c7 cc d2 d8 de e4
 0 93 99 9f a5 aa b0 b6 bc c2 c8 ce d4 da e0 e6 eb
 1 9a a0 a6 ac b2 b8 be c4 c9 cf d5 db e1 e7 ed f3
 0 a2 a7 ad b3 b9 bf c5 cb d1 d7 dd e3 e8 ee f4 fa
 0 a9 af b5 bb c1 c6 cc d2 d8 de e4 ea f0 f6 fc ff
 0 b0 b6 bc c2 c8 ce d4 da df e5 eb f1 f7 fd ff ff
 0 b8 bd c3 c9 cf d5 db e1 e7 ed f3 f9 fe ff ff ff
 0 bf c5 cb d1 d7 dc e2 e8 ee f4 fa ff ff ff ff ff

   4b 52 59 5f 66 6d 73 7a 81 88 8e 95 9c a2 a9 b0
   52 59 60 67 6d 74 7b 81 88 8f 96 9c a3 aa b0 b7
   5a 60 67 6e 75 7b 82 89 90 96 9d a4 aa b1 b8 bf
   61 68 6f 75 7c 83 89 90 97 9e a4 ab b2 b8 bf c6
   68 6f 76 7d 83 8a 91 97 9e a5 ac b2 b9 c0 c7 cd
   70 77 7d 84 8b 91 98 9f a6 ac b3 ba c0 c7 ce d5
   77 7e 85 8b 92 99 9f a6 ad b4 ba c1 c8 ce d5 dc
   7e 85 8c 93 99 a0 a7 ae b4 bb c2 c8 cf d6 dd e3
   86 8d 93 9a a1 a7 ae b5 bc c2 c9 d0 d6 dd e4 eb
   8d 94 9b a1 a8 af b5 bc c3 ca d0 d7 de e5 eb f2
   95 9b a2 a9 af b6 bd c4 ca d1 d8 de e5 ec f3 f9
   9c a3 a9 b0 b7 bd c4 cb d2 d8 df e6 ec f3 fa ff
   a3 aa b1 b7 be c5 cc d2 d9 e0 e6 ed f4 fb ff ff
   ab b1 b8 bf c5 cc d3 da e0 e7 ee f4 fb ff ff ff
   b2 b9 bf c6 cd d3 da e1 e8 ee f5 fc ff ff ff ff
   b9 c0 c7 cd d4 db e2 e8 ef f6 fc ff ff ff ff ff
 - intra pred :          [FAILED]
 - quant :               [OK]
 - denoise dct :         [OK]
 - decimate_score :      [OK]

P.S. huh, maybe this is not nal-hrd-patch... investigation continues...
P.P.S. apparently I broke intel-support patch... sorry...

[kieranrk]

Please test this new revision to make sure I haven't broke anything.

There are a few things left and it should be ready for final review.

[shon3i]

I just successfully produced two Blu-ray movies . Tell me about CBR-HRD what is recommendation for ratecontrol? With CRF i can't specify bitrate, is it only for ABR and 2pass, and what is advantage of CBR instead VBR HRD

[Dark Shikari]

Originally Posted by shon3i

I just successfully produced two Blu-ray movies . Tell me about CBR-HRD what is recommendation for ratecontrol? With CRF i can't specify bitrate, is it only for ABR and 2pass, and what is advantage of CBR instead VBR HRD

CBR HRD implies filler bytes; it is not necessary or recommended for Blu-ray.

[mopurist]

When I try http://pastebin.com/d51413f02 pastebin says "Unknown post id, it may have expired or been deleted."

Is there a new version about? Merged into git? Anyone care to share?

Thanks.

[kieranrk]

Originally Posted by mopurist

When I try http://pastebin.com/d51413f02 pastebin says "Unknown post id, it may have expired or been deleted."

Is there a new version about? Merged into git? Anyone care to share?

Thanks.

I probably set the expiration date too soon.

See: http://pastebin.com/m44061f19

(some minor changes)

[VFR maniac]

Originally Posted by kieranrk

http://pastebin.com/m44061f19

bs_realign is missing...

[mp3dom]

I don't know which BD verifier were used by shon3i, anyway I've made an encode with x264+1.1 NAL-HRD (the version at the 1st post) on the Elephant's Dream video. Using the Interra BDQuest Verifier it gave me 3 fatal errors. I must say that Scenarist MUI Generator (and Scenarist itself) accepts and mux without problems.
I've activated the --nal-hrd, --slices 4 and --aud, fps were 24p and resolution were 1920x1080 (obviously)
The error output of BDQuest says:
- 'pict_struct_present_flag', expected (1), found (0)
- Compression Ratio (CR) is less than MinCR (4). Number of bytes in NAL unit (1096693) is more than the maximum limit (983040)
- 'slice_type' in 'I Type' picture must be (7), found (2)

Regarding the first error (pict_struct_present_flag) I've see that in this x264 version there's a specific flag (--pict-struct) that is enabled by default for interlaced footage... Could be that it is mandatory for bluray?
I've got 8 errors regarding the "Compression Ratio (CR) is less than etc. etc. etc.". In every error the NAL unit value change and it's value is always bigger than the maximum limit of 983040.
About the third error, I want to say that this error appear even on encodes made by CineVision or the Scenarist Still Image Encoder. I think that this error could be ignored...

Hope this helps!
Thanks!

[kieranrk]

Originally Posted by VFR maniac

bs_realign is missing...

Forgot about that. Will post a corrected one.

Regarding the first error (pict_struct_present_flag) I've see that in this x264 version there's a specific flag (--pict-struct) that is enabled by default for interlaced footage... Could be that it is mandatory for bluray?

Presumably so. (See the spec )

I've got 8 errors regarding the "Compression Ratio (CR) is less than etc. etc. etc.". In every error the NAL unit value change and it's value is always bigger than the maximum limit of 983040.

Not sure about this one; I'm double checking the H.264 spec about this. Try with the new patch and build I will post in a second to double check it isn't related to the bitstream issues.