Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Subtitles

Reply
 
Thread Tools Search this Thread Display Modes
Old 16th March 2009, 17:47   #81  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Yeah, I kinda forgot to remove the file check for the command line interface. So it still blocks HD-DVDs from the command line. Will be fixed in the next release.
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 00:01   #82  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
16.03.2009 1.9 -> 2.0
  • SUP: palette is only exported up to the highest entry actually used (previous versions always exported 256 entries)
  • Increased resolution of all internal time stamps to 90kHz (was 1kHz)
  • During export, start/end time (or start/delay) are synchronized to the target frame rate (special handling for PAL, NTSC and 24P)
  • HD-DVD SUPs were refused from the command line: fixed.
  • New frame rate: 23.975Hz. equal handling of frame rates for command line and export dialog (e.g. aliases)
  • Frame rate info is written into the PCS headers of created BD-SUPs (and read for src fps detection)
  • Wildcard support for command line (read online help for details)

Last edited by 0xdeadbeef; 17th March 2009 at 00:16.
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 02:37   #83  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Regarding the MKVMerge issue, I got a little more insight what causes this problem. Indeed MKVMerge doesn't complain about a time overlap, but about a "wrong" offset. This seems to happen for each subtitle that doesn't fit into one 0x800 bytes packet and thus uses an RLE buffer split over multiple (usually 2) packets.

While I'm not so keen to claim that there is no chance that I messed something in my implementation, chances are that MKVMerge doesn't consider multi-packets at all. At least the fact that VobSync is able to decode the multi-packet subtitles created by BDSup2Sub hints that the command buffer and the offset can't be that wrong. Besides, I'm pretty sure I saw multi-packet subtitles displayed correctly when used to create a DVD.

So this might be an issue of MKVMerge. I'm not yet 100% sure though.
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 04:20   #84  |  Link
SquallMX
Special SeeD
 
Join Date: Nov 2002
Location: Mexico
Posts: 244
Thanks for the update and the research, you're right, only MKVMerge has problems with the subs, others VobSub programs works fine (VobSub, DirectVobSub, MPC Subtitle Module, SubSync, etc).

SquallMX is offline   Reply With Quote
Old 17th March 2009, 06:04   #85  |  Link
turbojet
Registered User
 
Join Date: May 2008
Posts: 1,840
Thanks for the update and uniterrupted download of it.

I tried the wildcard cli: java -jar BDSup2Sub.jar "'00001*.sup' '*-bbsup2sub.sup /res:720"

and I got

Code:
OPTION: set resolution to 720p (1280x720)
Exception in thread "main" java.lang.NullPointerException
        at BDSup2Sub.main(BDSup2Sub.java:313)
I tried with spaces (added ') and without spaces in path and also outputting to *.sub and also without resziing maybe I'm missing something?

Also exported sups (1080 and 720) are displaying correctly now in mpc-hc and powerdvd, great work!

Last edited by turbojet; 17th March 2009 at 06:12.
turbojet is offline   Reply With Quote
Old 17th March 2009, 12:24   #86  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Quote:
Originally Posted by turbojet View Post
I tried the wildcard cli: java -jar BDSup2Sub.jar "'00001*.sup' '*-bbsup2sub.sup /res:720"
You don't need the single quotes here at all since the file names don't contain any space. So the following should do as well:
Code:
java -jar BDSup2Sub.jar "00001*.sup *-bbsup2sub.sup /res:720"
If you need the single quotes (due to spaces in file names), they have to be around a filename, not around filename+parameter. I'll improve syntax checking in the next version though to avoid the exception.
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 15:39   #87  |  Link
turbojet
Registered User
 
Join Date: May 2008
Posts: 1,840
With same files but no space in path I tried: java -jar BDSup2Sub.jar "00001*.sup *-bbsup2sub.sup /res:720"
and the same error popped up

I also tried: java -jar BDSup2Sub.jar "00001*.sup *-bbsup2sub.sup" /res:720
and got: ERROR: No extension given for target /res:720
turbojet is offline   Reply With Quote
Old 17th March 2009, 18:07   #88  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Ok, it has nothing to do with single quotes. It's just that I always tested with the source files in a path. So I overlooked that no path inside the source file name results in a null pointer exception.
Until I fix this in the next release, use the following workaround:
Code:
java -jar BDSup2Sub.jar ".\00001*.sup *-bbsup2sub.sup /res:720"
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 18:18   #89  |  Link
turbojet
Registered User
 
Join Date: May 2008
Posts: 1,840
Thanks that works, that's not a bad way to do it especially for people with linux experience.
turbojet is offline   Reply With Quote
Old 17th March 2009, 19:56   #90  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
While we're at it, there are some restrictions to the characters that the wildcard will replace. Indeed more or less only alphanumeric characters (and ".") are supported. I guess I will switch to a more relaxed regular expression for the next release, bur for the moment, special characters like "(){}[]!%&#~" etc. are not matched by the wildcard.

I also made some progress regarding the MKVMerge issue. Indeed it's really a bug in BDSup2Sub. It happens only for subtitle frames where the RLE data would fit into 0x800 bytes, but due to the control header, a 2nd packet is needed. In this case, the overall packet length is wrong which is exactly what MKVMerge reports (if you know how to take it). VobSub Resync seems to be pretty relaxed about this and SubtitleCreator crashes when it tries to show such a subtitle. I have also at least one report that hints that this could lead to problems with standalone DVD players.
-> Will be fixed in next version.

Last edited by 0xdeadbeef; 17th March 2009 at 20:31.
0xdeadbeef is offline   Reply With Quote
Old 17th March 2009, 21:36   #91  |  Link
hubblec4
Registered User
 
Join Date: Apr 2008
Posts: 660
Quote:
Originally Posted by 0xdeadbeef View Post
I also made some progress regarding the MKVMerge issue. Indeed it's really a bug in BDSup2Sub. It happens only for subtitle frames where the RLE data would fit into 0x800 bytes, but due to the control header, a 2nd packet is needed. In this case, the overall packet length is wrong which is exactly what MKVMerge reports (if you know how to take it). VobSub Resync seems to be pretty relaxed about this and SubtitleCreator crashes when it tries to show such a subtitle. I have also at least one report that hints that this could lead to problems with standalone DVD players.
-> Will be fixed in next version.
Thats sounds really good. Thanks again for your hard work!

I had converted some BD.sups and found another issue.
in the idx-file i found some entries like this:

timestamp: 01:26:34:439, filepos: 000ce2000
timestamp: 00:00:00:000, filepos: 000ce3800
timestamp: 01:26:39:444, filepos: 000ce6800
timestamp: 01:26:40:486, filepos: 000ceb800

thats the last 4 entries!

in another case:

timestamp: 01:26:37:775, filepos: 000cdc000
timestamp: 01:26:41:613, filepos: 000cdf000
timestamp: 00:00:00:000, filepos: 000ce2000
timestamp: 00:00:00:000, filepos: 000ce4000



i think this entries are to much.

hubble


sample

Last edited by hubblec4; 18th March 2009 at 06:00.
hubblec4 is offline   Reply With Quote
Old 17th March 2009, 22:25   #92  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Approval may take a while, better use Sendspace or whatever. Then again I had enough for today anyway.

17.03.2009 2.0 -> 2.1
  • Fixed: usage of wild card from the command line would cause exception when source file name didn't contain a path
  • Fixed: wrong VobSub packet size if only the control header was shifted to the next packet, but the first packet was not completely filled.
  • Fixed: delay can be entered in milliseconds again. It's adjusted to target frame rate automatically.
  • Added command line parameter "/dly" to define a delay
  • Added target frame rate auto detection for command line
  • Changed command line parameter "/fps" to allow setting of only the target frame rate
0xdeadbeef is offline   Reply With Quote
Old 18th March 2009, 00:12   #93  |  Link
turbojet
Registered User
 
Join Date: May 2008
Posts: 1,840
Wildcards are working as documented in the help now thanks again.
Without really bloating the cli help do you think wildcard usage could be added?
turbojet is offline   Reply With Quote
Old 18th March 2009, 06:14   #94  |  Link
hubblec4
Registered User
 
Join Date: Apr 2008
Posts: 660
Quote:
Originally Posted by 0xdeadbeef View Post

17.03.2009 2.0 -> 2.1
  • Fixed: wrong VobSub packet size if only the control header was shifted to the next packet, but the first packet was not completely filled.
this fix is ok. mkvmerge shows no warnings anymore.

but the 00:00:00-timestamp-entries are there.

thats the last entries in the idx-file(BDSup2sub v.2.1)

timestamp: 01:26:34:355, filepos: 000ccb800
timestamp: 00:00:00:000, filepos: 000cce800
timestamp: 00:00:00:000, filepos: 000cd1000
timestamp: 01:26:41:446, filepos: 000cd6000
timestamp: 01:26:41:613, filepos: 000cd8800
timestamp: 00:00:00:000, filepos: 000cdb000
timestamp: 00:00:00:000, filepos: 000cdc800

its possible to delete this entries automaticly?

sample


hubble

Last edited by hubblec4; 18th March 2009 at 06:18.
hubblec4 is offline   Reply With Quote
Old 18th March 2009, 12:19   #95  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Invalid timestamp are usually corrected by BDSup2Sub. There are obviously special circumstances here that I need to examine.
It's also possible that I broke this correction (partly) in 2.0 or 2.1. It basically still works though, as I tested several SUPs with invalid time stamps before I released 2.1.
We'll see when I get back from work and can have a look at your samples.

[Edit]
Ok, let's say it will be fixed in the next release

Last edited by 0xdeadbeef; 18th March 2009 at 19:12.
0xdeadbeef is offline   Reply With Quote
Old 18th March 2009, 22:48   #96  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Only one little change this time:
18.03.2009 2.1 -> 2.2
  • Fixed: missing end times were not handled correctly.

Last edited by 0xdeadbeef; 19th March 2009 at 01:14.
0xdeadbeef is offline   Reply With Quote
Old 19th March 2009, 08:16   #97  |  Link
hubblec4
Registered User
 
Join Date: Apr 2008
Posts: 660
Quote:
Originally Posted by 0xdeadbeef View Post
Only one little change this time:
18.03.2009 2.1 -> 2.2
  • Fixed: missing end times were not handled correctly.
thanks. now i think works the converting perfect!!

question: sometimes is the time too short for showing the subtitles.

is it possible manuelly change the start- and endtime in your tool? :-)


hubble
hubblec4 is offline   Reply With Quote
Old 19th March 2009, 08:31   #98  |  Link
Mtz
Registered User
 
Mtz's Avatar
 
Join Date: Sep 2003
Location: On The Beach
Posts: 712
I don't think that is possible. But maybe to add some check if a subtitle have duration under 1 second (23 frames), to automatically extend the duration to at least 23 frames for any subtitle, but with the caution to not overlap the timmings with the next one.

enjoy,
Mtz
Mtz is offline   Reply With Quote
Old 19th March 2009, 08:51   #99  |  Link
hubblec4
Registered User
 
Join Date: Apr 2008
Posts: 660
ok but i hope 0xdeadbeef can find a way to implement this feature. because SubtitleCreater doesnt support 1080p.sub/idx-files at the moment.

hubble
hubblec4 is offline   Reply With Quote
Old 19th March 2009, 12:19   #100  |  Link
0xdeadbeef
Author of BDSup2Sub
 
Join Date: Jun 2003
Posts: 478
Editing the times/position is not really planned currently as it would involve a redesign of several program parts.

Detecting too short subtitles is something I thought about some time ago but simply forgot.
I'd like to output a warning as default and fix the length only if it's selected via (export) menu.

Last edited by 0xdeadbeef; 19th March 2009 at 12:22.
0xdeadbeef is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 03:59.


Powered by vBulletin® Version 3.8.9
Copyright ©2000 - 2017, vBulletin Solutions, Inc.